Commit Graph

256 Commits

Author SHA1 Message Date
Sebastian Thomeczek
dc2cf85e53 [Insights] Update Regions code to use custom trace events instead of hijacking regular bookmarks
#rb Ionut.Matasaru
#jira UE-148203
#preflight 64072d276e1dadfcda7352c9
#preflight 640731e4ba12ba641681363a

[CL 24538562 by Sebastian Thomeczek in ue5-main branch]
2023-03-07 08:00:11 -05:00
tyler staples
bf09d60d6b Add non-persistent metadata to the CsvProfiler.
By default csv metadata persists between captures which may be problematic if capturing different modes that have specific metadata since prior captures can pollute future ones.
This change adds a CSV_NON_PERSISTENT_METADATA macro which sets metadata that is cleared once the current capture ends.

For sake of review I've included the change to the FortLevelSaveComponent to update the creative metdata to use this macro. This will be submitted separately though.

#rb ben.woodhouse
[FYI] andrew.ladenberger

[CL 24436772 by tyler staples in ue5-main branch]
2023-02-27 20:55:32 -05:00
jian ru
a068006c5d Generalized templates for allcoation recording to and playback from log files
#rb dmytro.vovk, ben.woodhouse

[CL 24175227 by jian ru in ue5-main branch]
2023-02-13 10:38:26 -05:00
Johan Berg
2b44a347bb Fix for metadata scopes applied in tasks.
When launching a task, the metadata stack is captured at the calling site, and reapplied as a scope as soon as the task begins to execute. The macro that performed this reapplication was misnamed and didn't imply that it was actually creating a scope. This change removes the macro and adds a custom scope type which can be embedded in the inherited context for the task.

#rb ionut.matasaru, andriy.tylychko
#jira UE-167069
#preflight 63e64e153c247ccd13e986e4

[CL 24118353 by Johan Berg in ue5-main branch]
2023-02-10 09:31:37 -05:00
QFSW
54c0bafbc6 PR #9886: Fixed linker error when using operator+ in FResourceSizeEx outside of Core (Contributed by QFSW)
#github https://github.com/EpicGames/UnrealEngine/pull/9886
#preflight 63dd3484244dc45a20976474

[CL 23991897 by QFSW in ue5-main branch]
2023-02-03 11:40:36 -05:00
catalin dragoiu
83deb26fb5 Fix snapshot bugs in Insights Status Bar Widget.
#rb Ionut.Matasaru
#jira UE-175267,UE-175284,UE-175356
#preflight 63d7ea2fec3d1af4409128d3
#lockdown mark.lintott

[CL 23951418 by catalin dragoiu in ue5-main branch]
2023-02-01 12:28:50 -05:00
steve robb
ad6364e24e Replaced some enable-if/disable-if overloads with if constexpr blocks in a single function.
#rb devin.doucette
#preflight 63d45377f626715201acf9cb

[CL 23897639 by steve robb in ue5-main branch]
2023-01-27 23:12:19 -05:00
steve robb
38612a3e15 Removed TRemoveCV usage.
#rb devin.doucette
#preflight 63d3f7005c69f453c12698ee

[CL 23890475 by steve robb in ue5-main branch]
2023-01-27 15:19:12 -05:00
danny couture
74782129ec Fix race in FCounters used in FileSystemCacheStore and AsyncLoading
#rnx
#rb Devin.Doucette
#preflight 63d1d57e6a14d8406d8fc7d4

[CL 23863764 by danny couture in ue5-main branch]
2023-01-25 21:07:51 -05:00
Johan Berg
b0ba00dce1 Properly implement snapshot to server in Insights status bar
#preflight 63d12034033e457ba8c659af

[CL 23846388 by Johan Berg in ue5-main branch]
2023-01-25 07:35:06 -05:00
ionut matasaru
8dcfca1aea [Insights]
- MemoryTrace: Added CallstackId for all free events and also for HeapMarkAlloc, HeapUnmarkAlloc events.
  - MemoryTrace: Increased trace version to 2.

#rb Johan.Berg
#preflight 63cab54dee564281cdc111bf

[CL 23790801 by ionut matasaru in ue5-main branch]
2023-01-20 11:12:39 -05:00
Catalin Dragoiu
4993a1a079 Add Trace Bookmark and Trace Screenshot buttons to the Insigths Status Bar Widget.
#jira UE-161773
#rb Ionut.Matasaru
#preflight 639b28bbc16855964d64326e

[CL 23527321 by Catalin Dragoiu in ue5-main branch]
2022-12-15 10:15:25 -05:00
Martin Ridgers
3a2d557c40 Allow tracing to be started without sending the tail of historical events.
#rb im
#rnx
#preflight 637c9664f514e1ded9ee4db7

[CL 23233106 by Martin Ridgers in ue5-main branch]
2022-11-22 06:26:27 -05:00
Catalin Dragoiu
2c65745543 Add options to the Insights Status Bar Widget
#rb Ionut.Matasaru
#jira UE-161773
#preflight 636e5b00ee4d25f90af1325a

[CL 23097615 by Catalin Dragoiu in ue5-main branch]
2022-11-11 09:46:20 -05:00
henrik karlsson
b985fbd1b1 Removed lots of includes in high traffic headers in order to reduce compile times. Headers are still included if UE_ENABLE_INCLUDE_ORDER_DEPRECATED_IN_5_2 is set to 1
List of highlights
* PlayerController - Removed ForceFeedback and and OnlineReplStructs
* Class - Removed Package.h
* World - Pawn, Blueprint and GameInstance
* Actor - CoreNet, HitResult and ActorDatalayer
* EngineBaseTypes - TaskGraphInterface
* AssetManager - AssetData
* Scene/Child/ActorComponent - CoreNet
* AnimInstance - AttributesRuntime, Skeleton, AnimCurveTypes, AnimMontage, BonePose
* BulkData - IoDispatcher
* AssetData - IoDispatcher, LinkerLoad
* SecureHash - AsyncWork
* CanvasTypes - UnrealEngine, StaticMeshResources
* IpAddress - AsyncWork, Stats

#preflight 6363717ece676ae8688f5d8c
#rb none

[CL 22968258 by henrik karlsson in ue5-main branch]
2022-11-03 17:56:44 -04:00
henrik karlsson
cd1466475b Fixed up const/constexpr variables in header files to be "inline"
This is required for c++ modules/header units in order to decide if constexpr/const value should be available to outside module

#preflight 635c0b5c1803be35c767e0ea
#rb none

[CL 22835882 by henrik karlsson in ue5-main branch]
2022-10-28 15:38:42 -04:00
danny couture
502492d223 Fix TSAN warning in BeginEventCommon by using proper atomics
#rnx
#rb Martin.Ridgers
#preflight 635a6167ec7f617ff48c41e1

[CL 22807327 by danny couture in ue5-main branch]
2022-10-27 07:03:27 -04:00
robert millar
ade7908ce6 Csv Profiler: public accessor for a copy of current metadata for embedding inside other profiling/debugging output files.
#rb ben.woodhouse

[CL 22792960 by robert millar in ue5-main branch]
2022-10-26 17:30:09 -04:00
danny couture
684e00a15e Fix potential race condition on multicast delegate used from multiple threads
#rb Martin.Ridgers, Ionut.Matasaru
#preflight 6346a435fa31324bb133affb

[CL 22481908 by danny couture in ue5-main branch]
2022-10-12 13:39:40 -04:00
tyler staples
e469e98032 Add OnCSVProfileEndRequested delegate that fires right before we end a capture, allowing final information to be written.
#rb ben.woodhouse

[CL 22408903 by tyler staples in ue5-main branch]
2022-10-07 16:37:53 -04:00
ionut matasaru
f5ec088bd8 [Insights] Fixed incorrect usage of CORE_API for FDefaultMemScope (Horde issue #220129).
#rb Andriy.Tylychko
#preflight 633c6209116db430588dd367
#lockdown Mark.Lintott

[CL 22363950 by ionut matasaru in ue5-main branch]
2022-10-05 17:37:04 -04:00
Andriy Tylychko
ab5a1abe8d InheritedContext
grouped inherited LLM tag, mem tag and trace metadata into FInheritedContext to simplify their usage, avoid forgetting using all of them together, and to hide the ugly conditional compilation. Added FInheritedContext to higher level tasks instead of the low-level tasks to allow batch task launch to capture the inherited context once per batch

#rb ionut.matasaru
#preflight 633c47792f4bf32d31687192

[CL 22331272 by Andriy Tylychko in ue5-main branch]
2022-10-04 11:22:08 -04:00
marc audy
edd83dc1fb Trace:
* Replaced OnTraceFileStarted delegate with OnTraceStarted
* Added OnTraceStopped delegate
* Both events pass if the recording was for a network or file type.

#rb Brian.Bekich, Martin.Ridgers
#preflight

[CL 22088546 by marc audy in ue5-main branch]
2022-09-20 00:42:05 -04:00
louisphilippe seguin
e738e717e3 Trace
* Added trace file created callback:  Useful to gather all trace files created during execution
* Added config option to disable or resize tail buffers via [Trace.Config]:TailSizeBytes
* Added config option for worker thread sleep time via [Trace.Config]:SleepTimeInMS
* Fixed init code so it never creates a workerthread in builds that don't support multithreading

#rb Martin.Ridgets, Ionut.Matasaru

[CL 22013173 by louisphilippe seguin in ue5-main branch]
2022-09-14 15:04:08 -04:00
Martin Ridgers
378f8d57da Added F prefix to Options struct name
#rnx
#rb im
#preflight 632187ee9677b738f4d49188

[CL 22003200 by Martin Ridgers in ue5-main branch]
2022-09-14 04:06:08 -04:00