Commit Graph

160 Commits

Author SHA1 Message Date
lucas dower
2e1c38e5fc Fix for add virtual bone menu sometimes not showing
#rb thomas.sarkanen
#preflight 63ff42e130633435f80e2e55

[CL 24462174 by lucas dower in ue5-main branch]
2023-03-01 10:06:39 -05:00
jaime cifuentes
920d8d3e9e Fix for crash when showing Weighted Bones in Skeleletal Mesh Editor
#rb [at]thomas.sarkanen
#jira UE-178105
#preflight 63f7900dc35a141980254462
#lockdown Laurent.Delayen

[CL 24427011 by jaime cifuentes in ue5-main branch]
2023-02-27 12:59:57 -05:00
Thomas Sarkanen
502797ca50 Animation Curve Runtime & Editor Improvements
Runtime notes:
- Removes 'smart name' usage across the animation systems.
- Changed curve blending from a uniform array (sized per skeleton) to a sparse array of sorted named values. Blends and other combiners are performed using a dual iteration 'tape merge'.
- Skeleton curves are no longer guaranteed to cover all curve names that can be found at runtime.

Editor notes:
- Curve metadata (flags, bone links etc.) is still present on the skeleton, but can also now exist on a skeletal mesh
- Curve metadata (for morph targets) is still populated on import
- Curves can now be used arbitrarily at runtime

New features:
- New Find/Replace dialog that allows for batch-replacing curves and notifies across all of a project's assets
- New curve debugger tab in various Persona editors that allows for viewing curve values live. This also now allows viewing curves for specific pose watches.
- Pose watches now output curve tracks to the Rewind Debugger

#rb Jurre.deBaare,Nicholas.Frechette,Sara.Schvartzman,Helge.Mathee,Kiaran.Ritchie,Jaime.Cifuentes,Martin.Wilson,Keith.Yerex,Andrean.Franc (and more!)
#jira UE-167776
#jira UE-173716
#jira UE-110407
#preflight 63fc98c81206d91a2bc3ab90
#preflight 63f3ad4f81646f1f24c240c2

[CL 24421496 by Thomas Sarkanen in ue5-main branch]
2023-02-27 07:20:58 -05:00
kiaran ritchie
e815455ef7 Deprecate URig types in preparation for full removal in 5.4.
#rb halfdan.ingvarsson
#JIRA https://jira.it.epicgames.com/browse/UE-175090
#preflight https://horde.devtools.epicgames.com/job/63d1800d976daa618c701490

[CL 23863393 by kiaran ritchie in ue5-main branch]
2023-01-25 20:42:11 -05:00
Patrick Boutot
acff5d3a7d Slate: Deprecated protected access to SListView::ItemsSource. This will allow us to use other container type.
#jira UE-132673
#rb sebastian.nordgren
#preflight 6398beed2540a78d2730da51

[CL 23512016 by Patrick Boutot in ue5-main branch]
2022-12-14 10:22:25 -05:00
Jurre deBaare
31f1b097fd Animation Compression
- Added new compression and 'compiling' API/path
  * Relies on newer DDC API
  * Only fetches compressible data when data is not found in DDC
  * Fetching data happens off the GT now (including Additive animation)
- Deprecated and replace AnimSequence API around compression
** AnimStreamable still relies on old, synchronous, compression path **

IAnimationDataModel
- Removed bone track data being stored as FBoneAnimationTrack
- Bone animation can now only be referenced by Name (not track index anymore)
- Deprecated any API relying on FBoneAnimationTrack
- Added API to retrieve FTransform(s) for given frame(s) with provided bone name
- Added API to lock model against modifications during evaluation (required for non-racing off-GT evaluation)

Animation Sequence
- Frame-rate is now stored on a per-platform basis, allowing for future replacement of frame-stripping (editing property is disabled for now)
- Now allows for storing _transient_ per-platform compressed animation data (required for multi-platform cook)

PerPlatformProperties
- Added per-platform FFrameRate implementation

#preflight 63999f102540a78d2778adb7
#rb Thomas.Sarkanen, Nicholas.Frechette, Devin.Doucette
#fyi Zousar.Shaker

[CL 23510521 by Jurre deBaare in ue5-main branch]
2022-12-14 05:56:08 -05:00
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
Thomas Sarkanen
d9c2b172f7 Skeleton compatibility improvements
Skeleton compatibility is now bi-directional. Specifying a compatible skeleton A -> B now implies B -> A.
Skeleton compatibility is now an editor-only concern. The runtime will attempt to do the 'best it can' via name -> name mappings. Only the editor will prevent assigning incompatible skeletons in (e.g.) asset pickers etc.
Skeleton compatibility checks in editor can now be disabled in the editor preferences (and each asset picker now has a checkbox option in its view settings that allows for quick access to this).

Moves FSkeletonRemapping to its own file (which is now private).
Skeleton remappings are now generated on demand on worker threads just before animation decompression and stored in a registry, guarded by FRWScopeLock for thread-safety.

Fixed some anim BP compiler edge cases where asset references on pins were not getting preloaded correctly, causing skeletons to be erroneously reported as missing.

Exposed the current asset registry filter in SAssetView so that menu extensions can access it (and use it to provide context)

#jira UE-166054
#jira UE-167355
#rb Jurre.deBaare,John.vanderBerg
#preflight 635902602e6690262afa86f9

[CL 22878911 by Thomas Sarkanen in ue5-main branch]
2022-11-01 06:25:59 -04:00
Thomas Sarkanen
0196c12d6c Added support for copy/paste for curve viewer
#jira UE-168242
#rb Keith.Yerex
#preflight 635a52369b2e9c76c7fc133f

[CL 22806858 by Thomas Sarkanen in ue5-main branch]
2022-10-27 05:56:15 -04:00
henrik karlsson
0da5962f86 Removed lots of includes in UE based on compile profiling
#preflight 6356cb02ae33b04ec1e358ac
#rb none

[CL 22786278 by henrik karlsson in ue5-main branch]
2022-10-26 15:02:30 -04:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
Keith Yerex
6e2c3878b1 Fix FScopedTransaction instances missing a variable name, and add NODISCARD to FScopedTransaction to prevent this from happening in future.
#rb JeanMichel.Dignard
#preflight 635079e2ac48fa11ed65932c

[CL 22658047 by Keith Yerex in ue5-main branch]
2022-10-20 11:51:57 -04:00
alexis matte
fe35eb697a Interchange:
- Skeletal mesh is now import using the skeletalmesh compile system to make sure all properties are locked and will stall another thread trying to access them.
---- This fix multiple crash if a viewer display the skeletal mesh and use some properties.
- Remove animation pipeline ensure(no skeleton) if we import with force static mesh and there is some translated animation node
- Fix crash when importing static mesh and the get mesh payload return an empty mesh description
- Reimport of skeletalmesh is not calling anymore postedit change if we reimport with interchange, interchange will call it in a post edit step.
---- This fix multiple crash if a viewer display the bones of the re-import skeletal mesh.
General:
- Reimport handler now have a reimport async version so the caller can control if a reimport is done asynchronously or synchronously

#jira UE-166986
#rb danny.couture , jeanluc.corenthin
#rnx
#lockdown jeanmichel.dignard
#preflight 634f61fdec03b54e9cdfe0bf

[CL 22634973 by alexis matte in ue5-main branch]
2022-10-19 15:15:54 -04:00
eric knapik
ebeb6781c1 Animation BP toolbar trimming & permissions
* Tab filters are now applied before tab widgets before are created for animation blueprint editor instead of only when a user tries opening a new tab. This prevents disallowed tabs in default layouts being created.
* Event graph documents are not opened if event graph permissions are disabled when loading blueprint editor.
* Added new blueprint permission to optionally disable function overrides.

#rb thomas.sarkanen
#preflight 6346928ef04e6f8505f7b879

[CL 22547860 by eric knapik in ue5-main branch]
2022-10-15 02:13:23 -04:00
jaime cifuentes
b73f2f3e20 Truncation fixes for SkeletonEditor module
#rb
#jira UE-166636
#preflight 63493441a8717e9453adcf69

[CL 22524449 by jaime cifuentes in ue5-main branch]
2022-10-14 06:29:48 -04:00
lucas dower
25ebcb10ba Fix for blend profile slider transaction spam each time the slider moves slightly.
* A transaction is now made from when the slider begins moving to when the value is committed.

#jira UE-137121
#rb thomas.sarkanen
#preflight 633708e1d165c45137089a35

[CL 22279187 by lucas dower in ue5-main branch]
2022-09-30 15:49:04 -04:00
thomas sarkanen
0eb8edb6d5 Fix blend profiles submenu not appearing on a subsequent opening of a skeleton
Correctly apply context to tool menu

#jira UE-164429
#rb Jurre.deBaare
#preflight 63319338665f6b8f7fe54c45

[CL 22188382 by thomas sarkanen in ue5-main branch]
2022-09-26 13:23:13 -04:00
jose villarroel
2c5b30f7dd Fix CIS localization warning in SSkeletonTree
#jira none
#rb trivial
#preflight skip

[CL 22163469 by jose villarroel in ue5-main branch]
2022-09-23 19:58:22 -04:00
jose villarroel
5a184e07ff Different blend profile modes have their own section in pickers
#jira UE-101588
[REVIEW] [at]Thomas.Sarkanen
#preflight 632c7304b4515b7e22cdbb01

[CL 22145896 by jose villarroel in ue5-main branch]
2022-09-22 17:39:33 -04:00
benoit gadreau
d6a1908c70 follow the NumericValueChanged paradigm when pasting values + transaction
#jira UE-159365
#rb thomas.sarkanen
#preflight 6329bb63826e0c2fe945f50d

[CL 22094354 by benoit gadreau in ue5-main branch]
2022-09-20 11:39:48 -04:00
lucas dower
0ac5ddabcf Fix for blend profile rename being reset when committing via clicking to lose focus
* No longer have to explicitly press Enter to commit to the name change.

#jira UE-158072
#rb thomas.sarkanen
#preflight 6329b9cd9840225da2638c0d

[CL 22094263 by lucas dower in ue5-main branch]
2022-09-20 11:37:06 -04:00
lucas dower
a5b975ca24 Fix for Persona mesh details text overlay blocking hit tests
* Fix for Persona mesh sections showing as selectable when not.
* Fix for editor viewport cursor style not updating if using orbit camera mode.

#jira UE-157811
#rb thomas.sarkanen
#preflight 63246538ea1c94f4c5b3dfc7

[CL 22052213 by lucas dower in ue5-main branch]
2022-09-16 12:44:00 -04:00
kiaran ritchie
9ece7682e8 Adding "Preview Scene Settings" tabs to IK Rig & Retarget editors.
This change also added a delegate to FPersonaToolkitArgs with reference to a IDetailBuilderLayout so assets can customize the Preview Scene Settings.

#JIRA https://jira.it.epicgames.com/browse/UE-148894
#rb halfdan.ingvarsson
#preflight
#preflight 631b7a00967ffc68fb262e06

[CL 21924418 by kiaran ritchie in ue5-main branch]
2022-09-09 13:58:03 -04:00
jaime cifuentes
b1d5d73613 SSkeletonTree : Fixed LOD bone reduction RequiredBones calculation, when done from the SkeletonTree
#rb thomas.sarkanen
#jira UE-60491
#preflight 6316f04aab25bb91f5eaf8bb

[CL 21807749 by jaime cifuentes in ue5-main branch]
2022-09-06 03:07:07 -04:00
bryan sefcik
8cc129f2b6 IWYU Pass 1 - Engine/Source/Editor/...
#jira
#preflight 6306736ac85b7fef22be7751

[CL 21558583 by bryan sefcik in ue5-main branch]
2022-08-24 22:45:13 -04:00