Commit Graph

287 Commits

Author SHA1 Message Date
helge mathee
2979d9163a GraphEditor: Guard against trashed UEdGraphPins
#rb sara.schvartzman
#preflight https://horde.devtools.epicgames.com/job/64076c682559570cc7e26bc4

[CL 24556125 by helge mathee in ue5-main branch]
2023-03-08 04:19:40 -05:00
halfdan ingvarsson
a233962e1e Control Rig: Link creation performance improvements
[FYI] benoit.gadreau
#rb sara.schvartzman
#preflight 63ef951f977ceed9151fad2e

[CL 24309702 by halfdan ingvarsson in ue5-main branch]
2023-02-20 02:18:32 -05:00
christopher waters
cad10136bf Removing dependencies on GraphEditor Private by moving GraphActionNode.h to its Public folder.
#preflight 63e159aacf24c08f2c924fb2

[CL 24040429 by christopher waters in ue5-main branch]
2023-02-06 18:06:48 -05:00
christopher waters
fc59298fcd Removing GraphEditor private includes via moving SGraphPinEnum.h to the Public folder.
#preflight 63dd804b1b44ee7cb1851048

[CL 24035653 by christopher waters in ue5-main branch]
2023-02-06 14:21:12 -05:00
Patrick Boutot
6e02de5817 Fix memstomp with color picker. Prepare SColorPicker for API change. Update AssetViewUtilis::PathColors to use FLinearColor instead of shared pointer. The shared pointer was only needed for the SColorPicker.
#jira UE-173303, UE-173454
#review-23672715 23617361,23611673
#rb daren.cheng
#preflight 63c0b12b1a06fc61059f2fa3

[CL 23672712 by Patrick Boutot in ue5-main branch]
2023-01-12 20:33:08 -05:00
phillip kavan
f67d259b19 CIS non-unity fix.
#rb None (trivial)

[CL 23671984 by phillip kavan in ue5-main branch]
2023-01-12 19:09:47 -05:00
phillip kavan
0507c05d34 Extend SGraphActionMenu to allow owners to directly provide the action menu source list at refresh time.
#jira UE-167392
#rb Lauren.Barnes
#preflight 63c075b20225f00e14ab8664

[CL 23671671 by phillip kavan in ue5-main branch]
2023-01-12 18:36:13 -05:00
jaime cifuentes
a20a6e0027 Added validation and visual error functionality to AnimNode_SkeletalControlBase, which can be used to check referenced bones and show errors on the AnimGraph nodes that use them (so it is clear if the setup does not work due to a bone missing)
#rb thomas.sarkanen
#jira UE-160111
#preflight 63b85453c927e34482895de4

[CL 23599353 by jaime cifuentes in ue5-main branch]
2023-01-06 12:16:12 -05:00
henrik karlsson
b5164ac775 Fixes to make modules compile with IWYU. We've added to IWYU toolchain so it compiles "orphaned" headers which does not have a owning cpp file. This identified lots of headers that couldn't be compiled by themselves (or if they were to included first)
Change consist of only forward declaration and additional includes

#preflight 63789c1de30d438849c48188
#rb none

[CL 23218412 by henrik karlsson in ue5-main branch]
2022-11-21 03:22:23 -05:00
benjamin jillich
a6ef0d5b7f [UE-136096] Relinking transitions in anim graph state machines
[UE-168360] User can create a transition from a state into the entry state

* Relinking multiple transitions (transition nodes at once) when none of the transition nodes is selected.
* Selective relinking in case a subset of the transition nodes on a transitions are selected.
* Special case handling for transitions from entry state (they don't have a transition node connected).
* Drawing circle indicator around the arrow head in case the mouse cursor is approaching the transition.
* Hovering the arrow head of a transition highlights it by filling the circle with solid orange color and turning the arrow black.
* Ending the relink operation in empty space or the entry node will cancel the relink operation.
* Fixed bug that prevents creating new transitions ending in an entry state.

#jira https://jira.it.epicgames.com/browse/UE-136096
#jira https://jira.it.epicgames.com/browse/UE-168360
#preflight 636a169963037c10262bc421

[CL 23025287 by benjamin jillich in ue5-main branch]
2022-11-08 04:09:22 -05:00
Helge Mathee
5867d63b99 Control Rig: Visual representation of casts on connection lines
#rb sara.schvartzman
#jira UE-158186
#preflight https://horde.devtools.epicgames.com/job/63511d888176062ea72f4494

[CL 22653714 by Helge Mathee in ue5-main branch]
2022-10-20 08:55:17 -04:00
yohann dossantos
adb9f13530 Fix for regional issue (when using ',' as decimal separator) in the numeric and vector input in blueprint.
The regression was introduced a few weeks ago when fixing another bug.
The issue was that conversion functions (between float and string) using the current regionnal settings were introduced in the graph pins, but this kind of conversion is done in a lot of places and does not all support the different type of decimal separator ('.' or ','). So those conversion functions were not supporting the new format of decimal they were receiving.
Also, while the bug is mentionning issue with float, it was existing also for vector.
Bonus: remove a bit of duplicated code.

#jira UE-162993, UE-159512
#rb jamie.dale massimo.tristano patrick.boutot

#test In blueprint/niagara/material, played with node using float, vector, rotator, to ensure that everything was behaving as expected with 2 regional settings (english with '.' decimal separator, french with ',' separator).
Validated that the initial bug (selecting default value with the mouse but not changing it was adding an entry in the undo stack), was still fix.
#preflight 6329be440a4ad044de92d0c9

[CL 22094319 by yohann dossantos in ue5-main branch]
2022-09-20 11:38:57 -04:00
dave jones2
1b50b70aee UE-160862 - Fix FW-Gameplay miscellaneous module truncation warnings
#jira UE-160862
#preflight 63191b1cb069eea9ab594ea2
#rb andrew.davidson

[CL 21974045 by dave jones2 in ue5-main branch]
2022-09-12 18:16:22 -04:00
bryan sefcik
0837230669 Ran IWYU again on half of the Engine/Source/Editor/... source files.
#jira

[CL 21716414 by bryan sefcik in ue5-main branch]
2022-08-30 23:03:03 -04:00
bryan sefcik
8cc129f2b6 IWYU Pass 1 - Engine/Source/Editor/...
#jira
#preflight 6306736ac85b7fef22be7751

[CL 21558583 by bryan sefcik in ue5-main branch]
2022-08-24 22:45:13 -04:00
massimo tristano
a2934e54d2 Fix SGraphPinNum bug causing value not to change in the Niagara editor when the user enters a new value.
#rb kevin.ortegren
#preflight 63034cf8c00af5e294de9df3

[CL 21481129 by massimo tristano in ue5-main branch]
2022-08-22 05:37:51 -04:00
massimo tristano
c333401cd5 Re-introduced 21440571 after fixing a crash opening some Blueprints. From 21440571:
Fixed Scalar Parameter and Vector node to avoid triggering a component value change transaction if the user only clicks on the textbox (without effectively changing the value).

Currently when the user clicks on a Scalar or Vector parameter text box and then simply deselects the node, a data change is erroneously detected and a transaction is pushed onto the Undo stack. This change fixes the logic that determines whether the value is actually changed, removing these spurious and redundant transactions.

#rb sebastian.nordgren
#jira UE-159512
#preflight 62ff9986f7404b55a326ce08

[CL 21457315 by massimo tristano in ue5-main branch]
2022-08-19 10:40:49 -04:00
ben hoffman
3cd99fcd75 Revert 21442104 because it crashes a blueprint when you open it.
#fyi massimo.tristano
#preflight skip
#rnx
#jira UE-161349

[CL 21448370 by ben hoffman in ue5-main branch]
2022-08-18 15:31:18 -04:00
massimo tristano
1f8d25197d Fixed Scalar Parameter and Vector node to avoid triggering a component value change transaction if the user only clicks on the textbox (without effectively changing the value).
Currently when the user clicks on a Scalar or Vector parameter text box and then simply deselects the node, a data change is erroneously detected and a transaction is pushed onto the Undo stack. This change fixes the logic that determines whether the value is actually changed, removing these spurious and redundant transactions.

#rb sebastian.nordgren
#jira UE-159512
#preflight 62fe4890200ff87e07bddf46

[CL 21442104 by massimo tristano in ue5-main branch]
2022-08-18 10:39:09 -04:00
Rob Gay
2ae22b2f87 Make Graph Knot API public so it can be extended
#preflight 62f186fe086f90bbc47f1c70

[CL 21276599 by Rob Gay in ue5-main branch]
2022-08-08 18:06:03 -04:00
dave jones2
52ee51c6a8 Build fix - missing headers.
#jira UE-158700
#rb none
#preflight none

[CL 20971216 by dave jones2 in ue5-main branch]
2022-07-06 15:11:16 -04:00
dave jones2
3799e9c331 UE-157166 - Vector literal pins lack precision with high values
Similar to other numerical Slate widgets, we need to templatize SGraphPinVector so that it can choose between a float and double representation. Currently, only the BP editor will use the double variant, while other tools continue to use a float.

This also update SGraphPinVector2D and SGraphPinVector4 to use a template. While we do use SGraphPinVector2D in BPs, we currently don't use SGraphPinVector4. However, that may change in the future.

#jira UE-157166
#preflight 62bf6898c438da7f09e95af0
#rb andrew.davidson

[CL 20947777 by dave jones2 in ue5-main branch]
2022-07-05 15:33:08 -04:00
jordan hoffmann
f2957e798a [Bug Fix] Navigating the Event Graph in Blueprint Diff window causes visual snapping issues
#jira UE-156552
#rb Phillip.Kavan
#preflight 62b245a4e9509b62d927a108
#preflight 62b24d09604d9ccfc7422282

[CL 20767743 by jordan hoffmann in ue5-main branch]
2022-06-21 19:07:19 -04:00
Marc Audy
e2dd041c0f Fix static analysis warnings
#codereview Helge.Mathee
#rnx
#preflight

[CL 20618311 by Marc Audy in ue5-main branch]
2022-06-11 22:32:15 -04:00
jordan hoffmann
490bccda39 [Feature] blueprint diff node outlines colored by diff state
#jira UE-150555
#rb aditya.ravichandran
#preflight 62a38ead2558795127e232d0

[CL 20600224 by jordan hoffmann in ue5-main branch]
2022-06-10 14:52:59 -04:00