Commit Graph

49 Commits

Author SHA1 Message Date
Dmitry Rekman
477e61d251 Shadowing fixes in IPv6 socket.
#codereview Ryan.Gerleve

[CL 2521643 by Dmitry Rekman in Main branch]
2015-04-22 16:08:44 -04:00
Bart Bressler
c58ceb419b Add a couple more error codes for getaddrinfo
#codereview dmitry.rekman

[CL 2516091 by Bart Bressler in Main branch]
2015-04-17 12:47:16 -04:00
Bart Bressler
f22ab9f178 Add winsock specific error messages to TranslateGAIErrorCode
[CL 2514403 by Bart Bressler in Main branch]
2015-04-16 11:57:18 -04:00
Mike Fricker
114458bf0f Clang warning fixes: Fixed missing 'override' specifiers
- Also removed some unreferenced functions that adding 'override' revealed

PR #1002 -- Thank you, Omar007!

[CL 2498415 by Mike Fricker in Main branch]
2015-04-01 07:20:55 -04:00
Dmitry Rekman
e647eeb2a0 Hardened the beacons fix.
- Do not honor -multihome unless valid.
- More getaddrinfo() errors to ignore + more accurate error reporting.

#codereview Peter.Knepley, Josh.Markiewicz

[CL 2466955 by Dmitry Rekman in Main branch]
2015-03-02 16:50:10 -05:00
Saul Abreu
79a26091bf Fixed behavior on FString::ParseIntoArray (muliple delimiters overload) functionality to support optionally culling empty strings. Greatly simplified implementation logic. Output parameter now properly named and taken by reference.
#codereview Steve.Robb, Robert.Manuszewski

[CL 2466824 by Saul Abreu in Main branch]
2015-03-02 15:51:37 -05:00
Dmitry Rekman
a185b60b1f Fix for beacons not binding to 0.0.0.0.
The "smallest footprint" change, as the logic is a bit convoluted (the code is used by beacons and by OnlineSubsystemNull for slightly different purposes).

- Do not consider EWOULDBLOCK a failure and instead proceed to bind to any address.
- Honor -multihome= command line arg.

#codereview Peter.Knepley, Josh.Markiewicz

[CL 2466820 by Dmitry Rekman in Main branch]
2015-03-02 15:47:06 -05:00
Peter Knepley
3386e2cc95 Merging 2456661
Fix assert and still returning no error if an unexpected error code happens in bsd sockets getaddrinfo()

//depot/UE4-UT/...

to //depot/UE4/...

#codereview John.Pollard

[CL 2456666 by Peter Knepley in Main branch]
2015-02-23 14:39:18 -05:00
Jaroslaw Surowiec
beef593d5a Stats - Stats for async task running on the thread pool
[CL 2446649 by Jaroslaw Surowiec in Main branch]
2015-02-16 03:16:32 -05:00
Daniel Lamb
7413ce2bc7 Changed FSocket.GetPeerAddress to return a bool.
#codereview Josh.Markiewicz

[CL 2412787 by Daniel Lamb in Main branch]
2015-01-20 16:06:16 -05:00
Daniel Lamb
228a6e3add Added support for multiple client connections to the networkfileserver.
#codereview Josh.Markiewicz

[CL 2412234 by Daniel Lamb in Main branch]
2015-01-20 10:51:54 -05:00
Jaroslaw Surowiec
1085fb3b7a Core - UE/UE-6813 - Confusing API: We have both FMemory::MemZero() and FMemory:Memzero()
[CL 2405761 by Jaroslaw Surowiec in Main branch]
2015-01-14 04:21:10 -05:00
Dmitry Rekman
99fb9814fd Linux: return a non-loopback address for local host.
- Ubuntu/Debian/SteamOS have an entry in /etc/hosts that maps hostname to 127.0.1.1
- This breaks the code that tries to advertise local addr over LAN (e.g. OnlineSubsystemNull).
- Resolves UE-5407 (ShooterGame cannot join match)

#codereview Josh.Adams, Michael.Trepka

[CL 2401553 by Dmitry Rekman in Main branch]
2015-01-08 20:04:00 -05:00
Ben Marsh
149375b14b Update copyright notices to 2015.
[CL 2379638 by Ben Marsh in Main branch]
2014-12-07 19:09:38 -05:00
Jamie Dale
1c9697aa03 Fixed TranslateGAIErrorCode asserting when there was no error
#codereview Dmitry.Rekman

[CL 2369683 by Jamie Dale in Main branch]
2014-11-25 07:29:43 -05:00
Dmitry Rekman
e54b2a1f0f Translate getaddrinfo() in a separate function.
#codereview Bart.Bressler, Ryan.Gerleve, Josh.Markiewicz, John.Pollard

[CL 2369297 by Dmitry Rekman in Main branch]
2014-11-24 18:29:41 -05:00
Dmitry Rekman
d3bb66e2af Bind to any address if cannot resolve hostname.
- This was the actual behavior before CL 2363558 (UE-4390).
- Fixes FORT-2795 with servers crashing on certain VM setups.
- Also, map getaddrinfo() error codes to cross-platform enum.

#codereview Bart.Bressler, John.Pollard

[CL 2369070 by Dmitry Rekman in Main branch]
2014-11-24 17:40:21 -05:00
Ben Zeigler
c0dae66f68 #UE4 Fix non-windows bsd sockets, they all access Socket directly so it can't be private
#codereview max.preussner

[CL 2364501 by Ben Zeigler in Main branch]
2014-11-18 22:35:20 -05:00
Max Preussner
cd3ced6cbc Sockets: Disabling socket handle inheritance on Windows
Windows enables inheritance for socket inheritance by default, which causes open listener sockets to be passed to client processes. This causes problems in certain scenarios, for example when restarting the Editor to load a new project, or when interfacing with the Android SDK (adb.exe).  Child processes or new instances of the Editor are then not able to bind to the listener ports.

#CodeReview: sam.zamani

[CL 2364217 by Max Preussner in Main branch]
2014-11-18 19:09:38 -05:00
Max Preussner
ec87082180 Sockets: Code and documentation cleanup pass
[CL 2364175 by Max Preussner in Main branch]
2014-11-18 18:49:50 -05:00
Bart Bressler
a818b25d70 Fix UE-4390 - convert gethostbyname function calls to getaddrinfo function calls.
[CL 2363558 by Bart Bressler in Main branch]
2014-11-18 12:24:38 -05:00
Marcus Wassmer
8ae2ba326c Integrate final set of cert changes for Shootergame ps4.
[CL 2345540 by Marcus Wassmer in Main branch]
2014-10-30 18:13:48 -04:00
Ryan Gerleve
9dd2e948b1 Combine the implementations of TranslateFlags.
[CL 2339282 by Ryan Gerleve in Main branch]
2014-10-23 18:47:12 -04:00
Dmitry Rekman
0aa67c6c34 Place IPv6 TranslateFlags() in a different namespace.
- Fixes unity build when both IPv4 and IPv6 sockets happen to be in a single compile unit.

#codereview Ryan.Gerleve

[CL 2339241 by Dmitry Rekman in Main branch]
2014-10-23 18:27:07 -04:00
Ryan Gerleve
521f860fd7 Translate socket flags to handle platforms that define them with different values.
#codereview john.pollard

[CL 2338997 by Ryan Gerleve in Main branch]
2014-10-23 16:01:35 -04:00