Commit Graph

153 Commits

Author SHA1 Message Date
andrew grant
7c2df5fb70 Editgrate fix for warning about -ddc=default not being a valid backend
[FYI] marc.audy

#ROBOMERGE-SOURCE: CL 13043962 via CL 13043963 via CL 13043964
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v683-13008971)

[CL 13043965 by andrew grant in Main branch]
2020-04-24 20:11:55 -04:00
andrew grant
387622c149 Removed some debugging code that was accidentally submitted.
Droped some debug logging to VeryVerbose
Set EngineTest back to regular DDC logging

#jira UE-92249 UE-92221
#rb swarm
[FYI] devin.doucette

#ROBOMERGE-SOURCE: CL 12954517 in //UE4/Release-4.25/... via CL 12954529 via CL 12958534
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 12958578 by andrew grant in Main branch]
2020-04-21 14:45:10 -04:00
andrew grant
835b997f53 Edit-grated improved DDC behavior logging from Main to get better info around failing cooked tests
Temporarily turning on verbose DDC logging for EngineTest project

[FYI] zabir.hoque ben.ingram
#jira #rb na
#lockdown cristina.riveron

#ROBOMERGE-OWNER: andrew.grant
#ROBOMERGE-AUTHOR: andrew.grant
#ROBOMERGE-SOURCE: CL 12911373 in //UE4/Release-4.25/... via CL 12911375 via CL 12911433
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 12911435 by andrew grant in Main branch]
2020-04-19 14:32:34 -04:00
ben ingram
8b1cd24d0b #jira none
Add some more verbose DDC logging
#rb none

#ROBOMERGE-OWNER: ben.ingram
#ROBOMERGE-AUTHOR: ben.ingram
#ROBOMERGE-SOURCE: CL 12905133 in //UE4/Release-4.25/... via CL 12905135 via CL 12905175
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 12907642 by ben ingram in Main branch]
2020-04-18 16:05:20 -04:00
andrew grant
e7779bd965 Added DDC options to engine test to investigate corruption issue
- VerifyDDC option is now correctly passed to the editor for editor-based tests and the cooker for cooked tests
- DDC= option added that allows kicked tests to use a different DDC backend (e.g. noshared). Defaults to 'default' which will use the default DDC set up.

[FYI] zabir.hoque
#jira nojira
#rb swarm
#lockdown cristina.riveron

#ROBOMERGE-SOURCE: CL 12726902 in //UE4/Release-4.25/... via CL 12726918 via CL 12781760
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v681-12776863)

[CL 12782565 by andrew grant in Main branch]
2020-04-14 13:41:19 -04:00
josh adams
c8e00d8797 - Fixed missing DDCUtils.dll error
[FYI] bob.tellez
#rb trivial

#ROBOMERGE-SOURCE: CL 12716604 via CL 12716607 via CL 12716608
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v676-12543919)

[CL 12716617 by josh adams in Main branch]
2020-04-10 00:10:33 -04:00
josh adams
4b52d412cf - Moved some engine modules from NotForLicensees/NoRedist to Restricted
#rb ben.marsh, advisor

#ROBOMERGE-SOURCE: CL 12691853 via CL 12691860 via CL 12691865
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v676-12543919)

[CL 12691873 by josh adams in Main branch]
2020-04-09 13:18:06 -04:00
andrew grant
c0c327ac48 Fix for shader compilers showing message about unmapped drives
[FYI] chance.ivey
#rb swarm

#ROBOMERGE-SOURCE: CL 12678563 via CL 12678843 via CL 12678861 via CL 12678882
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12678920 by andrew grant in Main branch]
2020-04-08 16:41:08 -04:00
andrew grant
bccf8a1464 DDC Optimization for slow caches in the hierarchy -
* Reduce the calls to CachedDataProbablyExists in DDC hierarchy when forward/backfilling other caches and skip entirely for slower caches.
* Added some comments for future visitors.

#tests Benchmark PIE test with warm & cold caches. On fiber shows a ~20 sec gain with a warm cache and 3mins with cold to AthenaTestBed (likely a 3-5x multiple on slower connections).

#rb swarm
[at]devin.doucette

#ROBOMERGE-SOURCE: CL 12669758 via CL 12669760 via CL 12669761 via CL 12669762
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12669764 by andrew grant in Main branch]
2020-04-07 21:48:22 -04:00
andrew grant
9507ad45d6 Removed some deoptimization pragmas that were left in accidentally.
#rb trivial

#ROBOMERGE-SOURCE: CL 12653726 via CL 12653737 via CL 12653738 via CL 12657818 via CL 12657855 via CL 12657880
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12657904 by andrew grant in Main branch]
2020-04-07 12:47:12 -04:00
andrew grant
2d7a1db75c Changed the S3 DDC backend so it elects not to write to lower cache levels.
(This value is only checked on backends that have a cache of the data, so data that is not in the S3 DDC will still be written back to lower levels if the S3 cache misses).

Changed the speed class for backends to be elligible to be backfilled to fast.

[at]devin.doucette [at]ben.marsh

#ROBOMERGE-SOURCE: CL 12647496 via CL 12647501 via CL 12649274 via CL 12649832 via CL 12649856 via CL 12649891
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12649923 by andrew grant in Main branch]
2020-04-07 00:58:22 -04:00
andrew grant
8b29dd89a2 Fixed crash when verbose DDC logging is enabled
#rb trivial

#ROBOMERGE-SOURCE: CL 12647456 via CL 12647457 via CL 12649270 via CL 12649828 via CL 12649852 via CL 12649887
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12649913 by andrew grant in Main branch]
2020-04-07 00:58:12 -04:00
andrew grant
919e5daa5c Fix for DDC warnings in Fortnite EC jobs that use UnrealPak.
- Use a GUID rather than machine ID for write tests for programs (ShaderCompilerWorker, UnrealPak) that spin up multiple instances.

- When creating missing files for read-tests check if a failure could have been due to another instance creating that path at the same time.

- Improved some logging of issues to make future diagnosis of issues easier.

#rb swarm
[at]ryan.durand [at]devin.doucette

#ROBOMERGE-SOURCE: CL 12629650 via CL 12631522 via CL 12631547 via CL 12631579 via CL 12631609 via CL 12631644
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12631701 by andrew grant in Main branch]
2020-04-06 15:54:34 -04:00
ben marsh
538ac728ad Allow disabling the S3 backend by setting the UE-S3DataCachePath environment variable to "None"
#rb none
#jira

#ROBOMERGE-SOURCE: CL 12486037 via CL 12486375 via CL 12486409 via CL 12486440
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v673-12478461)

[CL 12487544 by ben marsh in Main branch]
2020-03-30 12:12:06 -04:00
andrew grant
963ad0c629 Allow users to customise S3 path by setting an UE-S3DataCachePath environment variable. If not set the default of ProjectDir/Saved/S3DDC is still used
#rb swarm
[at]devin.doucette [at]ben.marsh
[FYI] antoine.guilbaud
#tests Booted editor and PIE'd into AthenaTest with UE-S3DataCachePath set to a different drive. Verified data is there.

#ROBOMERGE-SOURCE: CL 12474206 via CL 12474221 via CL 12474232 via CL 12474240
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12474252 by andrew grant in Main branch]
2020-03-27 15:57:11 -04:00
andrew grant
95b59e82f4 Fixed a... typo? bad resolve? that was causing new data not to be written to DDC caches
[FYI] uriel.doyon, devin.doucette
#rb uriel.doyon

#ROBOMERGE-SOURCE: CL 12473303 via CL 12473315 via CL 12473325 via CL 12473327
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12473331 by andrew grant in Main branch]
2020-03-27 14:57:01 -04:00
andrew grant
6a3a6a6425 Temp workaround for FORT-273296 while I investigate why ShaderCompiler on Mac doesn't like the speed test option.
[FYI] stefan.boberg
#rb na
#tests compiled SCW and booted into editor with -noshaderddc to force shader compiles

#ROBOMERGE-SOURCE: CL 12466138 via CL 12468387 via CL 12468494 via CL 12468566
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12468580 by andrew grant in Main branch]
2020-03-27 11:20:28 -04:00
andrew grant
14d1b683f8 Moved some DDC debug options into a common class that can be provided to a backend to simulate certain behavior.
E.g.

'-ddc-local-missrate=50' simulates a 50% miss rate of keys on the local backend,
'-ddc-shared-misstypes=AnimSeq' simulates misses for any AnimSeq key. Use + to combine keys. E.g. AnimSeq+Audio

Memory DDC, FileSystemDDC and S3DDC support these options as do the classes that wrap other backends (e.g. AsyncPut).

#tests lots of warm and cold DDC
#swarm https://p4-swarm.epicgames.net/reviews/12458696

#ROBOMERGE-SOURCE: CL 12466119 via CL 12466177
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12466179 by andrew grant in Main branch]
2020-03-27 08:12:16 -04:00
andrew grant
e224300cc3 Moved some DDC debug options into a common class that can be provided to a backend to simulate certain behavior.
E.g.

'-ddc-local-missrate=50' simulates a 50% miss rate of keys on the local backend,
'-ddc-shared-misstypes=AnimSeq' simulates misses for any AnimSeq key. Use + to combine keys. E.g. AnimSeq+Audio

Memory DDC, FileSystemDDC and S3DDC support these options as do the classes that wrap other backends (e.g. AsyncPut).

#tests lots of warm and cold DDC
[at]ben.marsh [at]josh.engebretson [at]devin.doucette

#ROBOMERGE-SOURCE: CL 12458693 via CL 12462167 via CL 12464485 via CL 12464606
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12464717 by andrew grant in Main branch]
2020-03-26 20:55:39 -04:00
ben marsh
a4c0ecd2eb Suppressing errors about S3DDC if disabled.
#jira

#ROBOMERGE-SOURCE: CL 12455905 via CL 12455924 via CL 12455926 via CL 12460993 via CL 12461148
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12461272 by ben marsh in Main branch]
2020-03-26 17:59:17 -04:00
ben marsh
604cd08968 Enable S3DDC by default if available, with a check for canary file not reachable from internal IPs. Also add an editor setting (in the Global panel) for disabling it.
Also suppress some warning messages when a download is cancelled.

[FYI] Andrew.Grant
#jira

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 12453891 via CL 12454085 via CL 12454109 via CL 12459232 via CL 12459415
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12459547 by ben marsh in Main branch]
2020-03-26 17:03:08 -04:00
andrew grant
178b067378 Temporrily disabling filesystem DDC optimization that breaks virtual texturing
[FYI] jeremy.moore
#rb na


#ROBOMERGE-SOURCE: CL 12420666 via CL 12425989 via CL 12436837
#ROBOMERGE-BOT: (v671-12333473)

[CL 12442290 by andrew grant in Release-Engine-Staging branch]
2020-03-26 07:31:34 -04:00
andrew grant
3cc86b3d2f Optimizations for DDC access on remote / slow drives.
If a filesystem node is not available not prompt the user and optionally retry incase they need to mount a drive or start VPN

Fiilesystem nodes now perform a speed test using a selection of 'DDC sized' files to determine a classification (local, fast, ok, slow).

Add a new 'ConsiderSlowAt' property to the 'Filesystem' DDC node type. If latency to the node is >= this value then the node will be marked as slow which disables touch'ing and reduces file stats

Interface Changes

- Add the concept of a speed class to nodes
- Add GetName to nodes for better debugging / logging
- WouldCache query that allows caches to opt of of consideration early and avoid async tasks being created.
- Create a new 'FileBackedDerivedDataBackend' class that's the for the memory/boot backend and future classes
- TryToPrefetch interface functions for future use

Behavior Changes

- Moved parameter parsing into FileSysteDerivedDataBackend as things were getting out of hand
- FileSystemDerivedDataBackend now performs a speed test using 'DDC sized' files in separate directories and applies a classification
- Slow locations turn off touching of data on read
- Slow locations always return true for CachedDataProbablyExists. It's faster just to try to read and fail
- If the shared DDC is not available the user is prompted incase they need to mount it.

[at]ben.marsh [at]josh.engebretson
#rb swarm
#tests lots of PIE runs with / without this option


#ROBOMERGE-SOURCE: CL 12387516 via CL 12387517 via CL 12396622
#ROBOMERGE-BOT: (v671-12333473)

[CL 12396757 by andrew grant in Release-Engine-Staging branch]
2020-03-24 19:12:36 -04:00
devin doucette
77c43f6842 Improved DDC error when no backends are available
#jira UE-90680
#rb Zousar.Shaker
[RN] fix Core/Cooker

#ROBOMERGE-SOURCE: CL 12247507 in //UE4/Release-4.25/... via CL 12247524
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v668-12245121)

[CL 12247553 by devin doucette in Main branch]
2020-03-18 11:14:04 -04:00
Devin Doucette
e8ba41d54f Changed FStringView parameters to virtual functions to pass by value instead of by reference
This is the preferred way to use string views. These interfaces were added in 4.25 so this is the time to fix them without breaking user code.

#jira none
#rb trivial
#rnx

#ROBOMERGE-OWNER: Devin.Doucette
#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 12236111 in //UE4/Release-4.25/... via CL 12236115
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v664-12234175)

[CL 12238549 by Devin Doucette in Main branch]
2020-03-17 22:32:03 -04:00