Commit Graph

70 Commits

Author SHA1 Message Date
Tim Smith
5fb833c5c1 Added support for more arbitrary property changes to live coding.
1) Changed the pre/post compile notifications from module notifications to process commands.
2) Added server command to notify that we want re-instance patching (two phase)
3) Added support for two phase patching to enable re-instancing without all the limitations.
4) Added a null CDO check for old blueprint classes (approved by Phillip)

#rb ben.marsh
#rnx
#preflight 6086e3481046fb000183c2d4

[CL 16115620 by Tim Smith in ue5-main branch]
2021-04-26 12:49:25 -04:00
Marc Audy
01b7c9f4f5 Merge UE5/RES @ 15958325 to UE5/Main
This represents UE4/Main @ 15913390 and Dev-PerfTest @ 15913304

[CL 15958515 by Marc Audy in ue5-main branch]
2021-04-08 14:32:07 -04:00
Tim Smith
737ad605ed Fixing Clang warnings in LiveCoding
#rb devin.doucette
#jira UE-112494

[CL 15877566 by Tim Smith in ue5-main branch]
2021-03-31 13:00:20 -04:00
halfdan ingvarsson
e5c856c8c9 Instead of relying on non-conflict with library-provided wmemchr, just re-implement std::wstring::find on top of wcsstr for clang 11.0 on Windows only.
#jira none
#rb tim.smith
#rnx

[CL 15860653 by halfdan ingvarsson in ue5-main branch]
2021-03-30 09:03:46 -04:00
tim smith
238c0372a1 Removing UE4 from code
#rb none
#jira UE-111710

#ROBOMERGE-SOURCE: CL 15852066 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15852981 by tim smith in ue5-main branch]
2021-03-29 13:42:53 -04:00
halfdan ingvarsson
c8d619d990 Workaround for a bug in clang-cl 11.0 when building in C++17 mode, where __builtin_wmemchr is not implemented.
#jira none
#rb tim.smith
#rnx

[CL 15850274 by halfdan ingvarsson in ue5-main branch]
2021-03-29 09:23:17 -04:00
Tim Smith
196d6c5b42 Fix improper extern declaration that caused issues with Clang but not MSVC (Clang was right IMHO)
#rb trivial
#jira UE-111492

[CL 15747765 by Tim Smith in ue5-main branch]
2021-03-19 11:36:00 -04:00
Tim Smith
a2237e050d LiveCoding Re-instancing
LIMITATIONS:

1) Re-instancing will only update UClass instance data.
2) Adding and removing properties should only be done towards the end of a class or structure and can not be followed by complex data types.
3) Adding and removing properties from a base class should not be done if a derived class contains complex data types.

KNOWN ISSUES:

1) Changes to enumerations and structures will not be reflected in existing blueprints.  However, adding new nodes to the blueprint will show the updated enumeration or structure.
2) If a class contains an enumeration or structure as a member, the class will not be re-instanced if enumeration or structure is changed.

CHANGES:

1) LiveCodingServer
1a) Modified to always execute certain static instances during load.
1b) Modified to exclude the _Statics static structures to avoid patching to old copies.

2) Added support for LiveCoding reinstancing
2a) Refactored deferred registration system for UClass, UEnum, and UScriptStruct to use a common system that works for normal game, hot reload and live coding.
2b) Type specific version check data is possible (i.e. enum doesn't have a size)
2c) Single registration static for UClass
2d) Single registration class for all types that is just a blind forward to API.
2e) Static and dynamic registrations use different API entry points to avoid having overloaded argument lists that just apply to one or the other.
2f) Shims for older API

3) New common "Reload" system to avoid using HotReload code.
3a) Support common delegates regardless of who is reloading/reinstancing.
3b) Re-instancing code moved from HotReload to Kismet2 (where the bulk of the re-instance code already existed).
3c) Modified PyWrapper to use new helper class instead of depending on HotRelaod
3d) Added WITH_RELOAD which is defined if HotReload or LiveCoding is enabled.
3e) Modifed existing code to use new #define and delegates.

Robert did the review on the changes covered by Part 2.  Remaining changes are all straightforward.

#rb robert.manuszewski
#jira UE-74493

[CL 15736777 by Tim Smith in ue5-main branch]
2021-03-18 08:13:59 -04:00
Tim Smith
bbe145fc4d Refixing a PVS warning stomped by the integration
#rb trivial
#jira none
#rnx

[CL 15136209 by Tim Smith in ue5-main branch]
2021-01-19 11:40:24 -04:00
Tim Smith
e599eed6a4 Integration of Live++ 1.6.4 (2021/18/01)
This fixes and re-enables a feature of 1.6 that didn't work in an Unreal environment.

#jira none
#rb trivial
#rnx

[CL 15131026 by Tim Smith in ue5-main branch]
2021-01-18 13:02:32 -04:00
Tim Smith
d193b70a3b Fixing PVS 7.7 Issues:
warning V781: The value of the 'XYZ' index is checked after it was used. Perhaps there is a mistake in program logic.

#rb trivial
#jira UE-91644

[CL 15066377 by Tim Smith in ue5-main branch]
2021-01-13 09:08:55 -04:00
Martin Ridgers
51437d6cf8 Fixed static analysis warning. The warning is correct; _setjmp is declared with and without the _Out_ annotation in setjmp.h and intrin.h respectively. It is however, harmless in this instance.
#rb none
#rnx

[CL 14968921 by Martin Ridgers in ue5-main branch]
2020-12-30 11:10:50 -04:00
Tim Smith
76cec15371 Fixing a PVS warning. Changing the code to avoid the + operator since PVS is having issues interpreting the code in this instance.
#rb trivial
#jira UE-104645

[CL 14946615 by Tim Smith in ue5-main branch]
2020-12-17 10:05:33 -04:00
Tim Smith
ca0e8a4101 Fixing a few PVS warning. The memcpy issue is intentional by the 3rd party library.
#rb trivial
#jira UE-104645

[CL 14940455 by Tim Smith in ue5-main branch]
2020-12-16 13:43:24 -04:00
Tim Smith
cae58c2372 Crash fix in LC_ClientStartupThread.cpp. If LPP is initialized but not started, the editor/game/cooker could crash on shutdown.
#rb trivial

[CL 14932140 by Tim Smith in ue5-main branch]
2020-12-15 12:53:25 -04:00
Tim Smith
b48b94b010 Integration of Live++ 1.6.3
#rb none
#rnx

[CL 14926202 by Tim Smith in ue5-main branch]
2020-12-15 09:27:44 -04:00
Marc Audy
ada7c144fa Merge //UE5/Release-Engine-Staging @14903491 to //UE5/Main
[CL 14906022 by Marc Audy in ue5-main branch]
2020-12-11 14:21:20 -04:00
Ben Marsh
e5c1cf2274 Fix static analysis warning.
#rb none
#rnx
#jira UE-87765

[CL 11199518 by Ben Marsh in Main branch]
2020-01-31 15:18:30 -05:00
Ben Marsh
0e6aa011b3 Copying //UE4/Dev-Build @ CL 11166028 to Dev-Main (//UE4/Dev-Main)
#rb none
#rnx

[CL 11166227 by Ben Marsh in Main branch]
2020-01-29 14:48:18 -05:00
ryan durand
471d972e62 Updating copyright for Engine Developer.
#rnx
#rb none


#ROBOMERGE-SOURCE: CL 10869240 via CL 10869516 via CL 10869902
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870584 by ryan durand in Main branch]
2019-12-26 15:32:37 -05:00
ben marsh
227ccc472b Fix compile error on Clang due to different behavior in scoping for extern'd variables.
#jira UE-79560


#ROBOMERGE-SOURCE: CL 8376935 via CL 8380487
#ROBOMERGE-BOT: (v402-8361577)

[CL 8380544 by ben marsh in Main branch]
2019-08-29 19:52:45 -04:00
ben marsh
1c50519254 LiveCoding: Add a delegate that's called when a Live Coding patch is applied.
#jira UE-79227
[FYI] Rex.Hill


#ROBOMERGE-SOURCE: CL 8362316 via CL 8362852
#ROBOMERGE-BOT: (v402-8361577)

[CL 8362915 by ben marsh in Main branch]
2019-08-28 12:34:28 -04:00
Ben Marsh
f2af127fe7 Fix some compile errors running with /permissive- on Windows.
#rb none
#rnx

[CL 8211779 by Ben Marsh in Main branch]
2019-08-22 10:52:35 -04:00
ben marsh
eaa2228904 Live Coding: Use FPlatformMisc::RequestExit(true) when quick restarting an application, to ensure that logs are flushed and the session is not considered an abnormal termination.
#rb none
#rnx
#jira

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 7713202 in //UE4/Release-4.23/... via CL 7713203
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v389-7813075)

[CL 7837351 by ben marsh in Dev-Build branch]
2019-08-06 23:07:22 -04:00
ben marsh
307c1187b1 Live Coding: Fix patches not being reapplied during a quick restart for lazy loaded modules. Now forces such modules to be enabled immediately if they have pending patches.
#rb none
#jira UE-77610
#rnx

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 7713016 in //UE4/Release-4.23/... via CL 7713017
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v389-7813075)

[CL 7837321 by ben marsh in Dev-Build branch]
2019-08-06 23:07:04 -04:00