Commit Graph

306 Commits

Author SHA1 Message Date
phil popp
07800695cd Replace use of FSoftObjectPath with UPROPERTY for dependent metasound assets.
#jira UE-156087
#rb rob.gay
#preflight 634841dffd22d1fbde5d7d73

[CL 22512918 by phil popp in ue5-main branch]
2022-10-13 17:38:11 -04:00
rob gay
d46c6dfa56 [Metasounds] Inputs not constructing TInputReceiverOperators intermittently causing parameter transmission to fail
#rb phil.popp
[REVIEW] phil.popp
#rnx
#jira UE-166767
#preflight 63472185663dafe41641788b

[CL 22489111 by rob gay in ue5-main branch]
2022-10-12 20:05:22 -04:00
phil popp
25b5881f1c Remove 5.0 channel format from MetaSoundSource and MetaSound WavePlayer node.
#jira UE-161170, UE-161172
#rnx
#preflight 63460236b757820b7aa1fdd2
#rb helen.yang

[CL 22482360 by phil popp in ue5-main branch]
2022-10-12 14:07:25 -04:00
rob gay
84771db13f Remove input receive node injection by implementing receive implementation within non-ctor input node operator
#rb phil.popp
[REVIEW] phil.popp
#rnx
#jira UE-166569
#preflight 63445c0f360ee7edea15afdb

[CL 22437484 by rob gay in ue5-main branch]
2022-10-10 15:44:28 -04:00
rob gay
0a1401644a Remove AnalyzerAddress from MetaSound Editor UX/auto-node registration
#rb helen.yang
[REVIEW] helen.yang
#jira UE-165926
#rnx
#preflight 63445019e94bf5d35ebd356f

[CL 22436806 by rob gay in ue5-main branch]
2022-10-10 15:21:30 -04:00
phil popp
a0c1e0840f Fix naming of metasound array node input
#jira UE-160926
#rb helen.yang
#preflight 633714be0d2b0d7bd8a415d4

[CL 22279846 by phil popp in ue5-main branch]
2022-09-30 16:23:15 -04:00
phil popp
aad06f1be7 Metasound DSP fixes around ADSR and triggers
- Updated logic on trigger delay node
- Updated logic for signalling that metasound generator is done
- Added ability to clear out selection of triggers
- Fixed ADSR situation when attack is zero.
#jira UE-162042
#rb Rob.Gay
#preflight 633714925c2225fe5f7ade1f

[CL 22279780 by phil popp in ue5-main branch]
2022-09-30 16:18:48 -04:00
rob gay
08f64dc10a [MetaSounds] Param loop virtualization fixes
- Split default param transmitter to SoundCueTransmitter & ParameterTransmitterBase to avoid generating transmitters for SoundBase child classes that don't support/require one (ex. SoundWaves)
- Move param transmitter to sharedptrs to avoid a bunch of unnecessary copy/clone logic when virtualizing loops
- Remove DefaultParameters field on ActiveSound in favor of shared impl in FParameterTransmitterBase that caches current state of parameters
- Fix for move that clears out active sound's current parameters when sound could have multiple wave instances that need said parameters
#rb phil.popp
#jira UE-164898
#preflight 6334a0a1ee7b13756dcd20ea

[CL 22240385 by rob gay in ue5-main branch]
2022-09-28 22:19:31 -04:00
bryan sefcik
50d4fac9e0 Updated ../Engine/Plugins/... to inline gen.cpp files
Before:
3548 unity files
Total CPU Time: 47343.578125 s
Total time in Parallel executor: 494.60 seconds

After:
3445 unity files
Total CPU Time: 46044.671875 s
Total time in Parallel executor: 468.51 seconds

#jira
#preflight 63336159b20e73a098b7f24f

[CL 22218213 by bryan sefcik in ue5-main branch]
2022-09-28 01:06:15 -04:00
phil popp
881a7f949e Fix for ensure on metasound audio tests accessing missing variable
#jira UE-164804
#rb trivial
#preflight 632ccc932c7bc831f8f1526f

[CL 22151098 by phil popp in ue5-main branch]
2022-09-22 22:19:02 -04:00
rob gay
3edfbbaa76 Fix null deref static analysis warning
#rb trivial
#jira none
#rnx
#preflight skip

[CL 22146897 by rob gay in ue5-main branch]
2022-09-22 18:02:34 -04:00
phil popp
fbe2bf4faa Adding graph name to warning log for metasound array nodes
#jira UE-159860
#preflight 632b95eab4515b7e22905d7d

[CL 22142966 by phil popp in ue5-main branch]
2022-09-22 15:30:27 -04:00
rob gay
9dbc0c6693 [MetaSounds] Editor Graph Syncronization Upgrade
- Move synchronize/details panel flag to more generic ModifyContext
- Do not use MarkAsGarbage as means of enforcing not to show object in details panel to avoid leaving objects in invalid state if undo called. Check ed graph membership instead
- Get rid of leaky namechanged delegates
    - Allows for migration to isolated synchronization in the future
    - Removes conflation of having to synchronize and update views when modifying frontend document
    - Decouples concept of a specific view to update from generic frontend graph modifications
#rb helen.yang
#jira UE-151448
#preflight 632b7afdc7791417aa44126f

[CL 22142063 by rob gay in ue5-main branch]
2022-09-22 15:02:24 -04:00
phil popp
1cd4208860 Make MetaSound parameter error logs into warnings
Add log warning when constructor input value is ignored on runnign instance.
#jira UE-162285
#rb Rob.gay
#preflight 632b4cf72c7bc831f867d2c1

[CL 22121048 by phil popp in ue5-main branch]
2022-09-21 15:42:38 -04:00
rob gay
57d0be3dd2 Missing recursive call to reset sync state in prior CL
#rb trivial
#jira none
#preflight 6323a1805f55ba280ed12b0f

[CL 22042427 by rob gay in ue5-main branch]
2022-09-15 20:11:13 -04:00
rob gay
31435d69a5 Fix bug with synchronization not being completed prior to validation for referenced MetaSound graphs
TLBSRA (Too long but still read anyway)
This was due to validation moving to recursive behavior but sync not to support bubbling up referenced errors/warnings in 5.1.  This resulted in missing members after interface transforms are applied and potentially hitting ensures in validation.
...
But wait there's more!!! Synchronization on tick is now more efficient as it doesn't attempt to resynchronize/validate references already synchronized/validated in prior pass in same frame due to referencing graph needing to sync

#rb helen.yang
#rnx
#jira UE-162586
#preflight 63223e6c29254beccbf06119

[CL 22019580 by rob gay in ue5-main branch]
2022-09-14 18:49:46 -04:00
rob gay
e6a69d94c8 Set invalid controller's default access type to unset
#rb trivial
#jira none
#rnx
#preflight skip

[CL 21997854 by rob gay in ue5-main branch]
2022-09-13 21:51:42 -04:00
rob gay
7c89cca430 Fix missing rerouted implicit accessor behavior causing various bugs with constructor pins
#rb helen.yang
#rnx
#jira UE-163090
#preflight 6320d96829254beccb80dc36

[CL 21997851 by rob gay in ue5-main branch]
2022-09-13 21:51:22 -04:00
rob gay
2c38378951 - Fix doubleclick to add connected reroute not capturing full transaction
- Fix pasted reroute ed nodes not generating reroute template frontend node
- Fix for "promote to" transactions not capturing graph changes
#rb helen.yang
#jira UE-162560
#jira UE-161233
#jira UE-147944
#rnx
#preflight 631fac6a575e11cd2a6ffe70

[CL 21985212 by rob gay in ue5-main branch]
2022-09-13 12:30:44 -04:00
robert millar
aa6e458004 FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for Metasound.

#jira UE-161932
#rb none
#preflight https://horde.devtools.epicgames.com/job/631f7da6a9331c69c3aa4ac5

[CL 21976387 by robert millar in ue5-main branch]
2022-09-12 19:52:49 -04:00
rob gay
3698d480b1 Fix crash when no output is supplied on a reroute and user attempts undo
#jira UE-161229
#rnx
#rb trivial
#preflight skip

[CL 21927053 by rob gay in ue5-main branch]
2022-09-09 16:14:43 -04:00
rob gay
367eeb114e Fix for assetpath not being generated properly from displayed filepath indirectly in SGraphPinObject locations that attempt to extract short display name from the pin's DefaultValue
#rb phil.popp
#jira none
#rnx
#preflight skip

[CL 21910546 by rob gay in ue5-main branch]
2022-09-08 21:30:35 -04:00
helen yang
d14412ac5b Rename MetaSound cvars for consistency, fix typos
#jira none
#rb trivial
#preflight 630d758d556fc14dce5ad10c

[CL 21707153 by helen yang in ue5-main branch]
2022-08-30 15:11:11 -04:00
Aaron McLeran
5f08d51e97 Fix for static analysis include cycle
#fyi Rob.Gay
#jira none
#rb none
#preflight none

[CL 21463121 by Aaron McLeran in ue5-main branch]
2022-08-19 15:42:08 -04:00
Rob Gay
25826b9069 Summer Cleaning
- Rename MetasoundArchetype Source file to MetasoundFrontendInterface
- Move MetaSound interface files to subdirectory.
- Break out document versioning transforms to own impl/header
#rb todo
#rnx
#jira none
#preflight 62fed263200ff87e07d77340

[CL 21458865 by Rob Gay in ue5-main branch]
2022-08-19 12:14:31 -04:00