Commit Graph

148 Commits

Author SHA1 Message Date
alexis matte
fe35eb697a Interchange:
- Skeletal mesh is now import using the skeletalmesh compile system to make sure all properties are locked and will stall another thread trying to access them.
---- This fix multiple crash if a viewer display the skeletal mesh and use some properties.
- Remove animation pipeline ensure(no skeleton) if we import with force static mesh and there is some translated animation node
- Fix crash when importing static mesh and the get mesh payload return an empty mesh description
- Reimport of skeletalmesh is not calling anymore postedit change if we reimport with interchange, interchange will call it in a post edit step.
---- This fix multiple crash if a viewer display the bones of the re-import skeletal mesh.
General:
- Reimport handler now have a reimport async version so the caller can control if a reimport is done asynchronously or synchronously

#jira UE-166986
#rb danny.couture , jeanluc.corenthin
#rnx
#lockdown jeanmichel.dignard
#preflight 634f61fdec03b54e9cdfe0bf

[CL 22634973 by alexis matte in ue5-main branch]
2022-10-19 15:15:54 -04:00
eric knapik
ebeb6781c1 Animation BP toolbar trimming & permissions
* Tab filters are now applied before tab widgets before are created for animation blueprint editor instead of only when a user tries opening a new tab. This prevents disallowed tabs in default layouts being created.
* Event graph documents are not opened if event graph permissions are disabled when loading blueprint editor.
* Added new blueprint permission to optionally disable function overrides.

#rb thomas.sarkanen
#preflight 6346928ef04e6f8505f7b879

[CL 22547860 by eric knapik in ue5-main branch]
2022-10-15 02:13:23 -04:00
jaime cifuentes
b73f2f3e20 Truncation fixes for SkeletonEditor module
#rb
#jira UE-166636
#preflight 63493441a8717e9453adcf69

[CL 22524449 by jaime cifuentes in ue5-main branch]
2022-10-14 06:29:48 -04:00
lucas dower
25ebcb10ba Fix for blend profile slider transaction spam each time the slider moves slightly.
* A transaction is now made from when the slider begins moving to when the value is committed.

#jira UE-137121
#rb thomas.sarkanen
#preflight 633708e1d165c45137089a35

[CL 22279187 by lucas dower in ue5-main branch]
2022-09-30 15:49:04 -04:00
thomas sarkanen
0eb8edb6d5 Fix blend profiles submenu not appearing on a subsequent opening of a skeleton
Correctly apply context to tool menu

#jira UE-164429
#rb Jurre.deBaare
#preflight 63319338665f6b8f7fe54c45

[CL 22188382 by thomas sarkanen in ue5-main branch]
2022-09-26 13:23:13 -04:00
jose villarroel
2c5b30f7dd Fix CIS localization warning in SSkeletonTree
#jira none
#rb trivial
#preflight skip

[CL 22163469 by jose villarroel in ue5-main branch]
2022-09-23 19:58:22 -04:00
jose villarroel
5a184e07ff Different blend profile modes have their own section in pickers
#jira UE-101588
[REVIEW] [at]Thomas.Sarkanen
#preflight 632c7304b4515b7e22cdbb01

[CL 22145896 by jose villarroel in ue5-main branch]
2022-09-22 17:39:33 -04:00
benoit gadreau
d6a1908c70 follow the NumericValueChanged paradigm when pasting values + transaction
#jira UE-159365
#rb thomas.sarkanen
#preflight 6329bb63826e0c2fe945f50d

[CL 22094354 by benoit gadreau in ue5-main branch]
2022-09-20 11:39:48 -04:00
lucas dower
0ac5ddabcf Fix for blend profile rename being reset when committing via clicking to lose focus
* No longer have to explicitly press Enter to commit to the name change.

#jira UE-158072
#rb thomas.sarkanen
#preflight 6329b9cd9840225da2638c0d

[CL 22094263 by lucas dower in ue5-main branch]
2022-09-20 11:37:06 -04:00
lucas dower
a5b975ca24 Fix for Persona mesh details text overlay blocking hit tests
* Fix for Persona mesh sections showing as selectable when not.
* Fix for editor viewport cursor style not updating if using orbit camera mode.

#jira UE-157811
#rb thomas.sarkanen
#preflight 63246538ea1c94f4c5b3dfc7

[CL 22052213 by lucas dower in ue5-main branch]
2022-09-16 12:44:00 -04:00
kiaran ritchie
9ece7682e8 Adding "Preview Scene Settings" tabs to IK Rig & Retarget editors.
This change also added a delegate to FPersonaToolkitArgs with reference to a IDetailBuilderLayout so assets can customize the Preview Scene Settings.

#JIRA https://jira.it.epicgames.com/browse/UE-148894
#rb halfdan.ingvarsson
#preflight
#preflight 631b7a00967ffc68fb262e06

[CL 21924418 by kiaran ritchie in ue5-main branch]
2022-09-09 13:58:03 -04:00
jaime cifuentes
b1d5d73613 SSkeletonTree : Fixed LOD bone reduction RequiredBones calculation, when done from the SkeletonTree
#rb thomas.sarkanen
#jira UE-60491
#preflight 6316f04aab25bb91f5eaf8bb

[CL 21807749 by jaime cifuentes in ue5-main branch]
2022-09-06 03:07:07 -04:00
bryan sefcik
8cc129f2b6 IWYU Pass 1 - Engine/Source/Editor/...
#jira
#preflight 6306736ac85b7fef22be7751

[CL 21558583 by bryan sefcik in ue5-main branch]
2022-08-24 22:45:13 -04:00
kriss gossart
0422ca7705 Skeletal Mesh - Replace the newly created GetSkeletalMesh function by GetSkeletalMeshAsset so it matches the setter SetSkeletalMeshAsset function (which itself couldn't be named SetSkeletalMesh due to the function already existing and doing something else).
#rb Josie.Yang
#preflight 62fa2afeae3edb54c979492e
#jira none

[CL 21385959 by kriss gossart in ue5-main branch]
2022-08-15 09:26:50 -04:00
peter knepley
2975f6a374 Fixed repeated menu items (and crash) in skeleton tree blend profile picker
#jira UE-157315
#rb Lucas.Dower
#preflight 62bb04a4727d9bb33ba1766c

#ROBOMERGE-OWNER: peter.knepley
#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 20859004 via CL 20863671 via CL 20876698 via CL 20876756
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20879418 by peter knepley in ue5-main branch]
2022-06-29 14:34:20 -04:00
Josie Yang
6b15506e58 Replace direct access to SkeletalMesh object from USkinnedMeshComponent with GetSkeletalMesh function
#rb kriss.gossart
#preflight 62aafc9ada0af39a4783930a

[CL 20686007 by Josie Yang in ue5-main branch]
2022-06-16 09:14:04 -04:00
roland munguia
b9b9ad911f Fixed bone transform clipboard pasting not working unless bone was previosly modified.
#jira UE-155761
#review-20634582 Keith.Yerex
#preflight 62a7bc8fe019c73dbae7c46e

[CL 20637140 by roland munguia in ue5-main branch]
2022-06-13 19:05:34 -04:00
lucas dower
3fbd006532 Updated skeleton tree children ordering: sockets, preview meshes, and virtual bones are now placed at the head of a bone's children
#jira UE-153887
#preflight 62a72fc12a70e8deaccfa63e
#rb roland.munguia

[CL 20625838 by lucas dower in ue5-main branch]
2022-06-13 08:56:26 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Leon Huang
19877e39c5 Fix for duplicate localization key warnings and missing localization defines/undefines in various files.
#rnx
#rb: Vincent.Gauthier
#jira: UE-151614
#preflight: 628fc4a98c23e52ef0fdfa7d

[CL 20384450 by Leon Huang in ue5-main branch]
2022-05-26 16:11:10 -04:00
lauren barnes
5f7006fb53 Fixing EditorStyle->AppStyle merge errors
#rb trivial

#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20073150 via CL 20073151
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20105751 by lauren barnes in ue5-main branch]
2022-05-09 13:31:58 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
thomas sarkanen
3f8fa9692b Converted a number of animation editor menus & toolbars to use tool menus
Also applied asset permissions to various UI sections

#rb Jurre.deBaare,Sara.Schvartzman
#preflight 6267d7dd272f4a558dbcdb6a

#ROBOMERGE-OWNER: thomas.sarkanen
#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 19918869 via CL 19921093 via CL 19923159 via CL 19923181
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 19926251 by thomas sarkanen in ue5-main branch]
2022-04-26 15:03:55 -04:00
kiaran ritchie
2ac904be3d Adding compatible skeletons to Retarget Sources
#JIRA https://jira.it.epicgames.com/browse/UE-145950
#rb halfdan.ingvarsson
#preflight 6234aca13f685c2b421fcce6

[CL 19441181 by kiaran ritchie in ue5-main branch]
2022-03-18 16:55:51 -04:00