Commit Graph

37 Commits

Author SHA1 Message Date
genis sole
39148cf1d5 [Mutable] Fix dummy texture when changing texture parameters rapidly.
- Added logs for more image acquire failure cases.
- Now the external images to be cached are obtained from the mutable parameters and not from the descriptor.

[REVIEW] [at]alexei.lebedev, [at]gerard.martin
#preflight 63d167bb574ab9cae4c5ef5b

#rnx

[CL 23865670 by genis sole in ue5-main branch]
2023-01-26 05:27:35 -05:00
gerard martin
0ad4406ad4 [Mutable] Postpone DefaultImageProvider image cache.
- Added documentation.

[REVIEW] [at]pere.rifa, [at]alexei.lebedev
#rnx

[CL 23851359 by gerard martin in ue5-main branch]
2023-01-25 13:01:06 -05:00
pere rifa
9e96764ea7 [Mutable] Fix IORelease tasks overwritting other queued tasks of the same type.
+ Fix MipDataProvider not freeing instances after an update.
+ Fix static analysis warnings.

#rnx
#rb gerard.martin

[CL 23848779 by pere rifa in ue5-main branch]
2023-01-25 11:08:55 -05:00
pere rifa
d7291558a8 [Mutable] Implement new LOD system to allow generation of individual LODs depending on the PredictedLODLevels.
+ Base implementation of a new kind of update that allows reusing data from previous updates (currently disabled)
+ Refactor of the CustomizableObjectInstance update workflow and code clean up

#rnx
#rb alexei.lebedev
#rb gerard.martin
#preflight 63ce4a8c3a03cb0bbfa3c47a

[CL 23829312 by pere rifa in ue5-main branch]
2023-01-24 08:45:18 -05:00
alexei lebedev
074a087bac #rnx
[CL 23773852 by alexei lebedev in ue5-main branch]
2023-01-19 10:44:15 -05:00
henrik karlsson
d0b484d55c Fixed a bunch of non unity errors
#preflight 63bfbb2d577437afe61a7d48
#rb none
#jira none

[CL 23659781 by henrik karlsson in ue5-main branch]
2023-01-12 02:59:45 -05:00
henrik karlsson
2f78497e67 [Engine/Plugins]
* Updated private files with IWYU for all plugins which had 3 or less changes made in ue5 main since last integration to fn

#preflight 63bf8d8b577437afe607dc72
#rb none

[CL 23659643 by henrik karlsson in ue5-main branch]
2023-01-12 01:48:34 -05:00
alexei lebedev
506b8a3196 #rnx
[CL 23651603 by alexei lebedev in ue5-main branch]
2023-01-11 14:44:41 -05:00
jordi rovira
f4fcf134b5 [mutable] fix and reapply changes backed out in changelist 23600471
#rnx
#preflight 63bd5c5871079a8d1c0b21f6
#preflight 63bd6dd60b7fcef8b0d9b39f

[CL 23651046 by jordi rovira in ue5-main branch]
2023-01-11 14:28:53 -05:00
alexei lebedev
f3f4b09318 [FYI] [at]jordi.rovira, [at]gerard.martin
#rnx

[CL 23632571 by alexei lebedev in ue5-main branch]
2023-01-10 15:48:59 -05:00
zousar shaker
35fe3cba5c Undo range //Fortnite/Main/Engine/Plugins/Experimental/Mutable/... from changelist 23586315 to now
[CL 23601661 by zousar shaker in ue5-main branch]
2023-01-06 14:48:25 -05:00
jordi rovira
7f0279e213 [mutable] Additional mutable code generation optimizations: improve removal of resizes and swizzles.
#preflight 63b686932960b73220f935cf
[REVIEW] [at]pere.rifa
[FYI] [at]max.garcia
#rnx

[CL 23586566 by jordi rovira in ue5-main branch]
2023-01-05 07:44:39 -05:00
pere rifa
c54ca46c18 [mutable] Add operation to optimize the skinning of the generated meshes. If possible, bone index buffers will be formated and bonemaps shrinked.
#rnx
#rb [at]jordi.rovira
#preflight 63b45e761c35d1cbdb33f873

[CL 23580175 by pere rifa in ue5-main branch]
2023-01-04 15:46:42 -05:00
daniel broder
bf759ab9bc While Investigating a client hang, found some code that is either unsafe, not clearly safe, or violates UE coding standards.
Code cleanup:
* Added a lot of checks() to make sure we crash explicitly with useful information rather than hoping a crash will have enough info to work from.
** NOTE: I'm aware that _some_ of the "GetPrivate()" calls have a check internal to them, but they're not named to indicate that, so it may change, and other GetPrivate() calls do NOT have internal checks for nullptr.  So to reduce the need for specific implementation knowledge and the possible confusion between them, I just re-assert in those cases if the pointer is nullptr.
* Fixed a number of coding standard issues, including:
** Variable names must start with initial capitals
** Spacing, indentation, and bracing issues that didn't match UE coding standards.
* Cleaned up some other spacing and indentation issues to be consistent within the file and for general readability.

Also, removed a line of code that would cause a crash due to dereferencing a pointer that's guaranteed to be nullptr or invalid.

Added a few temporary comments to investigate some other oddities in the code.



#RB Alexei.Lebedev, Pere.Rifa, Joel.Anderson

#UE5 #RNX #NoReleaseNotes

[CL 23519838 by daniel broder in ue5-main branch]
2022-12-14 17:05:40 -05:00
jordi rovira
4cd90bca49 [mutable] Smart pointer cleanup. Move to proper atomics. Remove unnecessary weak pointer support.
Fix mistreatment of image-interpolate operations when number of mips differ.
[REVIEW] [at]gerard.martin
#rnx
#preflight 6390cae19549ddaa28d408ae

[CL 23461479 by jordi rovira in ue5-main branch]
2022-12-09 03:57:57 -05:00
gerard martin
724e1c4b87 [Mutable] Changed CPU traces to use the Mutable macro.
#rnx

[CL 23348374 by gerard martin in ue5-main branch]
2022-12-01 06:49:41 -05:00
gerard martin
acab6d3761 [Mutable] Fix Instance LOD being set to early in the update process.
- Fixed Min Max LOD being commited to late during the Instance update process.
- Fixed Min Max LOD not being specified when creating an Instance.

[REVIEW] [at]alexei.lebedev, [at]pere.rifa

[CL 23287187 by gerard martin in ue5-main branch]
2022-11-28 07:21:35 -05:00
genis sole
e458c83219 [mutable] optimizations for bone and physics reshape operations and other improvements.
-Physics reshape methods have been reimplemented to be more robust, add more sampling points and have a better method of extracting the shape characteristics from those points.
-Bind data that does not track orientation has it's own more compact data type.
-Physics mesh merging will only merge when necessary.
-Physics asset creation does not create a duplicate which is slow but creates a new asset and populate it with relevant data.

#preflight 637fab33337745090038df61

#rb jordi.rovira

[CL 23264729 by genis sole in ue5-main branch]
2022-11-25 05:57:54 -05:00
alexei lebedev
ab2ecd3c7a #rnx
[CL 23259387 by alexei lebedev in ue5-main branch]
2022-11-24 10:07:28 -05:00
alexei lebedev
3ae58b38d1 #rnx
[CL 23232636 by alexei lebedev in ue5-main branch]
2022-11-22 04:57:22 -05:00
alexei lebedev
31fb627b18 [FYI] [at]pere.rifa, [at]max.garcia, [at]gerard.martin, [at]rachael.thompson, [at]story.martin
#rnx

[CL 23102243 by alexei lebedev in ue5-main branch]
2022-11-11 14:11:45 -05:00
pere rifa
2264831f93 [Mutable] Reduce the amount of skeletons to merge to avoid bone collisions.
+ Fix CO compilation error when using group projectors.
+ Fix generation issues on low-end platforms when lower LODs are discarded.

#rnx
#rb jordi.rovira
#preflight 63651173de2c4dbb5dad12cd

[CL 23008941 by pere rifa in ue5-main branch]
2022-11-07 04:57:31 -05:00
gerard martin
a537149814 [Mutable] Added support for Multidimensional Texture Parameters.
- Extended the Instance/Descriptor api to support setting a UTexture2D directly as a Texture Parameter.

[REVIEW] [at]alexei.lebedev
[FYI] [at]devlin.willis
#rnx
#preflight 6363f7671052c15f1395b033

[CL 22985536 by gerard martin in ue5-main branch]
2022-11-04 09:18:44 -04:00
gerard martin
7f476f173d [Mutable] Instance update minor improvements.
- Fixed issue where the Instance Preview Viewport was not showing the correct message overlay.
- Merged DoUpdateSkeletalMesh and DoUpdateSkeletalMeshAsync.
- Converted known alwyas valid pointers to references.
- Removed DoUpdateSkeletalMesh bAsync parameter (always was checked against true).

[REVIEW] [at]alexei.lebedev, [at]pere.rifa
#preflight 6362741954471d10beed4260

[CL 22959164 by gerard martin in ue5-main branch]
2022-11-03 14:23:46 -04:00
gerard martin
e2a46be9a1 [Mutable] Split ReloadParametersFromObject.
- Split into two funcitons:
    - GetParameters: Creates a Core Parameters object.
    - ReloadParameters: Copies parametres from the core.
- Fixed an issue where SetCurrentState was setting an incorrecte state index.
- Minor code improvements.
- Fix UCustomizableObjectInstance::PostLoad not calling ReloadParameters.

#preflight 635bfc4bdf01edd149f71e3d
[REVIEW] [at]alexei.lebedev, [at]pere.rifa
#rnx

[CL 22959099 by gerard martin in ue5-main branch]
2022-11-03 14:23:00 -04:00