Commit Graph

11477 Commits

Author SHA1 Message Date
kriss gossart
0422ca7705 Skeletal Mesh - Replace the newly created GetSkeletalMesh function by GetSkeletalMeshAsset so it matches the setter SetSkeletalMeshAsset function (which itself couldn't be named SetSkeletalMesh due to the function already existing and doing something else).
#rb Josie.Yang
#preflight 62fa2afeae3edb54c979492e
#jira none

[CL 21385959 by kriss gossart in ue5-main branch]
2022-08-15 09:26:50 -04:00
patrick enfedaque
74fd7a10b8 Uncontrolled Changelist: Make sure background task is completed on module shutdown
#jira UE-160847
#rb richard.malo, jeanfrancois.dube
#preflight 62f68bca185b21882a9438d3

#ROBOMERGE-AUTHOR: patrick.enfedaque
#ROBOMERGE-SOURCE: CL 21359248 via CL 21359468 via CL 21359507
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21362286 by patrick enfedaque in ue5-main branch]
2022-08-12 15:52:47 -04:00
chris constantinescu
0d0ad8e4c8 Remove faulty global GBlockLocalPrint, cleanup unused VS config
All platforms preflight 62f67851b66d5d9313f240b6
#rb Devin.Doucette
#preflight 62f67866bd746abb99c0be54

[CL 21362093 by chris constantinescu in ue5-main branch]
2022-08-12 15:45:37 -04:00
luc eygasier
f431296a8a Changes reverting UncontrolledChangelist new assets to also delete them.
#rb Patrick.Enfedaque
#preflight 62f56afaad3bd8ad642e2a79

#ROBOMERGE-AUTHOR: luc.eygasier
#ROBOMERGE-SOURCE: CL 21354458 via CL 21354491 via CL 21354503
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21356205 by luc eygasier in ue5-main branch]
2022-08-12 11:43:42 -04:00
paul chipchase
fd77942248 We no longer consider failing to restore the original workspace as a fatal error when submitting virtualized payloads to perforce.,
#rb trivial
#jira UE-160083
#rnx
#preflight 62f64714185b21882a875427

- When this backend was written, it shared the source control provider interface with the rest of the editor, so if we were unable to restore the workspace it would likely break the editor in interesting and hard to diagnose ways.
- Given the scope for problems and the low change of the operatation I opted to make the error fatal.
- Now that the backend owned it's own source control provider interface, the worst thing that can happen is that future virtualization attempts will also fail, but the user will not be left with a non functioning editor. With this in mind there is no longer a reason to consider this a fatal failure.

[CL 21353746 by paul chipchase in ue5-main branch]
2022-08-12 08:45:08 -04:00
Joakim Lindqvist
a1c6e408bc OidcToken - Fixed path passed for project to oidc token to always be the project directory (no matter if its a foreign project or not). This makes sure we are able to read the configuration from the project if a project is set.
Also updated the prompt asking user to login to make it clear who is asking and for what (assuming this is used by DDC - which is only the case now but may not be forever)

#preflight https://horde.devtools.epicgames.com/job/62f639b3153b17e74650f16e

[CL 21353268 by Joakim Lindqvist in ue5-main branch]
2022-08-12 07:40:29 -04:00
ricard rovira
d69f51b63a Make DetectAlphaChannel public
#preflight 62f36ee2f75a2a539c716721
[REVIEW] [at]alexei.lebedev
#rnx

#ROBOMERGE-OWNER: ricard.rovira
#ROBOMERGE-AUTHOR: ricard.rovira
#ROBOMERGE-SOURCE: CL 21352299 via CL 21352302 via CL 21352378
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21352671 by ricard rovira in ue5-main branch]
2022-08-12 04:37:59 -04:00
Catalin Dragoiu
69a2ca195a [Insights] Clean up imported table tab display name and tooltip text.
#rb none
#preflight 62f52233185b21882a38c68d

[CL 21352605 by Catalin Dragoiu in ue5-main branch]
2022-08-12 04:23:44 -04:00
paul chipchase
f901c84c12 Change the name used to identify the VA source control backend in the config file from 'SourceControl' to 'P4SourceControl' to make it clearer which source control provider is actually supported.
#rb trivial
#jira UE-156189
#rnx
#preflight 62f5f1a01e61d1ba0e6c893b

- Note that the older name 'SourceControl' will continue to work but will log a warning if used to notify the user to update their config files.

[CL 21352223 by paul chipchase in ue5-main branch]
2022-08-12 02:27:28 -04:00
patrick enfedaque
b1948f9827 Uncontrolled Changelist: Filter out /Tmp assets + Procedural/Auto saves
#rb jeanfrancois.dube, luc.eygasier
#preflight 62f53a8cb66d5d9313a35714

#ROBOMERGE-AUTHOR: patrick.enfedaque
#ROBOMERGE-SOURCE: CL 21342544 via CL 21342580 via CL 21342599
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21345594 by patrick enfedaque in ue5-main branch]
2022-08-11 17:19:27 -04:00
Laura Hermanns
bbb62728d4 Strip [[clang::optnone]] attribute from Metal shaders due to performance hit with WPO on M1 Macs.
#rb Will.Damon
#fyi MarcAndre.Lalonde
#jira none
#preflight 62f56422f3107c023cc15341
#rnx

[CL 21344324 by Laura Hermanns in ue5-main branch]
2022-08-11 16:27:00 -04:00
bob tellez
410858eb02 #UE Compile fix for when WITH_AUTOMATION_TESTS is false in an editor build
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 21342143 via CL 21342255 via CL 21342279
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21343966 by bob tellez in ue5-main branch]
2022-08-11 16:19:05 -04:00
patrick enfedaque
29c089706b Uncontrolled Changelist
-Startup scan is now a background task (Saves 1min15 editor startup time on projects with lots of assets)
-Wait on startup task with dialog on reconcile if it isn't finished
-Don't allow changing module enabled state past startup (CVar read at startup only)

#rb richard.malo, jeanfrancois.dube
#preflight 62f4eeb5b66d5d9313960f4e

#ROBOMERGE-AUTHOR: patrick.enfedaque
#ROBOMERGE-SOURCE: CL 21338280 via CL 21339224 via CL 21339734
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21341653 by patrick enfedaque in ue5-main branch]
2022-08-11 14:46:56 -04:00
phil popp
8716f75b0d Add SourceDataOverride to other platform settings
#jira UE-159924
#rb Jimmy.Smith
#preflight 62f52d78b66d5d93139ea4ce

[CL 21339572 by phil popp in ue5-main branch]
2022-08-11 13:19:54 -04:00
Catalin Dragoiu
b088c308b2 [Insights] Made imported table views to run in async mode.
#rb none
#preflight 62f513edad3bd8ad6415511f

[CL 21336131 by Catalin Dragoiu in ue5-main branch]
2022-08-11 10:42:09 -04:00
paul chipchase
145cee1fb4 Fix UE_REGISTER_VIRTUALIZATION_BACKEND_FACTORY_LEGACY_IMPL to work correctly on none MSVC platforms
#rb trivial
#jira UE-156189
#rnx
#preflight

- The constructor parameters should've been const, this doesn't show when compiling with MSVC as we have that warning currently disabled.

[CL 21335846 by paul chipchase in ue5-main branch]
2022-08-11 10:28:39 -04:00
Joakim Lindqvist
99738a925d Allow users to interactivly login if they are missing a token. Will present a dialog for users if not unattended so they are aware they need to login.
#preflight https://horde.devtools.epicgames.com/job/62f26d7723003b62a3f3b58f

[CL 21334992 by Joakim Lindqvist in ue5-main branch]
2022-08-11 09:17:03 -04:00
Tim Smith
6da6208fa9 Fixed issue where modules listed to be preloaded were not being preloaded.
#rb self
#jira UE-160674
#preflight 62f4f82e7c66d5539e8a8bad

[CL 21334853 by Tim Smith in ue5-main branch]
2022-08-11 08:59:35 -04:00
paul chipchase
928ac24c35 Add a way to change the name used to identify a VA backend in the config file without breaking existing set ups.
#rb trivial
#jira UE-156189
#rnx
#preflight 62f4f504b66d5d9313969a92

- Use the new macro UE_REGISTER_VIRTUALIZATION_BACKEND_FACTORY_LEGACY when trying to rename how backends are identified.

[CL 21334721 by paul chipchase in ue5-main branch]
2022-08-11 08:44:32 -04:00
chris constantinescu
1bfe2da3f2 Use platform-dependent LocalPrint and make sure output is redirected to stdout when running LowLevelTests so that local and build machine test runs print debug and fault information directly to stdout.
AssertionMacrosTest is printing out failed asserts using LocalPrint which is undesirable - implemented GBlockLocalOutput as a way to supress LocalPrint output.
Other fixes included:
- ability to select a low level test build based on any configuration, not just Development: useful for Debug builds
- New "printoutput" LLT Gauntlet parameter used for certain platforms to control output redirect to stdout
#rb David.Harvey
#preflight 62f405a05a6f2fec99b64f21

[CL 21334255 by chris constantinescu in ue5-main branch]
2022-08-11 07:31:45 -04:00
paul chipchase
64e53f7b3d The macro for creating backend factories (UE_REGISTER_VIRTUALIZATION_BACKEND_FACTORY) now adds the prefix F to the generated factory class.
#rb trivial
#rnx
#preflight 62f4dc987c66d5539e89198f

[CL 21334023 by paul chipchase in ue5-main branch]
2022-08-11 06:59:15 -04:00
helge mathee
317046bf91 RigVM: Generalize all execute pins to use the RigVMExecuteContext
#rb sara.schvartzman
#jira UE-159391
#preflight https://horde.devtools.epicgames.com/job/62f39397086f90bbc4d92510

#ROBOMERGE-OWNER: helge.mathee
#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 21333330 via CL 21333332 via CL 21333623
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21334003 by helge mathee in ue5-main branch]
2022-08-11 06:58:29 -04:00
sara schvartzman
f5caea7afc Control Rig: Fix new name of the Function does not display on Function's node in the Rig Graph after renaming
#jira UE-160273
#rb helge.mathee
#preflight 62f4d3e5185b21882a28d8e5

[CL 21333761 by sara schvartzman in ue5-main branch]
2022-08-11 06:17:57 -04:00
paul chipchase
158dcbe0cc Change the VA graph name LocalStorageHierarchy to 'CacheStorageHierarchy' which better describes it.
#rb Per.Larsson
#jira UE-156189
#rnx
#preflight 62f4c098e60c9215b9bcde08

- The orignal name implied tha the payloads would only be stored locally on the users machine, but the intent is to describe a number of backends that are a) faster than the persistent storage backends b) no guarantee that the payload will be found.
- The new name better describes this functionality.
- We still accept 'LocalStorageHierarchy' but will log a warning informing the user to update their graph but this backwards compatibility code will most likely be removed before 5.1 ships.
-- EStorageType::Local will follow the usual deprecation rules.
- Not strictly related to this change but I also cleaned up and added additional loggng during the initialization of the virtualization manager.

[CL 21333601 by paul chipchase in ue5-main branch]
2022-08-11 05:51:29 -04:00
bob tellez
4242d39647 #UE Add an IsEnabled check before doing very expensive GetAssets call during startup in UncontrolledChangelistsModule
[FYI] luc.eygasier

#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 21332948 via CL 21332954 via CL 21332959
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21333089 by bob tellez in ue5-main branch]
2022-08-11 01:55:37 -04:00