Commit Graph

3144 Commits

Author SHA1 Message Date
steve robb
288f3de432 Fixes for the implicit conversion of ints and chars to TCHARs in UTF-8 mode.
#rb trivial
#preflight 621ed0b4e15c51d8c5e5d081

#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 19219816 via CL 19220283 via CL 19220288 via CL 19223679
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19227684 by steve robb in ue5-main branch]
2022-03-02 15:30:50 -05:00
andrew rodham
355efbd7ef Fix for mismatched weakptr serialization between FJsonArchiveOutputFormatter and FJsonArchiveInputFormatter.
#rb Steve.Robb
#preflight 621da3fdca28c556340cc56d

#ROBOMERGE-AUTHOR: andrew.rodham
#ROBOMERGE-SOURCE: CL 19203318 via CL 19207261 via CL 19213316 via CL 19213622 via CL 19213693
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19225224 by andrew rodham in ue5-main branch]
2022-03-02 13:57:41 -05:00
dave jones2
17a79b862c UE-141802 - Set Editor Property fails with float and object argument types
Editor properties go through the PropertyAccessUtil interface to change property values. However, they don't support potential float<->double conversions that might occur. This has become more prevalent since Blueprint floats default to double precision.

We can fix this by simply adding explicit float<->double conversions to PropertyAccessUtil. Unfortunately, lossiness will potentially occur since there's a narrowing conversion, but we're already expecting some of that when interfacing with native float properties.

#jira UE-141802
#preflight 621e6f2ae15c51d8c5d69905
#rb jamie.dale
#lockdown julien.marchand


#ROBOMERGE-AUTHOR: dave.jones2
#ROBOMERGE-SOURCE: CL 19211200 via CL 19211319 via CL 19211986 via CL 19212055 via CL 19212198
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19224257 by dave jones2 in ue5-main branch]
2022-03-02 13:16:29 -05:00
jamie dale
88f34e3e51 Fixed FSoftObjectPath::GetLongPackageName returning an empty string when set to a package name
If a FSoftObjectPath was set to a package name (eg, "/Game/MyPackage") then GetLongPackageName would return an empty string which is inconsistent with GetLongPackageFName.

This change makes the behavior of GetLongPackageName and GetLongPackageFName consistent (returning the package name if there's no object in the path), and also removes a temporary FString allocation from GetLongPackageName and GetAssetName.

#jira
#preflight 62193b8a1d1c5017994bd387
#rb Matt.Peters

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 19178061 via CL 19183781 via CL 19185359 via CL 19185753 via CL 19200259
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19213115 by jamie dale in ue5-main branch]
2022-03-01 20:03:15 -05:00
robert seiver
40129f69bf Make a check for corrupted tags in an asset platform generic (instead of just on Windows)
#review-19203606 Brandon.Schaefer, Matt.Peters, Danny.Couture
#jira UE-144272
#preflight 621e74cdad75a7f58fca9634

[CL 19204978 by robert seiver in ue5-main branch]
2022-03-01 15:26:40 -05:00
Matt Peters
bb59284a90 Downgrade SavePackage messages that the package did not save because it was editor-only from display to verbose. They cause a lot of spam on projects using WorldPartition (or OneFilePerActor packages) because OneFilePerActor packages are editor-only.
#rb JeanFrancois.Dube
#rnx
#preflight 621e52763e14f0c7e5470839

[CL 19200611 by Matt Peters in ue5-main branch]
2022-03-01 12:13:18 -05:00
Matt Peters
63955f5f1f Optimize FCoreRedirects::GetMatchingRedirects since it is showing up as a moderately high cost in cooks (38s out of 870s in CitySample).
#rb Stefan.Boberg
#rnx
#preflight 621e42cbca28c556342bd1d9

[CL 19199624 by Matt Peters in ue5-main branch]
2022-03-01 11:28:32 -05:00
danny couture
5b1b53c0b3 Avoid stalling for long periods of time during map load and PIE
- Remove slowtask throttling during load as it could prevent meaningful top level slowtask to be created
  - Fix delayed slowtask that was never showing when children were added before the delay
  - Add missing slowtask handling on long gamethread functions to improve UI responsiveness
  - Add PIE preparation slowtask scopes
  - Test to make sure the total amount of time spent in all slowtask functions is reasonable (1s on a 2 minute map load)

#rb Jason.Nadro
#preflight 621e1ccf3e14f0c7e53fe337

[CL 19197334 by danny couture in ue5-main branch]
2022-03-01 09:02:24 -05:00
marc audy
7ec196ccbe Make Subobject Class Overrides (more) const correct
#rb Ben.Hoffman
#jira UE-114303
#preflight 621d079c037be0078ca95fdf
#lockdown julien.marchand

#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 19176515 in //UE5/Release-5.0/... via CL 19177706
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19179814 by marc audy in ue5-main branch]
2022-02-28 14:45:17 -05:00
benjamin fox
9565bad74b BlueprintHeaderView: Add ListView items for variables and fix function parameter type names
#jira UE-138707
#jira UE-143137
#rb phillip.kavan
#preflight 62180683e27ba405e8653eab

[CL 19175085 by benjamin fox in ue5-main branch]
2022-02-28 11:37:01 -05:00
steve robb
33c800a605 TEXT(""_SV) changed to TEXTVIEW("") for UTF-8 support.
#rb trivial

#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 19135062 via CL 19136099 via CL 19136620 via CL 19138526
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19155676 by steve robb in ue5-main branch]
2022-02-25 15:48:16 -05:00
martin sevigny
02fa587e82 Fix test for licensee flag in Engine content.
#rb matt.peters
#jira UE-143785
#preflight none
#lockdown simon.tourangeau

#ROBOMERGE-AUTHOR: martin.sevigny
#ROBOMERGE-SOURCE: CL 19128811 in //UE5/Release-5.0/... via CL 19129490
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19155133 by martin sevigny in ue5-main branch]
2022-02-25 15:32:09 -05:00
robert manuszewski
8a0a1ff00e Changes that somehow got lost when shelving and unshelving property setter and getter changes across streams + a few fixes
#rb Steve.Robb
#preflight 621515f40f71e491ccc7d14b

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 19075982 via CL 19098326 via CL 19104715 via CL 19104912 via CL 19110027
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19147883 by robert manuszewski in ue5-main branch]
2022-02-25 10:41:34 -05:00
marc audy
cff01aa9fa Added support for native FProperty setters and getters.
Setters and getters are native functions called by FProperties when setting property values with *_InContainer functions.
Setters and getter function names can be manually specified with Setter = Func and Getter = Func keywords inside of UPROEPRTY macro but they will also be automatically parsed if the name is not explicitly specified if the setter or getter function name matches SetPropertyName and GetPropertyName pattern.
The latter behavior can be disabled in UHT's DefaultEngine.ini by setting AutomaticSettersAndGetters=False.
ImportText and ExportTextItem functions have been deprecated and should be replaced with *_InContainer or *_Direct variants.

#rb Steve.Robb
#preflight 6210a377a83e0bcefd03d9e1

#ROBOMERGE-OWNER: marc.audy
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 19070318 via CL 19098059 via CL 19104650 via CL 19104661 via CL 19110012
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19147839 by marc audy in ue5-main branch]
2022-02-25 10:39:39 -05:00
zousar shaker
e31a1daa85 Fix assignment between Object and ObjectPtr from property utilities methods used by blueprints.
#rb marc.audy
#jira UE-142271
#lockdown aurel.cordonnier
#preflight


#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 19093307 via CL 19093854 via CL 19094624 via CL 19096120 via CL 19105355
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19146664 by zousar shaker in ue5-main branch]
2022-02-25 09:43:44 -05:00
jeanfrancois dube
c96587db2a UPackageMapClient is now aware of incomplete PIE packages streaming external actors:
- Original fix was to prevent discovery of incomplete PIE packages from the package map client, which resulted in potential failures to resolve external actors outer chain from the incomplete package.
- Solution is to revert the original fix and make the package map aware of incomplete PIE packages to delay resolving of external actors until the package is considered complete. This cannot rely on UPackage::IsFullyLoaded since technically, the package is fully loaded and needs to be for external actors to properly resolve their outer.

#jira UE-141116
#rb patrick.enfedaque
#preflight 6214de68a97c2c3348ca296f

#ROBOMERGE-AUTHOR: jeanfrancois.dube
#ROBOMERGE-SOURCE: CL 19082637 in //UE5/Release-5.0/... via CL 19097157
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19140938 by jeanfrancois dube in ue5-main branch]
2022-02-24 23:35:48 -05:00
Matt Peters
55e9f3e8ea FScopeCycleCounterUObject trace: suppress per-object timer names (using per-class instead) if AssetLoadTime channel is not enabled. This prevents poor performance due to 2million timers in insights on large cooks. Also change per-class timers to display"Blueprint" for blueprint classes, to prevent many new timers for projects with a large number of blueprints.
#rb Danny.Couture
#rnx
#preflight 6217bd47ea60a4af9d28a950

[CL 19117052 by Matt Peters in ue5-main branch]
2022-02-24 12:30:54 -05:00
charles bloom
38b1d2e51f Mark up more ParallelFor scopes for Insights
#rb none
#preflight 6216cd82647bb7debf703367

[CL 19105606 by charles bloom in ue5-main branch]
2022-02-23 19:25:03 -05:00
Dan Thompson
d412b366a3 Adding support to writing platform specific tags to the asset registry during cook by the book.
FArchive now holds a "CookData" blob that contains relevant information for cooking. The TargetPlatform has been moved to this structure, and it has a reference to a CookContext that can hold data generated during the cook that doesn't get serialized to the uasset (in this case, the asset registry tags).
#rb Matt.Peters
#preflight 62151bc4797dbbeb472af77d
#preflight 621011f6ff52bfecfc032b15
#preflight 62152777141b500e17eb24ef

[CL 19076066 by Dan Thompson in ue5-main branch]
2022-02-22 13:32:02 -05:00
Johan Torp
40758e08ce Use %llu instead of %ull as cross platform printf specifier
#rb steve.robb
#jira UE-142917
#rnx
#preflight 6214eaf8797dbbeb471bf945

[CL 19072037 by Johan Torp in ue5-main branch]
2022-02-22 09:07:01 -05:00
robert millar
5811293e2a Add TargetRules.bFNameOutlineNumber as an option to reduce the size of FName by 4 bytes by storing the number in the name table.
Adds a define UE_FNAME_OUTLINE_NUMBER.
Removes of FName, FMinimalName from memory image support. Adds of FMemoryImageName.
Removal of FMinimalName operator&lt;&lt;, all fields made private, size made variable.
All fields of FScriptName made private.
Added console commands for dumping numbered/unnumbered names and stats.

#rb johan.torp

#ROBOMERGE-OWNER: robert.millar
#ROBOMERGE-AUTHOR: robert.millar
#ROBOMERGE-SOURCE: CL 19058026 via CL 19058611 via CL 19058656 via CL 19061727 via CL 19061740 via CL 19064047
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19066701 by robert millar in ue5-main branch]
2022-02-21 02:35:48 -05:00
robert manuszewski
c36e03d5e3 do clause support
#rb Andrew.Scheidecker
#preflight 620f3a108863746a104d6c36

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 19047989 via CL 19048186 via CL 19048197 via CL 19048203 via CL 19049414
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19065767 by robert manuszewski in ue5-main branch]
2022-02-21 00:33:13 -05:00
Matt Peters
7645a7dd38 OnEndLoadPackage: Change the arguments to a context object to avoid future need to change the function prototype. Add RecursiveDepth and bSynchronous arguments so that callers can take action only on the top-level EndLoadPackage if necessary.
BulkDataRegistry: Wait until the top-level EndLoadPackage, and wait until after OnEnginePostInit, before deleting bulkdatasize records. Deleting them sooner can make them be deleted before they're used by the EditorDomain if the EditorDomain's TrySavePackage triggers package loading and a recursive OnEndLoadPackage.
#rb Zousar.Shaker
#rnx
#preflight 620f00e7e8554a6f64f74d5a

[CL 19046732 by Matt Peters in ue5-main branch]
2022-02-17 22:02:59 -05:00
Matt Peters
6dcd01dd70 EditorBulkData: Add an Owner argument for UpdatePayload, and supply it from FTextureSource, so we can know ahead of the save which package an in-memory bulk data will be saved under.
#rb Paul.Chipchase
#rnx
#preflight 620efcb4c602491fb81538f8

[CL 19046506 by Matt Peters in ue5-main branch]
2022-02-17 21:12:20 -05:00
marc audy
9caa8eee5e Fix FObjectPtrProperty identical not respecting deep comparisons
#jira UE-38871
#rb Zousar.Shaker, Michael.Noland
#preflight 620d3926f427898d6b598bd4
#preflight 620d92cb3609e1937152f204

#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 19031036 via CL 19031372 via CL 19031397 via CL 19031958
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v917-18934589)

[CL 19032182 by marc audy in ue5-main branch]
2022-02-17 03:44:36 -05:00