Commit Graph

522 Commits

Author SHA1 Message Date
jack cai
9d6ee2889b ControlRig: user defined struct used as function argument can trigger an assertion when one of the member variables change its type
#jira UE-165790
#rb Sara.schvartzman, Helge.mathee
#preflight https://horde.devtools.epicgames.com/job/633b1c006b10157eac5fc7ba

[CL 22336420 by jack cai in ue5-main branch]
2022-10-04 15:24:37 -04:00
jack cai
7104251034 ControlRig: Remove an unnecessary warning
#jira UE-165669
#rb trivial
#preflight skip

[CL 22323376 by jack cai in ue5-main branch]
2022-10-03 21:13:49 -04:00
sara schvartzman
3bd7ec35a9 Control Rig: Add even more assurance that we raise compilation issues when ResolvedFunctionName is not set
#jira na
#rb trivial
#preflight 633aac15b34118b9b4426ead

[CL 22296333 by sara schvartzman in ue5-main branch]
2022-10-03 07:12:07 -04:00
sara schvartzman
d41d43b4ed Control Rig: Avoid crashing when injection info is null
#jira UE-159421
#rb helge.mathee
#preflight 63342c20a907d7192f6d0018

[CL 22232356 by sara schvartzman in ue5-main branch]
2022-09-28 17:59:11 -04:00
sara schvartzman
6bdfee452f Control Rig: Fix undo delete select node fails
#jira UE-150210
#rb helge.mathee
#preflight 6332e99c1003050806d94067

[CL 22232136 by sara schvartzman in ue5-main branch]
2022-09-28 17:54:41 -04:00
jack cai
d64045bacd ControlRig: Fix Enum default getting overriden on load
#jira UE-164906
#rb Sara.schvartzman, helge.mathee
#preflight https://horde.devtools.epicgames.com/job/633297b11003050806c0f566

[CL 22217558 by jack cai in ue5-main branch]
2022-09-27 23:47:51 -04:00
sara schvartzman
e36913273a Control Rig: Fix undo rename local variable not working
#jira UE-144597
#rb helge.mathee
#preflight 6332e428d747fe52c8f127c9

[CL 22205492 by sara schvartzman in ue5-main branch]
2022-09-27 10:16:53 -04:00
sara schvartzman
f5c9f836f5 Control Rig: Fix CI unit test "Metadata Dispatch" failing in Linux
#jira UE-161473
#rb jack.cai
#preflight 6331cb61a4769ad714ac7d98

[CL 22203248 by sara schvartzman in ue5-main branch]
2022-09-27 07:10:47 -04:00
sara schvartzman
7110ae279a Control Rig: Fix crash when resolving template to different type by adding a link
#jira UE-164986
#rb benoit.gadreau
#preflight 632f3349a4769ad71440d862

[CL 22188297 by sara schvartzman in ue5-main branch]
2022-09-26 13:20:38 -04:00
bryan sefcik
0beee50b45 Updated ../Engine/Source/Developer/... to inline gen.cpp files
Before:
Total CPU Time: 53783.640625 s
Total time in Parallel executor: 558.66 seconds
After:
Total CPU Time: 47886.140625 s
Total time in Parallel executor: 498.81 seconds

#jira

[CL 22173145 by bryan sefcik in ue5-main branch]
2022-09-24 13:31:25 -04:00
sara schvartzman
a41c9937d6 Control Rig: Fix add link between array and element of Select values does not resolve select pin correctly
#jira UE-164187
#rb jack.cai
#preflight 632c656cd747fe52c84bf0c4

[CL 22163592 by sara schvartzman in ue5-main branch]
2022-09-23 20:01:01 -04:00
sara schvartzman
68a76b92b9 Control Rig: Do not allow IO exposed pin type change to something other than execute context
#jira UE-164557
#rb jack.cai
#preflight 632b1aa4fc7f1efbdf9702d8

[CL 22119028 by sara schvartzman in ue5-main branch]
2022-09-21 14:42:45 -04:00
sara schvartzman
ee2557c67a Control Rig: Fix crash when connecting subpin from entry node to cast, and resolving type of cast output
#jira UE-164603
#rb benoit.gadreau
[FYI] jack.cai
#preflight 632af57aa236a029de206f71

[CL 22114002 by sara schvartzman in ue5-main branch]
2022-09-21 11:36:56 -04:00
sara schvartzman
809dbae76c Control Rig: Fix crash when copy-pasting function with nested functions from one engine to another
#jira UE-163967
#rb benoit.gadreau
#preflight 632afca0826e0c2fe99f3961

[CL 22113997 by sara schvartzman in ue5-main branch]
2022-09-21 11:36:47 -04:00
jack cai
c0eef12309 ControlRig: fix graphguard not considering CancelAction. If an action was cancelled, guard would no longer need to pop graph in dtor
+ also we should register the pin type

#jira UE-161145
#rb Sara.schvartzman
#preflight https://horde.devtools.epicgames.com/job/6321ffa88c478acecfc24acf

[CL 22066642 by jack cai in ue5-main branch]
2022-09-17 01:49:42 -04:00
jack cai
fedab8a7cd controlrig: fix a place that was using GetStructCPPName, for control rig it should use GetUniqueStructTypeName
#rb Sara.schavartzman
#preflight tbd

[CL 22039967 by jack cai in ue5-main branch]
2022-09-15 18:08:49 -04:00
bob tellez
09bdded204 [Backout] - CL22010359
[FYI] jack.cai
Original CL Desc
-----------------------------------------------------------------
ControlRig: fix graphguard not considering CancelAction. If an action was cancelled, guard would no longer need to pop graph in dtor

+ also we should register the pin type

#jira UE-161145
#rb Sara.schvartzman
#preflight https://horde.devtools.epicgames.com/job/6321ffa88c478acecfc24acf

[CL 22030347 by bob tellez in ue5-main branch]
2022-09-15 11:49:26 -04:00
jack cai
542718d02b ControlRig: fix graphguard not considering CancelAction. If an action was cancelled, guard would no longer need to pop graph in dtor
+ also we should register the pin type

#jira UE-161145
#rb Sara.schvartzman
#preflight https://horde.devtools.epicgames.com/job/6321ffa88c478acecfc24acf

[CL 22020038 by jack cai in ue5-main branch]
2022-09-14 19:17:59 -04:00
sara schvartzman
db3913e419 Control Rig: Fix compilation issue
#jira na
#rb trivial

[CL 22018682 by sara schvartzman in ue5-main branch]
2022-09-14 18:23:20 -04:00
sara schvartzman
f0b0757d2e Control Rig: Fix crash when copy pasting function
#jira UE-163670
#rb jack.cai
#preflight 6321fdd647741a7dbd79309b

[CL 22017641 by sara schvartzman in ue5-main branch]
2022-09-14 17:42:55 -04:00
sara schvartzman
98701593de Control Rig: Second attempt to fix incorrect array default values when connected to reroute node#jira UE-163540
#rb jack.cai
#preflight 6321b7938838676d103d26e4

[CL 22004379 by sara schvartzman in ue5-main branch]
2022-09-14 07:23:59 -04:00
sara schvartzman
21b5d128f9 Control Rig: Revert fix for incorrect array default values when connected to reroute node
#jira UE-163540
#rb na

[CL 21989560 by sara schvartzman in ue5-main branch]
2022-09-13 15:02:02 -04:00
robert millar
0491bcc13c FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for misc developer dir files.

#jira UE-161932
#rb none
#preflight 631f8070fd6da68d68b56472

[CL 21976423 by robert millar in ue5-main branch]
2022-09-12 19:53:59 -04:00
sara schvartzman
283f87f1b7 Control Rig: Fix incorrect array default values when connected to reroute node
#jira UE-162826
#rb jack.cai
#preflight 631b5b15967ffc68fb21883d

[CL 21962237 by sara schvartzman in ue5-main branch]
2022-09-12 06:17:43 -04:00
sara schvartzman
da3ca1a53c Control Rig: Improve BubbleUpExpressions performance
#jira UE-163088
#rb jack.cai
#preflight 6319f039a60c539c988a8c58

[CL 21908296 by sara schvartzman in ue5-main branch]
2022-09-08 20:12:09 -04:00