Commit Graph

308 Commits

Author SHA1 Message Date
miles flanagan
34fe243092 Allow Metasound Bus Reader and Writer nodes to set up patch inputs after construction if their busses are set later
#jira UE-187408
#rb phil.popp

[CL 25848966 by miles flanagan in ue5-main branch]
2023-06-07 12:51:55 -04:00
Rob Gay
8e0ffe62c4 Nuke incorrect, redundant comment for self-documenting call
#rb trivial
#jira none
#rnx

[CL 25828927 by Rob Gay in ue5-main branch]
2023-06-06 17:21:38 -04:00
jimmy smith
a16df7fe4c Fix non-matching PRAGMA_ENABLE_DEPRECATION_WARNINGS pair.
#jira none
#preflight skip

[CL 25776044 by jimmy smith in ue5-main branch]
2023-06-02 18:31:58 -04:00
jimmy smith
d256cc1f44 Deprecate IAudioCodec API
#rb alfaroh.corney jake.burga
#jira none
#preflight 6477eaae1c5c2b3fa2e4e53d

[CL 25770939 by jimmy smith in ue5-main branch]
2023-06-02 15:27:25 -04:00
miles flanagan
3850c5e2a5 Fix crash when setting invalid default parameters on a new metasound
#jira UE-186065
#preflight 647625a44a277ca8f00ca111
#rb rob.gay, ryan.mangin

[CL 25684358 by miles flanagan in ue5-main branch]
2023-05-30 15:03:25 -04:00
rob gay
76c334b255 Fix .Add/.Remove copy pasta
Minor member name/comment fix ups
#rb trivial
#jira UE-186952
#rnx
#preflight skip

[CL 25683678 by rob gay in ue5-main branch]
2023-05-30 14:46:00 -04:00
helen yang
cc09fda972 Expand and consolidate MetaSound builder preset asset functionality
- Added document builder and BP functions for SetGraphInputDefault, ConvertFromPreset, ConvertToPreset, CreatePatch/SourcePresetBuilder, IsPreset
- Refactor MetaSound asset and preset initialization to use builder architecture more

#jira UE-185391
#rb rob.gay
#preflight 64710f423b73ebeef4c295bb

[CL 25683338 by helen yang in ue5-main branch]
2023-05-30 14:39:48 -04:00
nicholas howe
1cff9d7ff8 MetaSound Frontend allows derived classes to attach to base class pins at runtime.
FDataTypeRegistry::GetDataTypeInfo walks up the class hierarchy searching for a registered class.
Adds FDataTypeRegistryInfo::bIsExplicit to replace the editor's IsExplicitProxyClass and enable the same functionality of requiring exact types at runtime.

#rb rob.gay
[REVIEW] [at]phil.popp
#preflight 6470afe55d3ca2dfd99ab6a1

[CL 25649438 by nicholas howe in ue5-main branch]
2023-05-26 13:55:21 -04:00
rob gay
6b6b8a7530 MetaSound node support for traditional "sampler" usage of WaveTables
WaveTable memory reduction, better format support, player node
- Add support for 16bit assets & perform runtime BDC where necessary
- Add support for FixedSampleRate vs resolution
- Cache off and reuse single proxy
- Move entry data to table data in non-editor builds (instead of copying)
#rb helen.yang
#rb miles.flanagan
#rb phil.popp
#jira UE-181355
[FYI] sondra.moyls
#preflight 646bdac6656436839e30b8e1

[CL 25592219 by rob gay in ue5-main branch]
2023-05-23 18:13:14 -04:00
helen yang
f9514f5186 Fix MetaSound wave proxy reader using wrong duration for streaming sounds using Ogg Vorbis
#rb Jimmy.Smith, Seth.Weedin
#rnx

#localization none
#tests local, preflight 646675958377b53e1d0c5e15

[CL 25545963 by helen yang in ue5-main branch]
2023-05-19 12:02:16 -04:00
charlie huguenard
04cc192f7e [Metasound] Invalidate output changed delegate handle when generator is destroyed
#jira UE-185909
#rnx
#preflight 6462ae56b87b09aadd3e14b1

[CL 25494996 by charlie huguenard in ue5-main branch]
2023-05-16 15:30:22 -04:00
bryan sefcik
91c57d395e Removed redundant module includes.
#preflight 645d4bf3aa3c584c0b5b3a67

[CL 25435653 by bryan sefcik in ue5-main branch]
2023-05-11 16:48:21 -04:00
charlie huguenard
657def06c3 [Metasound] Fix race which would sometimes cause generator handles to stop receiving output updates from generators.
While the "thread-safe" variety of delegates does protect the invocation list from data races, if you use AddUObject, it will end up calling TWeakObjectPtr::Get() when it attempts to compact the invocation list (as it does when broadcasting or adding), which as far as I can tell is not thread-safe. This means it can sometimes incorrectly report that the object is no longer valid and should be removed from the invocation list.

#rnx
#rb phil.popp
#preflight 645beeb9ab621cb7013043a9

[CL 25429370 by charlie huguenard in ue5-main branch]
2023-05-11 12:18:34 -04:00
rob gay
d3e70524dc - Migrate and deprecate modify interfaces transform to frontend document builder with broken up, useful functionality available now to the API (ex. SwapInput/Output)
- New version no longer uses expensive controller system
- Fix-up & condense asset/builder initialization logic that utilizes modify interface transform functionality
- Misc clean-up
#rb helen.yang
#jira UE-120184
#rnx
#preflight 645bfd468e01daf0e5b92c30

[CL 25420172 by rob gay in ue5-main branch]
2023-05-10 20:28:39 -04:00
buzz burrowes
46600099fa Merge conflict reolution (by hand)
[CL 25418491 by buzz burrowes in ue5-main branch]
2023-05-10 18:10:35 -04:00
helen yang
24bf2e8fc0 Read sample rate and num frames from file header in MetaSound wave proxy reader to account for incorrect sample rate when using Resample for Device platform cook override
#jira UE-183237
#rb phil.popp, jimmy.smith
#preflight 645acead6c35ad81e6a237b2

[CL 25413497 by helen yang in ue5-main branch]
2023-05-10 15:14:06 -04:00
charlie huguenard
3ba6439ab6 [Metasound] Check whether analyzer exists before attempting to add it to a generator.
Also, remove ensure when trying to find an analyzer factory, since we can fail gracefully.

#jira UE-185335
#rnx
#rb phil.popp
#preflight 645a6477a73096fab7787284

[CL 25402611 by charlie huguenard in ue5-main branch]
2023-05-10 08:29:22 -04:00
maxwell hayes
568aa49a91 [Metasounds] re-adding Reset() function from audio bus writer node.
#jira UE-184800
#rb Phil.Popp
[FYI] Phil.Popp
#preflight 645975e54c3ec54e6e2d0a0a

[CL 25396155 by maxwell hayes in ue5-main branch]
2023-05-09 17:27:12 -04:00
rob gay
e576e8b8d9 Fix for shadowing of function when registering interface introduced in refactor
#rb trivial
#rnx
#preflight 6453fd5e4c3ec54e6eff425f

[CL 25343957 by rob gay in ue5-main branch]
2023-05-04 18:12:02 -04:00
rob gay
b17ee42ed3 Fix for ensure in the MS BP builder subsystem when attempting to add a MetaSound Node Class using a literal BP node value
#jira UE-180954
#rnx
#rb helen.yang
#preflight 64529cf1743c256cd6a98b13

[CL 25327697 by rob gay in ue5-main branch]
2023-05-03 18:06:20 -04:00
charlie huguenard
7b12ccaeae [Metasound] Get history of output changes instead of last value
#preflight 64513fbb4d593c0b42b03cc8
#rb phil.popp

[CL 25320519 by charlie huguenard in ue5-main branch]
2023-05-03 13:43:51 -04:00
charlie huguenard
5239c236a2 [Metasound] Fix mismatch in param transmitter ids
#preflight 645024ea6538e45f75d16b7e
#rb miles.flanagan, phil.popp

[CL 25300567 by charlie huguenard in ue5-main branch]
2023-05-02 09:27:16 -04:00
charlie huguenard
16e205ba71 [Metasound] Pass audio component id to OnGeneratorInstanceCreated instead of the individual voice id
#jira UE-184555, UE-184554
#preflight 644befb1f50260822919bc80

[CL 25234241 by charlie huguenard in ue5-main branch]
2023-04-28 12:28:48 -04:00
phil popp
e8be08d06e [Metasounds] removing Reset() function from0 audio bus writer node to see if it is the cause of automated test crashes.
#jira UE-184201
#rb Phil.Popp
#preflight 6449aa4a6b589f8b369fa4a2
[FYI] Maxwell.Hayes

[CL 25225488 by phil popp in ue5-main branch]
2023-04-27 18:49:33 -04:00
maxwell hayes
b2246c57ee [Metasounds] Adding Reset() function to audio bus reader/writer nodes.
#jira UE-179001
#rb Phil.Popp
#preflight 644317e90171aae0b1de17df

[CL 25156686 by maxwell hayes in ue5-main branch]
2023-04-21 20:49:41 -04:00