ionut matasaru
119dbc1a08
Enabled UnsafeTypeCast warnings as errors in Trace/Insights related modules (UnrealInsights, TraceAnalysis, TraceServices, TraceDataFiltering, TraceUtilities, EditorTraceUtilities).
...
Fixed conversion warnings in TraceAnalysis and in TraceServices modules.
#rb Catalin.Dragoiu
[CL 28339045 by ionut matasaru in ue5-main branch]
2023-09-29 07:22:52 -04:00
keith yerex
1391e09639
Enable visual logger rewind debugger integration
...
#rb Samuele.Rigamonti
[CL 28330456 by keith yerex in ue5-main branch]
2023-09-28 17:58:11 -04:00
jamie hayes
e967254bcf
Add a check to the mesh simplifier to avoid collapsing an edge if it is shared by all triangles, thus causing all triangles in the cluster to be degenerate.
...
This fixes asserts that have been seen in the wild.
#rb brian.karis
#jira UE-193405
[CL 28327825 by jamie hayes in ue5-main branch]
2023-09-28 16:30:49 -04:00
ionut matasaru
1c1a00ca7c
Enabled UnsafeTypeCast warnings as errors in the TraceInsights module.
...
Fixed conversion warnings.
#rb Catalin.Dragoiu
[CL 28314550 by ionut matasaru in ue5-main branch]
2023-09-28 08:01:12 -04:00
ionut matasaru
afcb88a1fc
[Insights] Fixed trimming of 64bit numbers to 32bit when displayed as hex (i.e. %x was used instead of %llx for uint64 numbers). This includes truncation of address displayed in Memory Insights when callstack resolving is not completed.
...
#rb Catalin.Dragoiu
[FYI] Martins.Mozeiko
[CL 28314477 by ionut matasaru in ue5-main branch]
2023-09-28 07:58:19 -04:00
jason hoerner
6f67025ccc
Shader Compiler: Optimized version of CleanupUniformBufferCode, called during preprocessing. New version is 3.8x faster, producing a 19% overall speedup in ConditionalPreprocessShader. Processes the shader in a single pass, scanning for potential compound identifiers (symbol tokens connected by dots and optional whitespace), then checking if they match known uniform buffer members. A few optimizations improve the speed of checking if an identifier matches, including an early out based on identifier length and start character, followed by organizing uniform buffers and their members by length, requiring only a small subset of members to be tested. Parsing uniform buffer definitions was also optimized to avoid memory allocation.
...
Doesn't produce bit identical preprocessed output, as it compacts whitespace from compound identifiers before testing them, whereas the original implementation compacts whitespace after matching. Compacting first makes testing more efficient and simpler, since it doesn't need to take into account whitespace. For A/B validation, I did add temporary debug code that stored and reverted un-matched identifiers, mimicking the old behavior, and it was identical across the board.
#rnx
#rb dan.elksnitis chris.waters jason.nadro
[CL 28313553 by jason hoerner in ue5-main branch]
2023-09-28 07:08:47 -04:00
christopher waters
cf3272d4e6
Bumping the SM6 version to force all D3D RT shaders to rebuild.
...
#jira UE-196567
[CL 28313514 by christopher waters in ue5-main branch]
2023-09-28 07:08:10 -04:00
chris constantinescu
1aeb7faa75
LLT: Pre-analyse dependency graph of low level test targets before setting compilation flags for UE components
...
Use -Mode=Test by default for all LLT Project to enable pre-analysis of dependency graph.
#jira UE-193632
#rb Sean.Sweeney
[CL 28313218 by chris constantinescu in ue5-main branch]
2023-09-28 06:52:15 -04:00
DuncanRare
0b2cf01d8a
Adding flag to toggle whether or not garbage collection should be delayed, by default they are. Added property to show in the Editor Details panel for the Functional Test in the Advanced section.
...
PR # 10898
#commit 10898
#jira UE-195842
[CL 28294665 by DuncanRare in ue5-main branch]
2023-09-27 17:26:59 -04:00
derek truong
c137ace85e
Fixing missing header guard in DialogUtils header file (added in CL 28276965)
...
#rnx
[CL 28290380 by derek truong in ue5-main branch]
2023-09-27 16:23:37 -04:00
nick edwards
220ccc4b3e
FIoDirectoryIndexReader::IterateDirectoryIndex: Use FStringViews and TStringBuilders instead of FStrings to avoid potentially unnecessary heap allocations
...
FPakPlatformFile::ForeachPackageInIostoreWhile: Update usage of IterateDirectoryIndex, and use overload of TryConvertFilenameToLongPackageName using string views and builders to avoid allocations
#rb elias.lozadabenavent
#rb anton.dunchev
[CL 28282945 by nick edwards in ue5-main branch]
2023-09-27 14:10:02 -04:00
derek truong
a579907a04
Support for rich text messaging in SMessageDialog and utility for converting between message categories and Slate brushes
...
#rb jamie.dale
[CL 28282154 by derek truong in ue5-main branch]
2023-09-27 13:56:29 -04:00
alexis matte
80bd8e62b9
Interchange: Add missing traces to be able to verify the performance.
...
#jira UE-152387
#rb jeanluc.corenthin
#rnx
[CL 28281857 by alexis matte in ue5-main branch]
2023-09-27 13:52:22 -04:00
zousar shaker
2069588930
Fix a bug with handling of Zen interprocess communication specific to Mac/Linux. When signaling a semaphore you haven't created, don't remove its ID, leave that for the creator to do.
...
#rb dan.engelbrecht
[CL 28280554 by zousar shaker in ue5-main branch]
2023-09-27 13:26:57 -04:00
dan elksnitis
4515e3b5f4
[shaders] add debug dump option to output "detailed" shader source, including the output of the preprocessing step unmodified, the stripped version used for hashing, and whatever the final source passed to the compiler is (can differ from the stripped version if further modifications are applied as part of the compile step). this is only done if the preprocessed job cache is enabled; otherwise (and if this cvar is disabled) the single output will either be the compiler-step-modified source if it exists, or the output of the preprocessing step.
...
#rb Jason.Hoerner
[CL 28274493 by dan elksnitis in ue5-main branch]
2023-09-27 11:02:18 -04:00
catalin dragoiu
30565203c0
[Insights] Add infinity and NaN support to table import and table diff.
...
#jira UE-177128
#rb Ionut.Matasaru
[CL 28267148 by catalin dragoiu in ue5-main branch]
2023-09-27 05:11:10 -04:00
graham wihlidal
5605de3a9d
Refactored DXC RemoveContainerReflection into RemoveContainerParts that can remove additional parts. Also disabled post compile signing step for now.
...
#rb christopher.waters
[CL 28262563 by graham wihlidal in ue5-main branch]
2023-09-26 23:49:12 -04:00
dmitriy dyomin
b967feaef8
Add ability to setup VT support on a per-platform basis
...
#rb jeremy.moore
[CL 28260983 by dmitriy dyomin in ue5-main branch]
2023-09-26 22:38:26 -04:00
alexander suvorov
7d23806b95
Implement PadWithBorderColor texture setting.
...
#jira UE-158070
#rb Dan.Thompson
[CL 28253332 by alexander suvorov in ue5-main branch]
2023-09-26 18:49:57 -04:00
robb surridge
b8fd678d2d
Apply padding around the button row in confirmation dialogs in places where it had been removed by a previous fix to SWindow.
...
#jira UE-195462
#rb aditya.ravichandran
[CL 28224816 by robb surridge in ue5-main branch]
2023-09-26 09:36:52 -04:00
jason hoerner
57a469b8d9
Build fix -- preprocessor compile error due to assigning a variable twice in one statement (once in the macro, once in the code). Second instance in the code, doh!
...
#rnx
[CL 28221361 by jason hoerner in ue5-main branch]
2023-09-26 07:30:24 -04:00
jason hoerner
fb2a55e5b7
Build fix -- preprocessor compile error due to assigning a variable twice in one statement (once in the macro, once in the code).
...
#rnx
[CL 28221307 by jason hoerner in ue5-main branch]
2023-09-26 07:29:25 -04:00
wouter burgers
1702425807
Skein / ConflictUE: Add conflict information to StatusBar.
...
Why? These buttons have to behave differently when there are unresolved conflicts remaining.
Note that it isn't possible to add a build dependency from a module in /Engine to the Skein module in /Engine/Plugins, hence the cvar/ccmd approach.
#rb manuel.lang, marco.anastasi
#rnx
[CL 28220661 by wouter burgers in ue5-main branch]
2023-09-26 06:31:30 -04:00
jason hoerner
046ace59ff
ShaderCompiler: Preprocessor optimizations, first pass. Saves 16.7% overall on ConditionalPreprocessShader.
...
* Inline array memory allocation added to low level preprocessor for output and various temporary buffers to reduce dynamic memory allocation and reallocation overhead. Saved 4.6%.
* FShaderPreprocessOutput::StripCode optimized to write to FString as TCHAR array, rather than using AppendChar (over 4x speedup). Saved 2.9%
* Shader source file cache now also stores stripped and ANSI converted source, to avoid need to convert and strip the source, plus allocating a copy is avoided. Saved 4.3%
* Uniform buffer structure declarations stored as ANSI converted source, avoiding convert and copy. Saved 4.9%
#rnx
#rb dan.elksnitis jason.nadro
[CL 28219741 by jason hoerner in ue5-main branch]
2023-09-26 05:29:05 -04:00
josh adams
cfdee19cd3
- Fixed IPhones to not show up as VisionOS devices in the Platforms menu in the editor
...
#rb adam.kinge
[CL 28207784 by josh adams in ue5-main branch]
2023-09-25 17:48:41 -04:00