#lockdown Nick.Penwarden
#rb none
#rnx
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3377136 on 2017/04/03 by Dan.Oconnor
Reenable compilation manager
Change 3377365 on 2017/04/03 by Dan.Oconnor
Back out changelist 3377136
Change 3378131 on 2017/04/04 by Dan.Oconnor
Enable compilation manager again after 3377912, 3378081, and 3378094
Change 3379268 on 2017/04/04 by Dan.Oconnor
Disable compilation manager
Change 3383505 on 2017/04/06 by Dan.Oconnor
Enabling compilation manager - no known issues.
Change 3430210 on 2017/05/09 by Dan.Oconnor
Disable compilation manager while I think about fixes for UE-44780/UE-44794
#rnx
Change 3431439 on 2017/05/09 by Marc.Audy
Editor only subobjects shouldn't exist in PIE world
#jira UE-43186
Change 3431542 on 2017/05/09 by Dan.Oconnor
Fix crash when opening a blueprint with missing variables and using the compilation manager
#jira UE-43843
Change 3432743 on 2017/05/10 by mason.seay
Added attachment test to map
Change 3432836 on 2017/05/10 by Lukasz.Furman
fixed behavior tree decorator's deactivation when it's placed on parallel task
#jira UE-44817
Change 3432837 on 2017/05/10 by Lukasz.Furman
fixed missing deactivation notifies in behavior tree nodes after forced stop of execution (StopTree call)
#ue4
Change 3433065 on 2017/05/10 by Marc.Audy
Timeline properties should be blueprint visible as they get expanded out to Get Property nodes
Change 3433135 on 2017/05/10 by Lukasz.Furman
added missing nav area registration call
#jira UE-44144
Change 3433195 on 2017/05/10 by Marc.Audy
de-auto
#rnx
Change 3433275 on 2017/05/10 by Phillip.Kavan
#jira UE-44765 - Fix a regression that introduced a potential EDL cycle on load for UDynamicClass dependencies in a nativized build.
Change summary:
- Added new helper methods to FGatherConvertedClassDependenciesHelperBase for populating converted class, struct and enum dependency sets.
- Minor refactor to FFindAssetsToInclude to more generally allow me to recursively add outer class and struct references as additional "used asset" dependencies, based on whether or not the type might also be getting converted. In CL#3416419 I was always adding owner class CDOs as a dependency even if the owner class was being converted, and this introduced the potential for an EDL cycle.
#rnx
Change 3433681 on 2017/05/10 by Mike.Beach
Adjusting the component tree search bar to be below the AddComponent buttons for level editor instance-editing mode (not enough room with the BP button).
Change 3433687 on 2017/05/10 by Ben.Zeigler
Remove delegate redirector type, I never implemented it and it's not useful, dynamic delegates fixup based on parameter type/count and not name in most cases
Change 3434005 on 2017/05/10 by Ben.Zeigler
#jira UE-44890 Don't reset local variables that are containers of user structs, delta serialization isn't used for user structs so just keep the same string as before. This is not a regression and looks to have always been broken
Change 3434011 on 2017/05/10 by Marc.Audy
Fix LocalVariable Properties to be flagged as CPF_BlueprintVisible
Change 3434026 on 2017/05/10 by Ben.Zeigler
Add automated test utility functions to clear standalone flag, needed to allow testing async loading in the editor
Change 3435245 on 2017/05/11 by mason.seay
Submitting test assets for input testing and interactive loading screens
Change 3435491 on 2017/05/11 by Mike.Beach
CIS SA fix (fallout from CL 3433681) - removing trinary operator that selects from two identical values.
Change 3435962 on 2017/05/11 by Ben.Zeigler
Change it so PrimaryAssetLabels are editor only by default. This allows them to cook content without the label itself being cooked
Change 3436322 on 2017/05/11 by Dan.Oconnor
Fix for calling CopyTermDefaultsToDefaultObject at the wrong time when using the compilation manager, needs to be postponed until other defaults are copied
#jira UE-44780, UE-44794
Change 3437205 on 2017/05/12 by Ben.Zeigler
Change Persistent Ubergraph Frame references to be correctly weak. With the old method if an asset had subobjects those internal references would cause it to be strong. Now, it doesn't expose them to GC at all other than to register them for clearing if GC deletes those objects
Change ObjectProperty to directly serialize object references when doing a reference collector, this is needed for above change so it will null the right value and not a stack local copy
Remove NoStrongReference flag and SetShouldHandleAsWeakRef entirely, this makes the internal GC code simpler and faster
Switch internals of GC to use FGCArrayStruct which has the serialize array as well as the weak references array
Change 3437206 on 2017/05/12 by Ben.Zeigler
Add Async loading functional test. This tests the LoadAsset and Convert nodes and ensures that the recent changes to ubergraph frame refs work properly
Change 3437234 on 2017/05/12 by Ben.Zeigler
Fix DirectoryPathStructCustomization to work properly with both LongPackageName and RelativeToGameContentDir set, before it was chopping off text and leaving nonsense
Change 3437368 on 2017/05/12 by Dan.Oconnor
Mirror 3434064, but with betterwhitespace. Prevents blueprint CDO subobjects from being stomped when using EDL
Change 3439330 on 2017/05/15 by Ben.Zeigler
First half of Blueprint API for AssetManager, this covers everything other than load/unload
Rename GetPrimaryAssetIdFromData to ExtractPrimaryAssetIdFromData and make comments clearer that it works even if the asset isn't in the dictionary. Add GetPrimaryAssetIdForData to cover dictionary case
Change it so modifying the asset manager settings within the editor will refresh the dictionary
#jira UE-45016 Fix crash scanning empty paths
Change 3439331 on 2017/05/15 by Ben.Zeigler
AssetManager Functional tests. Set up EngineTest project to have some assets and an ini configuration
Change 3439644 on 2017/05/15 by Dan.Oconnor
Fix BlueprintCompilationManager running OnLevelScriptBlueprintChanged before CDO defaults were up to date
#jira UE-44972
#rnx
Change 3439992 on 2017/05/15 by Dan.Oconnor
Add missing OptionallyRefreshNodes, which is a hot reload hack
#jira UE-44970
#rnx
Change 3440223 on 2017/05/15 by Ben.Zeigler
Move StreamableManager GC callback to pre GC to avoid requring 2 GCs to delete unreferenced assets
Change 3440406 on 2017/05/15 by Ben.Zeigler
Fix bug with combined StreamableManager handles where the complete callback wouldn't correctly execute. This can happen when using the asset manager to load more than one asset at a time
Change 3440879 on 2017/05/16 by Marc.Audy
Fix casing on #include to fix Linux CIS error
#rnx
Change 3441137 on 2017/05/16 by Ben.Zeigler
Fix it so ImportText/ExportText on an AssetObjectProperty correctly calls the StringAssetReferenceVersions, and fix a parse issue when importing class'/path' strings into the struct version
Change 3441364 on 2017/05/16 by Ben.Zeigler
#jira UE-45080 Fix Linux CIS issue
Change 3441444 on 2017/05/16 by Dan.Oconnor
Run RefreshExternalBlueprintDependencyNodes at a more appropriate time when using the compilation manager, link skeleton functions when using the compilation manager so that PropertyFlags match GeneratedClass
#jira UE-45029, UE-45037
#rnx
Change 3441445 on 2017/05/16 by Dan.Oconnor
Remove unused declaration
#rnx
Change 3441492 on 2017/05/16 by Ben.Zeigler
Rest of Asset Manager BP API
Added multiple async actions for loading and changing bundle states, and querying bundle states
Change it so the LoadAsset node has a then node to match the new async actions, and rename to Async Load Asset
Add HideThen metadata option to async actions and fix crash when renaming bound function
Change 3441493 on 2017/05/16 by Ben.Zeigler
Update AssetManager and AsyncLoading tests
Change 3441494 on 2017/05/16 by Ben.Zeigler
Update the archive's serialized property when serializing array, set, and map to point to the inner property. Fix a few call sites to look at parent property as needed.
This is needed for the new BPGC weak reference feature, but might also fix some crashes with HotReload where it was expecting the inner property and casting to ObjectProperty.
Change 3441600 on 2017/05/16 by Michael.Noland
Blueprints: Fixed some indentation issues in code
#rnx
Change 3441601 on 2017/05/16 by Michael.Noland
Blueprints: Changed DLL exporting on UK2Node_Tunnel and UK2Node_Composite to allow them to be used in plugins more readily
Change 3441602 on 2017/05/16 by Michael.Noland
Graph Editing: Changed FGraphEditorDragDropAction to work directly with a UEdGraphNode rather than a SGraphNode
Graph Editing: Allowed FGraphSchemaActionDragDropAction to be dropped onto pins in addition to the graph background, which will behave as if you dragged off the pin and picked the same action
Change 3441607 on 2017/05/16 by Michael.Noland
Blueprints: Allow functions from My Blueprints to be dropped onto pins in addition to the graph background, which performs the same action as if they had been picked from the menu after dragging off of that pin
Change 3441608 on 2017/05/16 by Michael.Noland
Blueprints: Allow non-readonly variables from the My Blueprints panel to be dropped onto exec pins, which creates a variable set node for them
Change 3441613 on 2017/05/16 by Michael.Noland
Epic Friday: Snap node prototype (more compact way of organizing straight line Blueprint code via drag-dropping)
- Super early prototype, plugin is not enabled by default and is currently in NotForLicensees
Change 3441802 on 2017/05/16 by Michael.Noland
Blueprints: Adding some includes that are missing according to CIS
#rnx
Change 3441921 on 2017/05/16 by Dan.Oconnor
Avoid skipping full compile when not loading a DOB from disk - when a blueprint became data only we were not running the full compile
#jira UE-45048
#rnx
Change 3442903 on 2017/05/17 by Marc.Audy
Refactor header parser verification of rep notify functions in preparation for other forms of function verification.
Fixed ability to specify incompatible properties as the parameter to the OnRep function as long as the base property type was the same (i.e. UObjectProperty, UArrayProperty, etc.)
Fixed errors generated by verification not being associated with the correct code line.
Verification errors are now "warnings" and will all be reported rather than a single one being fatal.
Change 3442908 on 2017/05/17 by Marc.Audy
Remove some autos
#rnx
Change 3443802 on 2017/05/17 by Ben.Zeigler
#jira UE-35683 Add ability for resolve AssetId node to go from hard object to assetptr
Add IsValid and == for Asset/ClassId
Change 3444075 on 2017/05/17 by Ben.Zeigler
#jira UE-45121 Remove references to deleted cards, this field was not in use but is now warning due to better validation
Change 3444178 on 2017/05/17 by Dan.Oconnor
Fix for CPFUO dropping default values of CDO subobjects if the blueprint's parent's CDO was being regenerated at the same time
#jira UE-45050
Change 3444927 on 2017/05/17 by Dan.Oconnor
Improve fix for UE-45050, honor Params.bDoDelta
#rnx
Change 3447280 on 2017/05/18 by Marc.Audy
Properties can now be exposed to blueprints in such a way that a getter or setter accessor will be used rather than a direct read/write of the variable
Change 3447320 on 2017/05/18 by Marc.Audy
Some minor schema cleanups
#rnx
Change 3447537 on 2017/05/18 by Dan.Oconnor
Make sure CDO is included in ArchetypeRerencers when a subobject of said CDO is reinstanced
#jira UE-37023
Change 3448754 on 2017/05/19 by Marc.Audy
Fix hot reload crashing in EngineTest
#rnx
Change 3448792 on 2017/05/19 by Marc.Audy
Functional test for BP Accessors
#rnx
Change 3448806 on 2017/05/19 by Marc.Audy
Fix static analysis warning
#rnx
Change 3449091 on 2017/05/19 by Marc.Audy
Allow Find References to be selected from the components panel
#jira UE-45101
Change 3449361 on 2017/05/19 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3449079
#rnx
Change 3449644 on 2017/05/19 by Marc.Audy
Fix Anim SubInstance generated properties not being Blueprint Visible
Change 3450003 on 2017/05/19 by Dan.Oconnor
We need to do a bytecode only compile of dependent blueprints when an individual blueprint is compile because we cannot safely skip functions that are removed or change layout
#jira UE-45196
#rnx
Change 3452022 on 2017/05/22 by Marc.Audy
Fix BlueprintVisibility issues in orion UI
#rnx
Change 3452133 on 2017/05/22 by Ben.Zeigler
#jira UE-45240 Fix it so invalid primary asset types are not parsed, this happens while halfway through editing in the UI
Stop asset manager from generating 600 notifications, this causes multiple second stalls in the editor
Change 3452697 on 2017/05/22 by Marc.Audy
Use BlueprintGetter/Setter metadata instead of BlueprintInternalUseOnly for preventing accessors from appearing in menus
Prevent BlueprintNativeEvents from being used as property accessors
Disable functional test for blueprint native events
Change 3452780 on 2017/05/22 by Ben.Zeigler
Switch it so the LongPackageName and ContentDir metadata on a FDirectoryPath do the same thing and give you the in-editor path picker. These two metadata flags were implemented in parallel on two separate branches
Change 3452790 on 2017/05/22 by Ben.Zeigler
Fix issue when calling TryConvertFilenameToLongPackageName with a root directory name, and add comment mentioning that it works for directories, it's used this way throughout the editor and we couldn't come up with a better name for the function
Deprecated FPackageName::ConvertRootPathToContentPath and PackageFromPath as they were confusingly named and not used much. Also cleaned up header in general
Change 3454629 on 2017/05/23 by Marc.Audy
Deal with fall out from initial approach to disabling the native event getter/setter functional tests
#jira UE-45321
#jira UE-45322
Change 3454661 on 2017/05/23 by Marc.Audy
Mark Actor.RootComponent as having a getter instead of GetRootComponent being an explicitly exposed blueprint callable function
Change 3454662 on 2017/05/23 by Marc.Audy
Fix blueprint visibility of anim notify properties
Change 3454663 on 2017/05/23 by Marc.Audy
Fix fortnite blueprint exposure issues
Change 3454695 on 2017/05/23 by Lukasz.Furman
fixed bug with behavior tree decorator duplication: properties are no longer reset to defaults
#3591
Change 3454789 on 2017/05/23 by Ben.Zeigler
Add ProposedPlacement parameter to TryCalculatePopupWindowPosition that if non zero will allow the less common anchor styles like MenuPlacement_ComboBoxRight to work properly for popups spawned in a new window
Make the variable type menu be ComboBoxRight so it gives more space for longer sub type descriptions coming in a different change
Change 3454816 on 2017/05/23 by Ben.Zeigler
Change blueprint type of AssetID to SoftObjectReference and AssetClassId to SoftClassReference. These will also change in native for 4.18
Fix display issues with complicated variable types, for some reason it was using the non-localized name
Change 3454967 on 2017/05/23 by Lukasz.Furman
fixed ANavigationData.bForceRebuildOnLoad being ignored by navigation system
#jira UE-44231
Change 3454982 on 2017/05/23 by Ben.Zeigler
#jira UE-45298 Refresh primary asset ID selector when menu is reopened
Change 3455714 on 2017/05/23 by Marc.Audy
Prevent attachment from being setup to attach to itself or in a cyclic fashion.
#jira UE-45244
Change 3455871 on 2017/05/23 by Marc.Audy
Rename UEdGraph::CreateBlankNode to CreateIntermediateNode
Added bIsIntermediate flag to UEdGraphNode which is set via CreateIntermediateNode
No longer set timeline variables as blueprint visible
#jira UE-45204
Change 3455930 on 2017/05/23 by Ben.Zeigler
#jira UE-45349 Resave TM-Gameplay map. The map got fixed while UE-44972 was still open, which lead to the level script variables being corrupted. Manually compiling fixed the issue and the core bug is now fixed. Any other maps saved directly on Framework might show the same issue
Change 3456507 on 2017/05/24 by Marc.Audy
Fix game builds
#rnx
Change 3457323 on 2017/05/24 by Marc.Audy
Undo CL# 3431439 and once again allow (incorrectly) for editor only objects to exist in a PIE world
#jira UE-45087
Change 3459068 on 2017/05/25 by mason.seay
Adding gamepad mapping for sprinting
Change 3459466 on 2017/05/25 by Dan.Oconnor
Fix for stale UClass ptrs in ReinstanceBatch when using compilation manager
#jira UE-45386
Change 3459469 on 2017/05/25 by Dan.Oconnor
Fix issue exposed by compilation manager - this function can't assign struct default values (e.g. LinearColor)
#jira UE-45389
[CL 3459511 by Marc Audy in Main branch]
New FindSortedStringCaseInsensitive algorithm, which binary searches strings in an array.
Many UHT string tests replaced with FindSortedStringCaseInsensitive.
FPropertySpecifier moved to UHT.
#codereview robert.manuszewski
[CL 2587588 by Steve Robb in Main branch]
Ben Marsh
Marc Audy
Steve Robb