Commit Graph

102 Commits

Author SHA1 Message Date
aurel cordonnier
e0ad4e25df Merge from Release-Engine-Test @ 16624776 to UE5/Main
This represents UE4/Main @ 16579691 and Dev-PerfTest @ 16579576

[CL 16625248 by aurel cordonnier in ue5-main branch]
2021-06-10 13:13:24 -04:00
Phillip Kavan
dfa32e9708 Extends the class viewer module to support multiple custom class filters along with an optional associated view option flag.
Additional changes:
- Deprecates the previous method for specifying a singular custom class viewer filter and updates all existing occurrences of this pattern in engine code.
- Extends the property editor utilities interface to expose custom class filter(s) that can be applied to the class picker widget used for editing class property values.
- Adds an implementation of this interface to SDetailsView such that additional class filter(s) can now be configured to be applied to all underlying class property nodes.

#jira UE-108316
#rb Lauren.Barnes
#preflight 60c2102e8ae8960001110d50

[CL 16623084 by Phillip Kavan in ue5-main branch]
2021-06-10 10:31:37 -04:00
sebastian nordgren
bb9ac331d5 Removed bShowOnlyWhitelistedProperties from details config. If the value was serialized, it would likely be nonsensical without the list of whitelisted properties, which are currently always set programmatically (by the diff tool, for example) and not by the user.
#review-16483499 @lauren.barnes
#preflight 60afa09e1db8a70001f3e6f9

[CL 16484336 by sebastian nordgren in ue5-main branch]
2021-05-27 10:32:27 -04:00
sebastian nordgren
394e3fcc62 Added FDetailsViewConfig to store various details view settings, using the new EditorConfig system.
Renamed FDetailFilter properties to be consistent with one another.

#review-16449481 @lauren.barnes

[CL 16468647 by sebastian nordgren in ue5-main branch]
2021-05-26 09:46:13 -04:00
sebastian nordgren
d3f04cfb76 Moved items in a details view array now have their expansion state restored after being moved.
#review-16446209 @lauren.barnes
#preflight 60ace54358f02e0001a57434

[CL 16446667 by sebastian nordgren in ue5-main branch]
2021-05-25 08:59:30 -04:00
sebastian nordgren
039605ce82 Renamed bShowOnlyDiffering to bShowOnlyWhitelisted - that it's only used for diffing is a detail that the details view shouldn't know about.
#rb paul.chipchase

[CL 16073432 by sebastian nordgren in ue5-main branch]
2021-04-21 10:40:13 -04:00
sebastian nordgren
a7739c5df1 Added SetIsCustomRowReadOnlyDelegate to enable customizing the read-only state of custom rows en-masse.
Removed SetIsCustomRowVisibilityFilteredDelegate, because it was unused and needlessly complex since the delegate that you pass into SetIsCustomRowVisibleDelegate can run the same logic and early out.

Category and property filtering through Properties To Show and Categories to Show now works properly.The problem was that visiblity was only considered once on creation and then never again.

#jira UE-88178
#review-15797106 @lauren.barnes
#preflight 605b2381c77fb000015e6a30

[CL 15797104 by sebastian nordgren in ue5-main branch]
2021-03-24 08:16:16 -04:00
sebastian nordgren
eba54425f5 Padding fixes for left alignment in the details panel.
Splitter line now always visible, and splitter column width ratio adjusted to be closer to 50/50.

Favorites hint text now renders with a more subdued style.

[at]lauren.barnes

#ROBOMERGE-SOURCE: CL 15355944 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15360308 by sebastian nordgren in ue5-main branch]
2021-02-08 17:05:10 -04:00
Marc Audy
cac1fe0019 Merge UE5/Release-Engine-Staging @ CL# 15299266 to UE5/Main
This represents UE4/Main @ CL# 15277572

[CL 15299962 by Marc Audy in ue5-main branch]
2021-02-03 14:57:28 -04:00
Matt Kuhlenschmidt
24fd139385 Fixed up locations making one off thumbnail pools and converted them to use the shared thumbnail pool.
[CL 15211295 by Matt Kuhlenschmidt in ue5-main branch]
2021-01-26 17:21:08 -04:00
sebastian nordgren
560ed14eb0 Added EditorMetadataOverrides subsystem and enabled its usage for details view favourites.
The Favorites category is now always visible, and displays a note about how to add properties there when empty.

#rb chris.gagnon
#jira UETOOL-2769

[CL 15208242 by sebastian nordgren in ue5-main branch]
2021-01-26 11:51:28 -04:00
Marc Audy
bc88b73a29 Merge Release-Engine-Staging to Main @ CL# 15151250
Represents UE4/Main @ 15133763

[CL 15158774 by Marc Audy in ue5-main branch]
2021-01-21 16:22:06 -04:00
sebastian nordgren
09e38a136c SDetailsViewBase now allows deferred actions to call EnqueueDeferredAction. These additional deferred actions are then immediately processed in the same frame.
This manifested as an ensure in a details customization calling EnqueueDeferredAction from within CustomizeChildren when a UCurveTable was added to an array.

Since programmers may not understand that it can be called from a deferred action, this restriction would be very hard for programmers to grasp until the assertion triggers.

#jira UE-104844
#rb matt.kuhlenschmidt

[CL 15010356 by sebastian nordgren in ue5-main branch]
2021-01-07 11:39:18 -04:00
sebastian nordgren
67f0f04615 The details tree now correctly restores expanded categories when clearing the search field.
This was occurring because multiple calls to RequestItemExpanded in the same frame would cause later calls to be ignored because the state it was trying to set was already the current state. However, this ignored that the state would change once the pending FilteredNodesRequestingExpansionState list had been processed at the end of the frame.

#rb lauren.barnes
#jira UE-85802

[CL 15009200 by sebastian nordgren in ue5-main branch]
2021-01-07 05:39:30 -04:00
geoff evans
bde28af943 Redefine Content Browser's "RealTime Thumbnails" to be only the item the cursor is hovering over instead of every thumbnail in an SAssetView.
This change removes the use of boolean attribute AreRealTimeThumbnailsAllowed. This attribute is less than ideal, design-wise, since it uses the thumbnail pool to drive the behavior of the thumbnails. Instead we build in default hover behavior to the thumbnail slate widgets, and implement plumbing for custom pathways to enable/disable real time behavior per thumbnail.

-> Add default OnMouseEnter/OnMouseLeave events on SAssetThumbnail for default hover behavior (over the actual thumbnail image), which supports detail panel, customizations, and things like FoliageEditor and Niagara Stack Overview thumbnail strip.
-> Add thumbnail initialize pathway support for disabling default hover behavior for use cases where the logical asset is more than just the thumbnail image (border elements, text elements with the asset name, etc).
-> Add custom OnMouseEnter/OnMouseLeave handlers on SAssetTileItem, SAssetListItem to perform real time behavior on entire logical asset item in Content Browser and Asset Picker.

#rb francis.hurteau
#fyi matt.kuhlenschmidt
#jira UETOOL-2363

[CL 14673948 by geoff evans in ue5-main branch]
2020-11-05 21:41:33 -04:00
sebastian nordgren
8be498928d Fixed bug causing categories that had been hidden by customizations to be visible.
I'd accidentally submitted some changes that enabled the favourites system prematurely, and apparently many rows were being counted as favorited despite not being so. This is a temporary fix that will go away when further editor config and favourites system work is done.

#fyi matt.kuhlenschmidt

[CL 14446233 by sebastian nordgren in ue5-main branch]
2020-10-08 11:24:09 -04:00
sebastian nordgren
5050b88330 Details view reskin phase 1.
The details view now displays gridlines between rows, and now has 4 columns - edit condition, name, value, and reset/extensions.

Edit condition widgets are now created in SDetailSingleItemRow and are placed in their own fixed column on the left of the details view. FEditConditionParser is now in FPropertyNode rather FPropertyEditor, which allows access to it more broadly - notably in SDetailSingleItemRow.

The Reset to Default SWidget can no longer be replaced - the logic for it being visible and a handler for when it is pressed is still customizable. SPropertyEditorAsset no longer has a special slot for the reset to default widget.

All extension widgets are now placed in a resizable column on the right of the panel, including the Keyframe button.

FDetailColumnSizeData is now publicly exposed by IDetailsView, and is no longer passed around as much.

#rb matt.kuhlenschmidt

[CL 14375859 by sebastian nordgren in ue5-main branch]
2020-09-23 08:16:20 -04:00
Marc Audy
a7c9001a94 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14075166
#rb
#rnx

[CL 14075271 by Marc Audy in ue5-main branch]
2020-08-11 01:36:57 -04:00
Marc Audy
11f5b21210 Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main)
#rnx

[CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
Louise Rasmussen
df03257ec0 DetailsView - Reconfigure Tool Button placement between the DetailsNameArea and SSCSEditor for ActorDetails and BlueprintDetails Views.
#rb matt.kuhlenschmidt

[CL 13547009 by Louise Rasmussen in ue5-main branch]
2020-05-26 12:56:05 -04:00
ryan durand
627baf970a Updating copyright for Engine Editor.
#rnx
#rb none


#ROBOMERGE-SOURCE: CL 10869241 via CL 10869527 via CL 10869904
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870586 by ryan durand in Main branch]
2019-12-26 15:33:43 -05:00
Robert Manuszewski
7b6f840f7f Copying //UE4/Dev-Core @ 10708550 to Dev-Main (//UE4/Dev-Main)
#rb none

[CL 10708666 by Robert Manuszewski in Main branch]
2019-12-13 11:07:03 -05:00
brandon schaefer
a715ea4f14 Deprecate GIsRequestingExit
Get GIsRequestingExit now by IsEngineRequestingExit()

Set GIsRequestingExit now by RequestEngineExit(const TCHAR* Reason) or RequestEngineExit(const FString& Reason)
NOTE If Reason is 4 or less chars it will generate an ensure to force a reason to exit

The reason behind this change is right now setting GIsRequestingExit to true can cause many things to break mainly early on and with out any sort of log warning we have entered this state. We should wrap this behind a function to allow for proper handling

#rb Chris.Babcock, Michael.Trepka, Michael.Noland
#jira UE-79933
[FYI] Michael.Noland


#ROBOMERGE-SOURCE: CL 8649683 via CL 8653683
#ROBOMERGE-BOT: (v417-8656536)

[CL 8658680 by brandon schaefer in Main branch]
2019-09-12 14:21:26 -04:00
Dave Belanger
07f8963f5f Filter custom rows in UMG Details View
#jira UE-74956
#rb Matt.Kuhlenschmidt

[CL 6892364 by Dave Belanger in Main branch]
2019-06-07 12:44:15 -04:00
Chris Gagnon
930e33cb48 Copying //UE4/Dev-Editor to Dev-Main (//UE4/Dev-Main) for 4.23 From CL 6837861
#rb none

[CL 6838042 by Chris Gagnon in Main branch]
2019-06-04 15:42:48 -04:00