Commit Graph

75 Commits

Author SHA1 Message Date
sebastian nordgren
71aa25c115 Removed check of IsEditConst for DetailPropertyRows, since this was causing elements in VisibleAnywhere containers to not be editable.
#fyi marc.audy, kriss.gossart

[CL 16472196 by sebastian nordgren in ue5-main branch]
2021-05-26 13:51:53 -04:00
Patrick Boutot
aeea5f0679 Slate: Convert SConcertScrollBox, SWrapBox, SBoxPanel, SWindow FSlot's to the FSlotArgument syntax.
#jira UE-114425
#preflight 60adb0b704188d000133d0b9

[CL 16466544 by Patrick Boutot in ue5-main branch]
2021-05-26 06:42:00 -04:00
sebastian nordgren
8d9ccdd48d Fixed warnings related to &= in DetailPropertyRow.cpp on old VS compiler versions.
#jira UE-116397

[CL 16446098 by sebastian nordgren in ue5-main branch]
2021-05-25 07:14:01 -04:00
sebastian nordgren
e4fc76dfd1 Property rows with custom widgets now default to the standard IsEnabled check if a custom one is not set.
#jira UE-115779
#rb lauren.barnes, danny.chapman

[CL 16434493 by sebastian nordgren in ue5-main branch]
2021-05-24 07:26:49 -04:00
aurel cordonnier
8eebe8841f Merge UE5/RET @ 16305968 to UE5/Main
This represents UE4/Main @ 16261013 and Dev-PerfTest @ 16259937

[CL 16306996 by aurel cordonnier in ue5-main branch]
2021-05-12 18:10:03 -04:00
sebastian nordgren
ca7a047932 Edit conditions for properties that don't support edit condition toggles no longer checkSlow when retrieving the check state, but rather only when setting it.
CustomEditConditionValueChanged handlers are now postfixed with a call to FPropertyNode::InvalidateCachedState(), which causes the IsEditConst state to refresh.

Removed unnecessary code to access the PropertyEditor->IsEditConditionMet(), which is stored in EditConditionValue now.

#review @lauren.barnes, @patric.boutot
#jira FROST-1702

[CL 16008018 by sebastian nordgren in ue5-main branch]
2021-04-14 13:15:46 -04:00
sebastian nordgren
13d3eced9f When creating a CustomWidget from an FDetailPropertyRow ie. Category.AddProperty(MyProperty).CustomWidget(), we now forward the property handle to the widget row as well.
#rb lauren.barnes

[CL 15872336 by sebastian nordgren in ue5-main branch]
2021-03-31 04:11:44 -04:00
sebastian nordgren
a496f31be5 Moved unnecessary padding from FDetailPropertyRow that was causing 4 pixels of padding to always appear on the right and throw off alignment in the details panel.
#rb trivial

#ROBOMERGE-SOURCE: CL 15406764 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15406767 by sebastian nordgren in ue5-main branch]
2021-02-15 10:57:06 -04:00
lauren barnes
70f0a2dc9b Changing a check to an ensure so we can find the indeterminate behavior but not crash.
#rb Brooke.Hubert
[FYI] Sebastian.Nordgren

#ROBOMERGE-SOURCE: CL 15392972 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15393063 by lauren barnes in ue5-main branch]
2021-02-11 18:15:30 -04:00
sebastian nordgren
270e57b642 Added FDetailPropertyRow::SetWidgetRowProperties to handle the setting of the FDetailWidgetRow's custom properties correctly in both cases that it's used.
#rb paul.chipchase

#ROBOMERGE-SOURCE: CL 15386872 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15386875 by sebastian nordgren in ue5-main branch]
2021-02-11 07:59:12 -04:00
sebastian nordgren
00cdd61257 Details view labels are now, once again, left aligned.
#rb lauren.barnes

[CL 15279030 by sebastian nordgren in ue5-main branch]
2021-02-02 05:21:40 -04:00
sebastian nordgren
b480730be1 Property names in the details panel are now clipped consistently, rather than allowing a bit of slack that causes the text to zig-zag when the column is resized to be small.
#rb trivial

[CL 15130819 by sebastian nordgren in ue5-main branch]
2021-01-18 11:56:26 -04:00
sebastian nordgren
548ca6c766 IWYU. Removed unnecessary includes of SResetToDefaultPropertyEditor.
[CL 15009203 by sebastian nordgren in ue5-main branch]
2021-01-07 05:41:03 -04:00
sebastian nordgren
aedd43a9d1 Detail property rows that had a custom widget defined for them now correctly call the OverrideResetToDefault delegate given to the custom widget row.
FPropertyHandleImpl also no longer causes an infinite loop of deferred actions when a custom reset to default is set on a property row.

#rb lauren.barnes
#fyi kiaran.ritchie

[CL 14842839 by sebastian nordgren in ue5-main branch]
2020-12-03 06:13:13 -04:00
sebastian nordgren
09b15cf70d Exposed SResetToDefaultPropertyEditor publicly to allow it to be used for material slots.
#rb lauren.barnes

[CL 14444449 by sebastian nordgren in ue5-main branch]
2020-10-08 03:21:16 -04:00
sebastian nordgren
5050b88330 Details view reskin phase 1.
The details view now displays gridlines between rows, and now has 4 columns - edit condition, name, value, and reset/extensions.

Edit condition widgets are now created in SDetailSingleItemRow and are placed in their own fixed column on the left of the details view. FEditConditionParser is now in FPropertyNode rather FPropertyEditor, which allows access to it more broadly - notably in SDetailSingleItemRow.

The Reset to Default SWidget can no longer be replaced - the logic for it being visible and a handler for when it is pressed is still customizable. SPropertyEditorAsset no longer has a special slot for the reset to default widget.

All extension widgets are now placed in a resizable column on the right of the panel, including the Keyframe button.

FDetailColumnSizeData is now publicly exposed by IDetailsView, and is no longer passed around as much.

#rb matt.kuhlenschmidt

[CL 14375859 by sebastian nordgren in ue5-main branch]
2020-09-23 08:16:20 -04:00
Marc Audy
7379fa99c5 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14229157
[CL 14233282 by Marc Audy in ue5-main branch]
2020-09-01 14:07:48 -04:00
Marc Audy
a7c9001a94 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14075166
#rb
#rnx

[CL 14075271 by Marc Audy in ue5-main branch]
2020-08-11 01:36:57 -04:00
Louise Rasmussen
947a583088 Details View Style - First Pass
#rb matt.kuhlenschmidt

[CL 13310990 by Louise Rasmussen in ue5-main branch]
2020-05-14 15:26:59 -04:00
sebastian nordgren
8d60bf0d67 Struct customizations are now allowed to omit the header row in arrays and sets. Maps still require the header so that a default key widget can be generated.
Change requested by UDN.

#jira none
#rb matt.kuhlenschmidt

#ROBOMERGE-SOURCE: CL 12618908 in //UE4/Release-4.25/... via CL 12618909 via CL 12618910
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12618912 by sebastian nordgren in Main branch]
2020-04-06 03:55:45 -04:00
robert manuszewski
b938e59c9b Reimplementing FProperty changes from //UE4/Main
+ Reimplemented FProperty related fixed from //UE4/Main:
CL#10791312, 10804850, 10851666, 10855122, 10855198, 10942138, 11030611, 11030639, 11032261, 11061515, 11136964,11138881, 11214238, 11214865

#rb none (previously reviewed in Dev-Core)
[FYI] Chris.Bunnner, Daniel.Lamb


#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 11302985 via CL 11303011 via CL 11303019
#ROBOMERGE-BOT: (v0-11244347)

[CL 11303183 by robert manuszewski in Main branch]
2020-02-10 08:06:56 -05:00
Max Chen
b4881d8bf8 Copying //UE4/Dev-Editor to Dev-Tools-Staging (//UE4/Dev-Tools-Staging) @11123875
#rb none
#jira none

[CL 11123880 by Max Chen in Dev-Tools-Staging branch]
2020-01-27 20:11:15 -05:00
ryan durand
627baf970a Updating copyright for Engine Editor.
#rnx
#rb none


#ROBOMERGE-SOURCE: CL 10869241 via CL 10869527 via CL 10869904
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870586 by ryan durand in Main branch]
2019-12-26 15:33:43 -05:00
Robert Manuszewski
7b6f840f7f Copying //UE4/Dev-Core @ 10708550 to Dev-Main (//UE4/Dev-Main)
#rb none

[CL 10708666 by Robert Manuszewski in Main branch]
2019-12-13 11:07:03 -05:00
thomas sarkanen
10b564ab48 Exposed FAddPropertyParams to IDetailCategoryBuilder::AddExternalObjects API
This is done primarily to allow unique IDs to be specified to persist expansion state when displaying multiple external objects of the same type.
This forces AllowChildren(true) to mimic previous behavior

#jira UE-80654 - Adding an Input Pose to an Animation Layer will expand all Input options in that layer
#rb Sebastian.Nordgren

#ROBOMERGE-SOURCE: CL 10002792 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v560-9963197)

[CL 10002813 by thomas sarkanen in Main branch]
2019-11-05 05:37:41 -05:00