Commit Graph

41 Commits

Author SHA1 Message Date
rob gay
4971cd6678 UX Scaffolding for MetaSound Composition/Presets Part 2
- Leverage AssetRegistry/Manager to only load data on MetaSounds required to register (disabled until frontend registry supports this)
- Drag-And-Drop assets on MetaSound Graph
- Move ConvertToPreset to toolbar (WIP, still need to properly hide when clicked instead of closing editor blindly, has issue with refresh)

#rb phil.popp
#preflight 60c9a0a83e1b3c0001335ee7


#ROBOMERGE-SOURCE: CL 16689213
#ROBOMERGE-BOT: (v835-16672529)

[CL 16689237 by rob gay in ue5-main branch]
2021-06-16 11:20:44 -04:00
rob gay
0e4f7a7c51 MetaSound UI/UX Composition/Preset Scaffolding
- Revive UMetaSound Asset type
- Revive MS Output generation
- Fix copy pasta'ed type name so MetaSound Source shows up properly in editor
- Clean-up to dynamic doc version reporting if required (show the new version number in log)
- Add versioning to update the RootGraphClass name & add DisplayName

MetaSound Registry Scaffolding Part 1 (From Phil Popp)

#rb phil.popp
#jira UE-117108
#jira UE-117109
#jira UE-117110
#preflight 60bf11780c76f90001db5f5f


#ROBOMERGE-SOURCE: CL 16587155
#ROBOMERGE-BOT: (v828-16531559)

[CL 16587204 by rob gay in ue5-main branch]
2021-06-08 10:52:31 -04:00
rob gay
e26ac0345b - Migrate MetaSound InputLiterals to DefaultLiterals housed on FrontendNodes
- Add FrontendGraphBuilder support for generating VariableNodes for DefaultLiterals if no connection is provided on External/Output nodes
- Move node names to be guids (they're never seen by the user and this will be easier to migrate later)
- Fix DisplayName logic to be unique against one another SEPARATELY from node name logic
- Fix for MetaSounds not compiling if trigger outputs do not have input connected
- MetaSound Document Transform Support
- Fix for for MetaSound Generators not stopping source if failed to create generator due to build errors
#rb phil.popp
#jira UE-112951
#jira UE-116172
#jira UE-116174
#jira UE-116176
#jira UE-116178
#preflight 60b11e7b7e4e6a0001b81c21
#preflight 60b1292d072a1d000164b470

#ROBOMERGE-SOURCE: CL 16502735 in //UE5/Private-Frosty/...
#ROBOMERGE-BOT: STARSHIP (Private-Frosty -> Main) (v826-16501804)

[CL 16502750 by rob gay in ue5-main branch]
2021-05-28 14:09:45 -04:00
Rob Gay
e861882120 - Fix errors from cooking Editor-only content in MetaSounds by marking UMetasoundEditorGraphBase as IsEditorOnly() & !NeedsLoadForEditorGame()
- Make MetaSoundEdGraph transient (never serialized)
- Move FText::FromString calls to concrete FText definitions to avoid warnings while packaging
#rb phil.popp
#jira UE-114986
#preflight 609979f75b1a0b0001529285

[CL 16255509 by Rob Gay in ue5-main branch]
2021-05-10 16:56:43 -04:00
Rob Gay
12abad8cfb Metasound Class Validation & Versioning First Pass
#rb phil.popp
#jira UE-113416
#jira UE-113417
#jira UE-113419
#jira UEAU-781
#preflight 609065b7c4babe0001086600

[CL 16187219 by Rob Gay in ue5-main branch]
2021-05-03 17:52:04 -04:00
rob gay
e8806c89c1 - Rename AudioCommunicationInterface to AudioParameterInterface
- Add button to execute MetaSound trigger on node titlebar
#rb trivial
#jira UE-112952
#lockdown nick.whiting
#preflight 606d4a44b934f5000113fd7c

#ROBOMERGE-SOURCE: CL 15938407 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15938480 by rob gay in ue5-main branch]
2021-04-07 02:59:10 -04:00
phil popp
4f3b457c6e Removing more unwanted types and hiding blacklist of input types
#lockdown Nick.Whiting
#jira UE-112303
#rb Rob.Gay
#preflight 606cf9f30ecb2c0001e42a7c

#ROBOMERGE-SOURCE: CL 15937067 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15937071 by phil popp in ue5-main branch]
2021-04-06 21:02:21 -04:00
rob gay
a5adaf2847 - Fix triggered inputs firing on initialization in subsequent SoundGenerator instances
- Caused by leak in Transmission System's Global DataChannels, wherein AudioComponents were not removing instance data, which caused new sounds played from that Component taking on last value set from prior instance.
    - Remove custom input preview Sender logic in MetasoundEditor to avoid managing multiple senders (can just use the one housed on the preview AudioComponent).
#lockdown nick.whiting
#jira UE-111897
#rb phil.popp
#preflight 606bea71d5cb3c000197c7ac

#ROBOMERGE-SOURCE: CL 15927511 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15927516 by rob gay in ue5-main branch]
2021-04-06 01:41:29 -04:00
rob gay
c2009afd4f Fix Metasound object proxy asset filters (FOR GOOD!) to not include child class types. (Post EA, will make an option per proxy, but for now do all as SoundWave is only type).
#rb jimmy.smith
#jira UE-112301
#lockdown nick.whiting

#ROBOMERGE-SOURCE: CL 15924872 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15924897 by rob gay in ue5-main branch]
2021-04-05 19:26:15 -04:00
rob gay
ca0a540618 Fix MetaSound Editor CanDuplicate/Duplicate logic
Fix crash when copying comments in MetasoundEditor
#jira UE-110456
#rb maxwell.hayes
#jira UE-110456
#jira UE-112668

#ROBOMERGE-SOURCE: CL 15903543 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15907199 by rob gay in ue5-main branch]
2021-04-02 20:17:57 -04:00
rob gay
080ec409b3 More MetaSound UX Clean-up
- LogTemp & LogMetasound to LogMetaSound
- Hide Import/Export UI options (to/from Json) for EA from editor as its halfbaked
- Reorder node right-click context menu entries to follow suit with BP
- Add new dedicated metasound icon
#rb trivial
#jira none
#preflight 6066b882e0e94d0001afa196

#ROBOMERGE-SOURCE: CL 15899641 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15899642 by rob gay in ue5-main branch]
2021-04-02 03:03:27 -04:00
rob gay
adb961b654 Rename Metasound to MetaSound (PascalCase) in all places in UX. (Code-side to be cleaned up post EA)
#rb trivial
#jira nojira
#preflight 6066ab3dc5a3a100016fc8a0

#ROBOMERGE-SOURCE: CL 15899490 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15899491 by rob gay in ue5-main branch]
2021-04-02 02:09:50 -04:00
rob gay
9dc13df30e General Transaction Model Clean-up
- Fixes most Undo/Redo issues
- Fix desync between frontend & editor when moving nodes
- Add Metasound Icon & respective logic
- Add logic to bypass waveform rendering on inherited SoundWave types
#jira UE-112559
#jira UE-110511
#jira UE-111005
#jira UE-112306
#rb jimmy.smith

#ROBOMERGE-SOURCE: CL 15898805 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15898813 by rob gay in ue5-main branch]
2021-04-01 22:37:16 -04:00
rob gay
e2811a15b0 Only march Metasound ants when previewing
- Remove redundant graph policy code that was not used (and move implementation that was used to old stub code's .h/.cpp)
#rb aaron.mcleran
#jira none
#preflight 605cfc99a8aabd000186ab72

#ROBOMERGE-SOURCE: CL 15834279 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v785-15821902)

[CL 15834725 by rob gay in ue5-main branch]
2021-03-25 18:53:35 -04:00
rob gay
a63fd81565 Add "Promote To Input"
- Various tidy up micro-tasks
#rb aaron.mcleran
#jira UEAU-742
#preflight 605c0b3ffc582100013541b0

#ROBOMERGE-SOURCE: CL 15826528 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v785-15821902)

[CL 15833956 by rob gay in ue5-main branch]
2021-03-25 18:23:25 -04:00
rob gay
d4b6669542 - Display General Sound properties in new inspector view in Metasound Editor
- Disallow deleting outputs from Metasound editor graph.
- Disallow adding outputs to Metasound editor graph (re-enable once reading outputs is required by composition)
#rb aaron.mcleran
#jira UEAU-771
#preflight 605b6864d88d2d0001b39d7c

#ROBOMERGE-SOURCE: CL 15804373 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v783-15756269)

[CL 15808143 by rob gay in ue5-main branch]
2021-03-24 16:42:25 -04:00
rob gay
6661b718b6 Add Trigger Simulation
- Add ExecutableDataType statics required for updating and ownership of triggers on Receive and Input nodes to avoid triggers spamming when set from boolean literals (Could potentially be useful for AudioBuffer inputs transmission).
- Misc clean-up
#jira UEAU-740
#rb phil.popp
#preflight 60596c28216649000137e147

#ROBOMERGE-SOURCE: CL 15773055 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v783-15756269)

[CL 15785846 by rob gay in ue5-main branch]
2021-03-23 17:55:31 -04:00
rob gay
1e147aadf3 Metasound UI/UX Updates
- Input/Output Reference nodes (Allows more than one input node per input, & hiding output nodes if not desired)
- Implement hotswapping input/output types
- Update MS Graph context menu to dynamically add actions for available inputs/outputs
- Add copy/paste for input/output nodes (but disallow from other graphs)
- Various utility functions for frontend for iterating node inputs/outputs
- Consolidation of GetDisplayName/GetDescription node logic into Frontend
- 1st pass on fixing up sync code to support input/output ed reference nodes
- Migrate edgraph input literals to new UObject class to allow for input references & hotswapping type
#jira UEAU-740
#rb jimmy.smith
#preflight 6053e0c61965b60001192560

#ROBOMERGE-SOURCE: CL 15745119 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v781-15675533)

[CL 15750030 by rob gay in ue5-main branch]
2021-03-19 15:10:57 -04:00
jimmy smith
da49a7aa85 Metasound Communications Blueprint API
#jira UEAU-711, UEAU-714
#rb araron.mcleran phill.popp rob.gay
#preflight 604acc07e68f8200017d69af

#ROBOMERGE-SOURCE: CL 15684867 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v781-15675533)

[CL 15684870 by jimmy smith in ue5-main branch]
2021-03-11 22:49:38 -04:00
phil popp
69487dd719 Metasound live parameter updates
#jira UEAU-709
#rb Rob.Gay
#preflight 604a607bd9f7490001e8df79

#ROBOMERGE-SOURCE: CL 15679701 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v781-15675533)

[CL 15683578 by phil popp in ue5-main branch]
2021-03-11 21:12:31 -04:00
rob gay
0b4ed7f7cf Add Copy/Paste to Metasounds Editor
- Clean up FGraphBuilder's interface to clarify when node handles vs edgraph uobjects are created
- Split up FGraphBuilder's node creation interface for convenience and clarity (for inputs, outputs, & external nodes)
#rb aaron.mcleran
#jira UEAU-732

#ROBOMERGE-SOURCE: CL 15651066 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v779-15635321)

[CL 15651068 by rob gay in ue5-main branch]
2021-03-09 00:27:55 -04:00
rob gay
328f64f40b - Fix bug/crashes with undo desync after updating input literals from graph input node
- Fix minor bug with MS doc sync incorrectly marking package dirty
- Add MS sync when undo'ing transaction involving MS as a safeguard to ensure graph/document parity is preserved (and sync code is maintained)
- Make Metasound version history visible but not editable by end-user

#ROBOMERGE-SOURCE: CL 15577261 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15577265 by rob gay in ue5-main branch]
2021-03-02 21:39:09 -04:00
rob gay
201bac7367 Disable default UMetasoundFactory for EA as asset type as it's not fleshed out yet
#rb trivial
#jira none

#ROBOMERGE-SOURCE: CL 15566743 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15566748 by rob gay in ue5-main branch]
2021-03-02 01:26:04 -04:00
rob gay
3d0f8bff2e Add back Enum editor support to Metasound inputs
#ROBOMERGE-SOURCE: CL 15526259 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15526262 by rob gay in ue5-main branch]
2021-02-25 01:37:09 -04:00
rob gay
a1f87ce451 Checkpoint: Metasound Node Inspector Panel & Array Support
#rb phil.popp
#jira UEAU-710

#ROBOMERGE-SOURCE: CL 15511803 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15511819 by rob gay in ue5-main branch]
2021-02-24 02:02:03 -04:00