* Fix initial refresh UI not being call for all changelist type (esp. the Uncontrolled Cl)
#rb JeanFrancois.Dube, Patrick.Enfedaque
#jira UE-211803
[CL 33578294 by vincent beauchemin in ue5-main branch]
This case can occur when a submit is done external to the editor ( e.g. from P4V ) and has also been reported to happen after submits from within the editor. Now, when it is detected we request a changelists refresh in the next tick by setting bShouldRefresh to true.
This changelist also fixes another issue where files in the list view would get cleared when the selected changelist changed and then never get re-added to the list view.
#jira UE-211943
#rb brooke.hubert, zach.rammell
[CL 33213432 by ross smith2 in ue5-main branch]
Results with a 40K actors changelist editor startup time:
- Before: FPerforce::AddShelvedFilesToChangelist took 2:35 min
- After: FPerforce::AddShelvedFilesToChangelist took 160.08 ms
#rb sebastien.lussier
[FYI] jeansebastien.guay
[CL 29047110 by jeanfrancois dube in ue5-main branch]
General
Add support for returning tokenized messages from validation.
Unify validation reporting for different validation entry points - in particular, source control window context menu.
Move EDataValidationUsecase to CoreUObject for use by UObject::IsDataValid.
UEditorValidatorSubsystem
Add support for validating changelists. Use of this interface allows building lists of unmodified assets to re-validate based on the changes that were made.
Allow subclassing, with functions GatherAssetsToValidateFromChangelist and ShouldValidateAsset to modify behavior of validation.
Add optional to load assets for validation to validation parameters.
Capture logs during asset loads to report as errors (optional in validation parameters).
Allow limit to number of assets to validate in validation parameters, report limit reached.
Add message log page to validation parameters.
Add validation parameter to validate referencers of deleted assets in changelists for validation
UEditorValidatorBase
Centralize dispatch to BP/Native validation in non-virtual ValidateLoadedAsset function.
Add native interface functions to UEditorValidatorBase that take FDataValidationContext.
Rename BP interface functions to have K2 prefix and different signature to native functions.
FDataValidationContext
Add validation usecase.
Add 'associated assets' to allow associating external actors with maps for validators.
UDataValidationChangelist
Support changelists based on changelist objects, file states, and simple lists of files.
Group modifications into packages/non-assets and modified/deleted ahead of time for validators to inspect.
#rb dominic.couture
[CL 28824042 by robert millar in ue5-main branch]
This new delegate give users the capability to intercept and handle the submit instead of the regular flows.
Depending on the reply from the delegate the current flow will be:
- interrupted if the submit is handled by the delegate
- interrupted and set to fail state if the delegate returns an error
- continued if the delegate cannot handle the current source provider
#rb Stuart.Hill, brooke.hubert, Patrick.Enfedaque
[CL 28533359 by benoit chauvin in ue5-main branch]
Unsaved asset drag-and-drop handler: When unsaved assets are selected and then dropped onto a changelist entry, they are checked out, saved, and then moved to the target changelist.
#jira UE-181906
#rb @zach.rammell
[CL 26976967 by han chu in ue5-main branch]
+ Expand source control menu context with selected changelist,
+ Expose information about if changelist is default and its source control specific identifier,
#rb Patrick.Enfedaque, Patrick.Laflamme, zach.rammell
#preflight skip
#p4v-cherrypick 25526575
#preflight 64665919b91ab13b09c2089c
[CL 25528171 by jordan hoffmann in ue5-main branch]
Previously only refreshed the changelist view
#jira UE-181901
#rb ronald.koppers
#preflight 644832fc864f15ebf5dbe7aa
[CL 25188908 by zach rammell in ue5-main branch]
#jira UE-179855 - Validation system is Failing to Append '#changelist validated' Tag in CL Description
#rb Brooke.Hubert
#preflight 640f28c4af3fc35292b3b252
[CL 24634288 by Patrick Laflamme in ue5-main branch]
- Side panel no longer compressed
- Name changed to "View Changes"
#jira UE-175840
#rb ronald.koppers
#preflight 63daeceb4965eb8c33d456e5
#lockdown jeanmichel.dignard
[CL 23961626 by zach rammell in ue5-main branch]
* Sync Latest no longer listing and reloading all packages when the source control provider provides a sync preview functionality. When a Sync Preview is available, Sync Latest unloads only the files that are going to be overwritten by the sync operation, and then reloads them and the world
* Refactored Revert All operation to improve performance
* Revert All no longer lists and reloads all packages when the source control provider provides a sync preview functionality. Instead it unloads only the files that may be overwritten by the revert operation (i.e. submittable files), and then reloads them and the world
* Replaced RevertAndReloadAllPackages with RevertAndReloadWorld, no longer listing and reloading all packages (see https://p4-swarm.epicgames.net/reviews/23244245/)
This review is a combination of the two archived reviews https://p4-swarm.epicgames.net/reviews/23736137 and https://p4-swarm.epicgames.net/reviews/23736282
#rb wouter.burgers, stuart.hill, brooke.hubert, francis.hurteau
#preflight 63c9c7786a00f3cc8ead6779
[CL 23796067 by marco anastasi in ue5-main branch]
This prevents uncontrolled icons being shown in the outliner when not supported by the current source control.
#rb brooke.hubert, Marco.Anastasi, wouter.burgers
#preflight 63c54df6b0652247509d67bb
[CL 23729713 by stuart hill in ue5-main branch]