106 Commits

Author SHA1 Message Date
vincent beauchemin
ef121040b3 Source Control Changelist View
* Fix initial refresh UI not being call for all changelist type (esp. the Uncontrolled Cl)
#rb JeanFrancois.Dube, Patrick.Enfedaque
#jira UE-211803

[CL 33578294 by vincent beauchemin in ue5-main branch]
2024-05-10 12:25:21 -04:00
patrick boutot
a2b5613488 Slate: Deprecate SListView::ItemHeight and STreeViewItemHeight. ItemHeight and ItemWidth are only used when the panel is is as a tile or both value are assigned. With TreeView and ListView, you can't assigned both. The function are protected, a subclass of those could but it's up to them to expose the ItemHeight and ItemWidth. This behavior changed was introduced with CL 7634094.
#jira UE-210415
#rb editor-ui-systems

[CL 33370360 by patrick boutot in ue5-main branch]
2024-05-01 08:05:39 -04:00
ross smith2
301512e99c In SSourceControlChangelistsWidget::OnRefreshSourceControlWidgets handle the detection of a duplicate item gracefully instead of with a check.
This case can occur when a submit is done external to the editor ( e.g. from P4V ) and has also been reported to happen after submits from within the editor.  Now, when it is detected we request a changelists refresh in the next tick by setting bShouldRefresh to true.

This changelist also fixes another issue where files in the list view would get cleared when the selected changelist changed and then never get re-added to the list view.

#jira UE-211943
#rb brooke.hubert, zach.rammell

[CL 33213432 by ross smith2 in ue5-main branch]
2024-04-24 17:16:59 -04:00
jeanfrancois dube
87618ccfe5 Optimize source control changelist shelved state update.
Results with a 40K actors changelist editor startup time:
  - Before: FPerforce::AddShelvedFilesToChangelist took 2:35 min
  - After: FPerforce::AddShelvedFilesToChangelist took 160.08 ms

#rb sebastien.lussier
[FYI] jeansebastien.guay

[CL 29047110 by jeanfrancois dube in ue5-main branch]
2023-10-24 11:33:28 -04:00
benoit chauvin
8677bfe633 Refresh the UI once the delegate has been called.
#rb Stuart.Hill

[CL 28958591 by benoit chauvin in ue5-main branch]
2023-10-20 05:57:31 -04:00
benoit chauvin
c766ed8ed5 - Moved the delegate before the content valdiation
- Added logic to remove the validation tag if the content validation fails

#rb Stuart.Hill

[CL 28917274 by benoit chauvin in ue5-main branch]
2023-10-19 09:58:45 -04:00
robert millar
2a5bfbaae6 Restore validation outputs (without message log) to GetChangelistValidationResult
[FYI] benoit.chauvin
#rb none

[CL 28844537 by robert millar in ue5-main branch]
2023-10-17 13:32:20 -04:00
robert millar
784a7bef90 DataValidation refactor
General
    Add support for returning tokenized messages from validation.
    Unify validation reporting for different validation entry points - in particular, source control window context menu.
    Move EDataValidationUsecase to CoreUObject for use by UObject::IsDataValid.

UEditorValidatorSubsystem
    Add support for validating changelists. Use of this interface allows building lists of unmodified assets to re-validate based on the changes that were made.
    Allow subclassing, with functions GatherAssetsToValidateFromChangelist and ShouldValidateAsset to modify behavior of validation.
    Add optional to load assets for validation to validation parameters.
    Capture logs during asset loads to report as errors (optional in validation parameters).
    Allow limit to number of assets to validate in validation parameters, report limit reached.
    Add message log page to validation parameters.
    Add validation parameter to validate referencers of deleted assets in changelists for validation

UEditorValidatorBase
    Centralize dispatch to BP/Native validation in non-virtual ValidateLoadedAsset function.
    Add native interface functions to UEditorValidatorBase that take FDataValidationContext.
    Rename BP interface functions to have K2 prefix and different signature to native functions.

FDataValidationContext
    Add validation usecase.
    Add 'associated assets' to allow associating external actors with maps for validators.

UDataValidationChangelist
    Support changelists based on changelist objects, file states, and simple lists of files.
    Group modifications into packages/non-assets and modified/deleted ahead of time for validators to inspect.

#rb dominic.couture

[CL 28824042 by robert millar in ue5-main branch]
2023-10-16 19:03:01 -04:00
benoit chauvin
c36eb46eaf Fixing LOCTEXT conflicts introduced with previous CL 28533347.
#jira UE-197443
#rb none

[CL 28580200 by benoit chauvin in ue5-main branch]
2023-10-09 09:36:51 -04:00
benoit chauvin
5f4e27ed26 New Delegate to override the submit functionality for the Source Control Changelist window and the Source Control Window.
This new delegate give users the capability to intercept and handle the submit instead of the regular flows.
Depending on the reply from the delegate the current flow will be:
- interrupted if the submit is handled by the delegate
- interrupted and set to fail state if the delegate returns an error
- continued if the delegate cannot handle the current source provider

#rb Stuart.Hill, brooke.hubert, Patrick.Enfedaque

[CL 28533359 by benoit chauvin in ue5-main branch]
2023-10-06 04:38:12 -04:00
han chu
2c25f2c11e New feature:
Unsaved asset drag-and-drop handler: When unsaved assets are selected and then dropped onto a changelist entry, they are checked out, saved, and then moved to the target changelist.

#jira UE-181906
#rb @zach.rammell

[CL 26976967 by han chu in ue5-main branch]
2023-08-09 18:41:28 -04:00
zach rammell
72380fa32e Add UE::ComparisonHelpers::CompareNaturalOrder, use it in scene outliner and changelist window
#jira UE-168849
#rb Steve.Robb ronald.koppers

[CL 26134967 by zach rammell in ue5-main branch]
2023-06-20 17:17:09 -04:00
jordan hoffmann
2b08e650c7 [CDPR] Added more information about changelist to source control changelists window context menu
+ Expand source control menu context with selected changelist,
+ Expose information about if changelist is default and its source control specific identifier,

#rb Patrick.Enfedaque, Patrick.Laflamme, zach.rammell
#preflight skip
#p4v-cherrypick 25526575
#preflight 64665919b91ab13b09c2089c

[CL 25528171 by jordan hoffmann in ue5-main branch]
2023-05-18 13:20:35 -04:00
zach rammell
ea9c2dae18 View Changes: Only reregister components once when saving
#jira UE-181899
#rb ronald.koppers
#preflight 645c03848e01daf0e5bcc383

[CL 25416984 by zach rammell in ue5-main branch]
2023-05-10 17:14:13 -04:00
zach rammell
0154b40c13 View Changes: Saving to changelists can now be canceled
#jira UE-181898
#rb ronald.koppers
#preflight 64485db8b208f61af8c02a52

[CL 25191943 by zach rammell in ue5-main branch]
2023-04-25 19:16:30 -04:00
zach rammell
5dd8f64ecb View Changes: Refresh active view when sorting columns
Previously only refreshed the changelist view

#jira UE-181901
#rb ronald.koppers
#preflight 644832fc864f15ebf5dbe7aa

[CL 25188908 by zach rammell in ue5-main branch]
2023-04-25 16:24:25 -04:00
jamie dale
933348f856 Use the FMessageDialog overloads that pass the optional title by-value
#jira
#rb none
#rnx

[CL 25062589 by jamie dale in ue5-main branch]
2023-04-15 19:49:32 -04:00
Patrick Laflamme
3ba42cf0e5 Fixed missing '#changelist validated' tag when submitting without editing the changelist text.
#jira UE-179855 - Validation system is Failing to Append '#changelist validated' Tag in CL Description
#rb Brooke.Hubert
#preflight 640f28c4af3fc35292b3b252

[CL 24634288 by Patrick Laflamme in ue5-main branch]
2023-03-14 09:27:26 -04:00
Joe Kirchoff
c1f997087d Fix remaining UnrealGame Win64 V3 pathing issues
#rnx
#rb trivial
#preflight 63ec10e47e76998e9afe7aa7

[CL 24222870 by Joe Kirchoff in ue5-main branch]
2023-02-14 18:12:00 -05:00
zach rammell
bdc16077f3 View Changes UI visual improvements
- Side panel no longer compressed
- Name changed to "View Changes"

#jira UE-175840
#rb ronald.koppers
#preflight 63daeceb4965eb8c33d456e5
#lockdown jeanmichel.dignard

[CL 23961626 by zach rammell in ue5-main branch]
2023-02-01 19:44:37 -05:00
zach rammell
02dbe448a4 Fix crash in View Changes UI
#jira none
#rb jamie.dale
#preflight 63d8760f3656ea96dc3b12c2
#lockdown jeanmichel.dignard

[CL 23924091 by zach rammell in ue5-main branch]
2023-01-31 01:29:09 -05:00
zach rammell
1edfb3ed31 Unsaved Assets in Changelist Window
#jira UE-169781
#preflight 63d4247a5354589b5c022e4c
#rb brooke.hubert
#lockdown jeanmichel.dignard

[CL 23923988 by zach rammell in ue5-main branch]
2023-01-31 01:26:50 -05:00
marco anastasi
b29f599449 * Refactored Sync Latest operation to improve performance
* Sync Latest no longer listing and reloading all packages when the source control provider provides a sync preview functionality. When a Sync Preview is available, Sync Latest unloads only the files that are going to be overwritten by the sync operation, and then reloads them and the world

* Refactored Revert All operation to improve performance
* Revert All no longer lists and reloads all packages when the source control provider provides a sync preview functionality. Instead it unloads only the files that may be overwritten by the revert operation (i.e. submittable files), and then reloads them and the world
* Replaced RevertAndReloadAllPackages with RevertAndReloadWorld, no longer listing and reloading all packages (see https://p4-swarm.epicgames.net/reviews/23244245/)

This review is a combination of the two archived reviews https://p4-swarm.epicgames.net/reviews/23736137 and https://p4-swarm.epicgames.net/reviews/23736282

#rb wouter.burgers, stuart.hill, brooke.hubert, francis.hurteau
#preflight 63c9c7786a00f3cc8ead6779

[CL 23796067 by marco anastasi in ue5-main branch]
2023-01-20 15:31:16 -05:00
stuart hill
ecd02d133c For Source Control systems which don't support Uncontrolled Changelists, disable the entire Uncontrolled Changelists module, rather than just UI elements (as was done in CL 23490912).
This prevents uncontrolled icons being shown in the outliner when not supported by the current source control.

#rb brooke.hubert, Marco.Anastasi, wouter.burgers
#preflight 63c54df6b0652247509d67bb

[CL 23729713 by stuart hill in ue5-main branch]
2023-01-16 10:48:10 -05:00
stuart hill
894c619283 In the View Changelist window, hide the "Assets to check for reconcile" text if 'uncontrolled' changelists are not supported.
#rb brooke.hubert
#preflight 639c85052540a78d2741c962

[CL 23539911 by stuart hill in ue5-main branch]
2022-12-16 13:43:53 -05:00