280 Commits

Author SHA1 Message Date
wouter burgers
93261ee972 SourceControl: Fixed non package files starting with a dot (such as '.urcignore' or '.gitignore') showing up incorrectly in the 'Submit Files' dialog (they showed up with an empty string for AssetName).
#rnx
#rb Matt.Peters

[CL 35794924 by wouter burgers in ue5-main branch]
2024-08-26 04:13:38 -04:00
george rolfe
3ad27abefb [Backout] - CL34976623
[FYI] George.Rolfe
Original CL Desc
-----------------------------------------------------------------
[ToolWidgets] Dependencies reference correct base widget

#rnx

[CL 35075563 by george rolfe in ue5-main branch]
2024-07-25 00:59:31 -04:00
george rolfe
0ce09516bd [ToolWidgets] Dependencies reference correct base widget
[CL 34976625 by george rolfe in ue5-main branch]
2024-07-22 03:08:14 -04:00
ben hoffman
1fc0b264e1 Editor | Confirm changelist submit window fixes
- Fix UDataValidationChangelist warnings not propagating to the window properly and only being emitted into the Message Log
- Fix asset validation warnings not appearing in the Confirm changelist submit window if the validator says the asset is valid
- Fix tokenized messages appearing blank

#rb Sebastien.Lussier
#jira none

#ushell-cherrypick of 34860898 by gabriel.wreczycki

[CL 34879202 by ben hoffman in ue5-main branch]
2024-07-17 14:43:30 -04:00
wouter burgers
cf83f5484a SkeinUE: Improved asset class display name in Snapshot History and Checked Out dialogs.
#rb Stuart.Hill

[CL 34733526 by wouter burgers in ue5-main branch]
2024-06-28 04:07:02 -04:00
brooke hubert
f629a92be5 [Revision Control] Auto select CL description text when moving files between CLs
#Jira UE-217318
#rb zach.rammell

[CL 34361115 by brooke hubert in ue5-main branch]
2024-06-13 20:26:35 -04:00
dave belanger
df4bca31d8 [UEFN] Support multiple projects on the same perforce workspace
Put guardrails against using URC with multiple projects because it's not supported
#rb wouter.burgers

[CL 34127677 by dave belanger in ue5-main branch]
2024-06-05 12:05:35 -04:00
wouter burgers
ea3cc739ed SkeinUE: Generalized 'checked out by' dialog by moving it to /SourceControlWindows. Folluw up CL from #33935263.
#rb andrea.botti

[CL 34039996 by wouter burgers in ue5-main branch]
2024-05-31 15:24:34 -04:00
vincent beauchemin
ef121040b3 Source Control Changelist View
* Fix initial refresh UI not being call for all changelist type (esp. the Uncontrolled Cl)
#rb JeanFrancois.Dube, Patrick.Enfedaque
#jira UE-211803

[CL 33578294 by vincent beauchemin in ue5-main branch]
2024-05-10 12:25:21 -04:00
patrick boutot
a2b5613488 Slate: Deprecate SListView::ItemHeight and STreeViewItemHeight. ItemHeight and ItemWidth are only used when the panel is is as a tile or both value are assigned. With TreeView and ListView, you can't assigned both. The function are protected, a subclass of those could but it's up to them to expose the ItemHeight and ItemWidth. This behavior changed was introduced with CL 7634094.
#jira UE-210415
#rb editor-ui-systems

[CL 33370360 by patrick boutot in ue5-main branch]
2024-05-01 08:05:39 -04:00
ross smith2
301512e99c In SSourceControlChangelistsWidget::OnRefreshSourceControlWidgets handle the detection of a duplicate item gracefully instead of with a check.
This case can occur when a submit is done external to the editor ( e.g. from P4V ) and has also been reported to happen after submits from within the editor.  Now, when it is detected we request a changelists refresh in the next tick by setting bShouldRefresh to true.

This changelist also fixes another issue where files in the list view would get cleared when the selected changelist changed and then never get re-added to the list view.

#jira UE-211943
#rb brooke.hubert, zach.rammell

[CL 33213432 by ross smith2 in ue5-main branch]
2024-04-24 17:16:59 -04:00
SRombauts
a0044d6f99 PR #10360: [SourceControl] Fix DiffAgainstShelvedFile() to catch the date of the revision
#rb jordan.hoffmann
#Jira UE-183655

[CL 32233954 by SRombauts in ue5-main branch]
2024-03-13 19:32:54 -04:00
jaime cifuentes
48216ffacb Fixed crash when reverting Skeletal Mesh unsaved changes using an async task at SSourceControlChangelistRows, while the asset is opened, due to the async task being executed by the preview world of the SkeletalMesh being reverted. Changed the Async task for a CoreTicker call to Execute on game thread.
#rb brooke.hubert
#jira UE-207365

[CL 31760326 by jaime cifuentes in ue5-main branch]
2024-02-23 07:58:22 -05:00
matt peters
79da0bdad8 Updated display string for changelist descriptions to use space character in place of other whitespace characters (similar to P4V).
- allows viewing descriptions which traverse multiple lines
- only affects the single line view (tooltip, etc still display as before)
#rnx
#rb zach.rammell

[CL 30279052 by matt peters in ue5-main branch]
2023-12-12 17:18:07 -05:00
jeanfrancois dube
e9ad689957 Source Control: don't show the success icon when unable to submit the changelist and there's no warnings or errors.
#rb Richard.Malo
[FYI] jeansebastien.guay

[CL 30187851 by jeanfrancois dube in ue5-main branch]
2023-12-07 14:14:32 -05:00
wouter burgers
49478f82ac Skein / ConflictUE: Fixed 'check in changes' no longer saving dirty packages since #29866499.
#rb Marco.Anastasi
#rnx

[CL 30078117 by wouter burgers in ue5-main branch]
2023-12-04 08:12:13 -05:00
marco anastasi
4fc92d88f3 * Create 'Check in before syncing older snapshot' dialog
* Create Warning dialog for further rewind
* Implement 'Sync snapshot' functionality
* Implement 'Rewind to' functionality

#rb wouter.burgers

[CL 30015297 by marco anastasi in ue5-main branch]
2023-11-30 10:36:24 -05:00
wouter burgers
92e74b4c79 Skein / Snapshot History: Add 'View Snapshot History' menu item to Revision Control menu in Status Bar.
#rb Marco.Anastasi
#rnx

[CL 30012929 by wouter burgers in ue5-main branch]
2023-11-30 07:58:07 -05:00
wouter burgers
98afc5c310 Skein / ConflictUE: Streamlined behavior when user clicks CHECK-IN CHANGES.
Previously, the SYNC was done prior to showing the SUBMIT FILES dialog. If another user submitted anything while the user was typing their changelist description, the CHECK IN would fail (for Skein) because the user is no longer checking in as latest. By moving the SYNC to after the changelist description is completed, this is avoided. In addition, this allows the user once again to click the CHECK IN CHANGES without syncing to head if he just wants to see what local changes he has that need checking in - a workflow which I imagine is not uncommon.

Additionally, the check-in should be aborted if the SYNC results in the user entering conflict resolution.

#rb manuel.lang, marco.anastasi
#rnx

[CL 29484477 by wouter burgers in ue5-main branch]
2023-11-06 04:43:55 -05:00
jeanfrancois dube
87618ccfe5 Optimize source control changelist shelved state update.
Results with a 40K actors changelist editor startup time:
  - Before: FPerforce::AddShelvedFilesToChangelist took 2:35 min
  - After: FPerforce::AddShelvedFilesToChangelist took 160.08 ms

#rb sebastien.lussier
[FYI] jeansebastien.guay

[CL 29047110 by jeanfrancois dube in ue5-main branch]
2023-10-24 11:33:28 -04:00
benoit chauvin
8677bfe633 Refresh the UI once the delegate has been called.
#rb Stuart.Hill

[CL 28958591 by benoit chauvin in ue5-main branch]
2023-10-20 05:57:31 -04:00
benoit chauvin
c766ed8ed5 - Moved the delegate before the content valdiation
- Added logic to remove the validation tag if the content validation fails

#rb Stuart.Hill

[CL 28917274 by benoit chauvin in ue5-main branch]
2023-10-19 09:58:45 -04:00
robert millar
2a5bfbaae6 Restore validation outputs (without message log) to GetChangelistValidationResult
[FYI] benoit.chauvin
#rb none

[CL 28844537 by robert millar in ue5-main branch]
2023-10-17 13:32:20 -04:00
robert millar
784a7bef90 DataValidation refactor
General
    Add support for returning tokenized messages from validation.
    Unify validation reporting for different validation entry points - in particular, source control window context menu.
    Move EDataValidationUsecase to CoreUObject for use by UObject::IsDataValid.

UEditorValidatorSubsystem
    Add support for validating changelists. Use of this interface allows building lists of unmodified assets to re-validate based on the changes that were made.
    Allow subclassing, with functions GatherAssetsToValidateFromChangelist and ShouldValidateAsset to modify behavior of validation.
    Add optional to load assets for validation to validation parameters.
    Capture logs during asset loads to report as errors (optional in validation parameters).
    Allow limit to number of assets to validate in validation parameters, report limit reached.
    Add message log page to validation parameters.
    Add validation parameter to validate referencers of deleted assets in changelists for validation

UEditorValidatorBase
    Centralize dispatch to BP/Native validation in non-virtual ValidateLoadedAsset function.
    Add native interface functions to UEditorValidatorBase that take FDataValidationContext.
    Rename BP interface functions to have K2 prefix and different signature to native functions.

FDataValidationContext
    Add validation usecase.
    Add 'associated assets' to allow associating external actors with maps for validators.

UDataValidationChangelist
    Support changelists based on changelist objects, file states, and simple lists of files.
    Group modifications into packages/non-assets and modified/deleted ahead of time for validators to inspect.

#rb dominic.couture

[CL 28824042 by robert millar in ue5-main branch]
2023-10-16 19:03:01 -04:00
benoit chauvin
c36eb46eaf Fixing LOCTEXT conflicts introduced with previous CL 28533347.
#jira UE-197443
#rb none

[CL 28580200 by benoit chauvin in ue5-main branch]
2023-10-09 09:36:51 -04:00