However: function searches will do a quoted search by native function name. The previous behavior was unquoted search by node title (usually function display name). As a result, the previous behavior for Find References would fail in functions with special characters in their name. Now that the name is surrounded in quotes, all function names are supported. The new Find References behavior now searches for correct function name for parent call nodes, interface implementations, event overrides, where the previous behavior failed due to searching for node title.
#rb Phillip.Kavan
[CL 30854644 by zhikang shao in ue5-main branch]
Improves "Find References" in blueprints: now supports function search by [class, function] call-sites and definitions rather than a generic search for function name. Replaces the "Find References" context menu action with a sub-menu for variables and functions in BlueprintEditor, WidgetBlueprintEditor, SubobjectEditor and SubobjectEditor. That context sub-menu has 'By Name' and 'By Class Member' search options and local+global versions of both.
Made changes to Find-in-Blueprints metadata that is generated per blueprint asset to be able to do "specific function of a specific class" type queries; some search types were unsupported with previous metadata. Incremented the EFiBVersion so that the Find-in-Blueprints search window will ask to re-index all blueprints and resave. Added an opt-out editor setting "Allow Index All Blueprints" (default: true) to disable the button, which can be decided per project. Added an action in the Find-in-Blueprints modal when outdated metadata is detected to export the list of affected assets.
#rb Phillip.Kavan
[CL 30316851 by zhikang shao in ue5-main branch]
[FYI] zhikang.shao
Original CL Desc
-----------------------------------------------------------------
#jira UE-196209
Improves "Find References" in blueprints: now supports function search by [class, function] call-sites and definitions rather than a generic search for function name. Replaces the "Find References" context menu action with a sub-menu for variables and functions in BlueprintEditor, WidgetBlueprintEditor, SubobjectEditor and SubobjectEditor. That context sub-menu has 'By Name' and 'By Class Member' search options and local+global versions of both.
Made changes to Find-in-Blueprints metadata that is generated per blueprint asset to be able to do "specific function of a specific class" type queries; some search types were unsupported with previous metadata. Incremented the EFiBVersion so that the Find-in-Blueprints search window will ask to re-index all blueprints and resave. Added an opt-out editor setting "Allow Index All Blueprints" (default: true) to disable the button, which can be decided per project. Added an action in the Find-in-Blueprints modal when outdated metadata is detected to export the list of affected assets.
#rb Phillip.Kavan
[CL 30289794 by zhikang shao in ue5-main branch]
Improves "Find References" in blueprints: now supports function search by [class, function] call-sites and definitions rather than a generic search for function name. Replaces the "Find References" context menu action with a sub-menu for variables and functions in BlueprintEditor, WidgetBlueprintEditor, SubobjectEditor and SubobjectEditor. That context sub-menu has 'By Name' and 'By Class Member' search options and local+global versions of both.
Made changes to Find-in-Blueprints metadata that is generated per blueprint asset to be able to do "specific function of a specific class" type queries; some search types were unsupported with previous metadata. Incremented the EFiBVersion so that the Find-in-Blueprints search window will ask to re-index all blueprints and resave. Added an opt-out editor setting "Allow Index All Blueprints" (default: true) to disable the button, which can be decided per project. Added an action in the Find-in-Blueprints modal when outdated metadata is detected to export the list of affected assets.
#rb Phillip.Kavan
[CL 30289718 by zhikang shao in ue5-main branch]
Fixed various Title Case errors in graph editor command names.
#review-18238003 @lauren.barnes
#preflight 619b8f30f934c1a291ceaa0b
[CL 18258594 by sebastian nordgren in ue5-main branch]
Added a new animation graph node that hosts its own UBlendSpaceBase. Modified UBlendSpaceBase to allow for pose links to be evaluated as the sample points.
The new blend space graphs can be spawned from existing UBlendSpace and UBlendSpace1D assets, or they can be created from scratch, or they can be converted from existing blendspace player nodes via the context menu.
Fixed anim node conversion functions so that their transactions work correctly.
Updated FBlueprintEditorUtils::IsGraphNameUnique to allow it to work with any object as the outer, not just UBlueprint. UBlueprint still has a special case for functions and events. This is to support GenerateUniqueGraphName within a scope (e.g. an outer graph).
Formalized the concept of 'node sub-graphs' (as well as the composite node pattern a little). Previously a number of known node types that contained sub-graphs (e.g. UK2Node_Composite) had special case logic for dealing with node/graph deletion etc. Now any node can opt into this behaviour via the GetSubGraphs() override.
Added status bar readouts for the blendspace grid, so we dont have to stuff the prompts into the tooltip any more.
Moved anim BP related APIs out of FBlueprintEditor. They are always used via FAnimationBlueprintEditor.
Refactored graph title bar widget creation out into a function to allow other document tab factories to create it.
Altered breadcrumb trail click callbacks and SMyBlueprint::ExecuteAction to always JumpToHyperLink rather than calling OpenDocument directly. This allows unknown (to FBlueprintEditor) document types that reference objects to be correctly jumped to using the breadcrumb trail. Derived asset editors (i.e. FAnimationBlueprintEditor) can intercept the JumpToHyperlink call to ensure that the correct document is presented (i.e. the correct tab payload is generated).
Instead of making yet another bunch of duplicated code for handling the various alpha blend options, refactored this into FAnimGraphNodeAlphaOptions (for editor code) and FAnimNodeAlphaOptions (for runtime code).
Added OnCopyTermDefaultsToDefaultObject for per-node copying of default values from editor node to runtime node, rather than another special-case in the compiler.
#rb Jurre.deBaare,Phillip.Kavan
[CL 15177316 by Thomas Sarkanen in ue5-main branch]
#rnx
#rb none
#ROBOMERGE-SOURCE: CL 10869241 via CL 10869527 via CL 10869904
#ROBOMERGE-BOT: (v613-10869866)
[CL 10870586 by ryan durand in Main branch]
Add an editor action for "shift+del"
Only works for nodes with simple output/exec nodes
#jira UE-12271
#rb Fred Kimberley
[CL 7708603 by Ben Hoffman in Dev-Framework branch]
Change summary:
- Moved the FBlueprintEditor::OpenGraphAndBringToFront() API up into the IBlueprintEditor interface.
- Modified FGraphEditorCommandsImpl to define new "Quick Jump" commands for graph editor contexts. Keyboard shortcuts are currently set up as follows (where 'slot_index' is '0' through '9' on the keyboard):
- Quick Jump to Bookmark: SHIFT + <slot_index>
- Set Quick Jump Bookmark: CTRL + <slot_index>
- Modified FBlueprintEditor::CreateDefaultCommands() to map Quick Jump commands to actions within the top-level Blueprint editor toolkit context.
- Added implementations to FBlueprintEditor for handling Quick Jump commands within the relevant editor contexts.
- Added UBlueprintEditorSettings::GraphEditorQuickJumps to save Quick Jump bookmark info to local user settings (.ini).
Known issues:
- Keyboard input focus will be lost whenever the user clicks on a tab well at the top of the Blueprint editor window. As a result, quick jump keyboard shortcuts won't work again until the user clicks somewhere inside the tab to reclaim the input focus. This is a general UI problem that's not tied to this feature specifically.
- Similarly, top-level editor command keyboard shortcuts (including Quick Jump) won't work immediately after opening a Blueprint asset in a new editor window. The keyboard input focus is not set until the user clicks somewhere inside the tab area. All editors have this issue (not just Blueprint editor windows).
#rb None
#jira None
[CL 4286592 by Phillip Kavan in Dev-Framework branch]
#lockdown Nick.Penwarden
#rb none
#rnx
============================
MAJOR FEATURES & CHANGES
============================
Change 3431439 by Marc.Audy
Editor only subobjects shouldn't exist in PIE world
#jira UE-43186
Change 3457323 by Marc.Audy
Undo CL# 3431439 and once again allow (incorrectly) for editor only objects to exist in a PIE world
#jira UE-45087
Change 3499927 by Dan.Oconnor
UField::Serialize no longer serialize's its next ptr, UStruct::Serialize serializes all Children properties instead. This resolves a hard circular dependency between function libraries that EDL detected. It was resolved in an ad hoc way by the old linker
#jira UE-43458
Change 3502939 by Michael.Noland
Back out changelist 3499927
Change 3522783 by Zak.Middleton
#ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before).
Change 3544641 by Dan.Oconnor
Remove conditional that is no longer needed, replace with ensure. It is unsafe to change CDO names
#jira OR-38176
Change 3544645 by Dan.Oconnor
In addition to marking nodes as not transient, FBlueprintEditor::ExpandNode needs to mark them as transactional
#jira UE-45248
Change 3545023 by Marc.Audy
Properly encapsulate FPinDeletionQueue
Fix ensure during deletion of split pins when not clearing links
Fix split pins able to end up in delete queue twice during undo/redo
Change 3545025 by Marc.Audy
Properly allow changing the pin type from a struct that is split on the node
#jira UE-47328
Change 3545455 by Ben.Zeigler
Fix issue where combined streamable handles could be freed before their complete callback is called if nothing external referenced them
Copy of CL#3544474
Change 3545456 by Ben.Zeigler
Allow PrimaryAssets to update their AssetData based on in-memory changes when launching 'Standalone Game' and 'Mobile Preview' from the editor. As it was, changes could be detected and propagated through UPrimaryDataAsset::PostLoad, but the changes would always reapply whatever already exists in the AssetRegistry. The primary use-case for this: making AssetBundle tag changes and allowing them to propagate without resaving/recooking all affected assets.
Copy of CL #3544374
Change 3545547 by Ben.Zeigler
CIS Fix
Change 3545568 by Michael.Noland
PR #3758: Fixing a comment typo from Transistion to Transition (Contributed by gsfreema)
#jira UE-46845
Change 3545582 by Michael.Noland
Blueprints: Prevent duplicate messages from being added to the compiler results log (fixes a crash when resizing the results log while a math expression node has an error)
Blueprints: Fixed the tooltip of math expression nodes not showing up, and error messages getting cleared on subsequent compiles
[Duplicating fixes for UE-47491 and UE-47512 from 4.17 to Dev-Framework]
Change 3546528 by Ben.Zeigler
#jira UE-47548
Fix crash when a map's key type has changed but value has not, it was passing the UStruct defaults in when serialize was expecting the default instance, so pass null instead as we don't have the instance
Change 3546544 by Marc.Audy
Fix split pin restoration logic to deal with wildcards and variations in const/refness
Change 3546551 by Marc.Audy
Don't crash if the struct type is missing for whatever reason
Change 3547152 by Marc.Audy
Fix array exporting so you don't end up getting none instead of defaults
#jira UE-47320
Change 3547438 by Marc.Audy
Fix split pins on class defaults
Don't cause a structural change when reapplying a split pin as part of node reconstruction
#jira UE-46935
Change 3547501 by Ben.Zeigler
Fix ensure, it's valid to pass a null path for a dynamic asset
Change 3551185 by Ben.Zeigler
#jira UE-42835 Fix it so SoftObjectPaths work correctly when inside levels loaded for the first time from PIE. Added code to do in-place PIE fixup for levels that are loaded instead of duplicated, and changed the fixup logic to fix all level references, not just ones being explicitly duplicated
Change 3551723 by Ben.Zeigler
Improve UI for displaying actor soft references. Add an error/warning icon if the cross level reference is broken or unloaded, and fix various display and copy/paste behaviors
Change 3553216 by Phillip.Kavan
#jira UE-39303, UE-46268, UE-47519
- Nativized UDS now support external asset dependencies and will construct their own linker import tables on load.
Change summary:
- Modified FCompactBlueprintDependencyData and FFakeImportTableHelper to be more relevant to UStruct and not just UClass-derivative types.
- Modified FBlueprintDependencyData to accept a single FCompactBlueprintDependencyData struct rather than its individual fields.
- Modified FBlueprintCompilerCppBackendBase::GenerateCodeFromStruct() to emit dependency assignment and static type registration functions for nativized UStruct types.
- Modified FBlueprintNativeCodeGenModule::FStatePerPlatform to include an array for tracking UDS assets that need to be converted during the nativization pass at cook time.
- Modified FBlueprintNativeCodeGenModule::GenerateFullyConvertedClasses() to generate nativized code for UDS assets. This ensures that UDS conversion falls under the same scope as BPGC conversion, so that they both feed into the same NativizationSummary context for asset dependency tracking (i.e. since we only have a single global dependency table in the codegen). Also modified InitializeForRerunDebugOnly() to do the same.
- Modified FBlueprintNativeCodeGenModule::Convert() to defer UDS conversion so that it's done at the same time as BPGC conversion (see note above).
- Modified FEmitDefaultValueHelper::AddStaticFunctionsForDependencies() to include support for UStruct types and to conform to changes made to FCompactBlueprintDependencyData.
- Modified FEmitDefaultValueHelper::AddRegisterHelper() to include support for UStruct types.
- Modified FBlueprintNativeCodeGenModule::FindReplacedClassForObject() to ensure that converted User-Defined Enum types are switched to a UEnumProperty at package save time so that any import tables contain the proper class. This is necessary because we nativize User-Defined Enum types as 'enum class' types, and UHT will generate code for those as a UEnumProperty with an "underlying" property. However, non-nativized User-Defined Enum types are referenced as a UByteProperty with a UEnum reference, so we have to fix up all the import tables before saving. Otherwise, EDL will assert on load (see UE-47519).
Change 3553301 by Ben.Zeigler
Fix ensure when passing literal None to SoftObjectPath, it now treats them as empty instead
Change 3553631 by Dan.Oconnor
UField::Serialize no longer serialize's its next ptr, UStruct::Serialize serializes all Children properties instead. This resolves a hard circular dependency between function libraries that EDL detected. It was resolved in an ad hoc way by the old linker. This change was originally submitted in 3499927, but it was incorrectly clearing the UField::Next pointer in UField::Serialize.
#jira UE-43458
Change 3553799 by Ben.Zeigler
Fix issue where calling WaitUntilComplete on a combined handle with Stalled children wouldn't work properly. It now forces all stalled children to start immediately. I also added a warning log when this happens and an ensure if somehow the force didn't work
Copy of CL #3553781
Change 3553896 by Michael.Noland
Blueprints: Allow the autowiring logic to better break and replace existing connections when made (e.g., when dragging a variable onto a compatible pin with an existing connection, break the old connection to allow the new connection to be made)
#jira UE-31031
Change 3553897 by Michael.Noland
Blueprints: Adjust search query when doing 'Find References' on variables from My Blueprints so that bound event nodes show up for components and widgets
#jira UE-37862
Change 3553898 by Michael.Noland
Blueprints: Add the name of the variable directly in the get/set menu options (when dragging from My Blueprints into the graph)
Change 3553909 by Michael.Noland
Blueprints: Added the full name of the type, container type (and value type for maps) to the tooltips for the type picker elements, so long names can be read in full
#jira UE-19710
Change 3554517 by Michael.Noland
Blueprints: Added an option to disable the comment bubble on comment boxes that appears when zoomed out
#jira UE-21810
Change 3554664 by Michael.Noland
Editor: Renamed "Find in CB" command to "Browse" and renamed "Search" (in BP) to "Find", so terminology is consistent and keyboard shortcuts make sense (Ctrl+B for Browse, Ctrl+F for find, not using the term Search anywhere)
#jira UE-27121
Change 3554831 by Dan.Oconnor
Non editor build fix
Change 3554834 by Dan.Oconnor
Actor bound event related warnings now show up in blueprint status when opening level blueprint for first time, improved warning message. Removed unused delegate and return value from FixLevelScriptActorBindings. Can now pass raw strings to blueprint results log (no need for Printf, although padding is not great), UClasses in compiler results log will open the generated blueprint when clicked on
#jira UE-40438
Change 3556157 by Ben.Zeigler
Convert LevelSequenceBindingReference to use FSoftObjectPath so it works properly with redirectors and fixups
Change 3557775 by Michael.Noland
Blueprints: Fixed swapped transaction messages when converting a cast node between pure and impure
#jira UE-36090
Change 3557777 by Michael.Noland
Blueprints: Allow 'Goto Definition' and 'Find References' to be used while stopped at a breakpoint
PR #3774: Expose GotoFunctionDefinition during BP debugging (Contributed by projectgheist)
#jira UE-47024
Change 3560510 by Michael.Noland
Blueprints: Add support for 'goto definition' on Create Event nodes when the Object pin is not hooked up
#jira UE-38912
Change 3560563 by Michael.Noland
Blueprints: Disallow converting a variable get node to impure/back when debugging (no graph mutating operations should be allowed)
Change 3561443 by Ben.Zeigler
Restore code to support gc.DumpPoolStats, was accidentally removed when FGCArrayPool was moved to a header.
Clean up comments around Cleanup function, the functionality to trim the memory pools was integrated into ClearWeakReferences on a prior change
Change 3561658 by Michael.Noland
Blueprints: Refactored 'Goto Definition' so there is no per-class logic in the Blueprint editor or schema any more; any node can opt in individually
- Added a key binding for Goto Definition (Alt+G)
- Added a key binding for Find References (Shift+Alt+F)
- Collapsed 'Goto Code Definition' for variables and functions into the same path, so there aren't separate menu items and commands
- Added new methods CanJumpToDefinition and JumpToDefinition to UEdGraphNode, the default behavior for UK2Node subclasses is to call GetJumpTargetForDoubleClick and call into FKismetEditorUtilities::BringKismetToFocusAttentionOnObject
- Going to a native function now goes thru a better code path that will actually put the source code editor on the function definition, rather than just opening the file containing the definition
Change 3562291 by Ben.Zeigler
Fix issue where calling FSoftObjectPtr::Get during a package save would result in that ptr being forever marked broken, because the ResolveObject fails during save. It's too risky to change that behavior, so change it so the TagAtLastTest doesn't get updated in that case
Change 3562292 by Ben.Zeigler
#jira UE-39042 When renaming or moving actors between levels it now attempts to fix any soft object references from blueprints or sequencer
When deleting actors that are soft referenced by actor/sequencer it will now warn the same way it does for level script. Added IAssetTools::FindSoftReferencesToObject to perform this search
Change it so saving a non-primary world does not result it being dirtied due to the temporary physics scene fixup
Fix issue where the actor name was shown incorrectly in the SSCS tree for actor instances, which meant that if you renamed it you would end up renaming it to the BP's name
Change 3564814 by Ben.Zeigler
#jira UE-47843 Don't set InputKey output pins to AnyKey if empty, this was causing blueprints with key events to constantly dirty themselves
Change 3566707 by Dan.Oconnor
Remove unused code, UClassGenerateCDODuplicatesForHotReload was attempting to create a CDO with a special name, which triggered an ensure. The Duplicated CDO was never used (callign code removed in 3289276 as it was a waste of cycles)
#jira None
Change 3566717 by Michael.Noland
Core: Remove all defintions that contain "_API" from the command line when compiling .rc files (they do not support repsonse files and a too-long command line will fail the compile)
Change 3566771 by Michael.Noland
Editor: Fixing deprecation warning
#jira UE-47922
Change 3567023 by Michael.Noland
Blueprints: Change various TArray<> uses to TSet<> throughout name validation and related code to enable it to scale better to high component or variable counts
Adapted from PR #3708: Fast construction of bp (Contributed by gildor2)
#jira UE-46473
Change 3567304 by Ben.Zeigler
Add bCheckRecursive option to IsEditorOnlyObject that is enabled by default and will check outer/archetype/class.
This is needed for places that call this function from outside of SavePackage.cpp when the editor only mark is set, such as the automation test code
Change 3567398 by Ben.Zeigler
Fix crash when spawning a widget that has no editor WidgetTree, but does have a cooked widget tree template due to tree inheritance
Change 3567729 by Michael.Noland
Blueprints: Clarified message about "{VariableName} is not blueprint visible" to define what that means "(BlueprintReadOnly or BlueprintReadWrite)"
Change 3567739 by Ben.Zeigler
Don't crash if PropertyStruct cannot find it's struct. The function half handled this before, but Preload crashes with a null parameter
Change 3567741 by Ben.Zeigler
Disable optimization for a path test that was crashing in VC2015 in a monolithic build
Change 3568332 by Mieszko.Zielinski
Prevented UAIPerceptionSystem::GetCurrent causing a BP error when WorldContextObject is null #UE4
#jira UE-47948
Change 3568676 by Michael.Noland
Blueprints: Allow editing the tooltip of each enum value in a user defined enum
#jira UE-20036
Known issue: Undo/redo is not currently possible on the tooltip as it is directly stored in package metadata
Change 3569128 by Michael.Noland
Blueprints: Removing the experimental profiler as we won't be returning to it any time soon
#jira UE-46852
Change 3569207 by Michael.Noland
Blueprints: Allow drag-dropping component Blueprint assets into the graph to create Add Component nodes and improved the error message when dragging something that cannot be dropped into an actor Blueprint
#jira UE-8708
Change 3569208 by Michael.Noland
Blueprints: Allow specifying a description for user defined enums (shown in the content browser)
#jira UE-20036
Change 3569209 by Michael.Noland
Editor: Allow adjusting the font size for each individual comment box node in Blueprints and Materials
#jira UE-16085
Change 3570177 by Michael.Noland
Blueprints: Fixed discrepancy between the Structure tab name and the menu option for the tab in the user defined structure editor (now both say Structure Editor)
#jira UE-47962
Change 3570179 by Michael.Noland
Blueprints: Fixed the tooltip of a user defined structure not updating immediately in the content browser after being edited
Change 3570192 by Michael.Noland
Blueprints: Added "(selected)" after the label (in the 'debug filter' dropdown in the Blueprint editor) for actors that are selected in the level editor, which should make it easier to choose the specific actor you want to debug
#jira UE-20709
Change 3571203 by Michael.Noland
Blueprints: Cleanup and refactoring to prepare for turning commented out nodes into an official feature
- Made EnabledState and bUserSetEnabledState private on UEdGraphNode and added new getters/setters
- Introduced IsAutomaticallyPlacedGhostNode() and MakeAutomaticallyPlacedGhostNode() to start decoupling the concept from commented out nodes
- Updated a couple of places that used a hardcoded UberGraphPages[0] into instead editing the most recently interacted with event graph if possible
- Updated 'is data only blueprint' logic to allow multiple ubergraph pages, as long as they're all empty of non-disabled nodes
Change 3571224 by Michael.Noland
Blueprints: Draw banners on development-only and user disabled nodes (excluding 'ghost' nodes like autogenerated event entries in new BPs)
Adapted from PR #2701: Differentiate development nodes in BP (Contributed by projectgheist)
#jira UE-29848
#jira UE-34698
Change 3571279 by Michael.Noland
Blueprints: Changed UK2Node::GetPassThroughPin so that only the execution wire on nodes with exactly one input and one output exec wire will have a corresponding pass-through pin (when there is ambiguity in which exec would be used, e.g., with a branch or sequence or timeline node, the subsequent nodes are now effectively disabled as well)
Change 3571282 by Michael.Noland
Blueprints: Fixed the tooltip for dragging a variable onto an inherited category not showing the 'move to category' hint
Change 3571284 by Michael.Noland
Blueprints: Made wires into/out of a user-disabled node draw verly dimly (other than the passthrough exec if it exists)
Change 3571311 by Ben.Zeigler
Add ActorIteratorFlags which allows overriding which types of actors/levels are iterated by ActorIterator, to allow iterating levels that are not visible.
All of the iteration logic is now in the base and the children just set different flags, which fixes it so TActorIterator does the same level collection check as FActorIterator
Change 3571313 by Ben.Zeigler
Several fixes to automation framework to allow it to work better with Cooked builds.
Change it so the automation test list is a single message. There is no guarantee on order of message packets, so several tests were being missed each time.
Change 3571485 by mason.seay
Test map for Make Set bug
Change 3571501 by Ben.Zeigler
Accidentally undid the UHT fixup for TAssetPtr during my bulk rename
Change 3571531 by Ben.Zeigler
Fix warning messages
Change 3571591 by Michael.Noland
Blueprints: Made drag-dropping assets into a graph to create a component transactional (allowing the action to be undone)
#jira UE-48024
Change 3572938 by Michael.Noland
Blueprints: Fixed a typo in a set function comment
#jira UE-48036
Change 3572941 by Michael.Noland
Blueprints: Made the compact node title for cross and dot product the words cross and dot rather than hard to see . and x symbols
#jira UE-38624
Change 3574816 by mason.seay
Renamed asset to better reflect name of object reference
Change 3574985 by mason.seay
Updated comments and string outputs to list Soft Object Reference
Change 3575740 by Ben.Zeigler
#jira UE-48061 Change it so Editor builds work like cooked builds and always try to reuse existing packages when loading them instead of recreating them in place. Recreating in place does not work well for levels and blueprints, and blueprints already had a hack that was causing this behavior to not activate
Change 3575795 by Ben.Zeigler
#jira UE-48118 Call into the AssetManager as part of the DistillPackages commandlet. This makes sure that ShooterGame and EngineTest end up with the correct content in launcher builds
Change 3576374 by mason.seay
Forgot to submit the deleting of a redirector
Change 3576966 by Ben.Zeigler
#jira UE-48153 Fix issue where actors in streaming levels weren't properly replicating in PIE. It now does the remap path on both send and receive for the manual PC level streaming commands
Change 3577002 by Marc.Audy
Prevent wildcard pins from being connected to exec pins
#jira UE-48148
Change 3577232 by Phillip.Kavan
#jira UE-48034 - Fix EDL assert on load caused by a native reference to a nativized BP class that also references a nativized UDS asset.
Change summary:
- Modified FNativeClassHeaderGenerator::ExportGeneratedStructBodyMacros() to emit the 'ReplaceConverted' package name for the FCompiledInDeferStruct global associated with the nativized UDS asset in the UHT codegen. This brings nativized UDS to parity with nativized BP class assets (it was likely just an oversight initially).
Change 3577710 by Dan.Oconnor
Mirror of 3576977:
Fix for crash when loading cooked uassets that reference functions that are not present
#jira UE-47644
Change 3577723 by Dan.Oconnor
Prevent deferring of classes that are needed to load subobjects
#jira UE-47726
Change 3577741 by Dan.Oconnor
Back out changelist 3577723 - causes crash when starting QAGame in Dev-Framework - not in Release-4.17
Change 3578938 by Ben.Zeigler
#jira UE-27124 Fix issue where renaming a map with legacy map build data would end up with a half-loaded redirector package, becuase the old map build data was still in use. It's possible the call to HandleLegacyMapBuildData should just be in World PostLoad instead of piecemeal in several other places but I am unsure.
Fix it so the redirector cleanup code on map change will not be stopped by non-standalone top level objects, which could be left behind by issues in other systems
Change 3578947 by Marc.Audy
(4.17) Properly expose members of DialogueContext to blueprints
#jira UE-48175
Change 3578952 by Ben.Zeigler
Fix ensure where ParentHandles on a StreamableHandle could be modified while iterating
Change 3579315 by mason.seay
Test map for Make Container nodes
Change 3579600 by Ben.Zeigler
Disable window test on non-desktop platforms as they cannot be resized post launch
Change 3579601 by Ben.Zeigler
#jira UE-48236 Disable optimizations on PS4 for certain math tests pending fixing of platform issue
Change 3579713 by Dan.Oconnor
Prevent crashes when bluepints implement an interface that was deleted
#jira UE-48223
Change 3579719 by Dan.Oconnor
Fix two compilation manager issues: Make sure CDOs are not renamed under a UClass, because they will be considered as possible subobjects, which has bad side effects and make sure that we update references even on empty functions, so that empty UFunctions are not left with references to REINST data
#jira UE-48240
Change 3579745 by Michael.Noland
Blueprints: Improve categorization and reordering support in 'My Blueprints'
- Allow drag-dropping functions, macros, delegates, etc... to reorder them within a category or to change categories (bringing them to parity with variables)
- Make category ordering on all categories sticky so you can reorder categories (the relative ordering will be the same within different sections like variables and functions)
- Added hover cues when drag dropping some items that were missing them (e.g., event dispatchers)
- Added support for renaming categories using F2
Known issues (none are regressions):
- Timelines cannot be moved to other categories or reordered
- Renaming a nested category will result in it becoming a top level category (discarding the parent category chain)
- Some actions do not support undo
#jira UE-31557
Change 3579795 by Michael.Noland
PR #3867: Fix for not releasing Local Notification Delegate. (Contributed by enginevividgames)
#jira UE-48105
Change 3580463 by Marc.Audy
(4.17) Don't crash if calling PostEditUndo on an Actor in the transient package
#jira UE-47523
Change 3581073 by Marc.Audy
Make UK2Node_SpawnActorFromClass inherit from K2Node_ConstructObjectFromClass and eliminate duplicate code.
Correctly reconnect split pins when changing class on create widget, construct object, and spawn actor nodes
Change 3581156 by Ben.Zeigler
#jira UE-48161 Fix issue where split pins would not be restored if a Struct type was changed due to refactoring of parent variables/functions. For structs we want to copy the pins, if they're invalid due to other changes they will be individual orphaned
Also fix bug where the category of parent pins was being set incorrectly while changing variable type, we only want to override type for wildcard pins
Change 3581473 by Ben.Zeigler
Properly turn off optimization for PS4 test
Change 3582094 by Marc.Audy
Fix anim nodes not navigating to their graph on double click
#jira UE-48333
Change 3582157 by Marc.Audy
Fix double-clicking on animation asset nodes not opening the asset editors
Change 3582289 by Marc.Audy
(4.17) Don't crash when adding a streaming level that's already in the level
#jira UE-48928
Change 3545435 by Ben.Zeigler
#jira UE-47509 Rename and refactor internals StringAssetReferences and AssetPtrs to become SoftObjectPath/Ptr. This is to prepare them for use for subobjects like actors. Here is the rename table:
FStringAssetReference -> FSoftObjectPath
FStringClassReference -> FSoftClassPath
TAssetPtr -> TSoftObjectPtr
TAssetSubclassOf -> TSoftClassPtr
The old headers are deprecated, and FSoftClassPath is now in the same header has FSoftObjectPath.
This change increments the UE4 version because FSoftObjectPaths are now stored as a name + substring instead of one giant name, which in practice will improve performance and memory while manipulating them. Also the package table of soft referenced packages is now stored as FNames instead of FStrings as these packages names will already be in the name table due to the AssetRegistry
Remove automatic support for loading Objectpaths starting with engine-ini:, as it was only partially supported and is very outdated. ResolveIniObjectsReference can still be called manually
Changed TPersistentObjectPtr and TLazyObjectPtr to be structs instead of classes
Change UnrealHeaderTool to read configuration such as StructsWithNoPrefix out of inis instead of using a hardcoded list. Add support for TypeRedirects, which is used to make the old type names automatically remap to the new ones
Clean up FRedirectCollector to remove some of the functionality that is no longer used by the cooker, and disable tracking of redirects in standalone -game builds
Change 3567760 by Ben.Zeigler
Fix it so EngineTest can be cooked by moving some utility functions to EditorTestsUtilityLibrary and adding an EditorFunctionalTest. The core EngineTest module is safely runtime-only now and can run it's tests locally in windows cooked
Merge FuncTestManager into FunctionalTestModule to avoid confusion with FunctionalTestingManager UObject
Add EngineTestAssetManager and override the cook function to cook all maps with runtime functional tests
Change actor merging tests to be editor only, this stops them from cooking
Several individual tests crash on cooked builds, I started threads with the owners of those
Change 3575737 by Ben.Zeigler
#jira UE-48042 Change it so playing via PIE Standalone, multiprocess networked PIE and external cook launch on does not save temporary levels to UEDPC and instead prompts the user to save. This is how launch on works by default already, and this fixes cross level references/sequencer. The UEDPC code has been removed entirely.
As part of this change, connecting a -game client to a PIE server and vice versa is much more likely to work. You may still have game-side problems, look at UEditorEngine::NetworkRemapPath for an example of how to do the PIE prefix conversion
Remove advanced CreateTemporaryCopiesOfLevels option from sequencer capture, it has not been tested in multiple years and does not work with newer sequencer features
#jira UE-27124 Fix several possible crashes with changing levels while in PIE
Change 3578806 by Marc.Audy
Fix Construct Object not working correctly with split pins.
Add Construct Object test cases to functional tests.
Added split pin expose on spawn test cases.
#jira UE-33924
[CL 3582334 by Marc Audy in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3252833 on 2017/01/10 by Ori.Cohen
Refactor constraint so that it can be used for external solvers. (Copying //Tasks/UE4/Dev-ImmediateModePhysics to Dev-Framework (//UE4/Dev-Framework))
Change 3256288 on 2017/01/12 by Ori.Cohen
Undo constraint refactor as we found a way around it and it made the code much harder to read/debug
Change 3373195 on 2017/03/30 by Mike.Beach
For nativization, changing it so we key off of the target platform-info struct instead of the platform (in preparation for defining the nativized plugin's platform whitelist).
Change 3381178 on 2017/04/05 by Dan.Oconnor
Make sure we don't inherit the NATIVE func flag when generating skeleton functions, also make sure all bojects outer'd to the skeleton class are marked transient
#jira UE-43616
Change 3381532 on 2017/04/05 by Marc.Audy
(4.16) Fix various cases where built lighting on child actors could be lost when loading a level
#jira UE-43553
Change 3381586 on 2017/04/05 by Mike.Beach
Now generating TArrayCaster conversions for nativized UClass arrays that need it (to handle different TSubclassOf arrays).
#jira UE-42676, UE-43257
Change 3381682 on 2017/04/05 by mason.seay
Some more changes to test map
Change 3381844 on 2017/04/05 by Dan.Oconnor
Match existing logic for CPF_ReturnParm/CPF_OutParm. Fixes compilation error in BP_TurbineBlades when using compilation manager
Change 3382054 on 2017/04/05 by Zak.Middleton
#ue4 - Optimize CharacterMovementComponent::GetPredictionData_Client_Character() and GetPredictionData_Server_Character() to remove virtual calls.
#jira UE-30998
Change 3382703 on 2017/04/06 by Lukasz.Furman
fixed missing links between navmesh polys when there are more than 4 neighbor connections
#jira UE-43524
Change 3383357 on 2017/04/06 by Marc.Audy
(4.16) Make SetHiddenInGame propagate consistently with SetVisibility
#jira UE-43709
Change 3383359 on 2017/04/06 by Dan.Oconnor
Fix last errant SKEL reference when cooking Odin
Change 3383591 on 2017/04/06 by Mike.Beach
Prevent users from setting object variables as 'config' properties (disallowed by UHT). This prevents some errors that could happen later when users nativize the Blueprint.
#jira UE-42085
Change 3384762 on 2017/04/07 by Zak.Middleton
#ue4 - Fix SpringArmComponent not restoring relative transform when bUsePawnControlRotation is turned off. Fixes the editor interaction ignoring transform of the component in the viewport after bUsePawnControlRotation is toggled on then off, since by then the world transform had been overwritten (from tick in editor) and nothing would drive transform changes from the editable value.
Toggling bUsePawnControlRotation off at runtime now restores the rotation to the initial relative rotation, not stomping it with the current pawn rotation, allowing toggling between the editable/desired base rotation and the control rotation.
#jira UE-24850
Change 3384948 on 2017/04/07 by Dan.Oconnor
Prevent GForceDisableBlueprintCompileOnLoad from causing all sorts of badness when dependencies are loaded as part of a Diff operation. Instead of setting a global flag we flag the package as LOAD_DisableCompileOnLoad
Change 3385267 on 2017/04/07 by Michael.Noland
Graph Editing: Pushed some node diffing code down from UAIGraphNode into UEdGraphNode so nodes with details panel properties will diff correctly (e.g., various animation nodes and BP switch nodes)
#jira UE-21724
Change 3385473 on 2017/04/07 by Phillip.Kavan
#jira UE-43067 - Fix broken pin wires after an Expand Node operation, along with some misc. cleanup.
Change summary:
- Fixed to use correct string for "Expand Node" transaction name.
- Modified FBlueprintEditor::OnExpandNodes() to consolidate some redundant code.
- Fixed to generate a unique node GUID for cases where the source graph is not removed after expansion.
Change 3385583 on 2017/04/07 by Dan.Oconnor
Handle CreatePropertyOnScope nullptr return values (happens for structs missing a struct property)
#jira UE-43746
Change 3386581 on 2017/04/10 by Michael.Noland
Blueprints: Further hardening FBlueprintActionInfo::GetOwnerClass()
#jira UE-43824
Change 3386615 on 2017/04/10 by Marc.Audy
Instanced properties can now properly be set on a per-instance basis in blueprint added components.
#jira UE-42066
Change 3387000 on 2017/04/10 by Marc.Audy
Fix includes for CIS
Change 3387229 on 2017/04/10 by mason.seay
More changes to TM-Gameplay
Added Save Game test (with blueprint)
Tick Interval test (with blueprint)
BP logic cleanup
Level organization
Change 3388437 on 2017/04/11 by Mike.Beach
Adding support for map/set literals in the backend (so you can use set nodes for structs containing sets/maps, without having to connect a RHS input - resets to struct defaults).
#jira UE-42617
Change 3388532 on 2017/04/11 by mason.seay
Submitting latest changes for crash repro
Change 3389026 on 2017/04/11 by Ben.Zeigler
Performance and bug fixes for incremetal cooking with asset registry, duplicate of several changes made on //Fortnite/Main
Fix it so AssetRegistry.ScanPathsAndFilesSynchronous won't scan subdirectories inside already scanned directories, this cuts down on the number of cache files
Fix 2 second stall when shutting down AssetSourceFilenameCache if it had never been previously created
Change 3389163 on 2017/04/11 by Ben.Zeigler
#jira UE-42922 Fix it so connecting function input node output pins does not clear default value, we only want to clear the value when connecting an input pin. Properly testing this fix depends on UE-43883
Change 3389205 on 2017/04/11 by Marc.Audy
Protect against a handful of GEditor usages that can now be hit in standalone
Change 3389220 on 2017/04/11 by Marc.Audy
Don't borrow ClassWithin to masquerade as ParentClass during compilation and instead just set the super struct immediately
Change 3389222 on 2017/04/11 by Michael.Noland
Framework: Adding a cvar (t.TickComponentLatentActionsWithTheComponent) to allow users to revert to the old behavior on when component latent actions tick
- Non-zero values behave the same way as actors do, ticking pending latent action when the component ticks, instead of later on in the frame (default behavior in 4.16 and beyond)
- Prior to 4.16, components behaved as if the value were 0, which meant their latent actions behaved differently to actors
This CVar will be removed in a future version, defaulting to on
#jira UE-43661
Change 3389276 on 2017/04/11 by Marc.Audy
Spelling fix and NULL to nullptr
Change 3389303 on 2017/04/11 by Mieszko.Zielinski
Made sure AIController::Posses doesn't get called when compiling Pawn BP #UE4
#jira UE-43873
Change 3390215 on 2017/04/12 by mason.seay
Removed some tests, will need further review
Change 3390638 on 2017/04/12 by Mike.Beach
Generalizing the omission of the CoerceProperty (in EmitTerm) - previously we were only omitting properties for our custom array lib. For wildcards, a coerce property should not be used as its type will not match.
NOTE: There is a slight behavior change in UEdGraphSchema_K2::ConvertPropertyToPinType(), as it will return 'wildcard' for params marked as 'ArrayTypeDependentParams' (previously would have returned 'int').
#jira UE-42747
Change 3390774 on 2017/04/12 by Ben.Zeigler
#jira UE-43911 Fix several issues with saving a runtime asset registry containing redirectors that caused crashes in cook on the fly. Don't resolve redirectors on incoming links because it will make a circular link, and fix an issue where chained redirectors would break the for loop iteration and return a bad dependency
Fix it so the asset registry written out at the beginning of CookOnTheFly uses the registry generator, otherwise it will include all of the stripped editor only tags
Change 3390778 on 2017/04/12 by Ben.Zeigler
Fix UCookOnTheFlyServer::CollectFilesToCook to check for initial unsolicited packages up front. This is required in iterative mode because it may skip cooking all explicit packages and thus miss a new startup loaded package
Change 3390782 on 2017/04/12 by Ben.Zeigler
Change RunProjectCommand to not imply -nomcp, and allow reading -clientcmdline to override setting the map parameter to 127.0.0.1 by default
Fix RunProjectCommand to remove ios-specific checks to not pass weird platform parameters, and instead never pass them
Fix PS4Platform to pass along command line when calling build cook run, args needs to be the last parameter so explicitly set -target=
Change 3390859 on 2017/04/12 by Mike.Beach
T3D class fields now export with the class's fully qualified path name (to avoid abiguity). Since we can have multiple classes with the same name (Blueprints in different folders), we have to use the class's fully qualified object path.
#jira UE-28048
Change 3390914 on 2017/04/12 by Lukasz.Furman
fixed missing navlink component's transform in exported navigation data
#jira UE-43688
Change 3391122 on 2017/04/12 by Ben.Zeigler
Add new PreloadPrimaryAssets call to AssetManager that stream the desired assets without modifying the official load/unload state. This is useful if you want to preload things in case the might be used in the future, and it also supports recursion
Fix crash calling GetAssetDataForPath with null path
Change 3391494 on 2017/04/12 by Dan.Oconnor
Fix bad references in deep object (widget) hierarchies
#jira UE-43802
Change 3391529 on 2017/04/12 by Dan.Oconnor
Fix log spam, accidently submitted
#rnx
Change 3391756 on 2017/04/12 by Dan.Oconnor
LinkExternalDependencies needs to be performed before we RefreshVariables
#jira UE-43843
Change 3392542 on 2017/04/13 by Marc.Audy
Ensure that initialized actors get cleaned up when removed from world even if that world hasn't begun play.
#jira UE-43879
Change 3392746 on 2017/04/13 by Marc.Audy
(4.16) When duplicating a blueprint node, correctly make the new node a sibling of the duplicated node, not a child of it (unless duplicating the root component).
Also resets scale of a duplicated root component to 1 to avoid a squaring of the scale for that component.
#jira UE-40218
#jira UE-42086
Change 3393253 on 2017/04/13 by Dan.Oconnor
Make sure calculated meta data is correctly set on functions generated by the compilation manager (SKEL_ class functions)
#jira UE-43883
Change 3393509 on 2017/04/13 by Mike.Beach
Removing hack'ish ResetLoaders() call that was causing undesired side-effects (resetting of a loaded package that other objects were relying on). This was originally intended to release file handles so separate editor processes could make updates and save the file (from CL 1712376). Using ResetLoaders() for this is bad though, as it has too many side effects. Instead we have to wait for GC to run. This also makes sure that GC should run as intended as the CookOnTheFly sever is idling.
#jira UE-37284
Change 3394350 on 2017/04/14 by Michael.Noland
Core: Making FDateTime and FTimespan actually reflected, so they get duplicated properly in CopyPropertiesForUnrelatedObjects, etc...
#jira UE-39921
Change 3395985 on 2017/04/17 by Phillip.Kavan
#jira UE-38280 - Fix invalid custom type selections on member fields in the User-Defined Structure Editor after a reload.
Change summary:
- Ensure that the 'SubCategoryObject' member in a UDS variable descriptor has been loaded when converting to an FEdGraphPinType.
Change 3396152 on 2017/04/17 by Marc.Audy
TickableGameObjects that have IsTickableInEditor false should not tick in the editor
#jira UE-40421
Change 3396279 on 2017/04/17 by Phillip.Kavan
#jira UE-43968 - Fix failed validation of bitmask enum types when serializing bitmask literal nodes.
Change 3396299 on 2017/04/17 by Dan.Oconnor
Fix resintancing issues exposed by running TM-Gameplay with -game. We cannot reinstance actors in levels on load because the scene is not created.
#jira UE-43859
Change 3396712 on 2017/04/17 by Marc.Audy
Call PostLoad on subobjects before copying for unrelated properties to avoid cases where an out of date object patched over in the linker has not been brought up to date
#jira UE-38234
Change 3396718 on 2017/04/17 by Mike.Beach
Adding a search bar to the components tree for Blueprints.
#epicfriday
#jira UE-17620
Change 3396999 on 2017/04/17 by Mike.Beach
In generated code, call event '_Implementation' functions directly for interface functions being invoked on self (avoids a UHT runtime error).
#jira UE-44018
Change 3397700 on 2017/04/18 by Marc.Audy
UT struct BlueprintType fixups
Change 3397701 on 2017/04/18 by Marc.Audy
Odin struct BlueprintType fixups
Change 3397703 on 2017/04/18 by Marc.Audy
Ocean struct BlueprintType fixups
Change 3397704 on 2017/04/18 by Marc.Audy
WEX struct BlueprintType fixups
Change 3397705 on 2017/04/18 by Marc.Audy
Additional UT blueprint type struct fixups
Change 3397706 on 2017/04/18 by Marc.Audy
Fortnite struct BlueprintType fixups
Change 3397708 on 2017/04/18 by Marc.Audy
Fixup Engine BlueprintType markup of structs
Change 3397709 on 2017/04/18 by Marc.Audy
Sample Game struct BlueprintType fixups
Change 3397711 on 2017/04/18 by Marc.Audy
Mark AnimNodes as BlueprintType and BlueprintInternalUseOnly
Change 3397712 on 2017/04/18 by Marc.Audy
Paragon struct BlueprintType fixups
Change 3397735 on 2017/04/18 by Marc.Audy
Definition pieces of BlueprintInternalUseOnly to fix UHT errors with structs already marked to use it
Change 3397912 on 2017/04/18 by Mike.Beach
Fix for CIS warnings about shadowed variables (fallout from CL 3396718).
Change 3398455 on 2017/04/18 by Marc.Audy
Make less critical errors log an error rather than immediately throwing allowing multiple errors to be reported in the same compile
Change 3398491 on 2017/04/18 by Marc.Audy
BPRW/BPRO in a non-BlueprintType is now a UHT error
Change 3398539 on 2017/04/18 by Marc.Audy
Fixup live link struct markups
Change 3399412 on 2017/04/19 by Marc.Audy
Fix Match3 blueprint type struct markups
Change 3399509 on 2017/04/19 by Phillip.Kavan
#jira UE-38574 - Fix AnimBlueprint function graphs marked as 'const' to treat 'self' as read-only when compiling.
Change summary:
- Modified FKismetCompilerContext::ProcessOneFunctionGraph() to use the function graph schema rather than the compiler context schema for both the function context's schema as well as testing the function for 'const'-ness. For AnimBPs, the compiler context and the function graph context can differ, so we need to make sure we are using the right one when making queries for a specific function context during compilation.
- Minor cleanup: changed the function context schema to be 'const' in order to be consistent with the function graph GetSchema() API's result. Added a few 'const' qualifiers where needed to match.
- Added a new object version in order to avoid breaking compilation of existing AnimBP function graphs that may already be violating the 'const' rule (this is the same thing that was done when 'const' was first added to "normal" BP function graphs). Just as with normal function graphs in place before the addition, a warning will be generated for existing AnimBP function graphs if they violate 'const' correctness, and an error will be generated for all new ones.
Change 3399749 on 2017/04/19 by Mike.Beach
Hiding the Nativized Blueprints plugin from the in-editor browser (prevent users from disabling it).
Change 3399774 on 2017/04/19 by Marc.Audy
ConditionalPostLoad is already called on StaticMesh earlier in the function
#rnx
Change 3400313 on 2017/04/19 by Mike.Beach
Mirroring CL 3398673 from 4.16
Now, with ICWYU, making sure that the coresponding header gets included first in nativized Blueprint files (else we get a UHT error). Had to fixup some ShooterGame specific files as a result (they had missing includes and forward declarations).
#jira UE-44124
Change 3400328 on 2017/04/19 by Mike.Beach
Missing file from mirrored change (CL 3400313 - mirroring CL 3398673 from 4.16)
#jira UE-44124
Change 3400415 on 2017/04/19 by Chad.Garyet
adding physx switch build to framework
Change 3400514 on 2017/04/19 by Mike.Beach
Back out changelist 3400313 / 3400328 (mirrored from CL 3398673 in 4.16), as it was producing "include PCH first" errors. Likely, CL 3398673 was a fix for a 4.16 specific change, altering the expected include order. We'll have to wait for this one to be integrated back.
Change 3400552 on 2017/04/19 by Marc.Audy
Undo the calling of post load prior to the CPFUO as dependent objects may not yet be loaded. Instead copy the need load flag to the new CDO subobject, similarly to how the top level CDO object copies its flags over.
#jira UE-44150
Change 3400815 on 2017/04/19 by Marc.Audy
Spelling fix (part of PR #3490)
#rnx
Change 3400918 on 2017/04/19 by Marc.Audy
Partial pull of PR #3490: Improved remapping game controls support (Contributed by projectgheist)
This portion brings in the exposure of the bindings to blueprint
#jira UE-44122
Change 3401550 on 2017/04/20 by Marc.Audy
fix kitedemo blueprint type markup
#rnx
Change 3401702 on 2017/04/20 by Mike.Beach
Make it so plugins added to a project through the .uproject's 'AdditionalPluginDirectories' list get folded into the generated code project (for visual studio, etc.).
Change 3401720 on 2017/04/20 by Mike.Beach
Add white and black lists for target type (game, client, server, etc.) to plugin module descriptors.
Change 3401725 on 2017/04/20 by Mike.Beach
Whitelisting the nativized Blueprint plugin for only the targets it was built for (game, server, or client).
Change 3401800 on 2017/04/20 by Ben.Zeigler
Add Algo::BinarySearch, LowerBound, and UpperBound. These are setup to allow binary searching a presorted array, and allow for specifying projection and sort predicates. Convert some engine code to use it
Add TSortedMap, which is a map data structure that has the same API as TMap, but is backed by a sorted array. It uses half the memory and performance is faster below n=10
Add FName::CompareIndexes so a SortedMap with FNames can be used without doing very slow string compares, and FNameSortIndexes predicate to sort by it
Add code to Algo and Container tests. Split up container tests so the new ones aren't run in smoketest as they are a bit slow
Add RemoveCurrent and SetToEnd to ArrayIterator
Change 3401849 on 2017/04/20 by Marc.Audy
Partial pull of PR #3490: Improved remapping game controls support (Contributed by projectgheist)
This portion brings bug fixes and improvements to InputKeySelector UMG widgets.
#jira UE-44122
Change 3402088 on 2017/04/20 by Marc.Audy
Focus the search box when expanding the map value type
#jira UE-44211
Change 3402251 on 2017/04/20 by Ben.Zeigler
Fix issue where SortedMap needs to be resorted after serialization, because the sorting may have changed from when it was saved out
Change 3402335 on 2017/04/20 by Ben.Zeigler
Significant changes to FAssetData serialization and memory, cuts memory significantly but will break code that was using some of the internal API that was not properly hidden before
Both Editor and Runtime cache now use the same FAssetRegistryVersion, which is now registered as a custom version
Rename FAssetData and FAssetPackage operator<< to SerializeForCache to make it clear that it isn't safe to use for general serialization
Remove GroupNames from FAssetData, it has not been useful since the UE4 package structure changed around 4.0
Rename generic-sounding but not actually generic SharedMapView class to AssetDataTagMapSharedView to indicate what it is actually used for
Change TagsAndValues to use a new array-backed TSortedMap as the base structure instead of a hash map. Also, it only allocates the map on demand, which saves significant memory at runtime as many packages have no tags
Add bFilterAssetDataWithNoTags to [AssetRegistry] ini section, if set it will only save cooked asset data if it has tags, off by default but saves significant memory if your whitelist is set up properly
Fix issue where asset registry tags updated by loading assets during cook were not being reflected in the cooked registry
Add AssetRegistry::GetAllocatedSize and add to MemReport output
Change 3402457 on 2017/04/20 by Ben.Zeigler
Enable asset registry iteration and stripping unused asset data in Fortnite. Registry iteration is already on in //Fortnite/Main, stripping is a new feature I want to test
Change 3402498 on 2017/04/20 by Ben.Zeigler
CIS fix. Why did this compile locally?
Change 3402537 on 2017/04/20 by Ben.Zeigler
Remove ensure for making AssetData for subobjects, the editor does this for thumbnail creation in some cases
Change 3402600 on 2017/04/20 by Ben.Zeigler
Add bShouldGuessTypeAndNameInEditor to manager settings, can be set false for games where type cannot be safely implied and content must be resaved
Fix up some bool setting code inside asset manager, and fix const correctness and for iterator issues
AssetManager can now discover any BlueprintCore type when bHasBlueprintClasses=true
Add AssetManager.DumpAssetRegistryInfo to output detailed asset registry usage stats
Add Primary Name to asset audit window by default
Change 3403556 on 2017/04/21 by Marc.Audy
Fix Orion input key selector override class
#rnx
Change 3404090 on 2017/04/21 by mason.seay
Applying Forcefeedback to test map
Change 3404093 on 2017/04/21 by mason.seay
Changing text in level
Change 3404139 on 2017/04/21 by mason.seay
Added Force Feedback test and made some tweaks.
Change 3404146 on 2017/04/21 by mason.seay
Added source reference to Instanced Variable test
Change 3404154 on 2017/04/21 by mason.seay
More minor tweaks
Change 3404155 on 2017/04/21 by Marc.Audy
Remove auto
#rnx
Change 3404188 on 2017/04/21 by Marc.Audy
Fixed crash changing variable type when any type other than map
#jira UE-44249
#rnx
Change 3404463 on 2017/04/21 by Ben.Zeigler
Fix asset data code to not ensure when loading an object with invalid exports, and instead print warning with name of package that needs to be resaved
Resave a map that had a redirector from a DIFFERENT package saved in it's exports. I do not understand how this happened, but it appears to be related to the lightmap BuiltData transition when old maps are opened
Change 3404465 on 2017/04/21 by Ben.Zeigler
Fix issue with trying to load editor-only asset classes in a cooked build
Fix issues with renaming or changing template Ids of assets from the editor
Always print the Duplicate Asset ID error, as if you have more than one the ensuremsg only goes off once
Change 3404481 on 2017/04/21 by Dan.Oconnor
Remove unneeded walk up hierarchy - prevent stale entries in action database if we compile a BP but don't compile its children
Change 3404510 on 2017/04/21 by Phillip.Kavan
#jira UE-35727 - Collapsed graphs containing a local variable node will no longer cause a compile error when the parent graph is renamed.
Change 3404590 on 2017/04/21 by Michael.Noland
Editor: Fixed incorrect filtering of abstract/deprecated UDeveloperSettings and UContentBrowserFrontEndFilterExtension classes caused by a typo (HasAnyCastFlags versus HasAnyClassFlags)
Change 3404593 on 2017/04/21 by Marc.Audy
Fixed another crash to do with input pin secondary combo box
#jira UE-44269
#rnx
Change 3404600 on 2017/04/21 by Michael.Noland
Core: Allow UE_GC_TRACK_OBJ_AVAILABLE to be set externally
#rnx
Change 3404602 on 2017/04/21 by Michael.Noland
Engine: Switched from an include to a forward declaration of SWidget in UDeveloperSettings to keep it slim
#rnx
Change 3404608 on 2017/04/21 by Michael.Noland
Core: Marked TNumericLimits as constexpr so they can be used in static asserts
Change 3404659 on 2017/04/21 by Michael.Noland
Engine: Adding includes back to two UDeveloperSettings subclasses
Change 3405289 on 2017/04/24 by Marc.Audy
Remove auto
#rnx
Change 3405446 on 2017/04/24 by Marc.Audy
Fix Win32 unsigned compile issue
Change 3405512 on 2017/04/24 by Mike.Beach
Piping through NativizationOptions to filename generation (so we're able to gen different files names per target: client vs. server).
Change 3406080 on 2017/04/24 by Ben.Zeigler
Deprecate UEngine::OnPostEngineInit and move to FCoreDelegates, clean up comments for the initialization delegates
Call OnPostEngineInit from commandlet initialization as well as normal execution. I thought about making a wrapper function, but the commandlet calls EditorInit directly so it wouldn't work
Bind delegate to refresh the AssetRegistry native class hierarchy after engine init so it picks up game/plugin classes. Undo ini change that was required to hack around this
Change 3406381 on 2017/04/24 by Ben.Zeigler
#jira UE-23768 Enable Run Physics With No Controller for montage test pawn. The montage pawn has no controller so wasn't correctly running physics when the root motion stopped. This flag needs to be set to allow it to correctly stop after the montage is over
Change 3406438 on 2017/04/24 by Ben.Zeigler
Fix deprecation warning
Change 3406519 on 2017/04/24 by Phillip.Kavan
#jira UE-43612 - Suppress array "Get" node fixup notifications on load when the BP Compilation Manager is enabled.
Change summary:
- Wrapped BPCM calls to FBlueprintEditorUtils::ReconstructAllNodes() and ReplaceDeprecatedNodes() duirng compile-on-load with bIsRegeneratingOnLoad = true. This matches the BP's state during compile-on-load when the BPCM is not enabled.
Change 3406565 on 2017/04/24 by Dan.Oconnor
Make sure all interface functions are added to skeleton
#jira UE-44152
Change 3407489 on 2017/04/25 by Ben.Zeigler
#jira UE-44317 Fix game-only TickableGameObjects to correctly tick in PIE
Change 3407558 on 2017/04/25 by Ben.Zeigler
Fix Fortnite cook warnings, issue had to do with the CDO being registered as a Primary Asset in conflict with the Class being registered
Fix issue with renaming a BP primary asset not finding the old name
Change 3407701 on 2017/04/25 by Dan.Oconnor
Remove unneeded null check, static analysis doen't like the inconsistency
Change 3407995 on 2017/04/25 by Marc.Audy
Fixed maps and sets not working correctly with split pin.
#jira UE-43857
Change 3408124 on 2017/04/25 by Ben.Zeigler
#jira UE-39586 Change it so the blueprint String/Name/Object to Text node creates culture invariant text, and also have them show as an expanded node with a comment explaining this
Fix Transform to actually return in the format specified in the comment, and fix comments on many text conversions
Change 3408134 on 2017/04/25 by Marc.Audy
Graph pin container type now represented by an enumeration (EPinContainerType) rather than 3 "independent" booleans.
FEdGraphPinType constructor, UEdGraphNode::CreatePin, and FKismetCompilerContext::SpawnInternalVariable that took 3 booleans deprecated and replaced with a version that takes EPinContainerType.
UEdGraphNode::CreatePin parameters reorganized so that PinName is before ContainerType and bIsReference, which default to None and false respectively
Change 3408256 on 2017/04/25 by Michael.Noland
Core: Changed UClass::ClassFlags to be of type EClassFlags for improved type safety
Change 3408282 on 2017/04/25 by Marc.Audy
(4.16) Fix incorrect positioning of instance components after duplication
#jira UE-44314
Change 3408404 on 2017/04/25 by Mike.Beach
Adding and removing the nativized plugin to/from the project when we alter the packaging nativization setting (so it gets picked up by project generation).
Change 3408445 on 2017/04/25 by Marc.Audy
Fix up missed deprecation cases
#rnx
Change 3409354 on 2017/04/26 by Marc.Audy
Fix Linux CIS failure
#rnx
Change 3409487 on 2017/04/26 by Marc.Audy
When dragging assets in to the SCS create them as siblings, not nested
#jira UE-43041
Change 3409776 on 2017/04/26 by Ben.Zeigler
#jira UE-44401 Fix issue with cooking a map containing a reparented component. In that case the child component may think it's not editor only, but it's archetype is editor only. This is not allowed in EDL, so now the child is marked as editor only as well
Change 3410168 on 2017/04/26 by Dan.Oconnor
Avoid calling virtual functions in the middle of compile
#jira UE-44243
Change 3410252 on 2017/04/26 by Lukasz.Furman
adjusted WITH_GAMEPLAY_DEBUGGER checks after IWYU changes
#ue4
Change 3410385 on 2017/04/26 by Marc.Audy
ChildActorComponent SetClass no longer fails when setting at runtime.
#jira UE-43356
Change 3410466 on 2017/04/26 by Michael.Noland
Core: Ensuring EClassFlags is 32 bit in a different way (underlying type of the enum is coming out signed even though all members are unsigned, long term fix is probably to move it to an enum class)
#rnx
Change 3410476 on 2017/04/26 by Michael.Noland
Automation: Deleting some commented out methods
#rnx
Change 3411070 on 2017/04/27 by Marc.Audy
Properly complete deprecation of old attachment API
Change 3411338 on 2017/04/27 by mason.seay
Map for Latent Action Tick Bug
Change 3411637 on 2017/04/27 by Ben.Zeigler
Back out CL #3381532 as it was causing crashes when adding new variables to blueprints, as the transaction array was being recursively modified while it was being added to
Change 3412052 on 2017/04/27 by mason.seay
Updated jump test map and pawn
Change 3412231 on 2017/04/27 by Ben.Zeigler
Fix issue where running SearchAllAssets multiple times after mounting new paths would throw away the asset registry cache, which slowed down incremental cooking substantially because the cooker mounts the autosave folder
Duplicate of CL #3411860
Change 3412233 on 2017/04/27 by Ben.Zeigler
Made FStreamableHandle::GetLoadedCount much faster by taking advantage of existing progress counter
Duplicate of CL #3411778
Change 3412235 on 2017/04/27 by Ben.Zeigler
Add code to FStringAssetReferenceThreadContext and FStringAssetReferenceSerializationScope which allows setting package name and collect options for string asset references serialized via something other than linker load
Make RedirectCollector threadsafe to avoid issues with async loading asset references
Fix it so ProcessStringAssetReferencePackageList will remove entries from the string asset array like resolve did, and rename function to indicate that
Fix it so string asset references created by asset labels do not automatically get cooked, and significantly improve the speed of labels with lots of assets
Add code to cooker and asset manager to explicitly mark non-cookable assets as NeverVook, this stops labels from ending up in the build if set that way
Added option to not recurse package dependency changes more than one level when hashes change. This ended up not being significantly faster in a realistic case so left disabled
Duplicate of CL #3412080
Change 3412352 on 2017/04/27 by Marc.Audy
Refix lighting getting wrong position when getting component instance data
Change 3412426 on 2017/04/27 by Marc.Audy
Take first steps to making ComponentToWorld private and force use of accessor
Make bWorldToComponentUpdated private
Make ComponentToWorld and bWorldToComponentUpdated mutable
Add a SetComponentToWorld function for the (likely ill-advised) places that were setting it directly.
Change 3412468 on 2017/04/27 by Marc.Audy
Remove last remnants of deprecated (4.11) custom location system
Change 3413398 on 2017/04/28 by Marc.Audy
Fix up missed deprecated attachment API uses
Change 3413403 on 2017/04/28 by Marc.Audy
Fix Orion compile error
#rnx
Change 3413448 on 2017/04/28 by Marc.Audy
Fix up kite demo component to world privataization warnings
#rnx
Change 3413792 on 2017/04/28 by Ben.Zeigler
Fix many bugs with blueprint pin default values, and add "Reset to Default Value" option to pin context menu
Deprecate and rename SetPinDefaultValue because it actually sets the Autogenerated default. This was being called in bad places and destroying the stored autogenerated defaults
#jira UE-40101 Fix expose on spawn pins to correctly update when the spawned object's defaults change
#jira UE-21642 Fix struct pin default values to properly update when the struct is changed
#jira UE-39418 Fix changed function/macro default values to properly update in already placed call nodes
Change 3413839 on 2017/04/28 by samuel.proctor
Added some Blueprint focused tests for TM-Gameplay
Change 3414030 on 2017/04/28 by Ben.Zeigler
Enable use of AssetPtr variables with Config, for native and blueprint
This incorporates CL #3302487 but also enables for blueprint usage as that code is new to framework branch
Change 3414229 on 2017/04/28 by Marc.Audy
Fixup virtuals not calling their Super
Remove some autos
#rnx
Change 3414451 on 2017/04/28 by Lukasz.Furman
static analysis fix for gameplay debugger
Change 3414482 on 2017/04/28 by Ben.Zeigler
Fix crash found where changing pin type on ConvertAsset accessed an array while deleting it
Change 3414609 on 2017/04/28 by Ben.Zeigler
#jira UE-18146 Refresh graph when disconnecting a resolve asset id node
Change 3415852 on 2017/05/01 by Marc.Audy
Remove unused code
#rnx
Change 3415856 on 2017/05/01 by Marc.Audy
auto removal
#rnx
Change 3415858 on 2017/05/01 by Marc.Audy
Fix function taking an input as reference when unneeded and causing (still unclear why it suddenly started showing up) error in cooking
#rnx
Change 3415946 on 2017/05/01 by Marc.Audy
Have K2Node_StructOperation skip the K2Node_Variable validation as it doesn't need a property (per CL# 1756451)
#rnx
Change 3415988 on 2017/05/01 by Lukasz.Furman
renamed WorldContext param in AI related static blueprint functions to remove load/cook warnings
#jira UE-44544
Change 3416030 on 2017/05/01 by Ben.Zeigler
Fix issue with WorldContext pins being broken by my pin value refactor, partial paths like "WorldContext" need to be stored as strings and not as broken object references.
Change 3416230 on 2017/05/01 by Marc.Audy
Fix spelling error
#rnx
Change 3416419 on 2017/05/01 by Phillip.Kavan
#jira UE-44213 - Nativizing a Blueprint class with a non-nativized Blueprint class subobject dependency will no longer lead to a crash at load time.
Change summary:
- Modified the FFakeImportTableHelper ctor to inject subobject CDOs into the 'SerializeBeforeCreateCDODependencies' array. This in turn ensures that EDL will serialize those subobject CDOs (if necessary) before we create the subobject's nativized owner's CDO at load time.
- Modified FEmitDefaultValueHelper::GenerateCustomDynamicClassInitialization() to emit MiscConvertedSubobject instantiations AFTER we emit the FillUsedAssetsInDynamicClass() call. This is now consistent with the code emitted for other subobjects (all of which assumes that the UsedAssets array has been initialized).
- Modified FFindAssetsToInclude::HandleObjectReference() to add UField owner CDOs in addition to the owner class to the asset dependency list. This ensures that owner CDOs will be emitted alongside the class to both the nativized asset dependency table as well as to the fake import table associated with the UDynamicClass linker for the nativized BP asset.
Change 3416425 on 2017/05/01 by Phillip.Kavan
#jira UE-44219 - Nativizing a Blueprint class with a nativized DOBP class dependency will no longer lead to a compile error at cook/nativization time.
- Modified the FGatherConvertedClassDependencies ctor to properly handle DOBPs in exclusive mode that have been explicitly enabled for nativization. Previously, this code wasn't taking that possibility into account, and as a result could lead to a missing header file in a dependent nativized class body's include set.
- Modified FGatherConvertedClassDependencies::GetFirstNativeOrConvertedClass() to remove the 'bExcludeBPDataOnly' parameter, as it was primarily just being used for a redundant exclusion check when called from the FGatherConvertedClassDependencies ctor. That call site has now been modified to start searching from the super class instead. Additionally, any DOBPs will already fail the preceding WillClassBeConverted() check if they have not been explicitly enabled for nativization in exclusive mode, and will always fail if nativizing in inclusive mode. The extra check was breaking the explicitly-enabled case, so it was removed to allow explicitly-enabled DOBPs to pass.
Notes:
- Allowing for explicitly-enabled DOBPs in exclusive mode may be removed in a future change, but since it is currently supported, the changes noted above will at least ensure that the generated code will compile properly for now.
Change 3416570 on 2017/05/01 by mason.seay
Added UMG test to map. Tweaked force feedback test
Change 3416580 on 2017/05/01 by mason.seay
Resubmitting sub levels
Change 3416597 on 2017/05/01 by Dan.Oconnor
Compilation manager iteration, adds machinery for individual blueprint compilation, adds comments, cleans up duplicated code
Change 3416636 on 2017/05/01 by Phillip.Kavan
#jira UE-44505 - Potential fix for a low-repro crash tied to the Blueprint graph context menu.
Change summary:
- Switched FBlueprintActionInfo::ActionOwner to be a weak object reference.
Change 3416960 on 2017/05/01 by Dan.Oconnor
Use compilation manager when clicking the compile button, PIE'ing, etc
Change 3417207 on 2017/05/01 by Ben.Zeigler
Fix issue with None strings causing default value parsing failures
Add SetPinDefaultValueAtConstruction needed by some other changes
Change 3417519 on 2017/05/01 by Ben.Zeigler
Fix BP compile errors caused by local variables with invalid default values. There's no reason to set autogenerated here because the nodes are transient and invisible in the UI.
There is still a problem here, local variables are not getting their default values validated when type is changed, so you end up with an integer that has the default value of a struct.
Change 3418659 on 2017/05/02 by Ben.Zeigler
#jira UE-44534 Fix it so animation node pins get properly created autogenerated default values that are based on the node struct defaults. This fixes issues when they are reset to other defaults
#jira UE-44532 Fix it so connecting an animation asset pin on a node player resets the pin value to the autogenerated default instead of the cached asset. This was causing old unused assets to get unnecessarily cooked
Fix it so any animation node with an exposed pin that is an object property will reset that object propery when the pin is exposed. This fixes UE-31015 in a generic way
Change the OptionalPinManager to take a Defaults address as well as a current address, to allow setting autogenerated defaults properly
Remove Import/ExportKismetDefaultValueToProperty as they were redundant with PropertyValueFromString and were using the wrong pin setting functions, replaced with PropertyValueFromString_Direct and calling the schema pin set functions
I need to write some backward compatibility code to fix existing nodes, I'll do that in a later checkin
Change 3418700 on 2017/05/02 by Ben.Zeigler
Actually fix None object paths for real this time. I did not test sufficiently before
Change 3418811 on 2017/05/02 by Ben.Zeigler
Fix existing animation blueprint nodes with dead asset references duplicated by pins. This code can be applied independent of the other change to fix specific games
Change 3419165 on 2017/05/02 by Dan.Oconnor
Add misc. functionality from FKismetEditorUtilities::CompileBlueprint
Change 3419202 on 2017/05/02 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3417825
#rnx
Change 3419236 on 2017/05/02 by mason.seay
Removed OnPressed event from Widget BP
Change 3419314 on 2017/05/02 by Marc.Audy
Fix bad auto-resolve
#rnx
Change 3419524 on 2017/05/02 by Marc.Audy
PR #3528: Improved Input BP library node display names (Contributed by projectgheist)
#jira UE-44587
#rn Improved Input BP library node display names
Change 3419570 on 2017/05/02 by Zak.Middleton
#ue4 - Fix typo in TFunctionRef comment/example.
Change 3419709 on 2017/05/02 by Dan.Oconnor
Fix missing category metadata on SkeletonGeneratedClass when using compilation manager
Change 3419756 on 2017/05/02 by Dan.Oconnor
Remove unintentional verbosity increase
Change 3420875 on 2017/05/03 by Marc.Audy
Make IsExecPin static
Minor optimization to IsMetaPin
#rnx
Change 3420981 on 2017/05/03 by Marc.Audy
Change tagging temporarily until other changes are done so that we don't have warnings in the meantime
#rnx
Change 3421367 on 2017/05/03 by Marc.Audy
Manually introduce changes from CL# 3398673 in 4.16 that failed to make it to Dev-Framework as a result of the integration submitted as CL# 3401725.
#rnx
Change 3421685 on 2017/05/03 by Ben.Zeigler
#jira UE-23001 Convert literal Asset ID/Class ID pins to store path as string instead of as hard object reference. Old pins are fixed on load, after resaving the hard references will go away
Refactor the way that FStringAssetReference and FAssetPtr are serialized, it now does the various fixups in FStringAssetReference::SerializePath, which is called from archivers
Change it so the asset registry reads in a list of all scanned redirectors and adds them to GRedirectCollector, this means that saving a string asset reference will automatically fix it up to point to the redirector destination
Change the default behavior of FAssetPtr serialize on ArchiveUObject to match what most of it's children want, and remove several special case hacks. It now serializes as asset reference when saving/loading, and as object for other cases
Deprecate StringAssetReferenceLoaded/StringAssetReferenceSaving delegates, replace with PreSavePath and PostLoadPath on FStringAssetReference
Make AssetLongPathname private on FStringAssetReference, it was deprecated in 4.9
Change 3421728 on 2017/05/03 by Phillip.Kavan
Mirror CL 3408285 from //UE4/Release-4.16.
#jira UE-44124
#rnx
Change 3422370 on 2017/05/03 by Dan.Oconnor
Mirror 3422359
Implement UBlueprintGeneratedClass::NeedsLoadForEditorGame to match UBlueprint, also tag a class's CDO as NeedsLoadForEditorGame.
This prevents us from failing to load a UBlueprint's GeneratedClass when running the editor with -server.
#jira UE-44659
Change 3423192 on 2017/05/04 by Ben.Zeigler
CIS Fix
Change 3423305 on 2017/05/04 by Ben.Zeigler
Fix "Missing opening parenthesis" warnings for Vector and Rotator the same way they were fixed for Transform
Change 3423358 on 2017/05/04 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3422809
#rnx
Change 3423766 on 2017/05/04 by Ben.Zeigler
#jira UE-44680 Delete some corrupted redirectors that are no longer in use
Change 3423804 on 2017/05/04 by Dan.Oconnor
Honor SaveIntermediateCompilerResults when using compilation manager
Change 3424010 on 2017/05/04 by Marc.Audy
Validate that switch string cases are unique
Change 3424011 on 2017/05/04 by Marc.Audy
Re-fix switch node default pin not appearing as an exec output
Remove unused boolean
Change 3424071 on 2017/05/04 by Ben.Zeigler
Delete FixupRedirects commandlet, replace with -FixupRedirects/FixupRedirectors option on ResavePackages. This new method is much faster than the old commandlet as it uses the asset registry vs loading all packages, fixing up all redirectors in Fortnite only took about an hour vs 12+ hours the old way
Removed some hacky bits in Core that only existed to support FixupRedirects
Change it so the AssetRegistry listens to DirectoryWatcher callbacks in commandlets now that commandlets use the asset registry properly. This won't do anything unless you tick directory watcher the way that ResavePackages does
Change 3424313 on 2017/05/04 by Dan.Oconnor
Address missing property flags on SkeletonGeneratedClass when using compilation manager
#jira UE-44705
Change 3424325 on 2017/05/04 by Phillip.Kavan
#jira UE-44222 - Move nativized UDS implementation details into its own .cpp file in order to avoid circular dependencies.
Change summary:
- Modified IKismetCompilerInterface::GenerateCppCodeForStruct() to include an output parameter for CPP source and modified FKismet2CompilerModule to match the updated API.
- Modified IBlueprintCompilerCppBackend::GenerateCodeFromStruct() to include an output parameter for CPP source and modified FBlueprintCompilerCppBackendBase to match the updated API.
- Modified FBlueprintNativeCodeGenUtils::GenerateCppCode() to adjust the call to GenerateCppCodeForStruct() to include CPP source output.
- Modified FGatherConvertedClassDependencies::DependenciesForHeader() to switch UDS property dependencies to be forward declarations rather than includes (for default value init code).
- Modified FEmitDefaultValueHelper::GenerateGetDefaultValue() to emit implementation details to the 'Body' container, and adjust the header content to be a declaration only.
- Modified FIncludeHeaderHelper::EmitInner() to exclude a potentially-redundant line for the module's .h file, for the case when the caller has included the base filename in the 'AlreadyIncluded' set.
- Modified FEmitterLocalContext::FindGloballyMappedObject() to limit the 'TryUsedAssetsList' path to UClass conversions only (since that requires a UDynamicClass target to work).
- Modified FGatherConvertedClassDependencies::DependenciesForHeader() to only include BPGC fields if they are also being converted. Eliminates an issue with missing header files in generated code.
Change 3424359 on 2017/05/04 by Ben.Zeigler
Fix issue where StreamableManager would break when requesting an async load that failed the first time. Because our game supports downloading assets during gameplay it's not safe to assume it will never load again.
Port of CL #3424159
Change 3424367 on 2017/05/04 by Ben.Zeigler
Fix some asset manager warnings to not go off in invalid cases
Change 3425270 on 2017/05/05 by Marc.Audy
Pack booleans/enums in UEdGraphNode and FOptionalPinFromProperty
#rnx
Change 3425696 on 2017/05/05 by Ben.Zeigler
#jira UE-44672 Fix it so select node option pins get populated with default values properly
#jira UE-43927 Fix it so select node opion pin type is correctly maintained accross node recreation, as opposed to deriving from the attached pins
#jira UE-44675 Fix it to correctly refresh select node when switching from bool to integer index
Change 3425833 on 2017/05/05 by Ben.Zeigler
#jira UE-31749 Fix it so Undo works properly when modifying a local variable
#jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value
Change 3425890 on 2017/05/05 by Marc.Audy
Fix Copy/Paste of child actor components losing the template
#jira UE-44566
Change 3425947 on 2017/05/05 by Ben.Zeigler
This was meant to be part of last checkin
Change 3425959 on 2017/05/05 by Ben.Zeigler
#jira UE-44692 Fix it so only the sequentially last node can be removed from a Switch On Int, and for Switch On Name stop it from removing an exec pin if it's the only non-default one
Change 3425979 on 2017/05/05 by Dan.Oconnor
PVS fix
Change 3425985 on 2017/05/05 by Phillip.Kavan
Fix an uninitialized variable.
#rnx
Change 3426043 on 2017/05/05 by Ben.Zeigler
#jira UE-35583 Correctly refresh array node UI when connecting pins that change it away from wildcard
Change 3426174 on 2017/05/05 by Zak.Middleton
#ue4 - Avoid call to virtual getSimulationFilterData() to only use it when needed in PreFilter if we actually have items in the IgnoreComponents list (which is rare). The sim filter data 'word2' stores the component ID.
Change 3426621 on 2017/05/05 by Phillip.Kavan
#jira UE-44708 - Fix an issue that re-introduced component data loss in a non-nativized child Blueprint class with a nativized parent Blueprint class.
Change summary:
- Removed an unnecessary additional check I had for the presence of "-NativizeAssets" switch on the command line in UBlueprint::BeginCacheForCookedPlatformData(). This check was failing because the usage was recently changed to include an optional value. It was not needed anyway so I just removed it.
#rnx
Change 3426906 on 2017/05/05 by Ben.Zeigler
#jira UE-11189 Fix function/macro input default values to show as a pin customization instead of as a broken text box that doesn't work correctly for most types. This fixes enums and provide validation for other types
Types that don't have a customization (most structs) will now show any more, they did not work before either
#jira UE-21754 Hide function default values if pass by reference is set
Fix it so changing input parameter will also reset default value, to avoid having the wrong type value set and to work the same as local variables
Change 3426941 on 2017/05/05 by Dan.Oconnor
Fix determinstic cooking of LoadAssetClass nodes in macros
Change 3427021 on 2017/05/05 by Dan.Oconnor
Build fix, make initialization order in source match artifact
#rnx
Change 3427135 on 2017/05/05 by Phillip.Kavan
#jira UE-44702 - Restore code-based interface classes to Blueprint editor UI.
Change summary:
- Partially backed out CL# 3348513 to return to previous behavior for 4.16. The UI is no longer filtering on the __is_abstract() type trait for interface classes.
- Modified FNativeClassHeaderGenerator::ExportClassFromSourceFileInner() to emit the _getUObject() declaration for native interface types as a default implementation that returns NULL rather than as a pure virtual declaration.
#rnx
Change 3427144 on 2017/05/06 by Marc.Audy
Fix init order
#rnx
Change 3427146 on 2017/05/06 by Marc.Audy
remove stray semicolon
#rnx
Change 3427242 on 2017/05/06 by Phillip.Kavan
#jira UE-44744 - Fix a regression in which a UMG Widget Blueprint property not explicitly marked as a variable would cause Blueprint nativization to fail at package time.
Change summary:
- Modified FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() to only add 'Category' metadata when we set the 'CPF_BlueprintVisible' flag on the UProperty, which in is now tied to whether or not the property has been explcitly marked as a variable. This avoids a UHT warning when compiling the nativized codegen that would cause packaging to fail.
#rnx
Change 3427720 on 2017/05/08 by Dan.Oconnor
Backing out 3419202
#rnx
Change 3427725 on 2017/05/08 by Dan.Oconnor
SA fix
#rnx
Change 3427734 on 2017/05/08 by Dan.Oconnor
More exhaustive GEditor null checks, to appease SA
#rnx
Change 3427882 on 2017/05/08 by Marc.Audy
Properly order all booleans in intialization
#rnx
Change 3428049 on 2017/05/08 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3427804
#rnx
Change 3428523 on 2017/05/08 by Ben.Zeigler
#jira UE-44781 Refresh function input UI when blueprint graph refreshes, needed as pins may have gone away
Change 3428563 on 2017/05/08 by Ben.Zeigler
#jira UE-44783 If setting a hard reference pin type from a string, load the referenced object.
Change 3428595 on 2017/05/08 by Dan.Oconnor
Avoid node reconstruction when we're compiling a blueprint with no linker (e.g., a duplicated blueprint)
#jira UE-44777
Change 3428599 on 2017/05/08 by Ben.Zeigler
#jira UE-44789 Fix string asset renamer to not mark IsPersistent becuase that crashes in lightmap code, change it so the path fixup doesn't require the persistent flag
Change 3428609 on 2017/05/08 by Dan.Oconnor
Improved fix for UE-44777
#jira UE-44777
#rnx
Change 3429176 on 2017/05/08 by Phillip.Kavan
#jira UE-44755 - Fix nativization build errors when packaging a game project that is not IWYU-compliant for a build target that disables PCH files.
- Mirrored from //UE4/Release-4.16 (CL# 3429030).
#rnx
Change 3429198 on 2017/05/08 by Phillip.Kavan
CIS fix.
#rnx
Change 3429583 on 2017/05/08 by Ben.Zeigler
Fix SGraphPinClass to work properly after my changes to allow unloaded assets. For Class pins we need to store separate Runtime and Editor asset data objects, as one has _C and refers to the class, and the other doesn't and refers to the blueprint. The content browser wants the editor path, the pin defaults want the runtime path.
Change default value widgets to look more like properties widgets by forcing them to act as highlighted and disabling black background
Change 3429640 on 2017/05/08 by Marc.Audy
Fix issues with select nodes in macros connected to wildcard pins.
#jira UE-44799
#rnx
Change 3429890 on 2017/05/08 by Ben.Zeigler
Fix function/macro defaults to properly propagate when changed using the new edit UI
Refactor some code out of the details customization into the k2 schema
Disable defaults UI for object/class/interface hard references as it is disabled in KismetCompiler
Change 3429947 on 2017/05/08 by Michael.Noland
Core: Backing out CL# 3394352 (marking FDateTime and FTimespan nonexport member Tick with UPROPERTY()), which will re-break UE-39921 but fix UE-44418
There appears to be a more serious underlying issue with how the CDO is instanced which needs to be addressed
#jira UE-44418
#reimplementing 3411681 from Release 4.16
Change 3429987 on 2017/05/08 by Ben.Zeigler
#jira UE-44798 Do a better job of validating object paths saved as default values, due to an old bug with local variables some object paths are saved as struct exportext
At load time clear invalid default value for local variables
Add IsValidObjectPath to FPackageName that validates the passed in path would be valid to load with LoadObject
Change 3430392 on 2017/05/09 by Marc.Audy
Fix SA CIS error
#rnx
Change 3430747 on 2017/05/09 by Ben.Zeigler
#jira UE-44836 Don't reconstruct node during callback for param value changing, this can happen during a reconstruction and recursive reconstruction is unsafe
Don't call ModifyUserDefinedPinDefaultValue unless the default value has actually changed
Change 3431027 on 2017/05/09 by Marc.Audy
Fix BPRW mark up causing Ocean warnings
#rnx
Change 3431353 on 2017/05/09 by Marc.Audy
Fix UHT error due to exposing FJsonObjectWrapper to blueprints
#rnx
[CL 3431398 by Marc Audy in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
robert millar
zhikang shao
ben humphreys
bryan sefcik
sebastian nordgren
Thomas Sarkanen
Marcus Wassmer
Marc Audy
ryan durand
Ben Hoffman
Dan Oconnor
Phillip Kavan
Ben Marsh
Andrew Grant