65 Commits

Author SHA1 Message Date
jason walter
aaf893daaf Add timecode display to the animation editor viewport. This will include timecode, slate information, and rate as it was recorded on the animation sequence. If the display settings are off in the viewport tool bar or no timecode attributes are on the current sequence then the timecode, rate and slate value are not shown.
#jira UE-216582
#rb Nicholas.Frechette

[CL 35450731 by jason walter in ue5-main branch]
2024-08-12 09:24:40 -04:00
dave jones2
c4107f5283 UE-196156 - Add exec toggle for pure nodes
Blueprint pure nodes were initially intended to be similar to "functional pure". In other words, they're deterministic and produce no side effects (eg: doesn't mutate state). However, pure nodes have violated both conditions for a while now.

Instead, pure nodes are simply function nodes with output values and no visible exec pins. While this can be convenient, they come with a downside: the pure node is evaluated for each connected output. This can lead to unexpected performance issues if the node is expensive to evaluate. In the case of non-deterministic nodes, this can lead to unexpected behavior. In both cases, the user often needs to cull multiple outputs of a pure node and cache the result manually.

The solution here is to add support for toggling purity at the call site. When a function node is placed, right-clicking on it and selecting either "Hide Exec pins" or "Show Exec Pins" will toggle purity. Additionally, the meaning of BlueprintPure and the "Pure" check box changes slightly: it now means that the function node _defaults_ to a pure state when placed in a graph. However, it can be toggled to show its exec pins.

In future changes, we'll also reevaluate which common library functions should continue to default as pure.

#jira UE-196156
#rb dan.oconnor, jodon.karlik, ben.zeigler

[CL 35309072 by dave jones2 in ue5-main branch]
2024-08-05 11:58:15 -04:00
yoan stamant
938f456b05 Moved UserDefinedStruct to CoreUObject
#jira UE-216472
#rb Devin.Doucette

[CL 34495793 by yoan stamant in ue5-main branch]
2024-06-19 08:00:57 -04:00
gary yuan
f85b2347ba [Backout] - CL34482589
[FYI] Yoan.StAmant
Original CL Desc
-----------------------------------------------------------------
Moved UserDefinedStruct to CoreUObject
#jira UE-216472
#rb Devin.Doucette

[CL 34486763 by gary yuan in ue5-main branch]
2024-06-18 20:05:51 -04:00
yoan stamant
b9344fb62e Moved UserDefinedStruct to CoreUObject
#jira UE-216472
#rb Devin.Doucette

[CL 34482607 by yoan stamant in ue5-main branch]
2024-06-18 17:57:11 -04:00
keith yerex
83842c3f8e Blueprint function to access root transforms from an AnimSequence
#rb Jurre.deBaare

[CL 33079884 by keith yerex in ue5-main branch]
2024-04-18 14:23:47 -04:00
steve robb
f8d47335a4 Replaced RemoveAt(N, 1, EAllowShrinking::*) with RemoveAt(N, EAllowShrinking::*).
[CL 31626444 by steve robb in ue5-main branch]
2024-02-19 16:51:58 -05:00
aris theophanidis
7192b9d0a2 Remove text.h from script.h (script.h is included by object.h)
#rb Yoan.StAmant

[CL 30776575 by aris theophanidis in ue5-main branch]
2024-01-22 11:52:48 -05:00
steve robb
6d5b974842 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30735396 by steve robb in ue5-main branch]
2024-01-19 19:41:56 -05:00
shchavinskyi
6efc713fbc PR #10124: AnimationBlueprintLibrary Curve Functions
#jira UE-177275
#rb Thomas.Sarkanen

[CL 30037201 by shchavinskyi in ue5-main branch]
2023-12-01 07:19:43 -05:00
shchavinskyi
6e4d2301c8 Undo changelist 29838857
PR #10124: AnimationBlueprintLibrary Curve Functions
#ushell-cherrypick of 24248270 by UnrealBot
#jira UE-177275
#rb Thomas.Sarkanen

[CL 29839207 by shchavinskyi in ue5-main branch]
2023-11-20 07:22:30 -05:00
shchavinskyi
0b80f36be3 PR #10124: AnimationBlueprintLibrary Curve Functions
#ushell-cherrypick of 24248270 by UnrealBot
#jira UE-177275
#rb Thomas.Sarkanen

[CL 29838867 by shchavinskyi in ue5-main branch]
2023-11-20 06:36:25 -05:00
steve robb
51f3ea53ae Removed ChooseClass.h includes.
#rb trivial

[CL 27823723 by steve robb in ue5-main branch]
2023-09-13 05:43:01 -04:00
jurre debaare
fa256cd2f3 Allow users to specify bForceRootLock when sampling poses via AnimPose API
#jira UE-188193
#rb Thomas.Sarkanen, Euan.Carmichael

[CL 26767101 by jurre debaare in ue5-main branch]
2023-08-02 05:38:23 -04:00
max chen
dc036c590a Sequencer: Check for valid skeleton in EvaluateRootBoneTimecodeAttributesAtTime
#rb mike.zyracki

[CL 26746830 by max chen in ue5-main branch]
2023-08-01 14:08:12 -04:00
thomas sarkanen
295f81df17 Fix crash from incorrect bone index type usage in UAnimationSequencerDataModel::GeneratePoseData
Also fixed bone index usage in FAnimPose::GetPose

#rb Nicholas.Frechette
[FYI] Jurre.deBaare

[CL 26482431 by thomas sarkanen in ue5-main branch]
2023-07-20 07:41:53 -04:00
stan hormell
35591ff46d [Backout] - CL26178322 - CIS Issue 324063
[FYI] Jurre.deBaare
Original CL Desc
-----------------------------------------------------------------
Added UFunction missing deprecation/message keywords to deprecated Animation APIs
#rb Thomas.Sarkanen
#ushell-cherrypick of 26178265 by Jurre.deBaare

[CL 26198808 by stan hormell in ue5-main branch]
2023-06-22 19:16:46 -04:00
Jurre deBaare
e651178f8e Added UFunction missing deprecation/message keywords to deprecated Animation APIs
#jira none
#rb Thomas.Sarkanen

[CL 26178265 by Jurre deBaare in ue5-main branch]
2023-06-22 06:06:09 -04:00
nick baltis
61b7cf81c7 Variable Frame Stripping
Swarm review [at] https://p4-swarm.epicgames.net/reviews/25771279
https://horde.devtools.epicgames.com/job/6480c6078417d79259d7b71c

Added functionality to strip at ratios higher 1 out of every 2. testing shows good savings at stripping 2/3 frames on NX64 and in editor of around 8mb with no noticeable visual degradation.

Works through the VariableFrameStripping object that is a member of the AnimSequence.

Fixed issue with valkyrie

[CL 25857620 by nick baltis in ue5-main branch]
2023-06-07 16:48:21 -04:00
euan carmichael
15d2deee56 Reinstate some anim blueprint library methods which now use the Anim Pose api.
#jira UE-186382
#rb Thomas.Sarkanen
#lockdown aurel.cordonnier

[CL 25829981 by euan carmichael in ue5-main branch]
2023-06-06 17:54:21 -04:00
hilda cruz
a43cbb3322 [Backout] - CL25804385 for a BH issue
#rnx
[FYI] nick.baltis
Original CL Desc
-----------------------------------------------------------------
Variable Frame Stripping
Swarm review [at] https://p4-swarm.epicgames.net/reviews/25771279

Added functionality to strip at ratios higher 1 out of every 2. testing shows good savings at stripping 2/3 frames on NX64 and in editor of around 8mb with no noticeable visual degradation.

Works through the VariableFrameStripping object that is a member of the AnimSequence.

Fixed issue with valkyrie

[CL 25809604 by hilda cruz in ue5-main branch]
2023-06-05 22:13:54 -04:00
nick baltis
a400eefa24 Variable Frame Stripping
Swarm review [at] https://p4-swarm.epicgames.net/reviews/25771279

Added functionality to strip at ratios higher 1 out of every 2. testing shows good savings at stripping 2/3 frames on NX64 and in editor of around 8mb with no noticeable visual degradation.

Works through the VariableFrameStripping object that is a member of the AnimSequence.

Fixed issue with valkyrie

[CL 25804411 by nick baltis in ue5-main branch]
2023-06-05 17:26:01 -04:00
bryan sefcik
ecd9fa8a99 Removed dependencies that aren't needed by the modules that declare them. This is to help fix bad circular dependencies in the engine.
#preflight 647b5f919c5bac5c6f8be490
#jira

[CL 25782459 by bryan sefcik in ue5-main branch]
2023-06-03 15:25:01 -04:00
jurre debaare
7992f2536e Determine the location of a Socket in an Animation Sequence
#feature added functionality to FAnimPose API to retrieve animated Socket transforms
#misc ptr safety check
#rb Thomas.Sarkanen
#preflight 6470af2ad1157dc4a7f9b372

[CL 25648056 by jurre debaare in ue5-main branch]
2023-05-26 13:05:06 -04:00
edwin maynard
c98b625c8e [Backout] - CL25515851 (backed out due to cis issues)
[FYI] nick.baltis
Original CL Desc
-----------------------------------------------------------------
Due to Backout files marked for add could not show latest revision forcing me to submit this change directly though p4v.
Swarm review [at] https://p4-swarm.epicgames.net/reviews/25450246

Added functionality to strip at ratios higher 1 out of every 2. testing shows good savings at stripping 2/3 frames on Nx64 and in editor of around 8mb with no noticeable visual degradation.
Origional Cvar ssytem replaced with VariableFrameStrippingSettings Oject which is a member of AnimSequence. It contains PerPlatform variables for enableing the system and its rate.
The move to a member object wrapping around these settings were two fold. First to better mas change anim sequences by platform while also allowing for varried settings for edge cases. Second becuase due to the fact this affects objects in the cook, gateing it behind a cvar provides no hot fix saftey while hurting useability.

[CL 25521647 by edwin maynard in ue5-main branch]
2023-05-18 00:54:19 -04:00