202 Commits

Author SHA1 Message Date
ionut matasaru
973ace10b0 Marked the Profiler* modules as deprecated. The old Profiler is actually deprecated since UE 5.0, superceeded by Trace/UnrealInsights.
#rb Catalin.Dragoiu, Johan.Berg

[CL 36387437 by ionut matasaru in 5.5 branch]
2024-09-18 08:52:26 -04:00
patrick boutot
e046478394 Slate: Deprecate SListView::ItemHeight and STreeViewItemHeight. ItemHeight and ItemWidth are only used when the panel is is as a tile or both value are assigned. With TreeView and ListView, you can't assigned both. The function are protected, a subclass of those could but it's up to them to expose the ItemHeight and ItemWidth. This behavior changed was introduced with CL 7634094.
#jira UE-210415
#rb editor-ui-systems

[CL 33404292 by patrick boutot in ue5-main branch]
2024-05-02 14:31:41 -04:00
steve robb
f8d47335a4 Replaced RemoveAt(N, 1, EAllowShrinking::*) with RemoveAt(N, EAllowShrinking::*).
[CL 31626444 by steve robb in ue5-main branch]
2024-02-19 16:51:58 -05:00
steve robb
f43fc1d782 Fixed up more bool-taking calls to take EAllowShrinking instead.
[CL 30894388 by steve robb in ue5-main branch]
2024-01-25 14:09:12 -05:00
ionut matasaru
ed269bdc8e Another fix for "implicit conversion" errors in Profiler module.
#rnx

[CL 28346949 by ionut matasaru in ue5-main branch]
2023-09-29 13:14:54 -04:00
ionut matasaru
d5f2f2ae8b Fixed more "implicit conversion" errors in Profiler module.
#rnx

[CL 28346117 by ionut matasaru in ue5-main branch]
2023-09-29 12:53:57 -04:00
ionut matasaru
f779325956 Fixed "implicit conversion" errors in Profiler module.
#rnx

[CL 28343869 by ionut matasaru in ue5-main branch]
2023-09-29 11:36:18 -04:00
ionut matasaru
b2fbebf9b7 Enabled UnsafeTypeCast warnings as errors in Profiler, ProfilerClient, PerfCounters modules.
#rb Catalin.Dragoiu

[CL 28342235 by ionut matasaru in ue5-main branch]
2023-09-29 10:32:44 -04:00
robert manuszewski
3e763f018b Fixing compile errors ahead of enabling TObjectPtr GC barrier
#rb trivial

[CL 26868195 by robert manuszewski in ue5-main branch]
2023-08-05 02:54:45 -04:00
ionut matasaru
0ccbd0fcde Added UE_STATS_MEMORY_PROFILER_ENABLED to toggle on/off code related to MemoryProfiler in STATS system. It still requires STATS to be enabled and "-MemoryProfiler" to be specified in cmd line.
This is off by default as MemoryProfiler in STATS system functionality is deprecated in UE 5.3. For memory profiling, use instead Trace/MemoryInsights and/or LLM.

#jira UE-183900
#rb Johan.Berg
#preflight 64428b470206a6e20f579812

[CL 25145603 by ionut matasaru in ue5-main branch]
2023-04-21 10:47:57 -04:00
David Harvey
aba045960b Add LLM tags to session profiler.
#jira UE-153267
#rnx
#rb trivial
#preflight 6411eb4e924023147d9fd355

[CL 24656359 by David Harvey in ue5-main branch]
2023-03-15 12:22:30 -04:00
David Harvey
0158397359 Legacy Session Frontend profiler should be less likely to lose the connection during live data preview.
Root cause was the Editor/UFE framerate dropping too low when there was a lot of stat data arriving. This meant the keep-alive Ping request from the game could not be acknowledged fast enough to avoid the 5s disconnection timeout.

 - decompress incoming stat messages via a task pipe to avoid saturating all cores.
 - only process a few stat messages per frame.
 - reduce the timeslice for stat aggregation during live data preview.

However, if bandwidth is saturated (typically by a very large amount of log spam being sent to the Session Frontend too) then the connection can still be lost.

Note: It's recommended to use Unreal Insights instead of the Session Profiler for UE5.

#jira UE-174072
#rb Ionut.Matasaru, Francis.Hurteau
#rnx
#preflight 63ca5570894b640314806628

[CL 23787313 by David Harvey in ue5-main branch]
2023-01-20 04:03:59 -05:00
Andriy Tylychko
c1a38f5f28 deprecated a couple of stats methods that take TArray arg and provided a version with TArray64 to handle big stats files
#jira UE-172852
#preflight 63be962cde27f9bc45a9f14c

[CL 23645295 by Andriy Tylychko in ue5-main branch]
2023-01-11 10:07:13 -05:00
Andrew Rodham
4ff7bab147 Slate: Initial phase of FVector2D deprecation
- Expanded FDeprecateSlateVector2D to provide structs for parameters, return types and member variables that use FVector2f, while still allowing conversion to/from FVector2d with optional per-module deprecation mechanisms.
  - Many of the high-traffic SlateCore types like FSlateBrush, FGeometry and FSlateLayoutTransform have been converted to use these deprecation mechanisms.
  - Some legacy FGeometry::ToPaintGeometry and MakeChild overloads have been explicitly deprecated since they cause ambiguous overloads with FSlateLayoutTransform if it were to support implicit construction.
  - Deprecated ULocalPlayer::GetPixelBoundingBox and GetPixelPoint to prefer FVector2f for OptionalAllotedSize parameter since this parameter is expected to come from FGeometry
  - Exposed FVector2f members to blueprints

#jira none
#rb Andy.Davidson, Dave.Jones, Vincent.Gauthier, Patrick.Boutot
#preflight 63bc6fd068068a8bd6027c9f

[CL 23631073 by Andrew Rodham in ue5-main branch]
2023-01-10 14:46:43 -05:00
Andriy Tylychko
484b0188b4 remaining fixes for renaming TaskGraph -> ProfileVisualizer module
#preflight 639b1dae35203bc7aa551cb7

[CL 23526231 by Andriy Tylychko in ue5-main branch]
2022-12-15 08:56:31 -05:00
joe pribele
1d8537f20b changed PRAGMA_DISABLE_OPTIMIZATION to UE_DISABLE_OPTIMIZATION_SHIP
#preflight 6372ba60ee4d25f90ae3d207

[CL 23128414 by joe pribele in ue5-main branch]
2022-11-14 17:31:05 -05:00
ionut matasaru
26ef7c55b1 Fixed unsafe type cast warnings in Profiler and ProfilerClient modules.
#jira UE-166275
#rb Catalin.Dragoiu
#preflight 6352623e777a77c4403df7ee

[CL 22686686 by ionut matasaru in ue5-main branch]
2022-10-21 06:50:44 -04:00
bryan sefcik
892629fe83 Fixed some paths that got updated to include the full "ThirdParty" path.
#jira
#preflight 6320877bbc40358fa2995069

[CL 21997782 by bryan sefcik in ue5-main branch]
2022-09-13 21:48:33 -04:00
bryan sefcik
a3dddc6630 Pass 1 on Developer include fixes:
Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.

#jira
#preflight 631e281694758d0bf2ea1399

[CL 21960082 by bryan sefcik in ue5-main branch]
2022-09-11 18:32:18 -04:00
UnrealBot
73409369c0 Branch snapshot for CL 21319338
[CL 21319338 in ue5-main branch]
2022-08-10 16:03:37 +00:00
marc audy
cd4b7d3c78 Game user settings fix and rollback of 20905839, which was itself a rollback of 20029182
#rb [at]Josh.Adams
#preflight

#ROBOMERGE-OWNER: marc.audy
#ROBOMERGE-AUTHOR: mic.rooney
#ROBOMERGE-SOURCE: CL 20973575 via CL 20978259
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
#ROBOMERGE-CONFLICT from-shelf

[CL 20980862 by marc audy in ue5-main branch]
2022-07-07 01:55:35 -04:00
mic rooney
f5a58f4e71 Temp backout while Josh is out so that we don't break workflows and he can re-backout/unrevert this when he's back in.
* Contains some selected back outs from other cls that included config context dependent changes, though it's limited to only backing out broken parts as much as possible to minimize surface area.

[Backout] - CL20029182
[FYI] josh.adams
Original CL Desc
-----------------------------------------------------------------
- Adding FConfigContext which is used to repalce LoadExternalIniFile, LoadLocalIniFile, etc, as well as have localized data for all configs read on a thread (like the other platform configs loaded in the editor)
- The Load*IniFile functions will create a Context, but eventually those APIs will go away and the Context will be the only way to load ini files
- Simplified some of the ini loading code, like removing the HierarchyCache (it wasn't helping editor load times, and added much complexity, and was not thread-safe, and it shouldn't actually be helpful because all the calls to Load*IniFile should eventually be replaced with either GConfig or FCOnfigCacheIni::ForPlatform(), which won't need to re-read in files
- Ini reading time actually went down due to the simplification, including Cache removal
- Left in old code for now behing a #define (USE_CONTEXT) in case something goes wrong
- Added in VERIFY_CONTEXT mode which I used to run original and Context modes and compare (including preflighting builds) (I also added a Compare function that we may want to keep around to use for future debugging)
- Added a separate set of config layers for plugins which speeds up plugin parsing, but also will fix the issue with BaseEngine.ini vs DefaultEngine.ini in Engine vs Project plugins (this shows how Contexts can bring useful information down into the guts - however a later change will enable it)
- Once this is all seen to be working, I will clean up the non-Context functions, and some globals vs static members, etc
#rb paul.chipchase
#preflight 62716c1c5e6ce673f452005a


#ROBOMERGE-AUTHOR: josh.adams
#ROBOMERGE-SOURCE: CL 20029165 via CL 20029180 via CL 20905839 via CL 20905880
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20908094 by mic rooney in ue5-main branch]
2022-06-30 20:54:32 -04:00
Steve Robb
e7d90e65e8 Fixes for enum/int/float mismatches which warn under C++20 builds.
#rb devin.doucette
#jira none
#preflight 62a29a7ecc30ea8a284fb0e1

[CL 20603371 by Steve Robb in ue5-main branch]
2022-06-10 17:36:52 -04:00
lauren barnes
c95b2d31c4 Updating developer modules relying on Editor styles
#rb trivial
#jira UE-155158
#preflight 62964a4b95336ad2bfc79f49

#ROBOMERGE-OWNER: lauren.barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20440663 via CL 20442312 via CL 20442429 via CL 20442440
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20449508 by lauren barnes in ue5-main branch]
2022-06-01 04:24:16 -04:00
josh adams
46a830d6b4 - Replacing many uses of LoadGlobalIniFile and LoadExternalIniFile with FCOnfigContext
#rb matt.peters
#p4v-preflight-copy 20293528
#preflight 629665d15238916c514359ad

[CL 20441581 by josh adams in ue5-main branch]
2022-05-31 16:25:06 -04:00