902 Commits

Author SHA1 Message Date
a bialokozowicz
8be6ec6511 Fix "Update Redirector References" process unable to fix up redirectors of assets used in level instances
#jira UE-217737
#rb JeanFrancois.Dube

[CL 37274448 by a bialokozowicz in 5.5 branch]
2024-10-18 13:26:36 -04:00
kevin macaulayvacher
2576f229f2 Changes FAssetHeaderPatcherInner to leverage the CoreRedirect system for resolving FNames in a package header, and string paths when context about the string itself is well known (i.e. we know the string data is a stringified ObjectPath/PackagePath, or ObjectName are deducible). We still make use of string scanning replacement mechanism but those are now constrained to only patching strings content specifically (e.g. Tag data)
- Added FAssetHeaderPatcher::FContext for storing data on how to perform a patch (which redirects to follow, string -> string replacement map). Allows for an extensibility point for encapsulating special case patching so we don't need to  rely on string->string mappings exclusively
- Added `virtual FArchive& operator<<(FTopLevelAssetPath& Value)` to `FActorDescArchive` to allow for patching of FTopLevelAssetPath directly. Without this overload the FNames within a FTopLevelAssetPath would be patched one at a time losing all context about what the FNames are.
- Removed IAssetTools::GetAdditionalPatchCopyMappings, GetPatchCopyMappingsForRootRename, and PatchCopyPackageFile as these methods were internal and using the patcher directly should be preferred.
- Added some unit tests for the FAssetHeaderPatcherInner implementation works to codify the assumptions and expectations of the patcher implementation

Set use HeaderPatching as true by default for CopyProjectWithHeaderPatching. AdvancedCopy still disables header patching (to be enabled in a follow-up change)

#rnx
#rb Dave.Belanger
[FYI] Francis.Hurteau
#p4v-cherrypick 36706626, 36741243

[CL 36858806 by kevin macaulayvacher in 5.5 branch]
2024-10-04 09:42:40 -04:00
kevin macaulayvacher
1a8ac06fbb [Backout] - CL36700789
[FYI] kevin.macaulayvacher
Original CL Desc
-----------------------------------------------------------------
Changes FAssetHeaderPatcherInner to leverage the CoreRedirect system for resolving FNames in a package header, and string paths when context about the string itself is well known (i.e. we know the string data is a stringified ObjectPath/PackagePath, or ObjectName are deducible). We still make use of string scanning replacement mechanism but those are now constrained to only patching strings content specifically (e.g. Tag data)

- Added FAssetHeaderPatcher::FContext for storing data on how to perform a patch (which redirects to follow, string -> string replacement map). Allows for an extensibility point for encapsulating special case patching so we don't need to  rely on string->string mappings exclusively
- Added `virtual FArchive& operator<<(FTopLevelAssetPath& Value)` to `FActorDescArchive` to allow for patching of FTopLevelAssetPath directly. Without this overload the FNames within a FTopLevelAssetPath would be patched one at a time losing all context about what the FNames are.
- Removed IAssetTools::GetAdditionalPatchCopyMappings, GetPatchCopyMappingsForRootRename, and PatchCopyPackageFile as these methods were internal and using the patcher directly should be preferred.
- Added some unit tests for the FAssetHeaderPatcherInner implementation works to codify the assumptions and expectations of the patcher implementation

New patching changes are left disabled by default

#rnx

#rb Dave.Belanger, JeanFrancois.Dube

[CL 36764539 by kevin macaulayvacher in 5.5 branch]
2024-10-01 20:43:42 -04:00
kevin macaulayvacher
73861a1e58 Changes FAssetHeaderPatcherInner to leverage the CoreRedirect system for resolving FNames in a package header, and string paths when context about the string itself is well known (i.e. we know the string data is a stringified ObjectPath/PackagePath, or ObjectName are deducible). We still make use of string scanning replacement mechanism but those are now constrained to only patching strings content specifically (e.g. Tag data)
- Added FAssetHeaderPatcher::FContext for storing data on how to perform a patch (which redirects to follow, string -> string replacement map). Allows for an extensibility point for encapsulating special case patching so we don't need to  rely on string->string mappings exclusively
- Added `virtual FArchive& operator<<(FTopLevelAssetPath& Value)` to `FActorDescArchive` to allow for patching of FTopLevelAssetPath directly. Without this overload the FNames within a FTopLevelAssetPath would be patched one at a time losing all context about what the FNames are.
- Removed IAssetTools::GetAdditionalPatchCopyMappings, GetPatchCopyMappingsForRootRename, and PatchCopyPackageFile as these methods were internal and using the patcher directly should be preferred.
- Added some unit tests for the FAssetHeaderPatcherInner implementation works to codify the assumptions and expectations of the patcher implementation

New patching changes are left disabled by default

#rnx

#rb Dave.Belanger, JeanFrancois.Dube

[CL 36764489 by kevin macaulayvacher in 5.5 branch]
2024-10-01 20:42:58 -04:00
matt peters
989075aa0e Remove unnecessary check on full object path length
#rb thomas.sarkanen
#rnx
#ushell-cherrypick of 36486113 by gil.jaysmith

[CL 36752932 by matt peters in 5.5 branch]
2024-10-01 18:46:15 -04:00
robert rouhani
c9f59db7b1 Include all subcategories specified by UAssetDefinition in the New Content menu, instead of only using the first subcategory
#rb logan.buchy
#rnx

[CL 36317860 by robert rouhani in 5.5 branch]
2024-09-16 17:35:26 -04:00
rex hill
cbc63ec3ac Editor - When creating assets call new delegate to customize when to set package flag NotExternallyReferenceable
#rnx
#rb Dave.Belanger

[CL 36245385 by rex hill in 5.5 branch]
2024-09-12 17:02:59 -04:00
Ryan Hummer
4af2fd066d Updating Dev-Release-5.5 from Main at CL #36144969
#okforversepublic

[CL 36146571 by Ryan Hummer in Dev-5.5 branch]
2024-09-10 10:26:02 -04:00
aditya ravichandran
95977d05fe TEDS Content Browser:
Add folder and asset colors to TEDS
Remove the ItemName_ExperimentalColumn and replace with FNameColumn
Add extension utils to the CB to get/set folder colors
Add a new FFolder tag used by path rows
Remove test asset data and repurpose AssetProcessors.cpp to sync asset/folder data to and from TEDS
Modify the AssetDataLabel widget to show folder/asset colors

TEDS UI:
Add a new FSlateColor column and create a widget to view/edit it



#jira UE-221631
#rb Julien.StJean

[CL 36039406 by aditya ravichandran in ue5-main branch]
2024-09-05 10:36:43 -04:00
eric boucher
9f47fb79b5 Added another dialog option in the new LocalizedAssetTools
#jira UE-216348

[CL 35972463 by eric boucher in ue5-main branch]
2024-09-03 13:23:37 -04:00
dan oconnor
5d7327830d Null check before checking if NewObject is in the temporary package
#rb jordan.hoffmann
#jira UE-222817
[RN] Fixed crash when diffing assets in inactive plugins

[CL 35873890 by dan oconnor in ue5-main branch]
2024-08-28 13:32:53 -04:00
eric boucher
013a4849c8 Hotfix for cast precision lost
#jira UE-216348
#rnx

[CL 35806490 by eric boucher in ue5-main branch]
2024-08-26 15:04:22 -04:00
eric boucher
26d5dc1c35 Hotfix for implicit casting ints to floats
#jira UE-216348
#rnx

[CL 35805881 by eric boucher in ue5-main branch]
2024-08-26 14:54:42 -04:00
eric boucher
05f01fd839 Hotfix for implicit casting from ints to floats
#jira UE-216348
#rnx

[CL 35805822 by eric boucher in ue5-main branch]
2024-08-26 14:54:12 -04:00
eric boucher
ef71ea2b5b New localization option to move localized variants alongside source asset in the content browser and another one to detect if those localized variants are only in Revision Control:
- Project Settings / Editor / Assets / Internationalization / Rename Localized Variants Alongside Source Asset (defaults to: true)
 - Project Settings / Editor / Revision Control / Internationalization / Requires Revision Control to Rename Localizable Assets (defaults to: false) (works only with Perforce)

#jira UE-216348
#rb Jamie.Dale, wouter.burgers
[RN]

[CL 35804579 by eric boucher in ue5-main branch]
2024-08-26 14:02:18 -04:00
andrea botti
2ebe050d72 [ContentBrowser] Thumbnail Playback Indicator
#jira UE-216440
#rb aditya.ravichandran, ben.hoffman

[CL 35693075 by andrea botti in ue5-main branch]
2024-08-21 06:09:31 -04:00
alexis matte
690485dca1 Fix localisation error
#jira UE-222228
#rb jeanluc.corenthin
#rnx

[CL 35668883 by alexis matte in ue5-main branch]
2024-08-20 16:46:43 -04:00
alexis matte
29b1b1f8f7 Fix crash in UAssetToolsImpl::CreateAssetWithDialog where the UFactory::GetSupportedClass() is deferenced without check if its null.
#jira UE-220877
#rb JeanLuc.Corenthin
#rnx

[CL 35628488 by alexis matte in ue5-main branch]
2024-08-19 12:32:42 -04:00
eric knapik
326df70ce8 Undo CL: 35599474
Static initialization on startup

[FYI] andrea.botti

[CL 35610973 by eric knapik in ue5-main branch]
2024-08-16 18:59:53 -04:00
andrea botti
b9f350d86e [ContentBrowser] Thumbnail Playback Indicator
#rb aditya.ravichandran, ben.hoffman, Brian.Chrisman
#jira UE-216440

[CL 35599483 by andrea botti in ue5-main branch]
2024-08-16 13:24:27 -04:00
jeanfrancois dube
b76aa9d3c8 [World Partition] Remove assert when trying to use advanced copy on a partitioned world with streaming enabled, since it now works.
#rb vincent.beauchemin

[CL 35593322 by jeanfrancois dube in ue5-main branch]
2024-08-16 09:58:10 -04:00
dave belanger
869e58024d - Expose IAssetTools::GetAdditionalPatchCopyMappings and added a exclusion check for external actor/object assets
- Rename IAssetTools::GetMappingsForRootPackageRename to GetPatchCopyMappingsForRootRename for clarity
#rb Francis.Hurteau, kevin.macaulayvacher
#rnx

[CL 35562044 by dave belanger in ue5-main branch]
2024-08-15 09:59:29 -04:00
andrew phillips
a05a432db0 Gathering dependencies now includes ExternalObjects.
Correction for External(Objects|Actors) path destination path generation.

#rb Francis.Hurteau, kevin.macaulayvacher, Richard.Malo

[CL 35418159 by andrew phillips in ue5-main branch]
2024-08-09 06:02:57 -04:00
stu mckenna
c7191ce23e - Change Cascade asset creation name from Legacy to Deprecated
#rb Patrick.Kelly
#rnx
#tests Created Cascade asset, observed change in text

[CL 35281962 by stu mckenna in ue5-main branch]
2024-08-02 14:25:29 -04:00
andrew phillips
4a38a736de Redo for fix for Header patching of greybox level.
Addition fix for when copying to a name_[0-9]+ project.
Additional better logging should the FName writter fail. (now unlinky due to additional FName table entries being genorated on demand.)

#rb kevin.macaulayvacher

[CL 34670457 by andrew phillips in ue5-main branch]
2024-06-26 05:40:55 -04:00