140 Commits

Author SHA1 Message Date
elliot colp
190e0c7300 [WebRemoteControl] Fix bool property updates not being sent when a single bool property has changed
#jira UE-225092
#rb jeremie.roy

[CL 36748900 by elliot colp in 5.5 branch]
2024-10-01 18:00:55 -04:00
Ryan Hummer
4af2fd066d Updating Dev-Release-5.5 from Main at CL #36144969
#okforversepublic

[CL 36146571 by Ryan Hummer in Dev-5.5 branch]
2024-09-10 10:26:02 -04:00
jean perrier
63bdaf084b [WebRemoteControl] Http Route handler: Fix error paths of Preset Set Controller.
The rules for http route handlers:
- OnComplete callback must be called only once. some utils like ValidateContentType and DeserializeRequest already call OnComplete with an error message.
- If OnComplete callback is invoked, the handler must return true, even if the request didn't succeed (had some error), it is still considered "handled".

#jira UE-217594
#rb jeremie.roy

[CL 35147758 by jean perrier in ue5-main branch]
2024-07-29 15:04:24 -04:00
jean perrier
16759d3eae [Remote Control] Reverting fix for UE-215856 as it breaks the stage app.
#jira UE-220197
#rb Elliot.Colp

[CL 35115968 by jean perrier in ue5-main branch]
2024-07-26 14:49:59 -04:00
jean perrier
f9a97c86f2 [WebRemoteControl] Support for jpeg thumbnails and correctly identify the mime types in header (include svg for slate brushes)
#jira UE-215857
#rb jeremie.roy

[CL 34017819 by jean perrier in ue5-main branch]
2024-05-30 18:56:44 -04:00
jean perrier
e55a8a8a93 [WebRemoteControl] Fix Websocket http message wrapper to propagate the RequestId correctly from the incoming MessageId.
#jira UE-215856
#rb Matt.Chapman

[CL 33948049 by jean perrier in ue5-main branch]
2024-05-28 14:53:53 -04:00
jean perrier
5a40de675a [WebRemoteControl] Fixing API inconsistency with PresetGet/SetController routes. It should support either the Preset Name or Id to be consistent with the other routes.
#jira UE-215166
#rb Denys.Dubinin

[CL 33737689 by jean perrier in ue5-main branch]
2024-05-17 17:11:20 -04:00
jason walter
2ad93f6889 Add in IPAddress header to avoid NonUnity compilation issue
#jira UE-214707
#rnx

[CL 33582762 by jason walter in ue5-main branch]
2024-05-10 14:44:14 -04:00
josh adams
a1a04270b5 - Moved FConsoleManager to be actually private, just by moving the class decl into the .cpp. There were a lot of uses of #include "HAL/ConsoleManager.h" instead of IConsoleManager.h (and unknown number of licensee uses), so I left that file there and it just includes IConsoleManager.h now.
- Fixed up a couple of uses of FConsoleManager when IConsoleManager is the correct usage
#rb David.Harvey, Tim.Smith

[CL 32183192 by josh adams in ue5-main branch]
2024-03-12 12:40:07 -04:00
steve robb
09ac803581 More bool to EAllowShrinking fixes.
[CL 31120031 by steve robb in ue5-main branch]
2024-02-02 05:09:35 -05:00
steve robb
7da84c1d1b Replaced UE_NODISCARD with [[nodiscard]].
[CL 30593744 by steve robb in ue5-main branch]
2024-01-12 10:47:04 -05:00
andrea botti
61195ecf40 [RemoteControl]
Adding controller description and made controller name unique

#rb Jean.Perrier

[CL 30514616 by andrea botti in ue5-main branch]
2024-01-09 15:36:16 -05:00
andrea botti
3597cc6867 [RemoteControl]
Better error in RC, both for the Editor and the API.

#rb jeremie.roy, Simon.Therriault

[CL 30082923 by andrea botti in ue5-main branch]
2023-12-04 10:58:52 -05:00
andrea botti
745b6fad83 [RemoteControl]
Add Getter path when Reading Property.

#rb jeremie.roy

[CL 29840190 by andrea botti in ue5-main branch]
2023-11-20 08:37:10 -05:00
joe pribele
1e6438eb61 combining FObjectPropertyPtr and FObjectProperty and FClassPropertyPtr and FClassProperty together
simplifies usage of Object Properties and fixes a few edge cases

see zousar.shaker for issues

#rb zousar.shaker

[CL 29761675 by joe pribele in ue5-main branch]
2023-11-15 17:27:09 -05:00
andrea botti
a1c5e3bd21 [RemoteControl]
Fix Undo/Redo crash with the WebApp open while calling the OnPropertyUnexposed.
Fix Rename issue in the WebApp and OnFieldsRenamed never broadcasted in the Engine.
Fix Rename Transaction not created correctly.
Fix RCTransactionListener not keeping the Delegate by reference causing the system to not call bound function to the Delegate if they were bound after the creation of the TransactionListener.

#rb jeremie.roy

[CL 29711290 by andrea botti in ue5-main branch]
2023-11-14 08:59:44 -05:00
nick edwards
1ee04c17ae Swap FHttpRequestHandler to TDelegate from TFunction. Allows for more convenient callback handling.
Fixed up usage of FHttpRequestHandler across engine and projects.

#tests Ran some RPC tests successfully, which execute RPCs against the engine utilizing HTTPServer.

[CL 29401814 by nick edwards in ue5-main branch]
2023-11-03 07:44:22 -04:00
ionut matasaru
57769f8235 Fixed usage of TRACE_CPUPROFILER_EVENT_SCOPE macros in engine plugins.
* TRACE_CPUPROFILER_EVENT_SCOPE(ScopeName) --> to be used with a plain text as scope name (not a string!). If the parameter is a string ("abc" or TEXT("abc")), the quotes (and the TEXT prefix) will be included in the actual timer name.
* TRACE_CPUPROFILER_EVENT_SCOPE_STR("scope name") --> to be used with a static string (const ANSICHAR* or const TCHAR*); ex: when the scope name needs to include a space char
* TRACE_CPUPROFILER_EVENT_SCOPE_TEXT(*MyScopeName) --> to be used with a dynamic string (const ANSICHAR* or const TCHAR*)
See also the comments for these macros in ProfilingDebugging\CpuProfilerTrace.h.

#rb Catalin.Dragoiu

[CL 28337738 by ionut matasaru in ue5-main branch]
2023-09-29 04:29:47 -04:00
elliot colp
5abe7869f1 [RemoteControl] Add missing include to fix incremental build
#rb trivial
#jira UE-156392

[CL 27529921 by elliot colp in ue5-main branch]
2023-08-31 14:06:01 -04:00
elliot colp
7540b788d2 [RemoteControl] Add zlib compression option for WebSocket traffic
#jira UE-156392
#rb Alejandro.Arango, Jeremie.Roy

[CL 27527132 by elliot colp in ue5-main branch]
2023-08-31 12:51:37 -04:00
elliot colp
b896314c9b [RemoteControl] Fix ContributeToTransaction always failing when WebSocket transaction is first created
#rb Alejandro.Arango

[CL 27223354 by elliot colp in ue5-main branch]
2023-08-18 18:26:10 -04:00
elliot colp
23979ca837 [RemoteControl] Remove unnecessary ensures
#jira UE-190663
#rb Alejandro.Arango

[CL 26493664 by elliot colp in ue5-main branch]
2023-07-20 15:43:24 -04:00
elliot colp
4eacdce9e0 [UnrealStage] Fix color grading outliner entries becoming grey when level is reloaded
#jira UE-189303
#rb Jeremie.Roy, Patrick.Hardy

[CL 26214377 by elliot colp in ue5-main branch]
2023-06-23 14:24:04 -04:00
Elliot Colp
5b7947ba0f [RemoteControl] Fix HTTP query parameters not being parsed when sent via WebSocket http route
#jira UE-188884
#rb Jeremie.Roy

[CL 26060020 by Elliot Colp in ue5-main branch]
2023-06-16 13:29:14 -04:00
kirill zorin
b6ee3a6c64 Fix UE_LOG callsites that have format string-related UB
#rb trivial
#preflight 647107780a6634dbb236a0a6

[CL 25651638 by kirill zorin in ue5-main branch]
2023-05-26 15:52:39 -04:00