96 Commits

Author SHA1 Message Date
rob gay
f7339c17c4 Variables (and potentially other values when using the BuilderAPI) on different pages but of the same name cannot have unique default values (Using Frontend::DefaultPageID as fallback in these instances where they should be using BuildPageID)
#jira UE-227933
#rb helen.yang
#rnx
[FYI] sondra.moyls

[CL 37288856 by rob gay in 5.5 branch]
2024-10-18 18:23:15 -04:00
helen yang
be114d3e98 Fix crash when adding new MetaSound variable nodes after node removal
#jira UE-225256
#rb phil.popp
#rnx

[CL 37230469 by helen yang in 5.5 branch]
2024-10-17 13:10:05 -04:00
helen yang
97c94caac0 Fix ensure on copy/pasting required MetaSound interface outputs
#jira UE-227516
#rb Rob.Gay
#rnx

[CL 37209170 by helen yang in 5.5 branch]
2024-10-16 19:07:49 -04:00
rob gay
aa762e2b9c More logging around resolving page id/proxy generation to hunt down page packaging mystery of expected sound not playing
- Fix minor bug where removal of graph input would return false despite removal succeeding if input was on preset but not initially set to inherit
- Disable MetaSound live audition transactor in cook to avoid potential warnings caused by resolution on cook page mutations
#jira UE-225699
#rb helen.yang
#rnx

[CL 36949136 by rob gay in 5.5 branch]
2024-10-08 18:08:08 -04:00
rob gay
073beeb803 Fix static compilation unchecked nullref warning
#rb rob.gay
#rnx

[CL 36761971 by rob gay in 5.5 branch]
2024-10-01 20:13:09 -04:00
rob gay
b1e28337ad MetaSound Editor Output Node Location/Page Fixes
- Fix bug with moving initially placed editor output node moving same node on other pages in some cases
- Fix removing editor output nodes removing output nodes from all pages (and root output graph vertex)
- Disallow required interface input/output nodes from being removed from the ed graph
- Fix for occasional audition page desync

#jira UE-219586
#rnx
[FYI] jon.huller, sondra.moyls, miro.salminen
#rb helen.yang

#p4v-cherrypick 36635171

[CL 36761852 by rob gay in 5.5 branch]
2024-10-01 20:11:53 -04:00
rob gay
20217cc638 Fix renaming MetaSound inputs/outputs not applying to non-focused graph pages
#rb phil.popp, helen.yang
#jira UE-223839
#rnx
[FYI] jon.huller, sondra.moyls
#p4v-cherrypick 36348041

[CL 36348116 by rob gay in 5.5 branch]
2024-09-17 15:37:28 -04:00
rob gay
c390362d67 Fixes for pin inspector not showing input template node analyzer data
- Move edge style calls to builder from controllers
- Fix leaks where removing an edge did not remove  editor-only edge style
- Conform EditorOnly Data markup in BuilderAPI
- Make FindBuildGraphChecked private now that page work is complete (was public during transition between 5.4 & 5.5)

#jira UE-224299
#rb rob.gay
#rnx
[FYI] sondra.moyls, jon.huller

#p4v-cherrypick 36309245

[CL 36313950 by rob gay in 5.5 branch]
2024-09-16 15:56:55 -04:00
Ryan Hummer
4af2fd066d Updating Dev-Release-5.5 from Main at CL #36144969
#okforversepublic

[CL 36146571 by Ryan Hummer in Dev-5.5 branch]
2024-09-10 10:26:02 -04:00
helen yang
91c4370a7c Fix issues with MetaSound member metadata (ex. float input range) (changes not being serialized + values not inherited on preset creation)
#jira UE-222950
#jira UE-164990
#rb Rob.Gay

[CL 36024546 by helen yang in ue5-main branch]
2024-09-04 17:35:04 -04:00
rob gay
47e4e35c82 - Enable default page to not be targetable, allowing for removal at cook
- Add faux platform "editor" (ignores cook settings) and "default" (all platforms without specific target settings) as auditionable for faster workflow/more intuitive behavior
- Implement feedback to distinguish "audition page" (editor only concept) vs "target page" (runtime concept)
- Warn when auditioning  graphs that are not cooked/targeted for an assigned audition platform (as default input values cannot be resolved accordingly) in MetaSound Asset editor
- Add more editor/UX protections around having invalid settings where a platform has no target set

#jira UE-193186, UE-219821
#rb helen.yang
[FYI] sondra.moyls, jon.huller, Seth.Weedin, carlos.egas
#rnx

[CL 35930645 by rob gay in ue5-main branch]
2024-08-30 12:53:13 -04:00
rob gay
845f2318dc Round 2 post backouts w/fix (always provide at least default target page when cooking if no project page settings are supplied):
Update MetaSound cook to strip unsupported MetaSound platform page data
Page resolution perf/selection improvements
- Add option to disable MetaSound audition (page & platform) settings in PIE (default to enabled)
- Add ability for project to override resolved pageID
- Avoid constant set reallocation for now frequently-used page ID resolution (as inputs now call during generation independent of graph)
- Add trace event scope for page resolution perf monitoring

#jira UE-219821, UE-193186
#rb phil.popp, helen.yang
#rnx
[FYI] jon.huller, sondra.moyls, Seth.Weedin

[CL 35787942 by rob gay in ue5-main branch]
2024-08-23 21:59:54 -04:00
rob gay
92cfab856b [Backout] - CL35783574
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Update MetaSound cook to strip unsupported MetaSound platform page data

#jira UE-193186, UE-194160
#rb phil.popp, helen.yang
#rnx
[FYI] sondra.moyls, jon.huller

[CL 35785849 by rob gay in ue5-main branch]
2024-08-23 19:07:53 -04:00
rob gay
4f7ee4c0bb Update MetaSound cook to strip unsupported MetaSound platform page data
#jira UE-193186, UE-194160
#rb phil.popp, helen.yang
#rnx
[FYI] sondra.moyls, jon.huller

[CL 35783577 by rob gay in ue5-main branch]
2024-08-23 17:27:50 -04:00
rob gay
ffac5746ad - Fix up missing/newly added calls not respecting page IDs in document builder API (input/output vertex swapping, comment nodes, etc.)
#jira UE-193186, UE-219821
#rb helen.yang
#rnx

[CL 35725512 by rob gay in ue5-main branch]
2024-08-21 18:37:59 -04:00
miro salminen
3e99ab1a88 [MetaSound] [Editor] Add 'IsAdvanced' Field to Graph Vertices
#rb helen.yang
#jira UE-187752
#rnx

[CL 35649435 by miro salminen in ue5-main branch]
2024-08-20 03:27:21 -04:00
rob gay
9378559f6b Remove redundant call from bad local merge
#rb rob.gay
#rnx

[CL 35646313 by rob gay in ue5-main branch]
2024-08-19 20:38:03 -04:00
rob gay
c53434a951 - Change "RemoveAll<GraphPages/PageDefaultValues>Pages" to be "Reset", as the default value should always exist and be valid
- Add utility functions to EdGraphBuilder & FrontendDocBuilder to be used for editor updates to accomidate paged input defaults
- General minor controller to docbuilder API clean-up spots
- Misc comment clean-up

#jira UE-219821
#rb helen.yang
#rnx
[FYI] sondra.moyls

[CL 35638678 by rob gay in ue5-main branch]
2024-08-19 17:06:23 -04:00
phil popp
8c683e1558 Fix failing audio unit test on metasound graph output
Rename default graph page initialization for clarity.
#jira UE-221636
#rb Rob.Gay
#rnx

[CL 35538736 by phil popp in ue5-main branch]
2024-08-14 12:49:51 -04:00
rob gay
90a387e395 Checkpoint on Resolve Page logic rework to support input default literals
#jira UE-219821
#rb phil.popp
#rnx
[FYI] sondra.moyls

[CL 35503142 by rob gay in ue5-main branch]
2024-08-13 14:58:36 -04:00
helen yang
adb9a80bd6 Fix ensures when copying and pasting MetaSound interface input and reroute nodes
#jira UE-219691
#jira UE-220195
#rb Rob.Gay

[CL 35286317 by helen yang in ue5-main branch]
2024-08-02 16:25:37 -04:00
rob gay
60b65efb2d Part 1: AudioUnitTest fix-ups in response to prior default page graph/input literal changes
#rb phil.popp
#jira UE-219821
#rnx
[FYI] sondra.moyls

[CL 35116149 by rob gay in ue5-main branch]
2024-07-26 14:57:53 -04:00
rob gay
4bcc279ddd Add initial page implementation of input class default literals
#jira UE-219821
#rb phil.popp
#rnx

[CL 35115150 by rob gay in ue5-main branch]
2024-07-26 14:23:35 -04:00
rob gay
bd6b998c3e Fix for false negative ensure when swapping datatype/vertex access type on MetaSound via builder
#rnx
#rb rob.gay
#jira UE-217616

[CL 34889182 by rob gay in ue5-main branch]
2024-07-17 18:43:11 -04:00
rob gay
ecb39b4592 Migrate MetaSound editor input/output creation to builder API in preparation of supporting paged input literals
#jira UE-194160
#rb helen.yang
#tests automated in-editor, asset editor addition/removal of inputs/outputs via misc means
#rnx
[FYI] sondra.moyls

[CL 34882307 by rob gay in ue5-main branch]
2024-07-17 15:46:56 -04:00