78 Commits

Author SHA1 Message Date
rob gay
e43f356049 - Add more logging to MetaSound cook indicating page removal
- Fix off-by-one when removing default graph via builder API
- Add missing Super::PostLoad that may be causing config values from getting loaded in MetaSoundSettings

#jira UE-225009
#rb phil.popp
#rnx
#tests local cook
[FYI] sondra.moyls, jon.huller, phil.popp

[CL 36747695 by rob gay in 5.5 branch]
2024-10-01 17:46:57 -04:00
rob gay
97b2aa8d74 Editor support for MetaSound Paged Input Defaults
#jira UE-193186, UE-219821
#rb helen.yang
#rnx
[FYI] Seth.Weedin, sondra.moyls, jon.huller

[CL 35844323 by rob gay in ue5-main branch]
2024-08-27 19:05:41 -04:00
rob gay
845f2318dc Round 2 post backouts w/fix (always provide at least default target page when cooking if no project page settings are supplied):
Update MetaSound cook to strip unsupported MetaSound platform page data
Page resolution perf/selection improvements
- Add option to disable MetaSound audition (page & platform) settings in PIE (default to enabled)
- Add ability for project to override resolved pageID
- Avoid constant set reallocation for now frequently-used page ID resolution (as inputs now call during generation independent of graph)
- Add trace event scope for page resolution perf monitoring

#jira UE-219821, UE-193186
#rb phil.popp, helen.yang
#rnx
[FYI] jon.huller, sondra.moyls, Seth.Weedin

[CL 35787942 by rob gay in ue5-main branch]
2024-08-23 21:59:54 -04:00
rob gay
92cfab856b [Backout] - CL35783574
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Update MetaSound cook to strip unsupported MetaSound platform page data

#jira UE-193186, UE-194160
#rb phil.popp, helen.yang
#rnx
[FYI] sondra.moyls, jon.huller

[CL 35785849 by rob gay in ue5-main branch]
2024-08-23 19:07:53 -04:00
rob gay
c2412e52b1 [Backout] - CL35784129
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Page resolution perf/selection improvements
- Add option to disable MetaSound audition (page & platform) settings in PIE (default to enabled)
- Add ability for project to override resolved pageID
- Avoid constant set reallocation for now frequently-used page ID resolution (as inputs now call during generation independent of graph)
- Add trace event scope for page resolution perf monitoring

#jira UE-219821, UE-193186
#rb phil.popp
#rnx
[FYI] jon.huller, sondra.moyls, Seth.Weedin

[CL 35785813 by rob gay in ue5-main branch]
2024-08-23 19:05:52 -04:00
rob gay
a942539d62 Page resolution perf/selection improvements
- Add option to disable MetaSound audition (page & platform) settings in PIE (default to enabled)
- Add ability for project to override resolved pageID
- Avoid constant set reallocation for now frequently-used page ID resolution (as inputs now call during generation independent of graph)
- Add trace event scope for page resolution perf monitoring

#jira UE-219821, UE-193186
#rb phil.popp
#rnx
[FYI] jon.huller, sondra.moyls, Seth.Weedin

[CL 35784150 by rob gay in ue5-main branch]
2024-08-23 17:52:57 -04:00
rob gay
4f7ee4c0bb Update MetaSound cook to strip unsupported MetaSound platform page data
#jira UE-193186, UE-194160
#rb phil.popp, helen.yang
#rnx
[FYI] sondra.moyls, jon.huller

[CL 35783577 by rob gay in ue5-main branch]
2024-08-23 17:27:50 -04:00
miro salminen
3e99ab1a88 [MetaSound] [Editor] Add 'IsAdvanced' Field to Graph Vertices
#rb helen.yang
#jira UE-187752
#rnx

[CL 35649435 by miro salminen in ue5-main branch]
2024-08-20 03:27:21 -04:00
rob gay
890bbdb99e Fix shadow variable compilation errors
#rb rob.gay
#rnx

[CL 35640618 by rob gay in ue5-main branch]
2024-08-19 17:53:38 -04:00
rob gay
c53434a951 - Change "RemoveAll<GraphPages/PageDefaultValues>Pages" to be "Reset", as the default value should always exist and be valid
- Add utility functions to EdGraphBuilder & FrontendDocBuilder to be used for editor updates to accomidate paged input defaults
- General minor controller to docbuilder API clean-up spots
- Misc comment clean-up

#jira UE-219821
#rb helen.yang
#rnx
[FYI] sondra.moyls

[CL 35638678 by rob gay in ue5-main branch]
2024-08-19 17:06:23 -04:00
rob gay
701aa024c3 - Only enable interact input widgets on graph pages that implement the given input's default
- Support breadcrumbing all class input default values
- Reimplement input breadcrumb caching using MetaSoundFrontendDocumentBuilder API

#jira UE-219821
#rnx
#rb helen.yang

[CL 35539861 by rob gay in ue5-main branch]
2024-08-14 13:33:46 -04:00
phil popp
8c683e1558 Fix failing audio unit test on metasound graph output
Rename default graph page initialization for clarity.
#jira UE-221636
#rb Rob.Gay
#rnx

[CL 35538736 by phil popp in ue5-main branch]
2024-08-14 12:49:51 -04:00
rob gay
90a387e395 Checkpoint on Resolve Page logic rework to support input default literals
#jira UE-219821
#rb phil.popp
#rnx
[FYI] sondra.moyls

[CL 35503142 by rob gay in ue5-main branch]
2024-08-13 14:58:36 -04:00
rob gay
60b65efb2d Part 1: AudioUnitTest fix-ups in response to prior default page graph/input literal changes
#rb phil.popp
#jira UE-219821
#rnx
[FYI] sondra.moyls

[CL 35116149 by rob gay in ue5-main branch]
2024-07-26 14:57:53 -04:00
rob gay
4bcc279ddd Add initial page implementation of input class default literals
#jira UE-219821
#rb phil.popp
#rnx

[CL 35115150 by rob gay in ue5-main branch]
2024-07-26 14:23:35 -04:00
rob gay
f691eda44c Moving page mutable calls to builds loading editor-only data (pages initially will be a non-runtime mutable feature on serialized MetaSound assets only, so locking down accordingly)
#jira UE-193188
#rb helen.yang
#rnx

[CL 34817438 by rob gay in ue5-main branch]
2024-07-15 13:25:53 -04:00
rob gay
1878db9c63 Initial checkpoint for runtime graph to support Metasound document pages
- Adds ability for graph generation via target page ID
- Deprecates the requirement of a GraphController to build graph to IGraph

#rb phil.popp
#tests MetaSound automated tests & UnitTests
#rnx
#jira UE-194160

[CL 34731539 by rob gay in ue5-main branch]
2024-06-27 23:26:57 -04:00
rob gay
e0f2527ac7 Editor-only fixes included: Initial MetaSound Editor Page Support (cvar disabled until all transactions are supported and tested)
#jira UE-194160
#rb phil.popp
#rnx
#tests PIE, MetaSound Asset Editor, Engine Automation tests

[CL 34541631 by rob gay in ue5-main branch]
2024-06-20 15:27:03 -04:00
rob gay
e0359d1db1 [Backout] - CL34535555
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Initial MetaSound Editor Page Support (cvar disabled until all transactions are supported and tested)
#jira UE-194160
#rb phil.popp
#rnx
#tests PIE, MetaSound Asset Editor, Engine Automation tests

[CL 34538285 by rob gay in ue5-main branch]
2024-06-20 14:26:46 -04:00
rob gay
94e46a67f9 Initial MetaSound Editor Page Support (cvar disabled until all transactions are supported and tested)
#jira UE-194160
#rb phil.popp
#rnx
#tests PIE, MetaSound Asset Editor, Engine Automation tests

[CL 34535569 by rob gay in ue5-main branch]
2024-06-20 13:33:47 -04:00
rob gay
92e413738d Fix for Clang compiler warning. Minor feedback for const declaration of default page ID.
#rnx
#rb rob.gay

[CL 34485679 by rob gay in ue5-main branch]
2024-06-18 19:17:25 -04:00
AdricEpic
0976464d97 #1 Pages Checkpoint: Update BuilderAPI, associated delegates to support providing Pages
#rb helen.yang, phil.popp
#rnx
#jira UE-194160

[CL 34477958 by AdricEpic in ue5-main branch]
2024-06-18 16:47:21 -04:00
alan abram
f64052f200 Metasound changes to reduce the number of FNames generated.
Previously the FNodeRegistryKey::ToString() function was the only user of the "FullName" FName and was used for logging. We now build these inline when used as not to pollute the FNamePool.
#rb emanuel.masciarelli, Rob.Gay

[CL 34032750 by alan abram in ue5-main branch]
2024-05-31 11:06:37 -04:00
rob gay
69725d945e - Checkpoint for Initial MetaSound Pages document model support
- Fix-ups for MS AssetManager leaking asset names if not registered by moving to MultiMap
- Fix-up for ResetBuilder call passing off initial delegates properly
- Make builders map mutation thread safe when loading assets async
#rnx
#tests -game, AudioQA, Unit Tests, Automated Tests
#rb phil.popp
#jira UE-194160

[CL 33983705 by rob gay in ue5-main branch]
2024-05-29 15:33:29 -04:00
rob gay
b3ab5744bf - Fix for attempting to access EngineSubsystem during MetaSound versioning (serialization), which can assert when apparently certain commands in certain contexts can attempt to preload assets prior to the init phase.
- Minor Fix for LocText duplication
#tests BuildCookRun, -game, version MetaSounds assets in editor, PIE

[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33102023 by rob gay in ue5-main branch]
2024-04-19 10:09:04 -04:00