28 Commits

Author SHA1 Message Date
rob gay
e577c32b05 Fix for BuildToAsset fix-up collision with BuildAndOverwriteMetaSound
#jira UE-224638
#rb helen.yang
#rnx
[FYI] sondra.moyls, jon.huller, Brian.Chrisman

[CL 36759780 by rob gay in 5.5 branch]
2024-10-01 19:51:34 -04:00
rob gay
5ec150b388 Fix bad merge from last week causing false ensure on changing a MetaSound output's data type
#rb phil.popp
#jira UE-225221
#rnx



#p4v-cherrypick 36520081

[CL 36635850 by rob gay in 5.5 branch]
2024-09-26 13:18:57 -04:00
rob gay
20217cc638 Fix renaming MetaSound inputs/outputs not applying to non-focused graph pages
#rb phil.popp, helen.yang
#jira UE-223839
#rnx
[FYI] jon.huller, sondra.moyls
#p4v-cherrypick 36348041

[CL 36348116 by rob gay in 5.5 branch]
2024-09-17 15:37:28 -04:00
helen yang
91c4370a7c Fix issues with MetaSound member metadata (ex. float input range) (changes not being serialized + values not inherited on preset creation)
#jira UE-222950
#jira UE-164990
#rb Rob.Gay

[CL 36024546 by helen yang in ue5-main branch]
2024-09-04 17:35:04 -04:00
rob gay
845f2318dc Round 2 post backouts w/fix (always provide at least default target page when cooking if no project page settings are supplied):
Update MetaSound cook to strip unsupported MetaSound platform page data
Page resolution perf/selection improvements
- Add option to disable MetaSound audition (page & platform) settings in PIE (default to enabled)
- Add ability for project to override resolved pageID
- Avoid constant set reallocation for now frequently-used page ID resolution (as inputs now call during generation independent of graph)
- Add trace event scope for page resolution perf monitoring

#jira UE-219821, UE-193186
#rb phil.popp, helen.yang
#rnx
[FYI] jon.huller, sondra.moyls, Seth.Weedin

[CL 35787942 by rob gay in ue5-main branch]
2024-08-23 21:59:54 -04:00
rob gay
92cfab856b [Backout] - CL35783574
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Update MetaSound cook to strip unsupported MetaSound platform page data

#jira UE-193186, UE-194160
#rb phil.popp, helen.yang
#rnx
[FYI] sondra.moyls, jon.huller

[CL 35785849 by rob gay in ue5-main branch]
2024-08-23 19:07:53 -04:00
rob gay
4f7ee4c0bb Update MetaSound cook to strip unsupported MetaSound platform page data
#jira UE-193186, UE-194160
#rb phil.popp, helen.yang
#rnx
[FYI] sondra.moyls, jon.huller

[CL 35783577 by rob gay in ue5-main branch]
2024-08-23 17:27:50 -04:00
rob gay
80923ea941 Trivial - Deprecate and swap class default builder API that returns multiple class defaults (and conform node input API for visibility)
#jira UE-219821
#rb rob.gay
[FYI] sondra.moyls, jon.huller
#rnx

[CL 35731265 by rob gay in ue5-main branch]
2024-08-22 00:18:47 -04:00
rob gay
c53434a951 - Change "RemoveAll<GraphPages/PageDefaultValues>Pages" to be "Reset", as the default value should always exist and be valid
- Add utility functions to EdGraphBuilder & FrontendDocBuilder to be used for editor updates to accomidate paged input defaults
- General minor controller to docbuilder API clean-up spots
- Misc comment clean-up

#jira UE-219821
#rb helen.yang
#rnx
[FYI] sondra.moyls

[CL 35638678 by rob gay in ue5-main branch]
2024-08-19 17:06:23 -04:00
rob gay
4bcc279ddd Add initial page implementation of input class default literals
#jira UE-219821
#rb phil.popp
#rnx

[CL 35115150 by rob gay in ue5-main branch]
2024-07-26 14:23:35 -04:00
rob gay
f691eda44c Moving page mutable calls to builds loading editor-only data (pages initially will be a non-runtime mutable feature on serialized MetaSound assets only, so locking down accordingly)
#jira UE-193188
#rb helen.yang
#rnx

[CL 34817438 by rob gay in ue5-main branch]
2024-07-15 13:25:53 -04:00
rob gay
1878db9c63 Initial checkpoint for runtime graph to support Metasound document pages
- Adds ability for graph generation via target page ID
- Deprecates the requirement of a GraphController to build graph to IGraph

#rb phil.popp
#tests MetaSound automated tests & UnitTests
#rnx
#jira UE-194160

[CL 34731539 by rob gay in ue5-main branch]
2024-06-27 23:26:57 -04:00
rob gay
e0f2527ac7 Editor-only fixes included: Initial MetaSound Editor Page Support (cvar disabled until all transactions are supported and tested)
#jira UE-194160
#rb phil.popp
#rnx
#tests PIE, MetaSound Asset Editor, Engine Automation tests

[CL 34541631 by rob gay in ue5-main branch]
2024-06-20 15:27:03 -04:00
rob gay
e0359d1db1 [Backout] - CL34535555
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Initial MetaSound Editor Page Support (cvar disabled until all transactions are supported and tested)
#jira UE-194160
#rb phil.popp
#rnx
#tests PIE, MetaSound Asset Editor, Engine Automation tests

[CL 34538285 by rob gay in ue5-main branch]
2024-06-20 14:26:46 -04:00
rob gay
94e46a67f9 Initial MetaSound Editor Page Support (cvar disabled until all transactions are supported and tested)
#jira UE-194160
#rb phil.popp
#rnx
#tests PIE, MetaSound Asset Editor, Engine Automation tests

[CL 34535569 by rob gay in ue5-main branch]
2024-06-20 13:33:47 -04:00
AdricEpic
0976464d97 #1 Pages Checkpoint: Update BuilderAPI, associated delegates to support providing Pages
#rb helen.yang, phil.popp
#rnx
#jira UE-194160

[CL 34477958 by AdricEpic in ue5-main branch]
2024-06-18 16:47:21 -04:00
rob gay
1b3382acee Guid collision fix-up follow-up renaming
#rb helen.yang, phil.popp
#rnx

[CL 34426347 by rob gay in ue5-main branch]
2024-06-17 12:51:18 -04:00
rob gay
69725d945e - Checkpoint for Initial MetaSound Pages document model support
- Fix-ups for MS AssetManager leaking asset names if not registered by moving to MultiMap
- Fix-up for ResetBuilder call passing off initial delegates properly
- Make builders map mutation thread safe when loading assets async
#rnx
#tests -game, AudioQA, Unit Tests, Automated Tests
#rb phil.popp
#jira UE-194160

[CL 33983705 by rob gay in ue5-main branch]
2024-05-29 15:33:29 -04:00
rob gay
b411ae1cdf More MetaSound Asset/Builder registry clean-up
- Distinguish executing finish call from removal of register's weak pointer entry to avoid leaking stale builder registry entries
- Fix for removal calls to asset registry entries leaking during cook (due to cook package data being stripped when BeginDestroy is called)
- Fix for removing an asset manager entry that hasn't been registered with the node registry not getting removed due to the RegistryGraphKey referenced not being set on AssetBase
- Remove AssetRegistry MetaSoundEditor delegate handlers during cook that aren't used
- Add thread checks for safety to MetaSoundAssetManager
- Add better logging around AssetManager/BuilderRegistry destruction if applied prior to underlying respective entry/entries destruction
#jira UE-212969
#rb phil.popp

#rnx
#tests local AudioQA cook, loading all assets in editor, PIE, -game, automated tests, loading all assets in editor, PIE, -game

[CL 33641926 by rob gay in ue5-main branch]
2024-05-14 20:20:01 -04:00
rob gay
a50228584e Remove spamming error to fix cook.
#rb rob.gay
#jira UE-212969
#rnx

[CL 33582059 by rob gay in ue5-main branch]
2024-05-10 14:22:40 -04:00
rob gay
8c0905af1d Missing string arg to fix build, I can has program I swear (...perforce lately, apparently not so much)!
#rb rob.gay
#jira UE-212969
#rnx

[CL 33580359 by rob gay in ue5-main branch]
2024-05-10 13:29:00 -04:00
rob gay
ba836a04dc Round 3 w/registry validity check
- Fix for rename ensure regression from AssetManager refactor
- Add logging and track case when multiple assets are registered with the AssetManager with the same key for better debugging
- Add ability to force unregistration when request to finish building & utilize on destruction of MetaSound assets
#rb phil.popp
#jira UE-212969
#rnx
[FYI] sondra.moyls

[CL 33578794 by rob gay in ue5-main branch]
2024-05-10 12:40:21 -04:00
rob gay
a2af7ba4af [Backout] - CL33560215
[FYI] rob.gay
Original CL Desc
-----------------------------------------------------------------
Round 2 w/registry validity check
[Backout] - CL33559423
[FYI] rob.gay
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33551869
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
- Fix for rename ensure regression from AssetManager refactor
- Add logging and track case when multiple assets are registered with the AssetManager with the same key for better debugging
- Add ability to force unregistration when request to finish building & utilize on destruction of MetaSound assets
#rb phil.popp
#jira UE-212969
#rnx
[FYI] sondra.moyls

[CL 33563652 by rob gay in ue5-main branch]
2024-05-09 19:02:03 -04:00
rob gay
2f7f2bbc77 Round 2 w/registry validity check
[Backout] - CL33559423
[FYI] rob.gay
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33551869
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
- Fix for rename ensure regression from AssetManager refactor
- Add logging and track case when multiple assets are registered with the AssetManager with the same key for better debugging
- Add ability to force unregistration when request to finish building & utilize on destruction of MetaSound assets
#rb phil.popp
#jira UE-212969
#rnx
[FYI] sondra.moyls

[CL 33560224 by rob gay in ue5-main branch]
2024-05-09 17:24:19 -04:00
rob gay
1cd6fad836 [Backout] - CL33551869
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
- Fix for rename ensure regression from AssetManager refactor
- Add logging and track case when multiple assets are registered with the AssetManager with the same key for better debugging
- Add ability to force unregistration when request to finish building & utilize on destruction of MetaSound assets
#rb phil.popp
#jira UE-212969
#rnx
[FYI] sondra.moyls

[CL 33559463 by rob gay in ue5-main branch]
2024-05-09 16:58:48 -04:00