29 Commits

Author SHA1 Message Date
rob gay
9583f012e8 Remove checks for CanTarget in calls leveraged in non-editor builds. (PerPlatform settings are not available at runtime when initialized in an .ini and deserialized as CDOs)
#jira UE-225009
#rb helen.yang, eric.buchholz
[FYI] jon.huller, sondra.moyls, Randolph.Kestner
#rnx
#p4v-cherrypick 36557318

[CL 36756588 by rob gay in 5.5 branch]
2024-10-01 19:22:54 -04:00
rob gay
73be44d870 Fix warning in MetaSound tests
#rb rob.gay
#rnx

#p4v-cherrypick 36547161

[CL 36755433 by rob gay in 5.5 branch]
2024-10-01 19:07:55 -04:00
rob gay
e43f356049 - Add more logging to MetaSound cook indicating page removal
- Fix off-by-one when removing default graph via builder API
- Add missing Super::PostLoad that may be causing config values from getting loaded in MetaSoundSettings

#jira UE-225009
#rb phil.popp
#rnx
#tests local cook
[FYI] sondra.moyls, jon.huller, phil.popp

[CL 36747695 by rob gay in 5.5 branch]
2024-10-01 17:46:57 -04:00
rob gay
bfcdeda6ac Part 1: Fix for default config having two default page values
#rb helen.yang
#rnx

[CL 36314356 by rob gay in 5.5 branch]
2024-09-16 16:06:49 -04:00
rob gay
47e4e35c82 - Enable default page to not be targetable, allowing for removal at cook
- Add faux platform "editor" (ignores cook settings) and "default" (all platforms without specific target settings) as auditionable for faster workflow/more intuitive behavior
- Implement feedback to distinguish "audition page" (editor only concept) vs "target page" (runtime concept)
- Warn when auditioning  graphs that are not cooked/targeted for an assigned audition platform (as default input values cannot be resolved accordingly) in MetaSound Asset editor
- Add more editor/UX protections around having invalid settings where a platform has no target set

#jira UE-193186, UE-219821
#rb helen.yang
[FYI] sondra.moyls, jon.huller, Seth.Weedin, carlos.egas
#rnx

[CL 35930645 by rob gay in ue5-main branch]
2024-08-30 12:53:13 -04:00
rob gay
d43c1fecde - Rename 'Target' to 'Can'Target' for clarity in Page Settings
- Return copy instead of reference of platform target ids to avoid shared access violation when cooking pages
- Add trace info to monitor cook times of page data

#jira UE-193186
#rb rob.gay
#rnx
[FYI] jon.huller, sondra.moyls, helen.yang

[CL 35867678 by rob gay in ue5-main branch]
2024-08-28 10:50:41 -04:00
rob gay
a4bfa40fcb Giving a local variable a new name, allowing it to live its best life and removing it from the shadowy darkness
#rb rob.gay
#rnx

[CL 35788342 by rob gay in ue5-main branch]
2024-08-23 23:18:23 -04:00
rob gay
f2b5b9810f - Rename feedback from prior MetaSound page cook submission
- Fix for runtime-generated MetaSounds asserting when registering from minor oversight in earlier CL
- Exposition of page editor enablement for subsequent page default CL in review

#rb helen.yang, rob.gay
#tests automated PIE and unit
#jira UE-219821, UE-193186

[CL 35788266 by rob gay in ue5-main branch]
2024-08-23 23:03:23 -04:00
rob gay
14ca434d3c Re-backout macro comment fix
#rb rob.gay
#rnx

[CL 35788017 by rob gay in ue5-main branch]
2024-08-23 22:12:23 -04:00
rob gay
845f2318dc Round 2 post backouts w/fix (always provide at least default target page when cooking if no project page settings are supplied):
Update MetaSound cook to strip unsupported MetaSound platform page data
Page resolution perf/selection improvements
- Add option to disable MetaSound audition (page & platform) settings in PIE (default to enabled)
- Add ability for project to override resolved pageID
- Avoid constant set reallocation for now frequently-used page ID resolution (as inputs now call during generation independent of graph)
- Add trace event scope for page resolution perf monitoring

#jira UE-219821, UE-193186
#rb phil.popp, helen.yang
#rnx
[FYI] jon.huller, sondra.moyls, Seth.Weedin

[CL 35787942 by rob gay in ue5-main branch]
2024-08-23 21:59:54 -04:00
rob gay
92cfab856b [Backout] - CL35783574
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Update MetaSound cook to strip unsupported MetaSound platform page data

#jira UE-193186, UE-194160
#rb phil.popp, helen.yang
#rnx
[FYI] sondra.moyls, jon.huller

[CL 35785849 by rob gay in ue5-main branch]
2024-08-23 19:07:53 -04:00
rob gay
c2a97f5df1 [Backout] - CL35783705
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Fix for shadow var

#jira UE-219821
#rb rob.gay
#rnx

[CL 35785830 by rob gay in ue5-main branch]
2024-08-23 19:06:22 -04:00
rob gay
1605c8854e Fix for shadow var
#jira UE-219821
#rb rob.gay
#rnx

[CL 35783707 by rob gay in ue5-main branch]
2024-08-23 17:37:49 -04:00
rob gay
4f7ee4c0bb Update MetaSound cook to strip unsupported MetaSound platform page data
#jira UE-193186, UE-194160
#rb phil.popp, helen.yang
#rnx
[FYI] sondra.moyls, jon.huller

[CL 35783577 by rob gay in ue5-main branch]
2024-08-23 17:27:50 -04:00
rob gay
64374a703c Restrict target page to existing page names and reset if page provided is removed from the array of valid pages (trivial)
#rb rob.gay
#rnx

[CL 35720061 by rob gay in ue5-main branch]
2024-08-21 16:54:41 -04:00
rob gay
47580b61d5 - Add page info to render stats in MetaSound Editor
- Implement GetOptions feedback for simpler audition page UX
- Tidy connection manager init in asset editor & only visualize connections if viewed page is audition page
#jira UE-193186
#rb phil.popp
#rnx
[FYI] helen.yang, sondra.moyls

[CL 35505474 by rob gay in ue5-main branch]
2024-08-13 15:48:07 -04:00
rob gay
4bcc279ddd Add initial page implementation of input class default literals
#jira UE-219821
#rb phil.popp
#rnx

[CL 35115150 by rob gay in ue5-main branch]
2024-07-26 14:23:35 -04:00
rob gay
a895cd9b85 Trivial: Add cvar for setting MetaSound target page for convenience
#jira UE-193186
#rb rob.gay
#rnx
[FYI] sondra.moyls, helen.yang

[CL 34906555 by rob gay in ue5-main branch]
2024-07-18 13:40:05 -04:00
rob gay
5bf70c4745 - Deprecate UMetaSoundQualityHelper & move function to editor-only MetaSoundSettings util function
- Remove config copy pasta
#rb jimmy.smith
#rnx

[CL 34884324 by rob gay in ue5-main branch]
2024-07-17 16:31:15 -04:00
rob gay
1878db9c63 Initial checkpoint for runtime graph to support Metasound document pages
- Adds ability for graph generation via target page ID
- Deprecates the requirement of a GraphController to build graph to IGraph

#rb phil.popp
#tests MetaSound automated tests & UnitTests
#rnx
#jira UE-194160

[CL 34731539 by rob gay in ue5-main branch]
2024-06-27 23:26:57 -04:00
rob gay
086e40ac13 Simple polish feedback from earlier page CLs, misc clean-up:
- More const node handle fix-ups to isolate prioritization of controller callsites to refactor (and to avoid reloading active builder/resetting builder cache when not necessary)
- Make builders transactional to log when page ID is changed
- Fix mismatching EDITORONLY_DATA vs EDITOR macro chunk in MetaSoundSettings
- Protect FDocumentBuilderRegistry::FindBuilderObject calls so that callers providing an invalid asset path (ex. from controller back compat look-up calls) always returns a valid path over a stale one if both are in the registry

#rb rob.gay
#jira UE-194160
#rnx
[FYI] helen.yang

[CL 34570868 by rob gay in ue5-main branch]
2024-06-21 14:37:29 -04:00
rob gay
e0f2527ac7 Editor-only fixes included: Initial MetaSound Editor Page Support (cvar disabled until all transactions are supported and tested)
#jira UE-194160
#rb phil.popp
#rnx
#tests PIE, MetaSound Asset Editor, Engine Automation tests

[CL 34541631 by rob gay in ue5-main branch]
2024-06-20 15:27:03 -04:00
rob gay
e0359d1db1 [Backout] - CL34535555
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Initial MetaSound Editor Page Support (cvar disabled until all transactions are supported and tested)
#jira UE-194160
#rb phil.popp
#rnx
#tests PIE, MetaSound Asset Editor, Engine Automation tests

[CL 34538285 by rob gay in ue5-main branch]
2024-06-20 14:26:46 -04:00
rob gay
94e46a67f9 Initial MetaSound Editor Page Support (cvar disabled until all transactions are supported and tested)
#jira UE-194160
#rb phil.popp
#rnx
#tests PIE, MetaSound Asset Editor, Engine Automation tests

[CL 34535569 by rob gay in ue5-main branch]
2024-06-20 13:33:47 -04:00
jimmy smith
0637da8f9e Fix non-cooked quality settings by adding a cook stage the MetasoundSource to correctly save them out per platform.
Previously the PerPlatformSettings was added to the MetasoundSettings, however as this is not a true asset they weren't being correctly cooked.
The code previously pulled the global settings, then allowed overrides upon this. This decision is now made during cook.
#rb jake.burga, Josh.Adams
#tests Shelve tested back and forth with Sondra Moyles
#jira UE-204075

[CL 32370815 by jimmy smith in ue5-main branch]
2024-03-20 12:42:32 -04:00