35 Commits

Author SHA1 Message Date
rob gay
aa762e2b9c More logging around resolving page id/proxy generation to hunt down page packaging mystery of expected sound not playing
- Fix minor bug where removal of graph input would return false despite removal succeeding if input was on preset but not initially set to inherit
- Disable MetaSound live audition transactor in cook to avoid potential warnings caused by resolution on cook page mutations
#jira UE-225699
#rb helen.yang
#rnx

[CL 36949136 by rob gay in 5.5 branch]
2024-10-08 18:08:08 -04:00
rob gay
9583f012e8 Remove checks for CanTarget in calls leveraged in non-editor builds. (PerPlatform settings are not available at runtime when initialized in an .ini and deserialized as CDOs)
#jira UE-225009
#rb helen.yang, eric.buchholz
[FYI] jon.huller, sondra.moyls, Randolph.Kestner
#rnx
#p4v-cherrypick 36557318

[CL 36756588 by rob gay in 5.5 branch]
2024-10-01 19:22:54 -04:00
rob gay
e43f356049 - Add more logging to MetaSound cook indicating page removal
- Fix off-by-one when removing default graph via builder API
- Add missing Super::PostLoad that may be causing config values from getting loaded in MetaSoundSettings

#jira UE-225009
#rb phil.popp
#rnx
#tests local cook
[FYI] sondra.moyls, jon.huller, phil.popp

[CL 36747695 by rob gay in 5.5 branch]
2024-10-01 17:46:57 -04:00
rob gay
d43c1fecde - Rename 'Target' to 'Can'Target' for clarity in Page Settings
- Return copy instead of reference of platform target ids to avoid shared access violation when cooking pages
- Add trace info to monitor cook times of page data

#jira UE-193186
#rb rob.gay
#rnx
[FYI] jon.huller, sondra.moyls, helen.yang

[CL 35867678 by rob gay in ue5-main branch]
2024-08-28 10:50:41 -04:00
rob gay
ec1c156c46 - Don't bind MetaSound editor-only module delegates (including audition selector) when running cook commandlet
- Add lock around page resolve scratch array when resolving page IDs to protect against async registration resource contention
- Remove cruft set construction

#jira UE-194160, UE-219821, UE-193186
#rb rob.gay
[FYI] helen.yang, phil.popp
#rnx

[CL 35789564 by rob gay in ue5-main branch]
2024-08-24 11:36:20 -04:00
rob gay
f2b5b9810f - Rename feedback from prior MetaSound page cook submission
- Fix for runtime-generated MetaSounds asserting when registering from minor oversight in earlier CL
- Exposition of page editor enablement for subsequent page default CL in review

#rb helen.yang, rob.gay
#tests automated PIE and unit
#jira UE-219821, UE-193186

[CL 35788266 by rob gay in ue5-main branch]
2024-08-23 23:03:23 -04:00
rob gay
845f2318dc Round 2 post backouts w/fix (always provide at least default target page when cooking if no project page settings are supplied):
Update MetaSound cook to strip unsupported MetaSound platform page data
Page resolution perf/selection improvements
- Add option to disable MetaSound audition (page & platform) settings in PIE (default to enabled)
- Add ability for project to override resolved pageID
- Avoid constant set reallocation for now frequently-used page ID resolution (as inputs now call during generation independent of graph)
- Add trace event scope for page resolution perf monitoring

#jira UE-219821, UE-193186
#rb phil.popp, helen.yang
#rnx
[FYI] jon.huller, sondra.moyls, Seth.Weedin

[CL 35787942 by rob gay in ue5-main branch]
2024-08-23 21:59:54 -04:00
rob gay
92cfab856b [Backout] - CL35783574
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Update MetaSound cook to strip unsupported MetaSound platform page data

#jira UE-193186, UE-194160
#rb phil.popp, helen.yang
#rnx
[FYI] sondra.moyls, jon.huller

[CL 35785849 by rob gay in ue5-main branch]
2024-08-23 19:07:53 -04:00
rob gay
c2412e52b1 [Backout] - CL35784129
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Page resolution perf/selection improvements
- Add option to disable MetaSound audition (page & platform) settings in PIE (default to enabled)
- Add ability for project to override resolved pageID
- Avoid constant set reallocation for now frequently-used page ID resolution (as inputs now call during generation independent of graph)
- Add trace event scope for page resolution perf monitoring

#jira UE-219821, UE-193186
#rb phil.popp
#rnx
[FYI] jon.huller, sondra.moyls, Seth.Weedin

[CL 35785813 by rob gay in ue5-main branch]
2024-08-23 19:05:52 -04:00
rob gay
a942539d62 Page resolution perf/selection improvements
- Add option to disable MetaSound audition (page & platform) settings in PIE (default to enabled)
- Add ability for project to override resolved pageID
- Avoid constant set reallocation for now frequently-used page ID resolution (as inputs now call during generation independent of graph)
- Add trace event scope for page resolution perf monitoring

#jira UE-219821, UE-193186
#rb phil.popp
#rnx
[FYI] jon.huller, sondra.moyls, Seth.Weedin

[CL 35784150 by rob gay in ue5-main branch]
2024-08-23 17:52:57 -04:00
rob gay
4f7ee4c0bb Update MetaSound cook to strip unsupported MetaSound platform page data
#jira UE-193186, UE-194160
#rb phil.popp, helen.yang
#rnx
[FYI] sondra.moyls, jon.huller

[CL 35783577 by rob gay in ue5-main branch]
2024-08-23 17:27:50 -04:00
rob gay
90a387e395 Checkpoint on Resolve Page logic rework to support input default literals
#jira UE-219821
#rb phil.popp
#rnx
[FYI] sondra.moyls

[CL 35503142 by rob gay in ue5-main branch]
2024-08-13 14:58:36 -04:00
rob gay
0d34377c5f First Rough Pass at Pages Editor Audition Support
- Fix-up new transaction listener for updating page details on page transactions
- Misc clean-up

#rb helen.yang, phil.popp
#jira UE-193188
#rnx
[FYI] Sondra.Moyls

[CL 34844711 by rob gay in ue5-main branch]
2024-07-16 12:40:36 -04:00
rob gay
42672ab11e Fix negation causing illegitimate warning when no page default is provided.
#rb rob.gay
#rnx

[CL 34737443 by rob gay in ue5-main branch]
2024-06-28 09:48:28 -04:00
rob gay
1878db9c63 Initial checkpoint for runtime graph to support Metasound document pages
- Adds ability for graph generation via target page ID
- Deprecates the requirement of a GraphController to build graph to IGraph

#rb phil.popp
#tests MetaSound automated tests & UnitTests
#rnx
#jira UE-194160

[CL 34731539 by rob gay in ue5-main branch]
2024-06-27 23:26:57 -04:00
rob gay
086e40ac13 Simple polish feedback from earlier page CLs, misc clean-up:
- More const node handle fix-ups to isolate prioritization of controller callsites to refactor (and to avoid reloading active builder/resetting builder cache when not necessary)
- Make builders transactional to log when page ID is changed
- Fix mismatching EDITORONLY_DATA vs EDITOR macro chunk in MetaSoundSettings
- Protect FDocumentBuilderRegistry::FindBuilderObject calls so that callers providing an invalid asset path (ex. from controller back compat look-up calls) always returns a valid path over a stale one if both are in the registry

#rb rob.gay
#jira UE-194160
#rnx
[FYI] helen.yang

[CL 34570868 by rob gay in ue5-main branch]
2024-06-21 14:37:29 -04:00
AdricEpic
0976464d97 #1 Pages Checkpoint: Update BuilderAPI, associated delegates to support providing Pages
#rb helen.yang, phil.popp
#rnx
#jira UE-194160

[CL 34477958 by AdricEpic in ue5-main branch]
2024-06-18 16:47:21 -04:00
rob gay
1b3382acee Guid collision fix-up follow-up renaming
#rb helen.yang, phil.popp
#rnx

[CL 34426347 by rob gay in ue5-main branch]
2024-06-17 12:51:18 -04:00
rob gay
81433d4d49 Versioning guid collision fixes
#jira UE-217835
#rb phil.popp
#rnx
[FYI] sondra.moyls
#tests local edits, audioQA automated tests, project fast cook

[CL 34376054 by rob gay in ue5-main branch]
2024-06-14 13:05:35 -04:00
rob gay
be35f85305 - Move duplication to re-use registered builder at different points of duplication process as multiple builders per class name in the builder registry its now supported
- Give asset builders proper names based off the MetaSound asset being built for easier debugging
- Add log supression during duplication from spamming user as brief existence of multiple builders with shared class name is expected behavior (Leaving disabled until cook can be verified log is not being hit)
#rb helen.yang
#jira UE-216532
[FYI] sondra.moyls
#rnx

[CL 34245724 by rob gay in ue5-main branch]
2024-06-10 13:52:48 -04:00
rob gay
8f3676650d Fix up finishbuilding bug leaving stale entry around during some forms of builder destruction
#jira UE-216533
#rb helen.yang
#rnx
[FYI] sondra.moyls

[CL 34168315 by rob gay in ue5-main branch]
2024-06-06 14:50:30 -04:00
rob gay
dbb5f4c976 Stopgap disablement of error that is likely cruft with new look-up logic
#rb rob.gay
#rnx

[CL 34127739 by rob gay in ue5-main branch]
2024-06-05 12:06:07 -04:00
rob gay
496613928a Fixed cook issues ([Backout] - CL34114021)
- Fixed regression with referencing graphs not updating
#tests AudioQA -cook
[FYI] hilda.cruz

Original CL Desc
-----------------------------------------------------------------
[Backout] - CL34112568 due to autotest error.
#rnx
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
More protections around accessing the wrong builder via the MetaSound builder registry by supplying the TopLevelPath of the asset if available when the registry has multiple conflicting entries due to bad content.
#rb helen.yang
#jira UE-216533
#rnx
[FYI] sondra.moyls

[CL 34125321 by rob gay in ue5-main branch]
2024-06-05 11:00:21 -04:00
hilda cruz
66ba34fea1 [Backout] - CL34112568 due to autotest error.
#rnx
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
More protections around accessing the wrong builder via the MetaSound builder registry by supplying the TopLevelPath of the asset if available when the registry has multiple conflicting entries due to bad content.
#rb helen.yang
#jira UE-216533
#rnx
[FYI] sondra.moyls

[CL 34114022 by hilda cruz in ue5-main branch]
2024-06-04 22:37:34 -04:00
rob gay
5bbc4d55ac More protections around accessing the wrong builder via the MetaSound builder registry by supplying the TopLevelPath of the asset if available when the registry has multiple conflicting entries due to bad content.
#rb helen.yang
#jira UE-216533
#rnx
[FYI] sondra.moyls

[CL 34112574 by rob gay in ue5-main branch]
2024-06-04 20:25:06 -04:00