PR #10378 [Source Control][5.2] Fix the Check In option in the context menu for Git & Plastic SCM
[FYI] wouter.burgers
#rb brooke.hubert
#jira UE-192845
#jira UE-184025
[CL 32232897 by SRombauts in ue5-main branch]
Compared to the PR:
- Fixed non-Unity compiles by adding several header includes.
- Fixed Linux compile error in SPlasticSourceControlBranchesWidget.cpp: FPlasticSourceControlBranchPtr vs FPlasticSourceControlBranchRef usage in ::GetSelectedBranches().
#jira UE-203360
#rb Manuel.Lang
#review-30764285
[CL 31119614 by SRombauts in ue5-main branch]
#rb wouter.burgers
#rnx
### SourceControl
- Remove link to "InputCore" as it is not used
- Only include slate and rendering modules if the target we are building for uses slate.
- Define SOURCE_CONTROL_WITH_SLATE as 0 if the target we are building for does not use slate.
- When SOURCE_CONTROL_WITH_SLATE is zero the following will be applied:
-- FRevisionControlStyleManager will not be compiled as it only makes sense if slate is enabled.
-- The monitoring aspect of FSourceControlFileStatusMonitor will be disabled as we cannot be notified of user interactions.
-- FScopedSourceControlProgress will compile but essentially do nothing.
-- The ::GetIcon method of ISourceControlState will no longer be compiled as it returns a FSlateIcon by value.
[CL 29516345 by paul chipchase in ue5-main branch]
Results with a 40K actors changelist editor startup time:
- Before: FPerforce::AddShelvedFilesToChangelist took 2:35 min
- After: FPerforce::AddShelvedFilesToChangelist took 160.08 ms
#rb sebastien.lussier
[FYI] jeansebastien.guay
[CL 29047110 by jeanfrancois dube in ue5-main branch]
+ Expand source control menu context with selected changelist,
+ Expose information about if changelist is default and its source control specific identifier,
#rb Patrick.Enfedaque, Patrick.Laflamme, zach.rammell
#preflight skip
#p4v-cherrypick 25526575
#preflight 64665919b91ab13b09c2089c
[CL 25528171 by jordan hoffmann in ue5-main branch]
- Failed if user had multiple p4 tickets
- Failed if default p4 username didn't match the provided username in UE
#jira UE-181982
#rb paul.chipchase
#preflight 643061621d61ecec3b63c465
[CL 24970980 by jordan hoffmann in ue5-main branch]
* Option to check in an asset from the Content Browser Source Control Context Menu is now enabled if the SCC does not use Snapshots instead of if it uses File Revisions
* Option to check in an asset from the Scene Outliner Source Control Context Menu is now enabled if the SCC does not use Snapshots instead of if it uses File Revisions
* Ability to uncheck files in the Submit Files Window is now enabled if the SCC does not use Snapshots instead of if it uses File Revisions
* Option to revert the writable flag on an asset in the Content Browser Source Control Context Menu is now enabled if the SCC uses checkout instead of if it uses File Revisions (like the 'Make Writable' option)
#jira UCS-6630
#rb brooke.hubert, wouter.burgers
#lockdown jeanmichel.dignard
#preflight 640e6b41482188d710ff8316
[CL 24724061 by marco anastasi in ue5-main branch]
#rb PJ.Kack
#jira UE-179343
#rnx
#preflight 6408511a6c1b9295b9804827
- The crash itself isn't that interesting but it does distract the user from the actual error/problem which caused the engine to shutdown during PreInit wasting time while they look into the crash instead of the original error.
- When attempting to unregister the menu extension we now call ::TryGet rather than ::Try as this will return nullptr if UToolsMenu is not loaded and will not attempt to load it.
[CL 24563201 by paul chipchase in ue5-main branch]
Update the default set of revision control icons
Create FRevisionControlStyleManager to manage the currently active revision control style and add a default style that is used by all providers
#rb lauren.barnes, brooke.hubert
#preflight 639364ee67018b14b5fb9891
[CL 23466976 by aditya ravichandran in ue5-main branch]
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch
#preflight 63635997876630122adeab9f
#rb none
[CL 22958990 by henrik karlsson in ue5-main branch]
Change perforce Revert option to be based on if an item is checked out or marked for add, rather than if it can be checked in.
#tests Used to implement source control menu refactor https://p4-swarm.epicgames.net/reviews/22528870
[CL 22863683 by christian savoie in ue5-main branch]
Add Revision and Force options to Plastic and Subversion.
#tests Used when implementing source control menu refactor https://p4-swarm.epicgames.net/reviews/22528870, only tested perforce sync command.
[CL 22683432 by christian savoie in ue5-main branch]
