290 Commits

Author SHA1 Message Date
aditya ravichandran
2f5538dc40 Revision Control Overlays:
Remove the package update table in favor of an activatable query that sweeps through all actors in the Scene to update their overlays
Activate said query when the SCC status of an object changes

TEDS:
Fix a crash with activatable queries where you could have duplicates in the pending activatable queries, but unregistering a query only removed one instance

PrimitiveComponent:
Add functionality to persist OverlayColor in UPrimitiveComponent using the ComponentInstanceDataCache

#rb brooke.hubert

[CL 36828353 by aditya ravichandran in 5.5 branch]
2024-10-03 13:01:38 -04:00
brooke hubert
b9ad6443ff [Backout] - CL36478576
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL36477705
[FYI] brooke.hubert
Original CL Desc
-----------------------------------------------------------------
[TEDS] Deprecate accessor functions for TEDS features inside the TypedElementRegistry class

#jira UE-224434
#rb logan.buchy, ronald.koppers

[CL 36749089 by brooke hubert in 5.5 branch]
2024-10-01 18:02:46 -04:00
bob tellez
4ceee5b1e2 [Backout] - CL36477705
[FYI] brooke.hubert
Original CL Desc
-----------------------------------------------------------------
[TEDS] Deprecate accessor functions for TEDS features inside the TypedElementRegistry class

#jira UE-224434
#rb logan.buchy, ronald.koppers

[CL 36747703 by bob tellez in 5.5 branch]
2024-10-01 17:47:03 -04:00
brooke hubert
bd19637ae3 [TEDS] Deprecate accessor functions for TEDS features inside the TypedElementRegistry class
#jira UE-224434
#rb logan.buchy, ronald.koppers

[CL 36747601 by brooke hubert in 5.5 branch]
2024-10-01 17:45:46 -04:00
paul chipchase
3a38a7254d Perforce will now return the correct workspace root after a user has changed the workspace via the UX.
#rb juan.legaz
#jira UE-224100

- Calls to FPerforceSourceControlProvider::GetStatus on the GameThread will end up using the persistent connection to determine the current workspace root. Before this change the persistent connection was not getting updated when the user changed the workspace via the UX, so we'd return the root of the original workspace when the editor started up, if one had been set.
- Added a call to reset the persistent connection when the FConnect command is run, we can then let the persistent connection be recreated when it is next requested.
- Changed FPerforceSourceControlProvider::PersistentConnection from a raw pointer to TUniquePtr to make management of it a bit easier.

[CL 36258840 by paul chipchase in 5.5 branch]
2024-09-13 04:37:56 -04:00
paul chipchase
336b02feee [Backout] - CL36226535 (failing non unity CIS and it's too late in the working day for me to safely submit fixes for that)
[FYI] paul.chipchase
Original CL Desc
-----------------------------------------------------------------
Perforce will now return the correct workspace root after a user has changed the workspace via the UX.

#rb juan.legaz
#jira UE-224100

- Calls to FPerforceSourceControlProvider::GetStatus on the GameThread will end up using the persistent connection to determine the current workspace root. Before this change the persistent connection was not getting updated when the user changed the workspace via the UX, so we'd return the root of the original workspace when the editor started up, if one had been set.
- Added a call to reset the persistent connection when the FConnect command is run, we can then let the persistent connection be recreated when it is next requested.
- Changed FPerforceSourceControlProvider::PersistentConnection from a raw pointer to TUniquePtr to make management of it a bit easier.

[CL 36230464 by paul chipchase in 5.5 branch]
2024-09-12 11:47:09 -04:00
paul chipchase
1c5cc8dbb0 Perforce will now return the correct workspace root after a user has changed the workspace via the UX.
#rb juan.legaz
#jira UE-224100

- Calls to FPerforceSourceControlProvider::GetStatus on the GameThread will end up using the persistent connection to determine the current workspace root. Before this change the persistent connection was not getting updated when the user changed the workspace via the UX, so we'd return the root of the original workspace when the editor started up, if one had been set.
- Added a call to reset the persistent connection when the FConnect command is run, we can then let the persistent connection be recreated when it is next requested.
- Changed FPerforceSourceControlProvider::PersistentConnection from a raw pointer to TUniquePtr to make management of it a bit easier.

[CL 36228097 by paul chipchase in 5.5 branch]
2024-09-12 10:54:46 -04:00
paul chipchase
153b96316d Fix perforce source control module from adding double slashes to local file paths if the workspace root is set to a volume root.
#rb juan.legaz, wouter.burgers
#jira UE-223965

### Problem
- Previously when storing the workspace root we assumed it would be a directory path and so normalized it to make sure that there was no trailing slash so that our file path parsing code in ::ParseOpenedResults would be consistent. Note that this was changed back in CL 23945151, before that the root could have a trailing slash or not which could cause issues.
- This assumption didn't work if the user decided to use a volume root (i.e D:\) as the workspace root, as in our path utilities normalizing code assumes that volume roots should end with a trailing slash. This in turn would result in local file paths being generated by ::ParseOpenedResults that contained duplicate slashes in the path.
- It is also worth noting that other source control implementations were specifically adding trailing slashes to their equivalents of the workspace root, so forcing perforce roots to not have the trailing slash was inconsistent with other implementations too.

### Solution
- We now enforce that the workspace root ends with a trailing slash unless the workspace root is null, and parse the results accordingly.
- We also removed duplicate slashes from the client root as perforce seems to technically support that even if p4v has issues with workspaces set up like this. At the very least this will move any issues from that to be pure perforce issues and not in our own parsing code.

[CL 36220660 by paul chipchase in 5.5 branch]
2024-09-12 03:03:41 -04:00
Ryan Hummer
4af2fd066d Updating Dev-Release-5.5 from Main at CL #36144969
#okforversepublic

[CL 36146571 by Ryan Hummer in Dev-5.5 branch]
2024-09-10 10:26:02 -04:00
eric boucher
70ad2bf9c6 Added a SetQuiet boolean to FGetFileList Source Control Operation to be able to prevent messages "... - no such file(s)." from generating errors in the logs.
#jira UE-216348
#rb wouter.burgers

[CL 35977637 by eric boucher in ue5-main branch]
2024-09-03 15:36:14 -04:00
logan buchy
7370c2dbd3 Hotfix crash/check in source control when project depends on EditorDataStorage but not EditorDataStorageFeatures
#rb aditya.ravichandran, brooke.hubert, ronald.koppers
#jira UE-222869

[CL 35888837 by logan buchy in ue5-main branch]
2024-08-28 21:31:28 -04:00
eric boucher
dbe08c1650 Hotfixing a warning in a previous Submit
#jira UE-216348
#rnx

[CL 35808367 by eric boucher in ue5-main branch]
2024-08-26 15:50:58 -04:00
eric boucher
ef71ea2b5b New localization option to move localized variants alongside source asset in the content browser and another one to detect if those localized variants are only in Revision Control:
- Project Settings / Editor / Assets / Internationalization / Rename Localized Variants Alongside Source Asset (defaults to: true)
 - Project Settings / Editor / Revision Control / Internationalization / Requires Revision Control to Rename Localizable Assets (defaults to: false) (works only with Perforce)

#jira UE-216348
#rb Jamie.Dale, wouter.burgers
[RN]

[CL 35804579 by eric boucher in ue5-main branch]
2024-08-26 14:02:18 -04:00
brooke hubert
1629ddebd6 [Teds] Rename TypedElementQueryBuilder namespace to UE::Editor::DataStorage::Queries and adjust alignment and whitespace of queries.
#rnx
#Jira UE-221957
#rb ronald.koppers

[CL 35800692 by brooke hubert in ue5-main branch]
2024-08-26 11:55:46 -04:00
brooke hubert
896debb96b [Teds] Removing the final TypedElementDataStorage namespace and DSI using declarations
Also cleaning up some of the nested namespaces per last CR, and some CoreMinimal.h includes switched to ICWYU

#rnx
#jira UE-221957
#rb ronald.koppers

[CL 35790037 by brooke hubert in ue5-main branch]
2024-08-24 14:22:52 -04:00
brooke hubert
86095329dc [Teds] Update naming for RowHandle, QueryHandle, and TableHandle
Some more namespacing adjustments

#jira UE-221957
#rb aditya.ravichandran
[FYI] lucas.dower

[CL 35601536 by brooke hubert in ue5-main branch]
2024-08-16 14:28:31 -04:00
zach rammell
1001b77aa8 Optimize revision control overlay application query
Stacks queries into subqueries that only fire when necessary, drastically reduces time spent per frame. (~40ms on huge levels down to ~2us)

#rb brooke.hubert, logan.buchy, ronald.koppers

[CL 35157261 by zach rammell in ue5-main branch]
2024-07-29 18:39:17 -04:00
juan legaz
b90b64d474 Fix Perforce create changelist moving all files from the default CL to the new changelist instead of creating an empty changelist or moving only the selected files
#rb benoit.chauvin, paul.chipchase

[CL 34280276 by juan legaz in ue5-main branch]
2024-06-11 12:17:21 -04:00
juan legaz
36f7696d0d Changed p4 change -i to p4 change and reusing the template that the server provides
This ensures that we use the changelist type from the server which was being dropped

#rb alan.kwan, paul.chipchase
#rnx

[CL 34089332 by juan legaz in ue5-main branch]
2024-06-04 05:55:08 -04:00
dave belanger
9f643a5589 Add project directory to p4 workspace error message
#rb wouter.burgers

[CL 34031005 by dave belanger in ue5-main branch]
2024-05-31 09:20:07 -04:00
steve robb
7f9dd540a6 Fixed IsDerivedFromSharedFromThis() when there are multiple TSharedFromThis bases.
Refactored the TSharedFromThis code to enforce a compile error when trying to create a TSharedPtr with multiple TSharedFromThis bases.
Fixed fallout.

#rb devin.doucette

[CL 33610597 by steve robb in ue5-main branch]
2024-05-13 18:24:48 -04:00
christian savoie
96154163d5 Add Revision Control option to copy remote paths
* Fix mixed file/folder selection to properly resolve all items in selection
* Fix revert writable to use filtered file list instead of full file list.
* Expose the number of paths required to trigger user dialog about large operations so it can be customized per operation

#tests Tested copy remote paths action with files, folders and a mix, including local only files
[REVIEW] [at]aditya.ravichandran [at]Julien.StJean [at]lauren.barnes
#rb brooke.hubert, wouter.burgers

[CL 33533507 by christian savoie in ue5-main branch]
2024-05-08 18:57:35 -04:00
paul chipchase
4cf57d2d1e Extend FSourceControlInitSettings to allow the caller to control if a provider uses values parsed from the commandline or not when initializing.
#rb Juan.Legaz
#jira UE-212182
#rnx

- We default to the old behavior, so that the default way of creating a source control provider (no FSourceControlInitSettings) will read all of the commandline parameters available and the newer way (creating a provider with a FSourceControlInitSettings) will ignore the commandline.

[CL 33001499 by paul chipchase in ue5-main branch]
2024-04-16 11:05:04 -04:00
paul chipchase
59c0c62184 Fix typo in log message when switching workspaces.
#rb Per.Larsson
#rnx

[CL 32925564 by paul chipchase in ue5-main branch]
2024-04-12 07:08:30 -04:00
ronald koppers
db98e6f842 Replaced all cases of AddOrGetColumn with AddColumn where the call wasn't using the returned column.
#jira UE-171500
#rb logan.buchy

[CL 32623648 by ronald koppers in ue5-main branch]
2024-03-29 16:50:41 -04:00