2112 Commits

Author SHA1 Message Date
dominik peacock
7ada6bad34 Fix: Saving map resets assigned replicated properties on different clients.
- When a remote user saves a map, Concert will hot reload the map on all other clients
- Hot reload creates a temporary map called "Untitled"
- During hot reload, ignore the delegates for changing maps

#jira UE-228018
#rb jason.walter

[CL 37258527 by dominik peacock in 5.5 branch]
2024-10-18 05:41:03 -04:00
dominik peacock
cb6cf08f6d Fix replication system preventing transactions when transaction contains no properties.
- Reverted back to old logic (since that worked) and made the condition for exclusion stronger (AllOf instead of AnyOf).
- Added check for empty property list (AllOf returns true if empty)
- Also added CVar MultiUser.AllowTransactionsOnReplicatedproperties to disallow this feature altogether

#jira UE-227473
#rb jason.walter

[CL 37063424 by dominik peacock in 5.5 branch]
2024-10-11 16:17:44 -04:00
jason walter
9c4a4035af Allow take recorder to disable sequencer pacing which is necessary to have the pending take update playhead position during a record. We also had to reorder when the events get applied because the sequencer events were setting the UMovieScene range before the time adjustment event could see the delta time change so that it could update the section position for playback when you are recording with a level sequence.
During testing, I found a crash on exit while in Multi-user that was missing a nullptr check in STakeRecorderCockpit.cpp

#jira UE-226665
#rb dominik.peacock
#lockdown alejandro.arango

[CL 37035463 by jason walter in 5.5 branch]
2024-10-10 16:52:10 -04:00
dominik peacock
d5bdb95170 Adjusted MU transaction filter used when replicating properties.
Now, transactions are blocked only if all properties being changed by the transaction are replicated. If at least one property is not replicated, the entire transaction is allowed through.

#jira UE-225658
#rb jason.walter

[CL 37022760 by dominik peacock in 5.5 branch]
2024-10-10 11:50:11 -04:00
aditya ravichandran
2f5538dc40 Revision Control Overlays:
Remove the package update table in favor of an activatable query that sweeps through all actors in the Scene to update their overlays
Activate said query when the SCC status of an object changes

TEDS:
Fix a crash with activatable queries where you could have duplicates in the pending activatable queries, but unregistering a query only removed one instance

PrimitiveComponent:
Add functionality to persist OverlayColor in UPrimitiveComponent using the ComponentInstanceDataCache

#rb brooke.hubert

[CL 36828353 by aditya ravichandran in 5.5 branch]
2024-10-03 13:01:38 -04:00
catalin dragoiu
06e7c253e2 Deprecate TraceDataFilters plugin because the functionality has been moved to the Trace Control Widget from Session Frontend and the Live Trace Control Widget from Unreal Insights.
#rb ionut.matasaru

[CL 36760813 by catalin dragoiu in 5.5 branch]
2024-10-01 20:00:14 -04:00
brooke hubert
b9ad6443ff [Backout] - CL36478576
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL36477705
[FYI] brooke.hubert
Original CL Desc
-----------------------------------------------------------------
[TEDS] Deprecate accessor functions for TEDS features inside the TypedElementRegistry class

#jira UE-224434
#rb logan.buchy, ronald.koppers

[CL 36749089 by brooke hubert in 5.5 branch]
2024-10-01 18:02:46 -04:00
bob tellez
4ceee5b1e2 [Backout] - CL36477705
[FYI] brooke.hubert
Original CL Desc
-----------------------------------------------------------------
[TEDS] Deprecate accessor functions for TEDS features inside the TypedElementRegistry class

#jira UE-224434
#rb logan.buchy, ronald.koppers

[CL 36747703 by bob tellez in 5.5 branch]
2024-10-01 17:47:03 -04:00
brooke hubert
bd19637ae3 [TEDS] Deprecate accessor functions for TEDS features inside the TypedElementRegistry class
#jira UE-224434
#rb logan.buchy, ronald.koppers

[CL 36747601 by brooke hubert in 5.5 branch]
2024-10-01 17:45:46 -04:00
dominik peacock
db4a7ada13 The user now automatically receives ownership over replicated properties that they add to their selection.
#jira UE-223843

[CL 36443195 by dominik peacock in 5.5 branch]
2024-09-19 14:01:30 -04:00
jason walter
a14297777e Add a project setting to control the visibilty of presence in game mode.
#jira UE-221494

[CL 36301171 by jason walter in 5.5 branch]
2024-09-16 09:56:59 -04:00
paul chipchase
3a38a7254d Perforce will now return the correct workspace root after a user has changed the workspace via the UX.
#rb juan.legaz
#jira UE-224100

- Calls to FPerforceSourceControlProvider::GetStatus on the GameThread will end up using the persistent connection to determine the current workspace root. Before this change the persistent connection was not getting updated when the user changed the workspace via the UX, so we'd return the root of the original workspace when the editor started up, if one had been set.
- Added a call to reset the persistent connection when the FConnect command is run, we can then let the persistent connection be recreated when it is next requested.
- Changed FPerforceSourceControlProvider::PersistentConnection from a raw pointer to TUniquePtr to make management of it a bit easier.

[CL 36258840 by paul chipchase in 5.5 branch]
2024-09-13 04:37:56 -04:00
jason walter
ce88516da3 Add support for primitive component in Level Instances / PA transactions.
#jira UE-220708

[CL 36244689 by jason walter in 5.5 branch]
2024-09-12 16:46:26 -04:00
paul chipchase
336b02feee [Backout] - CL36226535 (failing non unity CIS and it's too late in the working day for me to safely submit fixes for that)
[FYI] paul.chipchase
Original CL Desc
-----------------------------------------------------------------
Perforce will now return the correct workspace root after a user has changed the workspace via the UX.

#rb juan.legaz
#jira UE-224100

- Calls to FPerforceSourceControlProvider::GetStatus on the GameThread will end up using the persistent connection to determine the current workspace root. Before this change the persistent connection was not getting updated when the user changed the workspace via the UX, so we'd return the root of the original workspace when the editor started up, if one had been set.
- Added a call to reset the persistent connection when the FConnect command is run, we can then let the persistent connection be recreated when it is next requested.
- Changed FPerforceSourceControlProvider::PersistentConnection from a raw pointer to TUniquePtr to make management of it a bit easier.

[CL 36230464 by paul chipchase in 5.5 branch]
2024-09-12 11:47:09 -04:00
paul chipchase
1c5cc8dbb0 Perforce will now return the correct workspace root after a user has changed the workspace via the UX.
#rb juan.legaz
#jira UE-224100

- Calls to FPerforceSourceControlProvider::GetStatus on the GameThread will end up using the persistent connection to determine the current workspace root. Before this change the persistent connection was not getting updated when the user changed the workspace via the UX, so we'd return the root of the original workspace when the editor started up, if one had been set.
- Added a call to reset the persistent connection when the FConnect command is run, we can then let the persistent connection be recreated when it is next requested.
- Changed FPerforceSourceControlProvider::PersistentConnection from a raw pointer to TUniquePtr to make management of it a bit easier.

[CL 36228097 by paul chipchase in 5.5 branch]
2024-09-12 10:54:46 -04:00
paul chipchase
153b96316d Fix perforce source control module from adding double slashes to local file paths if the workspace root is set to a volume root.
#rb juan.legaz, wouter.burgers
#jira UE-223965

### Problem
- Previously when storing the workspace root we assumed it would be a directory path and so normalized it to make sure that there was no trailing slash so that our file path parsing code in ::ParseOpenedResults would be consistent. Note that this was changed back in CL 23945151, before that the root could have a trailing slash or not which could cause issues.
- This assumption didn't work if the user decided to use a volume root (i.e D:\) as the workspace root, as in our path utilities normalizing code assumes that volume roots should end with a trailing slash. This in turn would result in local file paths being generated by ::ParseOpenedResults that contained duplicate slashes in the path.
- It is also worth noting that other source control implementations were specifically adding trailing slashes to their equivalents of the workspace root, so forcing perforce roots to not have the trailing slash was inconsistent with other implementations too.

### Solution
- We now enforce that the workspace root ends with a trailing slash unless the workspace root is null, and parse the results accordingly.
- We also removed duplicate slashes from the client root as perforce seems to technically support that even if p4v has issues with workspaces set up like this. At the very least this will move any issues from that to be pure perforce issues and not in our own parsing code.

[CL 36220660 by paul chipchase in 5.5 branch]
2024-09-12 03:03:41 -04:00
Ryan Hummer
4af2fd066d Updating Dev-Release-5.5 from Main at CL #36144969
#okforversepublic

[CL 36146571 by Ryan Hummer in Dev-5.5 branch]
2024-09-10 10:26:02 -04:00
dominik peacock
3489891871 Fix: Reassigning property and then clearing it on the reassigned to client's machine removes the object
#jira UE-221868

[CL 36036175 by dominik peacock in ue5-main branch]
2024-09-05 07:59:07 -04:00
dominik peacock
7ed8be7bd7 Fix: Reassign context menu shows ticks next to clients that do not own the object
#jira UE-223496

[CL 36035841 by dominik peacock in ue5-main branch]
2024-09-05 07:32:42 -04:00
dominik peacock
ca137648a3 Context menu ?Reassign this to? and ?Reassign children to? was compacted to ?Reassign all to?
[CL 36035735 by dominik peacock in ue5-main branch]
2024-09-05 07:24:06 -04:00
dominik peacock
a4c9275bf9 Fix Blueprints not having their properties auto-added when added for replication.
The bug was that objects that had been trashed previously were being added instead of the live instances.

#jira UE-207192

[CL 36035402 by dominik peacock in ue5-main branch]
2024-09-05 07:01:36 -04:00
jason walter
2da851fa5c [Backout] - CL33004032
[FYI] eric.renaudhoude
Original CL Desc
-----------------------------------------------------------------
MultiUser: Added new media plate resource type to include object class filters.

#jira UE-212269
#rb jason.walter
#rnx

[CL 36010777 by jason walter in ue5-main branch]
2024-09-04 11:29:38 -04:00
dominik peacock
c94fff395e Offline client state now is refreshed when a replication activity is produced. This fixes the UI not showing an offline client the first time the client leaves the session.
#jira UE-223259

[CL 36003520 by dominik peacock in ue5-main branch]
2024-09-04 07:19:36 -04:00
dominik peacock
21ca28f727 Fix forgetting to unsubscribe from OnActivityAddedOrUpdated
[CL 36003003 by dominik peacock in ue5-main branch]
2024-09-04 06:40:34 -04:00
dominik peacock
4ca55b7f29 Refresh the list of known offline endpoints whenever an activity produced. This fixes offline client info not being displayed correctly in certain cases.
#jira UE-223260

[CL 36002850 by dominik peacock in ue5-main branch]
2024-09-04 06:24:04 -04:00