585 Commits

Author SHA1 Message Date
dmytro vovk
c0fee2a134 Bring back correct handling of TLS index in MB2\3
[CL 32500359 by dmytro vovk in 5.4 branch]
2024-03-26 03:01:19 -04:00
dmytro vovk
c84d75e48b Revert correct TLS Index check in MB2\3 & CSV Profiler to old behavior in an attemt to mitigate rate Linux server crash
[REVIEW] [at]ben.woodhouse

#localization none
#tests locally tested that both MB2 and MB3 allocators work on Win Client builds

[CL 32077055 by dmytro vovk in 5.4 branch]
2024-03-06 21:09:01 -05:00
jordan cristiano
9f2fea071b Compiled out namedevents csv metadata changes when UE_SERVER=1 for now.
Server csvs are being filtered out by PRS due to auto trace/framepro captures during the match.

#rb richard.smith
[FYI] ben.woodhouse

[CL 31579466 by jordan cristiano in 5.4 branch]
2024-02-16 16:04:22 -05:00
Johan Berg
9473f946ce Check for read only channels when enabling channels
Some channels are marked read-only (e.g. memory tracing channels) and cannot be toggled while the application is running. However there was no feedback when users tried to enable those channels using console commands for example or using the public API. With this change a logging channel argument is added to several internal methods in order to output information correctly, to console feedback when needed.

#rb ionut.matasaru
#jira UE-149917

[CL 31514835 by Johan Berg in 5.4 branch]
2024-02-15 05:55:03 -05:00
jordan cristiano
9ce9a4fc7d Fixed csv metadata for NamedEvents not being set if namedevents was enabled after the csv capture starts.
#rb evgenii.babinets
[FYI] ben.woodhouse
#tests Win64 test client csv start/stop with stat namedevents/stop with stat namedevents

[CL 31492121 by jordan cristiano in 5.4 branch]
2024-02-14 15:56:33 -05:00
Johan Berg
02c5d63342 Fallback path to standard stackwalking for memory tracing
In some cases our unwinding tables approach doesn't seem to work (e.g. compiled with clang). In those cases fall back to the standard stack walking methods.

#jira UE-197065
#rb ionut.matasaru

[CL 31170577 by Johan Berg in 5.4 branch]
2024-02-05 08:19:06 -05:00
Johan Berg
025a185aa4 Split all argument for Mac/Linux when launching UTS
All arguments must be separate entries in the argument array. Otherwise they will be passed a single extra argument.

#rb ionut.matasaru
#jira UE-204157

[CL 31122947 by Johan Berg in 5.4 branch]
2024-02-02 09:37:40 -05:00
dmytro vovk
3aec270fa8 Fixed default initialization of TLS slots to 0 and invalidity check against 0 as 0 is a valid TLS slot index
Attempt no. 2
#rb Francis.Hurteau, Matt.Peters

[CL 31121091 by dmytro vovk in 5.4 branch]
2024-02-02 07:23:47 -05:00
sean boocock
307169752f [Backout] - 31084550 - Blocking launching FN editor
[FYI] dmytro.vovk
Original CL Desc
-----------------------------------------------------------------
Fixed default initialization of TLS slots to 0 and invalidity check against 0 as 0 is a valid TLS slot index
#rb Francis.Hurteau, Matt.Peters

[CL 31088667 by sean boocock in 5.4 branch]
2024-02-01 10:58:11 -05:00
dmytro vovk
75e1bb8735 Fixed default initialization of TLS slots to 0 and invalidity check against 0 as 0 is a valid TLS slot index
#rb Francis.Hurteau, Matt.Peters

[CL 31084557 by dmytro vovk in 5.4 branch]
2024-02-01 08:32:06 -05:00
matt peters
aa31764f09 LLM and Insights Tracing: Fix the parent declarations of TagTraces to use the parent declared by LLM's TagData rather than constructing it from unique name, which does not always work. Also pass in the DisplayName paths for the tag names rather than the UniqueName. Also fix a crash on editor shutdown due to PlatformTLS being destructed after main before LLM is destructed after main.
#rnx
#rb Johan.Berg

[CL 31012942 by matt peters in 5.4 branch]
2024-01-30 13:18:48 -05:00
catalin dragoiu
433216dba2 Add Trace Pause/Resume menu entry to the Trace Editor Widget.
#rb ionut.matasaru
#jira UE-205279

[CL 31012113 by catalin dragoiu in 5.4 branch]
2024-01-30 12:56:04 -05:00
ionut matasaru
194a3ff2cc [Insights] Fixed few typos.
#rb Catalin.Dragoiu

[CL 30966485 by ionut matasaru in 5.4 branch]
2024-01-29 07:54:17 -05:00
ben woodhouse
d149200704 Make the CSV profiler free up temp stats memory when slack data exceeds a threshold in bytes, specified with csv.MaxPerThreadStatDataSlackKB (default 64KB). Setting to 0 cleans up slack immediately but results in a lot more allocations (and can block the memory allocator excessively in some cases, impacting game performance). This fixes issues on low end platforms where starvation of the CSV profiling thread can result in excessive slack memory that is not cleaned up until capture end.
Also add a debug cvar csv.PauseProcessingThread to pause the processing thread, simulating CPU starvation.

#rb serge.bernier
#tests Tested on Switch
[FYI] luke.thatcher

[CL 30946963 by ben woodhouse in 5.4 branch]
2024-01-26 18:14:37 -05:00
gwennael arbona
8f115ba252 Add new RecordEventAtFrameStart method to the CSV profiler
#rnx
#rb ben.woodhouse
#tests Works as advertized on a local build

[CL 30925133 by gwennael arbona in 5.4 branch]
2024-01-26 10:48:03 -05:00
johan berg
7e297fc6f6 Version 1.19 of UnrealTraceServer for windows
UnrealTraceServer executable and debug files.
Version: 1.19
Platform: windows, mac, linux
Architecture: x64 (windows, linux), x64/arm64 (mac)
Compiled with musl: false (windows, mac), true (linux)

#rb ionut.matasaru

[CL 30916794 by johan berg in 5.4 branch]
2024-01-26 04:18:22 -05:00
gwennael arbona
4a5f4269e9 Allow tweaking the CSV stream buffering
#rnx

#rb ben.woodhouse

[CL 30916543 by gwennael arbona in 5.4 branch]
2024-01-26 03:57:20 -05:00
steve robb
57ca754749 Fixed up more bool-taking calls to take EAllowShrinking instead.
[CL 30894744 by steve robb in 5.4 branch]
2024-01-25 14:17:31 -05:00
johan berg
04cf87bfc6 Fix UTS launch args on Linux/Mac
Command being sent to the argument will include the initial space. Our code in runtime does not trim the argument string and fails comparison to the recognized commands.

#rb ionut.matasaru
#jira UE-204157

[CL 30802457 by johan berg in ue5-main branch]
2024-01-23 09:16:53 -05:00
ionut matasaru
d9563b28ec Fixed "disableunity" build when UE_TRACE_ENABLED is off but UE_TRACE_SERVER_LAUNCH_ENABLED is on.
#rb Johan.Berg

[CL 30770666 by ionut matasaru in ue5-main branch]
2024-01-22 09:20:58 -05:00
steve robb
f029468598 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
steve robb
66266c6a11 Fixed up DerivedDataCache, DesktopPlatform, ApplicationCore, AssetRegistry, Core, CoreUObject, Projects, Sockets code to use EAllowShrinking instead of bools.
[CL 30676428 by steve robb in ue5-main branch]
2024-01-17 19:51:06 -05:00
marc audy
19e84555b3 Silence PVS warnings
[CL 30653812 by marc audy in ue5-main branch]
2024-01-17 01:34:02 -05:00
catalin dragoiu
0dd3cb2478 [Insights] Fix Unreal Insights Context Switch channel not enabling from Editor Widget correctly
#jira UE-181171
#rb ionut.matasaru

[CL 30634034 by catalin dragoiu in ue5-main branch]
2024-01-16 10:42:32 -05:00
ionut matasaru
c7b81e8e3a [Insights] Added the Windows error message to the log warning when the "UnrealTraceServer.exe" process fails to start. Also updated log messages re UTS launch.
#rb Johan.Berg

[CL 30590072 by ionut matasaru in ue5-main branch]
2024-01-12 06:32:59 -05:00