32 Commits

Author SHA1 Message Date
eric renaudhoude
eda9a1381c ColorManagement: Convert tests to low-level tests.
#jira UE-202757
#rb chris.constantinescu
#rnx

[CL 30430836 by eric renaudhoude in ue5-main branch]
2023-12-21 12:56:11 -05:00
eric renaudhoude
78e6eedd87 ColorManagement: Fix crash on Linux with unaligned color space transform.
#jira UE-202757
#rb rod.bogart
#rnx

[CL 30410892 by eric renaudhoude in ue5-main branch]
2023-12-20 08:31:01 -05:00
tim doerries
81e46c9468 Added missing max(0, ) to MakeFromColorTemperature() and MaterialExpressionBlackBody() and also added a missing clamp on the temperature input to MaterialExpressionBlackBody.
#rb Sebastien.Hillaire, eric.renaudhoude
#jira UE-200962
#rnx

[CL 29883313 by tim doerries in ue5-main branch]
2023-11-22 00:00:11 -05:00
marc audy
763a611985 Fix C4072 warnings
#rnx

[CL 29852844 by marc audy in ue5-main branch]
2023-11-20 17:26:53 -05:00
eric renaudhoude
5ed6651239 WorkingColorSpace: Replace recently added convenience sRGB-to-working colorspace function with native expression to minimize material instructions when used on parameters.
Note however that with the new HLSL generator, EOperation::Dot is currently not implemented making this particular path suboptimal.

#jira UE-197130
#rb sebastien.hillaire

[CL 29480744 by eric renaudhoude in ue5-main branch]
2023-11-05 12:29:05 -05:00
eric renaudhoude
c0e4318bcb ColorManagement: Fixed DDC2 texture build for advanced source color/encoding settings, added dependency on OpenColorIO library version for key invalidation.
#jira UE-188952
#rb dan.thompson

[CL 26442009 by eric renaudhoude in ue5-main branch]
2023-07-18 14:44:35 -04:00
eric renaudhoude
05b88f3bec [Resubmitting with fix]
-----------------------------------------------------------------
ColorManagement: Utilize OpenColorIO for advanced color space transformations on textures during mip generation.

Relies on CL 26098047.

#jira UE-182792
#rb rod.bogart, dan.thompson, charles.bloom

[CL 26109698 by eric renaudhoude in ue5-main branch]
2023-06-19 19:10:44 -04:00
eric renaudhoude
461a877a66 [Backout] - CL26106088
[FYI] eric.renaudhoude
Original CL Desc
-----------------------------------------------------------------
ColorManagement: Utilize OpenColorIO for advanced color space transformations on textures during mip generation.

Relies on CL 26098047.

#jira UE-182792
#rb rod.bogart, dan.thompson, charles.bloom

[CL 26107262 by eric renaudhoude in ue5-main branch]
2023-06-19 18:04:26 -04:00
eric renaudhoude
973792234b ColorManagement: Utilize OpenColorIO for advanced color space transformations on textures during mip generation.
Relies on CL 26098047.

#jira UE-182792
#rb rod.bogart, dan.thompson, charles.bloom

[CL 26106116 by eric renaudhoude in ue5-main branch]
2023-06-19 17:26:54 -04:00
henrik karlsson
5db685f97d [Engine]
* Moved dllexport from type to methods/staticvar in all Engine runtime code. This improves compile times, memory and performance in dll builds

[CL 26082269 by henrik karlsson in ue5-main branch]
2023-06-17 18:13:06 -04:00
eric renaudhoude
ae948c4ce8 OCIO: Avoid adding the matrix transform when the source color space equals the working one.
#jira UE-182792
#rb ruslan.idrisov, rod.bogart
#rnx

[CL 26069322 by eric renaudhoude in ue5-main branch]
2023-06-16 16:45:40 -04:00
eric renaudhoude
b4a4897946 ColorManagement: Adding luminance factor getter.
#jira UE-159144
#rb rod.bogart
#rnx

[CL 25873816 by eric renaudhoude in ue5-main branch]
2023-06-08 12:08:45 -04:00
kirill zorin
b6ee3a6c64 Fix UE_LOG callsites that have format string-related UB
#rb trivial
#preflight 647107780a6634dbb236a0a6

[CL 25651638 by kirill zorin in ue5-main branch]
2023-05-26 15:52:39 -04:00
eric renaudhoude
0ae7a8a580 ColorManagement: Added missing enum max values.
#jira none
#rb trivial
#preflight 646b8384af4d6ab0cbb2508a
#fyi rod.bogart

[CL 25564875 by eric renaudhoude in ue5-main branch]
2023-05-22 11:27:05 -04:00
eric renaudhoude
3a4211535a ColorManagement: Unifying use of FGenericPlatformMath in transfer functions.
#jira none
#rb none
#rnx
#preflight 6464eb0611205d3573ba0bb0

[CL 25507847 by eric renaudhoude in ue5-main branch]
2023-05-17 11:13:35 -04:00
eric renaudhoude
054deea19e ColorManagement: Ensure the working color space has been loaded before use by shader compilation.
#jira UE-178519
#rb rod.bogart, sebastien.hillaire
#rnx
#preflight 63fe3efb30633435f89d8cf1
#lockdown juan.canada

[CL 24450497 by eric renaudhoude in ue5-main branch]
2023-02-28 15:52:17 -05:00
eric renaudhoude
454df0b032 ColorManagement: Cleanup of XYZ/xyY conversion functions.
ToYxy functions were serving no purpose so we deprecate them, and expose a new XYZ to xyY function. We also remove unnecessary FORCEINLINE.

#jira none
#rb rod.bogart
#preflight 63f3dd281d71bcd2624c2c82

[CL 24324429 by eric renaudhoude in ue5-main branch]
2023-02-20 16:06:27 -05:00
steve robb
b1201830a3 Removed TIsSame usage from AIModule (part of a larger change to deprecate TIsSame).
#rb none
#preflight 63c1a94c2e714f64ad2d7f36

[CL 23685806 by steve robb in ue5-main branch]
2023-01-13 15:58:40 -05:00
eric renaudhoude
5548dc396d ColorManagement: Adding a color luminance getter to the color space class.
Additional comments/parameter names cleanup.

#rb rod.bogart
#jira none
#preflight 63853a13170bc34a937506b2

[CL 23337754 by eric renaudhoude in ue5-main branch]
2022-11-30 14:11:19 -05:00
eric renaudhoude
4beebdb224 ColorManagement: Ensure that the light component color temperature is based on the working color space.
#jira UE-168309
#rb sebastien.hillaire, charles.derousiers, rod.bogart
#preflight 637b8d69e30d4388491f8964

[CL 23226965 by eric renaudhoude in ue5-main branch]
2022-11-21 16:22:57 -05:00
eric renaudhoude
f91572bd7e ColorManagement: Adding ANSI E1.54 PLASA color space definition.
This is mainly for color accuracy of calibrated DMX light fixtures.

#jira UE-155535
#rb rod.bogart
#preflight 6374f631ee4d25f90a95ca90

[CL 23153826 by eric renaudhoude in ue5-main branch]
2022-11-16 10:01:14 -05:00
eric renaudhoude
52b39c8005 ColorManagement: Bradford chromatic adaption method as the default transform argument.
#jira none
#rb rod.bogart
#rnx
#preflight 63644b811052c15f13d2f80b

[CL 22970947 by eric renaudhoude in ue5-main branch]
2022-11-03 19:27:24 -04:00
bryan sefcik
cb0456c6d4 Cleaned up build.cs files by removing any include paths that were already being added by UBT. This was done to help identify how include paths are being added and to help with future refactoring.
#jira
#preflight 631a5c04967ffc68fbf0dd8f

[CL 21911226 by bryan sefcik in ue5-main branch]
2022-09-08 21:44:02 -04:00
Bryan sefcik
b4a6e947d8 Ran IWYU on Public headers under Engine/Source/Runtime/...
Headers are updated to contain any missing #includes needed to compile and #includes are sorted.  Nothing is removed.

#ushell-cherrypick of 21065896 by bryan.sefcik
#preflight 62d4b1a5a6141b6adfb0c892
#jira

#ROBOMERGE-OWNER: Bryan.sefcik
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21150156 via CL 21151754 via CL 21154719
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
#ROBOMERGE-CONFLICT from-shelf

[CL 21181076 by Bryan sefcik in ue5-main branch]
2022-07-20 11:31:36 -04:00
eric renaudhoude
98ff99ed72 ColorManagement: Prevent copy on SetWorking call with move assignment.
#jira none
#rb trivial
#rnx
#preflight 62b603d1466962cd9a299c8c

[CL 20814062 by eric renaudhoude in ue5-main branch]
2022-06-24 14:42:31 -04:00