40 Commits

Author SHA1 Message Date
Josh Adams
b4eaa18015 - BinkAudio VisionOS libs
#rb Dan.Thompson, Jeff.Fisher
#jira UE-210874

#p4v-cherrypick 32593555

[CL 32621853 by Josh Adams in 5.4 branch]
2024-03-29 15:42:41 -04:00
dan thompson
15c19ac743 Removing check() in favor of error handling to unblock - needs further investigation!
[CL 32496836 by dan thompson in 5.4 branch]
2024-03-26 00:49:54 -04:00
dan thompson
6a58137ed9 Cleanup pass on Bink Audio decoder - avoid creating buffers since the common case can decode directly to the output without any intermediaries. For a typical stereo sound, this saves around 15kb of memory per sound. ~30kb for 7.1.
#jira UE-199172
#rb fabian.giesen

[CL 32483934 by dan thompson in 5.4 branch]
2024-03-25 16:55:19 -04:00
dan thompson
de87b8f810 Submitting new bink decoder libs to pick up the radfft init race condition fixed a while back for the encoder libs.
#rb fabian.giesen

[CL 31312565 by dan thompson in 5.4 branch]
2024-02-08 18:57:17 -05:00
jake burga
3c55b06d30 BinkAudioInfo should "Reset" its decoders every time it seeks, not just when "PrepareToLoop" is called.
#rb charlie.huguenard, Dan.Thompson
#jira UE-201941
#tests PIE

[CL 30593685 by jake burga in ue5-main branch]
2024-01-12 10:45:33 -05:00
jimmy smith
34fd0ddf42 Latch an error state in the case where the decoder returns negative samples
#rb Maxwell.Hayes

[CL 30311667 by jimmy smith in ue5-main branch]
2023-12-13 19:57:10 -05:00
jake burga
fa6ac56033 Add API to seek to a specific frame so we can be way more accurate about seeking.
- Avoids converting Frames to Seconds then back to Frames again.
- Allows for more precise (frame specific) seeking

[REVIEW] [at]jimmy.smith [at]brian.chrisman

[CL 28273237 by jake burga in ue5-main branch]
2023-09-27 10:20:58 -04:00
brian chrisman
c2247a65e6 Fix for Bink and Opus audio skipping in Sequencer.
#rb jimmy.smith

[CL 27901537 by brian chrisman in ue5-main branch]
2023-09-14 19:21:34 -04:00
adam kinge
1cdc2791c2 Add an arm64 iOS Simulator build of the BinkAudioDecoder library
#jira UE-168571
#rb Dan.Thompson
#rnx

[CL 26193080 by adam kinge in ue5-main branch]
2023-06-22 16:39:51 -04:00
jimmy smith
2fac1cece3 Retroactive fix up from comments from review and const tidyup
#rb dan.thompson

[CL 25908611 by jimmy smith in ue5-main branch]
2023-06-09 19:46:34 -04:00
jimmy smith
97169e1e8c Fix for very large binks files creating garbage data
#rb dan.thompson
#jira UE-188256

[CL 25887585 by jimmy smith in ue5-main branch]
2023-06-08 23:20:33 -04:00
jimmy smith
0b7741527a Small refactor to centralize the seek logic
#rb dan.thompson ryan.mangin
#preflight 6477d6ad313d43282fc737c9

[CL 25769217 by jimmy smith in ue5-main branch]
2023-06-02 14:38:11 -04:00
dan thompson
62c3c31c05 Updating bink audio encoder to support larger seek tables and lower sample rates.
#rb fabian.geisen
#jira UE-187214
#jira UE-173274
#preflight 6477e019947ff6973cd05b8d

[CL 25732576 by dan thompson in ue5-main branch]
2023-06-01 13:44:14 -04:00
jimmy smith
13dbfcba26 READD: Chunked Seektables for BinkAudio (with Fixes)
#rb dan.thompson igor.dallavanzi

[CL 25645493 by jimmy smith in ue5-main branch]
2023-05-26 12:21:41 -04:00
jimmy smith
3b948e43be [Backout] - CL25419229
[FYI] jimmy.smith
Original CL Desc
-----------------------------------------------------------------
Chunked Seektables for BinkAudio
#rb dan.thompson igor.dallavanzi

[CL 25497743 by jimmy smith in ue5-main branch]
2023-05-16 17:05:51 -04:00
jimmy smith
201ef64f16 Chunked Seektables for BinkAudio
#rb dan.thompson igor.dallavanzi

[CL 25420189 by jimmy smith in ue5-main branch]
2023-05-10 20:29:00 -04:00
Dan Thompson
56d05caea1 Adding logs for bink audio encode errors.
#rb jeff.roberts
#preflight 63b87063763c6c106440532f

[CL 23603493 by Dan Thompson in ue5-main branch]
2023-01-06 16:37:28 -05:00
Dan Thompson
b4856d7914 Fix for some assets clicking on loop with bink audio.
#jira UE-168024
#rb jimmy.smith
#preflight 636aa7e04d3c1d9d92e5308b

[CL 23034020 by Dan Thompson in ue5-main branch]
2022-11-08 14:09:14 -05:00
Ben Marsh
32c2ff2e51 Use a quoted string for error message in BinkAudioInfo.cpp, to avoid invalid token caused by unpaired apostrophe (which would be parsed as a character literal).
See: https://gcc.gnu.org/onlinedocs/gcc-4.5.0/cpp/Diagnostics.html

#preflight none
#fyi Dan.Thompson

[CL 23011509 by Ben Marsh in ue5-main branch]
2022-11-07 10:59:53 -05:00
dan thompson
f46d2b2ada Fix for bink audio 96khz regression.
#jira UE-168185
#rb trivial
#preflight 63571e833d41a4455a72fd99

[CL 22788149 by dan thompson in ue5-main branch]
2022-10-26 16:14:53 -04:00
dan thompson
84999c3416 Fixes from the fuzz testing of bink audio encoder
#rb jeff.roberts
#jira UE-166765
#preflight 63473b178a0a7b2adc9deb3e

[CL 22489125 by dan thompson in ue5-main branch]
2022-10-12 20:06:15 -04:00
adam kinge
924d0087f2 Add tvOS as a compilable target for Bink Decoder lib. Note: lipo isn't used as we only support arm64 based AppleTVs
#jira UE-137693
#review-22122687 @dan.thompson
#fyi jack.porter, axel.riffard
#preflight 6345d277045315f96a31d835

[CL 22466036 by adam kinge in ue5-main branch]
2022-10-11 17:36:10 -04:00
adam kinge
75ab80e71a Add tvOS to the allowed platform Bink Audio Decoder list and include a tvOS compatible static lib.
#jira UE-137693
#rb dan.thompson, jack.porter, axel.riffard
#preflight 632cafe6d747fe52c86802ac

[CL 22151052 by adam kinge in ue5-main branch]
2022-09-22 22:17:14 -04:00
Dan Thompson
e6191e9102 Copyright boilerplate
#rb none
#preflight n/a

[CL 22083040 by Dan Thompson in ue5-main branch]
2022-09-19 18:29:45 -04:00
Dan Thompson
ab13eaa3b4 bink audio arm64 encoding consistency, and picking up a handful of minor tweaks/fixes. This also adds scripts for building the various apple libs that don't require cmake.
Currently we still rely on a handful of libm functions to be consistent across compilers/plaforms, however current consistency tests pass.

Due to the (very) narrow range we call log, a custom approximation is added to ensure consistency.

Additionally, we reset the floating point state on entry in case fp:fast has messed with it on our thread.

Note that the decoder libs are not currently updated as none of the fixes are worth the testing load due to lack of active bug reports.

#preflight 6328cf2af87253e021d862ad
#rb fabien.geisen jeff.roberts

[CL 22082773 by Dan Thompson in ue5-main branch]
2022-09-19 18:17:37 -04:00