200 Commits

Author SHA1 Message Date
mark lintott
b55614cb56 Final 5.4 Polish for StudioTelemetry
Added PIE.PreBegin span to StudioTelemetry which was not previously captured in the PIE Phase
Added FStudioTelemetry::ScopedSpan class
Added ScopedSpan Fort.PIEStart
Refcactored how span stack depth works. Now use a stack for all active spans. Spans no longer inherit a parent if one is not specifed, this means unrelated stagerred spans can now run wothout being stopped by an unrelated parent span.
Removed the Child Lists in Spans This i smuch sumpler code now. The Span only has a parent and the code to explicitly shut down child spans on close of parent is now internal to the Tracer implementation
Added a OnPIEStarted editor event which is the first poiint at which PIE is requested to Start. Moved the PIE span to start on this event. This means that FN Start PIE span is correctly counted as part of the PIE span and Editor.Interact PIE.Startup are more representative of the actual workflow.
Added ShutDownPIE event to the Editor code.
Added the PIE.Shutdown span that listens to the OnPIECancelled event, now we can track how long PIE actually takes to shutdown and return to Editor.Interact.
Added easy to use STUDIO_TELEMETRY_SPAN_SCOPE, STUDIO_TELEMETRY_START_SPAN,STUDIO_TELEMETRY_END_SPAN macros to StudioTelemetry
[FYI] matt.breindel, Francis.Hurteau, kevin.macaulayvacher
#rb kevin.macaulayvacher, Wes.Hunt

[CL 30959281 by mark lintott in 5.4 branch]
2024-01-28 11:24:45 -05:00
steve robb
57ca754749 Fixed up more bool-taking calls to take EAllowShrinking instead.
[CL 30894744 by steve robb in 5.4 branch]
2024-01-25 14:17:31 -05:00
mark lintott
0b01b4d0dc Fix to hitch span logic so that spans closed by parent spans whilst hithcing creates a new hitch span. This means we now get hitch detection immediately after PIE has started if it was already hithcing before it ended.
Added IsActive to FAnalyticsSpan API
Reduced Hitch Detector frequency from 5sec to 1sec
Added Asset Registry Activity span
[FYI] matt.breindel

[CL 30847807 by mark lintott in ue5-main branch]
2024-01-24 11:43:07 -05:00
mark lintott
5ccfb9e4f3 Added Heartbeat callback running every 5 seconds to track hitches
Added basic hitch detection telemetry to StudioTelemetryEditor
Changed const FName& to const FName across API calls so they are consistent
Added RecordEvent( Category, Name, Attributes ) to API for future feature support
Renamed RecordEvent( Provider,  Name, Attributes ) to RecordEventToProvider( ) so it is more explicit and does not confuse with  RecordEvent( Category.. )
Added new attribute Config_IsDebuggerPresent to track whether a debugger is attached to the session or not.
#rb matt.breindel

[CL 30836596 by mark lintott in ue5-main branch]
2024-01-24 03:18:01 -05:00
steve robb
104c0f2416 Fixed up more bool-taking calls to take EAllowShrinking instead.
[CL 30806200 by steve robb in ue5-main branch]
2024-01-23 11:07:28 -05:00
steve robb
fde2961f55 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30803608 by steve robb in ue5-main branch]
2024-01-23 09:51:10 -05:00
steve robb
f029468598 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
steve robb
f3624fbcbc Replaced UE_NORETURN with [[noreturn]].
Replaced PLATFORM_COMPILER_HAS_DECLTYPE_AUTO blocks.
Replaced PLATFORM_COMPILER_HAS_FOLD_EXPRESSIONS blocks.

[CL 30600164 by steve robb in ue5-main branch]
2024-01-12 14:20:07 -05:00
mark lintott
997b39095e Fix for AnalyticsTracer shutdown to properly end the open spans
[CL 30394832 by mark lintott in ue5-main branch]
2023-12-19 10:36:39 -05:00
mark lintott
6e838f66c0 Studio Telemetry Update:
Added IAnalyticsTracer and IAnalyticsSpan interface that superseeds the FFlowTracker
StudioTelemetry no longer uses FFLowTracker and uses the simpler IAnalyticsTracer API instead inspired by OpenTelemetry Tracer/Span model.
Deprecated FFLowTracker as of 5.4
Added lots of documentation to the StudioTelemetry plugin code.
Moved creation of the AnalyticsProviderLog to the public BaseEngine.ini so it can be used as a public facing example. This will simply write out a JSON file to the Saved/Telemetry folder and overwrite it per session
Added new callbacks for PIE so that we can decopule when a PIE work has been created and is ready from when ALL PIE worlds have been created and are ready which makes TimeToPIE accurate for all projects.
Rolled in some shutdown recommendations from Paul.Chipchase.
Various fixes and improvements to the JSON file logigng example. Now works correctly with Tableau import.
#rb Eric.Knapik, Wes.Hunt, paul.chipchase

[CL 30391931 by mark lintott in ue5-main branch]
2023-12-19 06:42:52 -05:00
mark lintott
ae0e1db18a Pushed Set/GetDefaultAttributes into IAnalyticsProvider
Fixed up FileLogging, AnalyticsSwrve and AnalyticsMulticast to implement the IAnalyticsProvider changes to Set/GetDefaultAttributes
Replaced dependency on IAnalyticsProviderET with IAnalyticsProvider in Studio Telemetry
Added Dynamic Analytics Provider Module Loading support. Replaced hard coded provider creation with dynamic IAnalyticsModule interface through modules
Added AnalyticsLog module as an example for 3rd parties to add custom, data driven IAnalyticsProviders to Studio Telemetry
Updated the ini files to use ProviderModule as the factory type for Porivder creation
[FYI] wes.hunt

[CL 30212753 by mark lintott in ue5-main branch]
2023-12-08 11:57:27 -05:00
robert millar
3cc6c3af19 Re-implement re-entrancy check using thread-local bool.
#rb Matt.Peters

[CL 29962798 by robert millar in ue5-main branch]
2023-11-28 12:20:24 -05:00
mark lintott
b99d530ce0 Moved EpicStudioAnalytics plugin to StudioTelemetry which is now public facing.
The intention is to provide a set of "in the box" telemetry hooks to our most common developer workflows for use internal Epic use and licensees
Moved startup of StudioTelemetry plugin much earlier to PostConfigInit stage so that sessions can start much earlier in the workflow
Added WIP Client support to telemetry plugin
Added data driven provider support for FAnlayiticProvidersET interfaces via BaseEngine.ini for common games and sample projects. Settings and URLs for EPic are only avaliable in Resttricted/NotForLicensee config folders for Lyra and Shooter game.
Added support for Horde telemetry and fixed up various problems with duplicate attributes being sent.
Added Core.VirtualAssets telemetry event
Added Core.Zen telemetry event
Added Core.IAS telemetry event
Added check for IOStoreOnDemand IsEnabled to avoid sending empty IAS events
Added FAnalyticsMulticastProvider to forward telemetry events to multiple providers contained within
Removed deprecated Fire_LoadingEvent from StudioAnalytics
[FYI] paul.chipchase
#rb Wes.Hunt

[CL 29908039 by mark lintott in ue5-main branch]
2023-11-23 07:06:10 -05:00
marc audy
a88b71c8b7 Fix/silence C4702 warnings
#rnx

[CL 29883627 by marc audy in ue5-main branch]
2023-11-22 01:04:15 -05:00
matt peters
2f2ce2f130 TelemetryRouter: Temporarily disable ReentrancyGuard until we have time to make it threadsafe.
#rnx
#rb logan.buchy

[CL 29876376 by matt peters in ue5-main branch]
2023-11-21 17:56:59 -05:00
lorry li
f7ee29e5fe Resubmit after: //Fortnite/Main/... changelist 29101420
Make retry system don't rely on Tick from game thread;
Make http tests can run with retry system enabled/disabled.

#jira UE-163631
[REVIEW] [at]michael.atchison [at]michael.kirzinger
#rb [at]michael.atchison, [at]michael.kirzinger
#tests Passed WebTests, also tried on Windows to reach main menu

[CL 29180201 by lorry li in ue5-main branch]
2023-10-27 08:42:11 -04:00
wes hunt
c6408e7334 Change analytics testing to not spew warnings if the flush takes too long. Still spews info logging to help profilers track down responsible parties. Will spew warnings when payloads are too large because those issues should be addressed immediately in any tool.
#jira UE-197708
[FYI] Matt.Peters
#tests Compile

[CL 29166462 by wes hunt in ue5-main branch]
2023-10-26 22:26:56 -04:00
bob tellez
549b6f8bc8 [Backout] - CL29087771
[FYI] lorry.li
Original CL Desc
-----------------------------------------------------------------
Make retry system don't rely on Tick from game thread;
Make http tests can run with retry system enabled/disabled.

#jira UE-163631
[REVIEW] [at]michael.atchison [at]michael.kirzinger
#rb [at]michael.atchison, [at]michael.kirzinger
#tests Passed WebTests, also tried on Windows to reach main menu

[CL 29101454 by bob tellez in ue5-main branch]
2023-10-25 16:43:47 -04:00
lorry li
c6aee9025c Make retry system don't rely on Tick from game thread;
Make http tests can run with retry system enabled/disabled.

#jira UE-163631
[REVIEW] [at]michael.atchison [at]michael.kirzinger
#rb [at]michael.atchison, [at]michael.kirzinger
#tests Passed WebTests, also tried on Windows to reach main menu

[CL 29087807 by lorry li in ue5-main branch]
2023-10-25 10:01:09 -04:00
matt peters
44783d48cd AnalyticsProviderETEventCache: Change the automation test from SmokeFilter (runs early on startup) to EngineFilter (runs only when requested). In monolithic editor configurations, running at SmokeFilter time occurs before StartupModule is called, and the test requires some code from StartupModule.
#jira UE-197708
#rnx
#rb Matt.Peters

[CL 29044243 by matt peters in ue5-main branch]
2023-10-24 08:59:56 -04:00
matt peters
926355f7f8 AnalyticsProviderETEventCache: Add more feedback to the warning message "EventCache took too long to flush."
#jira UE-197708
#rnx
#rb Wes.Hunt

[CL 28980900 by matt peters in ue5-main branch]
2023-10-20 16:43:43 -04:00
matt peters
5183f1b598 Analytics: Set PayloadFlushTimeSecForWarning to a larger value when running in commandlets because hitches in commandlets are unimportant.
#rnx
#rb Wes.Hunt

[CL 27171750 by matt peters in ue5-main branch]
2023-08-17 09:56:59 -04:00
robert millar
8fa30b3f98 Add size validation to sometimes catch copy-pasted guids in telemetry event declarations.
Use FMemoryView instead of const void*.

#rb none

[CL 26924675 by robert millar in ue5-main branch]
2023-08-08 14:29:17 -04:00
francis hurteau
562b56049f Fix for Analytics tick float overflow, restore original intent
#rb Rex.Hill

[CL 26688683 by francis hurteau in ue5-main branch]
2023-07-28 17:30:10 -04:00
michael atchison
5140f3d6c8 Add support for comments in the default http user agent string.
[REVIEW] [at]lorry.li, [at]eric.day

[CL 26498012 by michael atchison in ue5-main branch]
2023-07-20 17:21:44 -04:00