276 Commits

Author SHA1 Message Date
joe kirchoff
b6a6ef74f8 UnrealBuildTool: bTreatAsEngine module creates a pch variant, clean up some unneeded logic
#rnx
#rb christopher.waters, henrik.karlsson

[CL 31070246 by joe kirchoff in 5.4 branch]
2024-01-31 17:55:21 -05:00
joe kirchoff
baece90398 UnrealBuildTool: Move module and plugin validation out of BuildAsync and cleanup warnings
#rnx

[CL 30892704 by joe kirchoff in 5.4 branch]
2024-01-25 13:15:22 -05:00
joe kirchoff
8c09ed7d23 [Backout] - CL30856930
[FYI] Joe.Kirchoff
Original CL Desc
-----------------------------------------------------------------
UnrealBuildTool: Move module and plugin validation out of BuildAsync and cleanup warnings

#rnx

[CL 30863455 by joe kirchoff in 5.4 branch]
2024-01-24 17:03:01 -05:00
joe kirchoff
2a6f0ca55a UnrealBuildTool: Move module and plugin validation out of BuildAsync and cleanup warnings
#rnx

[CL 30858471 by joe kirchoff in 5.4 branch]
2024-01-24 15:14:30 -05:00
joe kirchoff
7082591a99 UnrealBuildTool: Improve cycle route when circular dependencies are found
#rnx

[CL 30693890 by joe kirchoff in ue5-main branch]
2024-01-18 15:10:00 -05:00
joe kirchoff
3d60bf9d4f UnrealBuildTool: Split out circular dependency module check out of module creation and into a ValidateModule function that can continue to recurse until a circular dependency is found or the graph is exhaused so the entire graph will be checked and so messages will be emitted for every build of a target even if the makefile is up to date
#rnx

[CL 30417075 by joe kirchoff in ue5-main branch]
2023-12-20 13:33:57 -05:00
jeff fisher
46724f146f UE-195321 InternalncludePaths typo (missing I on Include)
#jira UE-195321
#rb Francis.Hurteau

[CL 27834268 by jeff fisher in ue5-main branch]
2023-09-13 11:55:50 -04:00
joe kirchoff
da089d0875 Support for .natstepfilter
#rnx
#jira UE-190863
#jira UE-191341

#ushell-cherrypick of 26715542 by Joe.Kirchoff

[CL 26723680 by joe kirchoff in ue5-main branch]
2023-07-31 18:02:16 -04:00
robert millar
c1261e2c67 Add natvis files to build outputs and manifest to ensure they are copied to intermediate directory during precompile and tagged in horde builds.
#rb joe.kirchoff
#jira UE-182499

[CL 26720420 by robert millar in ue5-main branch]
2023-07-31 16:50:42 -04:00
bryan sefcik
adc423d1db Fixed an issue where the linux editor would not create/use the unrealed shared PCH.
#jira

[CL 25861570 by bryan sefcik in ue5-main branch]
2023-06-07 18:56:39 -04:00
joe kirchoff
030f1a90c3 UnrealBuildTool: Allow any engine module (bTreatAsEngineModule) to access Internal include paths from other modules
#jira UE-186956

[CL 25829083 by joe kirchoff in ue5-main branch]
2023-06-06 17:28:21 -04:00
bryan sefcik
e40d241cde Updated the shared pch logic to not follow the private module dependencies/includes when getting all the possible modules referenced in the pch header.
#jira
#preflight 647bc13b67505cf55c9db0c0

[CL 25783023 by bryan sefcik in ue5-main branch]
2023-06-03 19:34:57 -04:00
bryan sefcik
5fcc1c97a3 Updated the shared pch logic to traverse the dependency tree to find the best shared pch for each module. The logic before would only look at the direct dependencies which if changed could result in possibly worse compile times because a less optimal pch could be picked.
Note: There however are occasions where the old logic can give better shared pchs because it doesn't check whether there is a circular dependency. The new logic does check for circular dependencies so it can sometimes return a safer but less optimal shared PCH. If we find the old logic gives a better shared pch then we go ahead and use it. This will be removed after some of the circular dependencies are resolved.

#rb joe.kirchoff
#preflight 6477e3b87f02573726be946c

[CL 25720154 by bryan sefcik in ue5-main branch]
2023-05-31 23:29:01 -04:00
joe kirchoff
acacd6a8de UnrealBuildTool: More automated code cleanup
* Use object type rather than var
* Remove double newlines
* Use pattern matching

#rnx
#preflight 647780095d23eca37d28a387

[CL 25706751 by joe kirchoff in ue5-main branch]
2023-05-31 13:37:21 -04:00
joe kirchoff
acf80ab609 [Backout] - CL25694851
[FYI] Joe.Kirchoff
Original CL Desc
-----------------------------------------------------------------
UnrealBuildTool: More automated code cleanup

#rnx

[CL 25695155 by joe kirchoff in ue5-main branch]
2023-05-30 19:55:37 -04:00
joe kirchoff
7ed1a39679 UnrealBuildTool: More automated code cleanup
#rnx

[CL 25694864 by joe kirchoff in ue5-main branch]
2023-05-30 19:36:05 -04:00
joe kirchoff
c04da27b3b UnrealBuildTool: More automated code cleanup
#rnx
#preflight 64767efb4b1ead7c7f428c7a

[CL 25693857 by joe kirchoff in ue5-main branch]
2023-05-30 18:59:32 -04:00
joe kirchoff
36d266e932 UnrealBuildTool: Automated code cleanup
#rnx
#preflight 6476799e947ff6973c225619

[CL 25693241 by joe kirchoff in ue5-main branch]
2023-05-30 18:38:07 -04:00
joe kirchoff
57a8fe409c UnrealBuildTool: Use expression body for simple properties and accessors
#rnx
#preflight 64766abcfe6a3b258a04cb50

[CL 25691579 by joe kirchoff in ue5-main branch]
2023-05-30 18:01:50 -04:00
marc audy
b85c7f6304 [Backout] - CL25633679
[FYI] jodon.karlik
Original CL Desc
-----------------------------------------------------------------
UBT: Recursively gather the PublicDependencies and link the entire chain so the writer of a module does not need to understand the linking requirements of every Plugin they use.

#jira UE-166371
#preflight 646fbee150786bb5ba9e2ed2

[CL 25646787 by marc audy in ue5-main branch]
2023-05-26 12:41:53 -04:00
jodon karlik
6c93e02c88 UBT: Recursively gather the PublicDependencies and link the entire chain so the writer of a module does not need to understand the linking requirements of every Plugin they use.
#jira UE-166371
#preflight 646fbee150786bb5ba9e2ed2

[CL 25646395 by jodon karlik in ue5-main branch]
2023-05-26 12:35:49 -04:00
Joe Kirchoff
3a974f2a9d UnrealBuildTool: Print reference chain correctly for include path modules. Process references before include path modules
#rnx
#rb trivial
#preflight 646fc9db2739064275f3c804

[CL 25629576 by Joe Kirchoff in ue5-main branch]
2023-05-25 17:24:14 -04:00
bryan sefcik
543057b477 Fixed an issue where the public dependencies weren't being added to the include path list.
#rb joe.kirchoff
#preflight 645d0d91592448f08b9ce111
#preflight 6464fa322d446eac96d40d6a

[CL 25509605 by bryan sefcik in ue5-main branch]
2023-05-17 12:31:45 -04:00
bryan sefcik
130ae2366e [Backout] - CL25429497
#fyi bryan.sefcik
Original CL Desc
-----------------------------------------------------------------
Fixed an issue where the public dependencies weren't being added to the include path list.

#rb joe.kirchoff
#preflight 645d0d91592448f08b9ce111

[CL 25432128 by bryan sefcik in ue5-main branch]
2023-05-11 14:14:52 -04:00
bryan sefcik
47d43ac65f Fixed an issue where the public dependencies weren't being added to the include path list.
#rb joe.kirchoff
#preflight 645d0d91592448f08b9ce111

[CL 25429497 by bryan sefcik in ue5-main branch]
2023-05-11 12:22:26 -04:00