63 Commits

Author SHA1 Message Date
dan oconnor
13cf660589 Fix for crash when adding a component in the level editor after its scene root has been deleted, which is permitted for actors based on native classes that do not have a required scene root
#rb ben.hoffman
#jira UE-209295

[CL 32498309 by dan oconnor in 5.4 branch]
2024-03-26 01:50:51 -04:00
ben hoffman
c036408a8b Fix an incorrect tooltip on the Default Scene Root component in the subobject editor. It incorrectly said that "it cannot be copied", but it is perfectly valid to copy the scene root component and paste it somewhere else in the subobject hierarchy.
#jira UE-192769
#rb Zak.Middleton

[CL 30979438 by ben hoffman in 5.4 branch]
2024-01-29 17:43:13 -05:00
zhikang shao
7404e83db3 Reverting blueprint editor shortcut Alt+Shift+F to search locally by mapping it to the singular Find References action. The singular Find References action, while not exposed to UI for nodes that have Find References By Name/Class Member support, can still be triggered with shortcut and will trigger a local By Name or By Class Member search based on what the previous behavior was for that node type. For function nodes it will search by function name, while for variable nodes it will do an exact search since Find References already did that for a while.
However: function searches will do a quoted search by native function name. The previous behavior was unquoted search by node title (usually function display name). As a result, the previous behavior for Find References would fail in functions with special characters in their name. Now that the name is surrounded in quotes, all function names are supported. The new Find References behavior now searches for correct function name for parent call nodes, interface implementations, event overrides, where the previous behavior failed due to searching for node title.
#rb Phillip.Kavan

[CL 30856744 by zhikang shao in 5.4 branch]
2024-01-24 14:33:15 -05:00
zhikang shao
5a4f3dadcf #jira UE-196209
Improves "Find References" in blueprints: now supports function search by [class, function] call-sites and definitions rather than a generic search for function name. Replaces the "Find References" context menu action with a sub-menu for variables and functions in BlueprintEditor, WidgetBlueprintEditor, SubobjectEditor and SubobjectEditor. That context sub-menu has 'By Name' and 'By Class Member' search options and local+global versions of both.

Made changes to Find-in-Blueprints metadata that is generated per blueprint asset to be able to do "specific function of a specific class" type queries; some search types were unsupported with previous metadata. Incremented the EFiBVersion so that the Find-in-Blueprints search window will ask to re-index all blueprints and resave. Added an opt-out editor setting "Allow Index All Blueprints" (default: true) to disable the button, which can be decided per project. Added an action in the Find-in-Blueprints modal when outdated metadata is detected to export the list of affected assets.
#rb Phillip.Kavan

[CL 30316851 by zhikang shao in ue5-main branch]
2023-12-14 06:34:39 -05:00
zhikang shao
15c016080d [Backout] - CL30289707
[FYI] zhikang.shao
Original CL Desc
-----------------------------------------------------------------
#jira UE-196209
Improves "Find References" in blueprints: now supports function search by [class, function] call-sites and definitions rather than a generic search for function name. Replaces the "Find References" context menu action with a sub-menu for variables and functions in BlueprintEditor, WidgetBlueprintEditor, SubobjectEditor and SubobjectEditor. That context sub-menu has 'By Name' and 'By Class Member' search options and local+global versions of both.

Made changes to Find-in-Blueprints metadata that is generated per blueprint asset to be able to do "specific function of a specific class" type queries; some search types were unsupported with previous metadata. Incremented the EFiBVersion so that the Find-in-Blueprints search window will ask to re-index all blueprints and resave. Added an opt-out editor setting "Allow Index All Blueprints" (default: true) to disable the button, which can be decided per project. Added an action in the Find-in-Blueprints modal when outdated metadata is detected to export the list of affected assets.
#rb Phillip.Kavan

[CL 30289794 by zhikang shao in ue5-main branch]
2023-12-13 07:33:50 -05:00
zhikang shao
68c300ecfa #jira UE-196209
Improves "Find References" in blueprints: now supports function search by [class, function] call-sites and definitions rather than a generic search for function name. Replaces the "Find References" context menu action with a sub-menu for variables and functions in BlueprintEditor, WidgetBlueprintEditor, SubobjectEditor and SubobjectEditor. That context sub-menu has 'By Name' and 'By Class Member' search options and local+global versions of both.

Made changes to Find-in-Blueprints metadata that is generated per blueprint asset to be able to do "specific function of a specific class" type queries; some search types were unsupported with previous metadata. Incremented the EFiBVersion so that the Find-in-Blueprints search window will ask to re-index all blueprints and resave. Added an opt-out editor setting "Allow Index All Blueprints" (default: true) to disable the button, which can be decided per project. Added an action in the Find-in-Blueprints modal when outdated metadata is detected to export the list of affected assets.
#rb Phillip.Kavan

[CL 30289718 by zhikang shao in ue5-main branch]
2023-12-13 07:25:05 -05:00
julien stjean
dfdef598b8 Speculative fix for an crash in the function SSubobjectEditor::RestoreSelectionState.
If the node doesn't have a valid handle for its data source it will crash when calling the function GetVariableName.

#rb Daren.Cheng

[CL 29420659 by julien stjean in ue5-main branch]
2023-11-03 16:41:14 -04:00
dan oconnor
364291983a Make subobject editor fix more conservative, just fix implementation of SSubobjectEditor::GetSelectedItemsForContextMenu to provide the correct component for inherited SCS components
#jira UE-194087, UE-196020, UE-194833
#rb Phillip.Kavan, Ben.Hoffman

[CL 28670594 by dan oconnor in ue5-main branch]
2023-10-11 13:09:28 -04:00
maxime mercier
9ce8273e17 Many fixes of entity prefab workflow breaks
#jira UE-187726 UE-190931 UE-190932 UE-191758 UE-190668 UE-191847 UE-187746 UE-191979

[CL 27067346 by maxime mercier in ue5-main branch]
2023-08-14 08:59:19 -04:00
kirill zorin
de8db5ff76 Converting ARO-facing raw pointers to TObjectPtr ahead of raw pointer ARO API deprecation.
#rb zousar.shaker
#rb markus.breyer
#rb robert.manuszewski

#preflight 646391406b1406b54ab15460

[CL 25489627 by kirill zorin in ue5-main branch]
2023-05-16 10:52:49 -04:00
maxime mercier
73a6f9aeef Made the subobject editor respect overrides Interface API
#preflight 6446e67027014596f38f1038

[CL 25180602 by maxime mercier in ue5-main branch]
2023-04-25 10:53:00 -04:00
jlnordin
76ba018fed PR #9991: Fix Blueprint debugger crash when attempting to observe a TimerHandle variable (Contributed by jlnordin)
#review-23644523 patrick.boutot
#jira UE-173788
#preflight 63bebd47bf54fa7b36e5cc1c

[CL 23645193 by jlnordin in ue5-main branch]
2023-01-11 09:57:42 -05:00
geordiemhall
2f702d7cb3 PR #9595: Fix selected component being lost when compiling a Blueprint (Contributed by geordiemhall)
#jira UE-165026
#preflight 6387c9d3b21cdd3a26dc2082
#rb daren.cheng

[CL 23340078 by geordiemhall in ue5-main branch]
2022-11-30 16:37:42 -05:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
patrick enfedaque
e64f17803d SActorDetails: Fix SubObjectEditor not being cleared properly
#rb ben.hoffman
#preflight 6346e694663dafe4162f6b77
#rnx

[CL 22505214 by patrick enfedaque in ue5-main branch]
2022-10-13 11:21:34 -04:00
bryan sefcik
cb0456c6d4 Cleaned up build.cs files by removing any include paths that were already being added by UBT. This was done to help identify how include paths are being added and to help with future refactoring.
#jira
#preflight 631a5c04967ffc68fbf0dd8f

[CL 21911226 by bryan sefcik in ue5-main branch]
2022-09-08 21:44:02 -04:00
phillip kavan
a5b516dcc9 Add missing imports after dragging one or more non-imported namespaced type assets into the components tree in the Blueprint editor.
Change summary:
- Removed SSubobjectBlueprintEditor::FOnNewSubobjectAdded typedef and OnNewSubobjectAdded delegate members. Deprecation was not needed as these were added after the 5.0 release.
- Restored SSubobjectBlueprintEditor::AddNewSubobject() back to its original implementation (prior to adding the now-defunct OnNewSubobjectAdded event).
- Added USubobjectDataSubsystem::OnNewSubobjectAdded() to allow potential listeners to register for and receive successful subobject "add" event notifications.
- Modified USubobjectDataSubsystem::AddNewSubobject() to broadcast new subobject data to any registered listener(s) after a successful add.
- Added FBlueprintEditor::DeferredNamespaceImports to stack auto-imports for events that can be triggered more than once within a single frame.
- Modified FBlueprintEditor::OnComponentAddedToBlueprint() to handle subobject add events that target editor Blueprint objects. Also fixed to query the subobject class for its default import set instead of the subobject itself.
- Modified the FBlueprintEditor dtor to unregister the OnBlueprintUnloaded() event handler as I noticed this was not previously being done (benign as the shared ptr was skipped for being invalid, but this now removes us from the broadcast chain).
- Fixed up minor formatting inconsistencies in some legacy FBlueprintEditor analytics-related code paths.

#jira UE-148495
#rb Ben.Hoffman
#preflight 63078bf937470da4bf38fcf2

[CL 21688272 by phillip kavan in ue5-main branch]
2022-08-29 16:50:08 -04:00
bryan sefcik
8cc129f2b6 IWYU Pass 1 - Engine/Source/Editor/...
#jira
#preflight 6306736ac85b7fef22be7751

[CL 21558583 by bryan sefcik in ue5-main branch]
2022-08-24 22:45:13 -04:00
scott nelson
b009b1c743 Remove Go/Edit To Blueprint menu options when the blueprint is not accessible
#rb Dave.Belanger
#preflight 630010d00f7187ef8120a99c

[CL 21500775 by scott nelson in ue5-main branch]
2022-08-22 21:51:43 -04:00
bryan sefcik
98b51354ed Ran IWYU on Public headers under Engine/Source/Editor/...
Headers are updated to contain any missing #includes needed to compile and #includes are sorted.  Nothing is removed.

#ushell-cherrypick of 21065253 by bryan.sefcik
#jira
#preflight 62d5b3e91062f2e63014598e

#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21152630 via CL 21156388 via CL 21157044
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21181817 by bryan sefcik in ue5-main branch]
2022-07-20 11:56:29 -04:00
dave belanger
4b30163a23 Hide C++ related menus and hyperlinks from the subobject editor when C++ is not allowed
#rb Phillip.Kavan
#preflight skip

#ROBOMERGE-AUTHOR: dave.belanger
#ROBOMERGE-SOURCE: CL 21113526 via CL 21113534 via CL 21113687 via CL 21113722 via CL 21113747
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21142385 by dave belanger in ue5-main branch]
2022-07-17 22:41:08 -04:00
nate strohmyer
ae5cf68a2f Fixing empty Actors having a root component with an Edit in Blueprint hyperlink that doesn't work
#jira UE-145339
#rb ben.hoffman
#preflight 629921851941378d7c78e4f4

[CL 20490724 by nate strohmyer in ue5-main branch]
2022-06-03 14:53:17 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
ben hoffman
e629c84afb Only create a new default subobject when destroying a component if the owner's class is not native. Native owner classes do not have to have a DefaultSceneRoot when you drag in the C++ class directly from the content browser into the level.
#jira UE-130740
#rb marc.audy
#preflight 623a33f4b3653cf6afe52385

[CL 19482791 by ben hoffman in ue5-main branch]
2022-03-23 14:41:32 -04:00
Matt Peters
c1b46b1fed FAssetData: Callsites need to handle AssetData.GetClass() returning null. Added IsInstanceOf(UClass*) for the common operation GetClass() && GetClass->IsChildOf(BaseClass).
#jira UE-146521
#rb Zousar.Shaker
#rnx
#preflight 623874b789625f06129e466b

[CL 19450936 by Matt Peters in ue5-main branch]
2022-03-21 09:00:36 -04:00