154 Commits

Author SHA1 Message Date
phillip kavan
91e6a80f36 Fix a regression that could prevent widgets from being destroyed after closing an editor window containing a graph panel.
This could lead to an inability to delete certain assets through the content browser, as panel widgets would continue to reference the underlying graph object through the slate application context with no way to clean them up. In turn, this would result in the asset persisting and being (incorrectly) noted as now existing in a "corrupt" state.

After this change, the asset deletion dialog will no longer report the asset as being referenced in this manner.

This change also minimizes the number of active timers registered to the panel widget for incoming node add/remove graph change events (which matches what was already being done for node select events).

#jira UE-201589, UE-194980
#rb ben.hoffman

[CL 30895230 by phillip kavan in 5.4 branch]
2024-01-25 14:26:36 -05:00
geordiemhall
c2dd3c9d30 PR: Fix graph nodes flashing for a frame when using undo/redo
#10486
#rb zahra.nikbakht
#jira UE-187947

[CL 30514745 by geordiemhall in ue5-main branch]
2024-01-09 15:39:38 -05:00
phillip kavan
239da03f7b Minor revision to SGraphPanel to decouple its refresh on updates to the underlying graph object from a dependency on a parent SGraphEditor.
This allows SGraphPanel widgets that live outside of an editor context (e.g. previews) to avoid node/pin references going stale if the underlying graph object is reconstructed.

#jira UE-194980
#rb daren.cheng

[CL 29963162 by phillip kavan in ue5-main branch]
2023-11-28 12:35:28 -05:00
dclyde-brg
0dad69c707 PR #10992: Hover shortcut to use "Straighten Connections" on an outgoing pin
#jira UE-198179
#rb Dan.OConnor

[CL 29105045 by dclyde-brg in ue5-main branch]
2023-10-25 17:56:34 -04:00
sameer mirza
cb8d9da87a Tooltip on Links for Material Expressions
#jira UE-190993
#rb massimo.tristano

[CL 28919530 by sameer mirza in ue5-main branch]
2023-10-19 11:01:44 -04:00
kirill zorin
e1d4ae74ed Preemprively fixing compile errors ahead of API deprecation.
#rb trivial

[CL 26785872 by kirill zorin in ue5-main branch]
2023-08-02 16:05:28 -04:00
geordiemhall
57ee928f20 PR #9389: Allow using "spawn node" keyboard shortcuts while dragging from a pin
#jira UE-159588

[CL 26780272 by geordiemhall in ue5-main branch]
2023-08-02 14:08:05 -04:00
tyson brochu
d5364aa75a GraphEditor: add a new delegate that is called when the user single-clicks on a node
Cloth Editor: fix for interactive tool starting when the user drags a node in the dataflow graph editor


#jira UE-190816
#rb daren.cheng alex.mcadams

[CL 26547957 by tyson brochu in ue5-main branch]
2023-07-24 12:55:46 -04:00
kevin ortegren
0fdb62b687 Expose single click action within SGraphPanel to allow hooking custom logic
#rb JeanMichel.Dignard
#preflight 64764fb58137a37b8558e9bc
#p4v-cherrypick 25675485

[CL 25686356 by kevin ortegren in ue5-main branch]
2023-05-30 16:07:48 -04:00
kirill zorin
de8db5ff76 Converting ARO-facing raw pointers to TObjectPtr ahead of raw pointer ARO API deprecation.
#rb zousar.shaker
#rb markus.breyer
#rb robert.manuszewski

#preflight 646391406b1406b54ab15460

[CL 25489627 by kirill zorin in ue5-main branch]
2023-05-16 10:52:49 -04:00
halfdan ingvarsson
a233962e1e Control Rig: Link creation performance improvements
[FYI] benoit.gadreau
#rb sara.schvartzman
#preflight 63ef951f977ceed9151fad2e

[CL 24309702 by halfdan ingvarsson in ue5-main branch]
2023-02-20 02:18:32 -05:00
Andrew Rodham
4ff7bab147 Slate: Initial phase of FVector2D deprecation
- Expanded FDeprecateSlateVector2D to provide structs for parameters, return types and member variables that use FVector2f, while still allowing conversion to/from FVector2d with optional per-module deprecation mechanisms.
  - Many of the high-traffic SlateCore types like FSlateBrush, FGeometry and FSlateLayoutTransform have been converted to use these deprecation mechanisms.
  - Some legacy FGeometry::ToPaintGeometry and MakeChild overloads have been explicitly deprecated since they cause ambiguous overloads with FSlateLayoutTransform if it were to support implicit construction.
  - Deprecated ULocalPlayer::GetPixelBoundingBox and GetPixelPoint to prefer FVector2f for OptionalAllotedSize parameter since this parameter is expected to come from FGeometry
  - Exposed FVector2f members to blueprints

#jira none
#rb Andy.Davidson, Dave.Jones, Vincent.Gauthier, Patrick.Boutot
#preflight 63bc6fd068068a8bd6027c9f

[CL 23631073 by Andrew Rodham in ue5-main branch]
2023-01-10 14:46:43 -05:00
benjamin jillich
d549c737b8 [UE-169576] Can't insert reroute nodes via double click
#preflight 636ccad97c2b5051905401d1

[CL 23073713 by benjamin jillich in ue5-main branch]
2022-11-10 05:06:04 -05:00
benjamin jillich
a6ef0d5b7f [UE-136096] Relinking transitions in anim graph state machines
[UE-168360] User can create a transition from a state into the entry state

* Relinking multiple transitions (transition nodes at once) when none of the transition nodes is selected.
* Selective relinking in case a subset of the transition nodes on a transitions are selected.
* Special case handling for transitions from entry state (they don't have a transition node connected).
* Drawing circle indicator around the arrow head in case the mouse cursor is approaching the transition.
* Hovering the arrow head of a transition highlights it by filling the circle with solid orange color and turning the arrow black.
* Ending the relink operation in empty space or the entry node will cancel the relink operation.
* Fixed bug that prevents creating new transitions ending in an entry state.

#jira https://jira.it.epicgames.com/browse/UE-136096
#jira https://jira.it.epicgames.com/browse/UE-168360
#preflight 636a169963037c10262bc421

[CL 23025287 by benjamin jillich in ue5-main branch]
2022-11-08 04:09:22 -05:00
dave jones2
1b50b70aee UE-160862 - Fix FW-Gameplay miscellaneous module truncation warnings
#jira UE-160862
#preflight 63191b1cb069eea9ab594ea2
#rb andrew.davidson

[CL 21974045 by dave jones2 in ue5-main branch]
2022-09-12 18:16:22 -04:00
bryan sefcik
0837230669 Ran IWYU again on half of the Engine/Source/Editor/... source files.
#jira

[CL 21716414 by bryan sefcik in ue5-main branch]
2022-08-30 23:03:03 -04:00
fabian giesen
7d8781778c Deprecate TVector2 operator <, >, <=, >=
2D vectors are not canonically ordered and having these operators results in very unfortunate interactions with generic code. In particular FMath::{Min,Max,Abs} on TVector2s compile but do not behave as one would expect.

Add explicit comparison methods as a replacement and deprecate uses of TVector2 overloaded relational operators since it's confusing and error-prone. Fix existing uses to avoid deprecation warnings. Several of these fixes are behavioral changes to fix what I am reasonably certain are bugs in the existing code - in particular, uses of FMath::{Min,Max,Abs} on TVector2s that almost certainly actually want TVector2::{Min,Max,GetAbs} instead.

#rb charles.bloom,jeff.roberts
#preflight 62d70a6547779a730aaac04b

#ROBOMERGE-AUTHOR: fabian.giesen
#ROBOMERGE-SOURCE: CL 21168341 via CL 21173069 via CL 21173193
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21192034 by fabian giesen in ue5-main branch]
2022-07-20 18:23:11 -04:00
jordan hoffmann
0c729fbf28 Unshelved from pending changelist '20809968':
Additional right-click Blueprint graph context menu profiling.

#preflight 62be03913f0d6beee29e55e0

#ROBOMERGE-OWNER: jordan.hoffmann
#ROBOMERGE-AUTHOR: jordan.hoffmann
#ROBOMERGE-SOURCE: CL 20905335 via CL 20915206 via CL 20915216
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20917862 by jordan hoffmann in ue5-main branch]
2022-07-01 14:16:41 -04:00
jordan hoffmann
927a75a885 [BugFix] Crash using blueprint Diff view without a selected diff item
- This was the result of a merge error. I removed the duplicate/incorrect code

#jira UE-156396
#jira UE-156396

[BugFix] Selected diff Pins aren't highlighted in blueprints with more than one graph
- FocusedDiffResult attribute returned the index of the diff result in a list of all diff results when it needed to return the index of a subset array that only includes results diffs between the currently rendered graph
#preflight 62a7d093045c9fe61ee09c19

[CL 20638583 by jordan hoffmann in ue5-main branch]
2022-06-13 20:11:07 -04:00
jordan hoffmann
6b0807f33f [BugFix] Crash using blueprint Diff view on complex blueprints
+ also added in Pin_DiffHighlight brush that never got committed
#preflight 62a3acd42558795127e5341c
#rb ben.zeigler

[CL 20602390 by jordan hoffmann in ue5-main branch]
2022-06-10 16:58:41 -04:00
jordan hoffmann
490bccda39 [Feature] blueprint diff node outlines colored by diff state
#jira UE-150555
#rb aditya.ravichandran
#preflight 62a38ead2558795127e232d0

[CL 20600224 by jordan hoffmann in ue5-main branch]
2022-06-10 14:52:59 -04:00
jordan hoffmann
ff6648b05f [BugFix] BP_Diff data flow changes
- because the graphs were being diffed in two different ways - once to generate the list and once to determine how to render the nodes, there were some differences in the diff behavior that caused certain nodes to not render as diffed even though they showed up in the list. this change uses the same diff list for both now so there shouldn't be any differences anymore

- This also solves an issue that caused highlighted pins from Blueprint Diff to persist to the blueprint itself. Now all visual modifications made by the diff viewer only appear in the diff panels rather than the main graph
#jira UE-93061
#preflight 62a256ef2469f462fdd9c693
#rb daren.cheng

This change sets up for future style changes allowing for us to render nodes in the diff graph based on their diff type. There are no style changes in this CL however.

[CL 20584624 by jordan hoffmann in ue5-main branch]
2022-06-09 16:44:27 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
julien lheureux
d59f4548e8 Fixed typo found by static analysis
#rb trivial
#preflight none
#rnx
#ue UE-150237

[CL 19919437 by julien lheureux in ue5-main branch]
2022-04-26 09:56:25 -04:00
julien lheureux
c6e5b5d7a7 Improved behavior on links in graphs that support multiple links per pin.
Fixes issues with highlighting and alt-click delete on a link.

#rb lauren.barnes
#preflight 62631588bc24759dc755101a

[CL 19900843 by julien lheureux in ue5-main branch]
2022-04-25 08:49:05 -04:00