34 Commits

Author SHA1 Message Date
jimmy smith
ccd3012a3d Dynamic Submixes rework
#rb phil.popp
#jira UE-200458

[CL 31578402 by jimmy smith in 5.4 branch]
2024-02-16 15:44:26 -05:00
jimmy smith
234ea64fff Dynamic Submix fixes:
- Fix unregistering submix on disconnect
- Fix debug command to correctly view graph
#jira UE-195550
#jira UE-195861
#rb ryan.mangin max.hayes

[CL 28558870 by jimmy smith in ue5-main branch]
2023-10-06 17:32:01 -04:00
aditya ravichandran
31830290ab Asset Editors: Deprecate OnClose and RequestClose in favor of similar functions that take in a close reason
Fix a crash in some asset editors when you force deleted an asset with pending changes and hit "cancel" on the save dialog

#jira UE-107248
#preflight 64517c880e33f2d51d6e3adb

[CL 25321878 by aditya ravichandran in ue5-main branch]
2023-05-03 14:45:26 -04:00
bryan sefcik
0837230669 Ran IWYU again on half of the Engine/Source/Editor/... source files.
#jira

[CL 21716414 by bryan sefcik in ue5-main branch]
2022-08-30 23:03:03 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
Matt Peters
c1b46b1fed FAssetData: Callsites need to handle AssetData.GetClass() returning null. Added IsInstanceOf(UClass*) for the common operation GetClass() && GetClass->IsChildOf(BaseClass).
#jira UE-146521
#rb Zousar.Shaker
#rnx
#preflight 623874b789625f06129e466b

[CL 19450936 by Matt Peters in ue5-main branch]
2022-03-21 09:00:36 -04:00
rob gay
3e8333ed69 Fix drag-and-drop misleadingly showing icon/tooltip saying you cannot drop Submixes on the Submix Graph Editor
#rb aaron.mcleran
#jira UE-106284

#ROBOMERGE-SOURCE: CL 15344018 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15359341 by rob gay in ue5-main branch]
2021-02-08 15:57:56 -04:00
Marc Audy
a7c9001a94 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14075166
#rb
#rnx

[CL 14075271 by Marc Audy in ue5-main branch]
2020-08-11 01:36:57 -04:00
brooke hubert
a470770796 Remove deprecated asset editor manager.
#Jira none
#rb lauren.barnes

[CL 13816532 by brooke hubert in ue5-main branch]
2020-07-01 16:35:41 -04:00
Marc Audy
11f5b21210 Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main)
#rnx

[CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
ethan geller
19e0259c7c Minifix: remove ensure since it will fire when the wire isn't connected to a pin yet.
#ROBOMERGE-SOURCE: CL 11369996 via CL 11370012
#ROBOMERGE-BOT: (v654-11333218)

[CL 11370019 by ethan geller in Main branch]
2020-02-11 21:23:27 -05:00
ethan geller
370ae85daf #jira UE-88442
Fix for bad submix state when you click "Break Links..." on the output pin of an input submix.
#rb maxwell.hayes
[FYI] kevin.neilson


#ROBOMERGE-SOURCE: CL 11369446 via CL 11369453
#ROBOMERGE-BOT: (v654-11333218)

[CL 11369459 by ethan geller in Main branch]
2020-02-11 21:08:05 -05:00
ethan geller
f76c7b5d59 #jira UE-88411, UE-88400, UE-88402
Fixes for various static analysis warnings.
[FYI] marc.audy


#ROBOMERGE-OWNER: ethan.geller
#ROBOMERGE-AUTHOR: ethan.geller
#ROBOMERGE-SOURCE: CL 11309897 via CL 11309923
#ROBOMERGE-BOT: (v653-11302973)

[CL 11311354 by ethan geller in Main branch]
2020-02-10 16:04:01 -05:00
ethan geller
1b9558d5fa Editgrate 4.25 audio features from project stream:
-Soundfield Submixes
-Endpoint Submixes
-Unreal Ambisonics Encoder/Decoder

[FYI] aaron.mcleran, maxwell.hayes, phil.popp, rob.gay, charles.egenbacher, kevin.neilson


#ROBOMERGE-OWNER: ethan.geller
#ROBOMERGE-AUTHOR: ethan.geller
#ROBOMERGE-SOURCE: CL 11302185 via CL 11302187
#ROBOMERGE-BOT: (v649-11301724)

[CL 11302191 by ethan geller in Main branch]
2020-02-09 18:57:53 -05:00
ryan durand
627baf970a Updating copyright for Engine Editor.
#rnx
#rb none


#ROBOMERGE-SOURCE: CL 10869241 via CL 10869527 via CL 10869904
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870586 by ryan durand in Main branch]
2019-12-26 15:33:43 -05:00
rob gay
964c7aae88 - Fix infinite recursion crash in editor when adding submix and disallowing linking submix as master's parent
- Fix crash when removing a child submix from parent in wrong submix command cue (causing a modification of children while looping through parent ProcessAudio call)
- Clean-up weakptrs in submix instances that become invalid
- Ensure submix soft object paths are loaded on game thread
#rb ethan.geller
#jira UE-86096


#ROBOMERGE-SOURCE: CL 10868601 via CL 10869790
#ROBOMERGE-BOT: (v613-10869866)

[CL 10869972 by rob gay in Main branch]
2019-12-24 16:11:48 -05:00
rex hill
62bc081d51 Brought over changes related to Tool Menus
#rnx
#rb none


#ROBOMERGE-OWNER: rex.hill
#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 9968254 via CL 9968365
#ROBOMERGE-BOT: (v560-9963197)

[CL 9969240 by rex hill in Main branch]
2019-11-04 12:21:36 -05:00
rob gay
582216c52d Minor clean-up regarding static analysis warning
#rb none
#jira UE-82733

#ROBOMERGE-SOURCE: CL 9890829 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v553-9872581)

[CL 9890839 by rob gay in Main branch]
2019-10-30 10:28:04 -04:00
Marc Audy
bf4db5fd35 Refix static analysis warning
#rb
#rnx
#fyi Rob.Gay
#robomerge[RELEASE] 4.24

[CL 9889642 by Marc Audy in Main branch]
2019-10-30 07:41:57 -04:00
Rob Gay
940c3f3133 Bad merge & variable hiding warning fix
#rb none
#jira none

[CL 9886362 by Rob Gay in Main branch]
2019-10-29 16:52:54 -04:00
rob gay
c68ed55092 Copy fixes to 4.24: SoundSubmix Editor Improvements
- Make Submix graph point in an intuitive direction and change input/output directions.
- Fix bugs around adding/removing submixes and having multiple editors open.
- Move implementation and definitions so SoundSubmix updates builds faster (remove SoundSubmix.h references from bulky headers that are used all over the engine)
- Safeguards around only having a single editor open for a given submix (avoids having multiple similar but not same graphs open for the same asset, which gets super confusing visually and hard to track in code)
- Enforce not being able to delete an editor's root submix from the graph (to avoid having to rebase the editable objects in the graph)

#rb ethan.geller
#jira UE-82681

#ROBOMERGE-OWNER: rob.gay
#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 9884534 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v553-9872581)

[CL 9884577 by rob gay in Main branch]
2019-10-29 15:27:35 -04:00
rob gay
904d209a75 - Safeguards around only having a single editor open for a given submix (avoids having multiple similar but not same graphs open for the same asset, which gets super confusing visually and hard to track in code)
- Enforce not being able to delete an editor's root submix from the graph (to avoid having to rebase the editable objects in the graph)
#rb ethan.geller


#ROBOMERGE-OWNER: rob.gay
#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 9881046 via CL 9881616
#ROBOMERGE-BOT: (v553-9872581)

[CL 9882163 by rob gay in Main branch]
2019-10-29 12:50:18 -04:00
marc audy
c0bd3ae202 Fix static analysis warning
#jira UE-82380
#rnx
[CODEREVIEW] Rob.Gay


#ROBOMERGE-SOURCE: CL 9786825 via CL 9786851
#ROBOMERGE-BOT: (v545-9751379)

[CL 9786859 by marc audy in Main branch]
2019-10-24 09:48:53 -04:00
rob gay
9338ad951c Clean-up SoundSubmix Implementation
- Make Submix graph point in an intuitive direction and change input/output directions.
- Fix bugs around adding/removing submixes and having multiple editors open.
- Move implementation and definitions so SoundSubmix updates builds faster (remove SoundSubmix.h references from bulky headers that are used all over the engine)
#rb aaron.mcleran


#ROBOMERGE-OWNER: rob.gay
#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 9766775 via CL 9766776
#ROBOMERGE-BOT: (v545-9751379)

[CL 9766806 by rob gay in Main branch]
2019-10-23 20:59:18 -04:00
Chris Gagnon
2e87118a18 Copying //UE4/Dev-Editor to Dev-Main (//UE4/Dev-Main) Interim 4.24.
#rb none

[CL 8614014 by Chris Gagnon in Main branch]
2019-09-10 11:35:20 -04:00