64 Commits

Author SHA1 Message Date
bryan sefcik
da92084a12 Optimized out more private modules includes and dependencies.
#preflight 64627c382965f6ea8ea83bd6

[CL 25479683 by bryan sefcik in ue5-main branch]
2023-05-15 16:26:12 -04:00
michael balzer
3be89ca0d5 StaticMeshEditor: Fix "Vert Color" toggle ignoring "Show Environment" preview flag
#jira UE-89109
#preflight 63dd9009cc75b13767802721
#rb jimmy.andrews

[CL 24009742 by michael balzer in ue5-main branch]
2023-02-04 00:33:49 -05:00
Kevin Ortegren
d355eb16c0 Disable shadows on preview scene sky
PR Description: "In the AdvancedPreviewScene, the skysphere appears to be casting shadows. This causes the directional light to not affect the current asset and prevents the user from properly seeing their changes. This is most obvious with the material editor as well as the static mesh editor, where the asset would appear dark due to only sky lighting being present. I have reproduced this when using Lumen with hardware ray tracing and it appears to be caused by Lumen tracing against backfaces. I have not attempted to reproduce this without hardware ray tracing due to the fact that the fix is simple and won't affect non hardware ray tracing. The sky didn't have the shadows disabled because previous forms of lighting ignored backfaces. But now, with backfaces being traced against, this seems like a good idea."

#jira UE-173255
#rb ola.olsson
#fyi krzysztof.narkowicz
#preflight

PR #9965

[CL 23788293 by Kevin Ortegren in ue5-main branch]
2023-01-20 07:08:50 -05:00
bryan sefcik
8cc129f2b6 IWYU Pass 1 - Engine/Source/Editor/...
#jira
#preflight 6306736ac85b7fef22be7751

[CL 21558583 by bryan sefcik in ue5-main branch]
2022-08-24 22:45:13 -04:00
ben hoffman
1c6f4ecf3f Deprecate old uses of ControllerId in any editor viewport clients.
#jira UE-147796
#rb Patrick.Boutot
#rb Michal.Cieciura
#preflight 62b0e2ae8e03312ad83c4116
#rnx

[CL 20745139 by ben hoffman in ue5-main branch]
2022-06-20 17:24:28 -04:00
jason hoerner
11ea386451 RHI validation fix: avoid redundant RHI frame begin/end when cubemap capture occurs during UEngine::Tick, and other Tick related functions where the RHI frame will already be active. A boolean "bInsideTick" flag is passed to UReflectionCaptureComponent::UpdateReflectionCaptureContents, specifying whether the cubemap capture is happening during Tick.
The four places this applies include UEditorEngine::Tick, UGameEngine::Tick, FAdvancedPreviewScene::Tick, and FPreviewScene::UpdateCaptureContents.  The last example is called from FBlueprintEditor::Tick and FThumbnailPreviewScene::Tick.

The counter-example is "UEditorEngine::BuildReflectionCaptures", which doesn't appear to be called anywhere from a Tick related function.  It's called in startup functions, various commands, and as part of static lighting generation.  If we run into further validation errors, we could add a flag to that function to differentiate those cases.  Even though there's only one counter-example, I figured it was best to err on the side of not changing behavior of client code that may also be using the function, so by default "bInsideTick" is set to false.

#jira UE-153604
#rb mihnea.balta jason.nadro
#rnx
#preflight 628d89082f2409bc1e08a42e

[CL 20362380 by jason hoerner in ue5-main branch]
2022-05-25 07:11:28 -04:00
Helge Mathee
c7ab7d5498 AdvancedPreviewScene: Allow to select things below the ground
#rb thomas.sarkanen
#jira na
#preflight https://horde.devtools.epicgames.com/job/628652472b53e2be4ca9f231

[CL 20280501 by Helge Mathee in ue5-main branch]
2022-05-19 10:45:32 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
chris kulla
862d615ec1 Allow caching of ray tracing instances for preview scenes
This enables the use of path tracing for the material editor and static mesh editors.

#rb Juan.Canada
#preflight 620c5818492761fc5ca38895

[CL 19009187 by chris kulla in ue5-main branch]
2022-02-15 21:07:37 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
geoff evans
46f99e3891 Fixed some warnings when trying to save a config that is read only.
The dataprep one doesn't have to save if it can't. It recreate the setup on the next boot.
The collision one is in the project setting where there is a visual warning if the ini file is in a read only mode.

#jira UE-132811
#rb JeanMichel.Dignard
#preflight 617c0c625dbdbc00016ea668

#ushell-cherrypick of 17984359 by Julien.StJean

#ROBOMERGE-AUTHOR: geoff.evans
#ROBOMERGE-SOURCE: CL 18006564 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v885-17909292)

[CL 18006602 by geoff evans in ue5-release-engine-test branch]
2021-11-01 15:07:40 -04:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
patrick laflamme
b18dc332d0 Added a 'Preview Profiles' combo box to the advances preview scene toolbar to quickly change preview profiles.
- The profile combo is only visible when the user has more than one profile
  - This was added to the Material Editor, the Static Mesh Editor and Niagara Editor.

#jira UETOOL-2775  Add preview scene background profile dropdown to asset editor vieport toolbar.
#rb Lauren.Barnes, Brooke.Hubert
#preflight 6130c00617a8610001b8ba61

#ROBOMERGE-SOURCE: CL 17402767 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17402787 by patrick laflamme in ue5-release-engine-test branch]
2021-09-02 10:04:12 -04:00
helge mathee
cfcd4e9777 Control Rig: Sync floor actor with floor mesh component in preview scene
#rb sara.schvartzman
#jira na

#ROBOMERGE-SOURCE: CL 17303839 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v861-17282326)

[CL 17303854 by helge mathee in ue5-release-engine-test branch]
2021-08-25 11:41:16 -04:00
aurel cordonnier
02c0f425e8 Copy up from Release-Engine-Staging @ 16738359
This represents UE4/Main @ 16738161 and Dev-PerfTest @ 16737719

[CL 16738582 by aurel cordonnier in ue5-release-engine-test branch]
2021-06-22 00:27:54 -04:00
jurre debaare
ea7fd05e8f The Undo doesn't work in Preview Scene Set
#fix hacky fix, adding config UProperty, to get the mutable CDO of UAssetViewerSettings transact, as its not in a package/saved
#jira UE-100441
#rb Thomas.Sarkanen

#ROBOMERGE-SOURCE: CL 16672046 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v834-16658389)

[CL 16672102 by jurre debaare in ue5-release-engine-test branch]
2021-06-15 07:49:11 -04:00
jurre debaare
9713ea941a Adding a Preview Scene Settings Profiles results in incorrect incrementing
#fix take number of profiles-1 instead of just number of profiles when generating profile name
#jira UE-89146
#rb Thomas.Sarkanen

#ROBOMERGE-SOURCE: CL 16672040 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v834-16658389)

[CL 16672097 by jurre debaare in ue5-release-engine-test branch]
2021-06-15 07:49:05 -04:00
sebastian nordgren
c678b96a4b FDetailsViewArgs 8 parameter defaulted constructor deprecated and all usages fixed.
#rb lauren.barnes

[CL 14750682 by sebastian nordgren in ue5-main branch]
2020-11-16 08:16:15 -04:00
Marc Audy
4c1bb11c29 Merge UE5/Release-Engine-Staging to UE5/Main @ 14548662
This represents UE4/Main @ 14525125 + cherrypicked fixes
#skipundocheck

[CL 14551026 by Marc Audy in ue5-main branch]
2020-10-22 19:19:16 -04:00
Marc Audy
50a3d7d368 Merge Release-Engine-Staging to Main @ CL# 14467590
This represents UE4/Main @ 14432125 + some cherrypick fixes

[CL 14468207 by Marc Audy in ue5-main branch]
2020-10-09 22:42:26 -04:00
brooke hubert
48113fc77e Adding EditorFramework to build.cs files
#rnx
#Jira UE-96448
#rb chris.gagnon

[CL 14114839 by brooke hubert in ue5-main branch]
2020-08-14 13:24:16 -04:00
robert manuszewski
b7568cc694 Fix for UE-90683: You can no longer delete conflicting variables
Refactored FindField into FindUField and FindFProperty to avoid confusion caused by the fact that FindField<UField> will no longer return FProperties.

#jira UE-90683
#rb Steve.Robb
#tests Basic editor functionality test, cooked and ran PC client and server, bot soak tests for two hours

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 12190998 in //UE4/Release-4.25/... via CL 12190999
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v661-12148976)

[CL 12191300 by robert manuszewski in Main branch]
2020-03-15 10:33:45 -04:00
matt kuhlenschmidt
3fa44160fd Improved the details panel root object customization API to support multiple objects in the "root object set". Deprecated old functionality and removed pass through customizations that are no longer needed
#rb none

#ROBOMERGE-OWNER: matt.kuhlenschmidt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
#ROBOMERGE-SOURCE: CL 11382968 via CL 11382988 via CL 11382990
#ROBOMERGE-BOT: (v654-11333218)

[CL 11383722 by matt kuhlenschmidt in Main branch]
2020-02-12 09:41:11 -05:00
JeanMichel Dignard
70d074639f Merging //UE4/Dev-Main @ 10886849 to Dev-Tools-Staging (//UE4/Dev-Tools-Staging)
#rb none
#rnx

[CL 10906274 by JeanMichel Dignard in Dev-Tools-Staging branch]
2020-01-08 13:26:18 -05:00