105 Commits

Author SHA1 Message Date
nick edwards
69726f5ee7 Update code using FJsonObject to use TCHAR strings instead of ANSI strings. Removes unnecessary string conversions and removes compilation errors when FJsonObject is updated to use FStringViews.
[CL 28536648 by nick edwards in ue5-main branch]
2023-10-06 08:18:42 -04:00
josh adams
aeb5cb1347 - Restoring a backout after fixing the issue that causes the backout
[Backout] - CL27745134
[FYI] stan.hormell
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL27731288 - CIS / Build Errors
[FYI] Josh.Adams
Original CL Desc
-----------------------------------------------------------------
- Deprecated GetSectionPrivate and FindOrAddSection, and accessors in FConfigFile that could return a non-const FConfigSection (this is so we can track modifications to config values)
- Added AddToSection, RemoveKeyFromSection, etc to replace directly accessing a FConfigSection
- Fixed up Epic code for the deprecations (at least the majority, some projects that aren't built by Horde presubmit may have some that we will address going forward)
#jira UE-194955
#rb david.harvey and various others

[CL 27923017 by josh adams in ue5-main branch]
2023-09-15 13:39:02 -04:00
stan hormell
37bad2d07b [Backout] - CL27731288 - CIS / Build Errors
[FYI] Josh.Adams
Original CL Desc
-----------------------------------------------------------------
- Deprecated GetSectionPrivate and FindOrAddSection, and accessors in FConfigFile that could return a non-const FConfigSection (this is so we can track modifications to config values)
- Added AddToSection, RemoveKeyFromSection, etc to replace directly accessing a FConfigSection
- Fixed up Epic code for the deprecations (at least the majority, some projects that aren't built by Horde presubmit may have some that we will address going forward)
#jira UE-194955
#rb david.harvey and various others

[CL 27745141 by stan hormell in ue5-main branch]
2023-09-10 22:58:21 -04:00
josh adams
a8a9a0b759 - Deprecated GetSectionPrivate and FindOrAddSection, and accessors in FConfigFile that could return a non-const FConfigSection (this is so we can track modifications to config values)
- Added AddToSection, RemoveKeyFromSection, etc to replace directly accessing a FConfigSection
- Fixed up Epic code for the deprecations (at least the majority, some projects that aren't built by Horde presubmit may have some that we will address going forward)
#jira UE-194955
#rb david.harvey and various others

[CL 27731364 by josh adams in ue5-main branch]
2023-09-08 17:58:55 -04:00
eric knapik
a4909063ef #jira: UE-188475
Unmount content when mounting to extract the images.
This allows to read the full pak file from the mount point and not have the old data which caused the bug

[CL 26415520 by eric knapik in ue5-main branch]
2023-07-17 15:49:46 -04:00
eric knapik
fcd9efa6c1 #jira: FORT-618159
Look for existing mounted pak files before attempting to make a new one.

[REVIEW] [at]Marc.Audy

[CL 25809599 by eric knapik in ue5-main branch]
2023-06-05 22:13:14 -04:00
paul chipchase
4b1dc1ddba Fix rare crash when populating a new project with starter content.
#rb Per.Larsson
#jira UE-164800
#preflight 638620748b12eb83a79b7723
#lockdown mark.lintott

- When populating the starter content, IAssetTools::ImportAssets will load and return one of the packages containing an asset and FFeaturePackContentSource will attempt to save that asset. The load can kick off async compilation which can still be in progress when the save occurs and the save will cause the package to become detached from its file on disk.
- This introduces the classic thread safety issue between editor bulkdata and package detachment.
- For now we fix this by flushing async compilation before doing operations that we know can cause this problem.
- This fix can be removed once UE-140944 is done.

[CL 23325988 by paul chipchase in ue5-main branch]
2022-11-30 07:43:44 -05:00
josh adams
e41490b912 - Added a system to remap .ini section and key names. This will convert names on load, so saving out the section will use new names, and should not cause issues (we do not force update because the files are usually checked in, so we warn in logs and in the editor on start to tell folks to update).
- Deprecation warnings will show up in C# log, C++ log and in editor as a load warning
- Next changelist will use the system to make some replacements
#rb david.hibbits
#jira UE-130960
#preflight 631f3c4194758d0bf225bd95

[CL 21974033 by josh adams in ue5-main branch]
2022-09-12 18:15:29 -04:00
bryan sefcik
b93a6cf7ed Pass 1 on editor include fixes:
Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.

#jira
#preflight 631e283bec5b0c765fc0ffdb

[CL 21960084 by bryan sefcik in ue5-main branch]
2022-09-11 18:33:06 -04:00
bryan sefcik
8cc129f2b6 IWYU Pass 1 - Engine/Source/Editor/...
#jira
#preflight 6306736ac85b7fef22be7751

[CL 21558583 by bryan sefcik in ue5-main branch]
2022-08-24 22:45:13 -04:00
robert manuszewski
f8a812a32f Converting hardcoded short class/enum names to pathnames ahead of ANY_PACKAGE removal
#rb trivial
#jira UE-99463
#preflight 6288fd998828ea88c8aef3d0

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20314896 via CL 20314897 via CL 20314903 via CL 20314904
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20315214 by robert manuszewski in ue5-main branch]
2022-05-22 10:30:02 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
f23ab4e7bb FPaths and PakPlatformFile: suppress the Pak warning mounting to unregistered paths when the mount path is GameFeatureRootPrefix.
#jira UE-149431
#rb Brandon.Schaefer
#rnx
#preflight 625efc29db15ac92dba1c193

[CL 19820566 by Matt Peters in ue5-main branch]
2022-04-19 18:41:54 -04:00
Robb Surridge
1a574573e9 [Backout] CL 19230249
Changelist 19230249 swapped out the SWidgetCarouselWithNavigation widget in the Add Feature or Content Pack window in Release-5.0 to avoid a rendering bug in SFxWidget. That bug has been fixed in Main, so we can re-enable the SWidgetCarouselWithNavigation.
#rb sebastian.nordgren
#preflight 6220ea377b383ac2989955db
#jira none

[CL 19266035 by Robb Surridge in ue5-main branch]
2022-03-04 10:04:52 -05:00
sebastian nordgren
ba1ba226d8 Screenshot carousel in the "Add Content or Feature Pack..." dialog removed for the time being and replaced with a plain SImage due to currently rendering black because of a presumed bug in SFxWidget.
There are currently no intentions to add multiple screenshots, so the previous SCarouselWidget was unnecessary anyway, but the decision can be revisited in the future if desired.

#jira UE-137893
#rb vincent.gauthier
#preflight 621f950b37049be51729f04b
#lockdown jeanmichel.dignard


#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 19224003 via CL 19226249 via CL 19226380 via CL 19226582 via CL 19226745
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19230249 by sebastian nordgren in ue5-main branch]
2022-03-02 16:52:10 -05:00
sebastian nordgren
292af9be14 Feature packs can now have multiple categories specified for them in the "Category" field of the manifest.json file.
Fixed several standards-breaking uses of auto and lots of const-incorrect code.

#rb paul.chipchase
#jira UE-139606
#preflight 61f2b405f50f352300cc6bee
#preflight 61f7f0ece55232619f85d472

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 18789263 in //UE5/Release-5.0/... via CL 18789286 via CL 18789396
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18789852 by sebastian nordgren in ue5-main branch]
2022-01-31 10:25:27 -05:00
mark lintott
e19030c1c8 Non-Unity fixes
#rb none
#jira none
#preflight 61a74a5f003ada03046d59ed

#ROBOMERGE-AUTHOR: mark.lintott
#ROBOMERGE-SOURCE: CL 18337284 in //UE5/Release-5.0/... via CL 18337287
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18337289 by mark lintott in ue5-release-engine-test branch]
2021-12-01 05:27:31 -05:00
matt kuhlenschmidt
5d10725c0c Fix up use cases of specifying "PrimaryButton" style directly. Replaced instances with SPrimaryButton
#pf https://horde.devtools.epicgames.com/job/612d40b9423a8f00013c5b92

#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
#ROBOMERGE-SOURCE: CL 17457077 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17457092 by matt kuhlenschmidt in ue5-release-engine-test branch]
2021-09-08 08:29:49 -04:00
oblm
c30ba63e83 PR #7931: Stops LogFeaturePack: Warning when a new project is opened. (Contributed by oblm)
#rb trivial
#jira UE-115205
#preflight 609adbb7cfc2c0000129f3c7

#ROBOMERGE-SOURCE: CL 16278740 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v799-16237190)

[CL 16279140 by oblm in ue5-release-engine-test branch]
2021-05-11 16:33:24 -04:00
Matt Kuhlenschmidt
6c7de7284d Reskin "Add Content/Feature Pack" dialog.
[CL 16005687 by Matt Kuhlenschmidt in ue5-main branch]
2021-04-14 11:08:21 -04:00
Patrick Boutot
9633dd85dd Fix implicit type conversion with CreateWithImageData.
#jira UE-88354

[CL 14641008 by Patrick Boutot in ue5-main branch]
2020-11-03 08:30:06 -04:00
brooke hubert
48113fc77e Adding EditorFramework to build.cs files
#rnx
#Jira UE-96448
#rb chris.gagnon

[CL 14114839 by brooke hubert in ue5-main branch]
2020-08-14 13:24:16 -04:00
Marc Audy
a7c9001a94 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14075166
#rb
#rnx

[CL 14075271 by Marc Audy in ue5-main branch]
2020-08-11 01:36:57 -04:00
Matt Kuhlenschmidt
603a4119c5 Fix HAL/PlatformFileManager.h non-portable casing CIS issues
#rb none

[CL 13214257 by Matt Kuhlenschmidt in ue5-main branch]
2020-05-06 17:58:18 -04:00
Rolando Caloca
bbb9564388 Copying //UE4/Dev-RenderPlat-Staging@11110326 to //UE4/Main
#rb none
#rnx

[CL 11110369 by Rolando Caloca in Main branch]
2020-01-24 18:07:01 -05:00