32047 Commits

Author SHA1 Message Date
Andrew Davidson
cf26a3f9ac Adding a missing null check on FActorTreeItem::OnVisibilityChanged
Some tools like the Chaos Visual Debugger can perform GC on their own, so if a visibility changed event in the outliner is processed while that is happening, we can end up with an invalid actor ptr which will result in a crash

#jira UE-221294

#rb aditya.ravichandran
#review-33150017

#[robomerge][bot5] -FNMain

#ushell-cherrypick of 33150749 by sergio.gardeazabal

[CL 35366853 by Andrew Davidson in 5.4 branch]
2024-08-07 09:34:36 -04:00
kiaran ritchie
97d7510914 Fixes crash in animation sequence editor when viewing old animation with bone track names out of sync with data model.
#rb halfdan.ingvarsson
#JIRA UE-214145

[CL 35281180 by kiaran ritchie in 5.4 branch]
2024-08-02 13:58:08 -04:00
benoit gadreau
54642e820e Sequencer: Constraints: fix for constraint creation on BPs with multiple SKM components
- actors with multiple scene components: the binding id must be the scene component handle instead of the owner actor handle if the constraint references a scene component that is not the actor's root component.
    This will also ensure that the binding for the component is created if it hasn't already been.
    - spawnable: use Component.Get(bEvenIfPendingKill) to get a valid component ptr that we can use to resolve the new binding

#jira UE-220111
#rb halfdan.ingvarsson, mike.zyracki

#ushell-cherrypick of 32821448 by benoit.gadreau

[CL 35211903 by benoit gadreau in 5.4 branch]
2024-07-31 09:53:24 -04:00
mikko mononen
ad911dd170 Fix animation root motion preview for animations authored Y-up.
#jira UE-215283
#rb jose.villarroel

[CL 34428703 by mikko mononen in 5.4 branch]
2024-06-17 13:45:36 -04:00
halfdan ingvarsson
91893691d1 Vertex Paint: Fixed broken logic to check for editable mesh data
#jira UE-216749

#rb Alexis.Matte

[CL 34324681 by halfdan ingvarsson in 5.4 branch]
2024-06-12 17:45:57 -04:00
jessica agee
c4a9a61d6c Unshelved from pending changelist '33822713':
Submitting for sebastian.arleryd since Swarm is being dumb -

Add section names to workspace menu categories to fix grouping issues in the "Window" and "Tools" main menus and also allow them to be extended

#jira UE-212448

[CL 34324580 by jessica agee in 5.4 branch]
2024-06-12 17:44:09 -04:00
halfdan ingvarsson
62bb6af1c3 Skeletal Mesh: Ignore refreshes on ULODInfoUILayout if the LOD no longer exists.
The assumption here is that the the LOD got removed but the details panel hasn't had time to refresh and delete no longer needed ULODInfoUILayout objects.

#jira UE-214907
#rb jack.cai

#ushell-cherrypick of 33609377 by halfdan.ingvarsson

[CL 34324575 by halfdan ingvarsson in 5.4 branch]
2024-06-12 17:44:04 -04:00
max chen
28dd0e7c49 Sequencer: Capture the texture resources and destroy those on the next tick.
This fixes a crash opening a level sequence with an audio track with Take Recorder

#rb Patrick.Boutot
#jira UE-214413

[CL 34324493 by max chen in 5.4 branch]
2024-06-12 17:42:53 -04:00
matt peters
6086c8d7c9 MPCook: Log replication: Call FMsg::LogF instead of GLog->CategorizedLogf so that messages at display verbosity and above from CookWorkers are routed into GWarn instead of GLog. GWarn handles writing to stdout and collection of errors for display in the Warning/Error Summary at the end of the commandlet.
#jira UE-214509
#rnx
#ushell-cherrypick of 33546018 by Matt.Peters

[CL 34324337 by matt peters in 5.4 branch]
2024-06-12 17:39:19 -04:00
alex kahn
7b782276bb [Backout] - CL33635101 - CIS Compile Error
#jira FORT-745737
#rnx
[FYI] Matt.Peters
Original CL Desc
-----------------------------------------------------------------
MPCook: Log replication: Call FMsg::LogF instead of GLog->CategorizedLogf so that messages at display verbosity and above from CookWorkers are routed into GWarn instead of GLog. GWarn handles writing to stdout and collection of errors for display in the Warning/Error Summary at the end of the commandlet.
#jira UE-214509
#rnx
#ushell-cherrypick of 33546018 by Matt.Peters

[CL 34324329 by alex kahn in 5.4 branch]
2024-06-12 17:38:55 -04:00
matt peters
31649d5dd0 MPCook: Log replication: Call FMsg::LogF instead of GLog->CategorizedLogf so that messages at display verbosity and above from CookWorkers are routed into GWarn instead of GLog. GWarn handles writing to stdout and collection of errors for display in the Warning/Error Summary at the end of the commandlet.
#jira UE-214509
#rnx
#ushell-cherrypick of 33546018 by Matt.Peters

[CL 34324328 by matt peters in 5.4 branch]
2024-06-12 17:38:50 -04:00
vincent beauchemin
690431c85f Source Control Changelist View
* Fix initial refresh UI not being call for all changelist type (esp. the Uncontrolled Cl)
#rb JeanFrancois.Dube, Patrick.Enfedaque
#jira UE-211803


#p4v-cherrypick 33578294
#tests Open ViewChangelist -- see the default uncontrolled cl

[CL 34324319 by vincent beauchemin in 5.4 branch]
2024-06-12 17:38:23 -04:00
Jeff Fisher
4042a81610 GitHub 11914 : [MultiPlayerTesting][VRPreview]: All windows should have border
-All the window styles need to match for multi-vr-pie support, where the hmd can drive multiple pie windows or go between them at runtime.
#jira UE-215525
#review-33898363
#rb erica.stella, Josie.Yang

[CL 34314254 by Jeff Fisher in 5.4 branch]
2024-06-12 13:24:31 -04:00
sebastien lussier
9eef48c800 World Partition - HLOD: When HLOD in editor is enabled, avoid stack overflow when pinning actors with circular references
#rb JeanFrancois.Dube, Richard.Malo, vincent.beauchemin
#jira UE-214736
#p4v-cherrypick 32728082

[CL 33587859 by sebastien lussier in 5.4 branch]
2024-05-10 17:01:47 -04:00
vincent beauchemin
e8f2030754 World Partition
* Fix crash when accessing context menu on Location Volume or ProceduleFoliageVolume within a non World Partition world.
#rb JeanFrancois.Dube
#jira UE-214539
#tests With and without WP, opening context menu on LocationVolume & ProcFoliageVolume


#p4v-cherrypick 33573053

[CL 33585025 by vincent beauchemin in 5.4 branch]
2024-05-10 15:46:02 -04:00
matt breindel
b590eee182 Merging using FNMain_To_5_4
Removing several stall detector scopes because they don't currently produce enough context in the crash reporter to act on them.

#jira UE-214224
#rb Francis.Hurteau, ionut.matasaru (original review 33494151)
#lockdown michal.valient

[CL 33533843 by matt breindel in 5.4 branch]
2024-05-08 19:04:58 -04:00
Max Chen
6519250e19 Take Recorder: Skip UpdateCachedFlags while recording
#jira UE-212099
#rb Andrew.Rodham, jessica.agee

#p4v-cherrypick 33279762

[CL 33498728 by Max Chen in 5.4 branch]
2024-05-07 18:09:30 -04:00
Jimmy Andrews
dac58ea6ef make spline component visualizer and details customization call the owner actor's posteditmove method to make sure the construction script can re-run as expected
#jira UE-213520
#rb brooke.hubert

[CL 33462304 by Jimmy Andrews in 5.4 branch]
2024-05-06 13:37:41 -04:00
eric renaudhoude
c2fccf1161 PropertyEditor: Fix issue where property change events on array members in array parent elements were indistinguishable between parent & child.
(Fix from @Mikko.Mononen.)

#jira UE-213813
#rb logan.buchy, mikko.mononen

[CL 33459528 by eric renaudhoude in 5.4 branch]
2024-05-06 12:24:43 -04:00
benoit gadreau
b1672fe625 Constraints & Layered Control Rig: changes to handle UControlRig::OnControlModified being called when evaluating additive rigs (instead of when setting values)
- ControlRigEditMode: skip compensation and evaluate the rig to force notifications: auto-key and constraints updates (among others) are based on OnControlModified broadcast
    - ConstraintsEvaluationGraph: do not mark constraints for evaluation while flushing (this can happen with OnControlModified being called while evaluating the rig)
    - TransformableControlHandle: guard from re-entrant notification (this can happen with OnControlModified being called while evaluating the rig)
    - CompensationEvaluator: evaluate the rig to force notifications after sequencer has been evaluated

#jira UE-212814
#rb halfdan.ingvarsson, sara.schvartzman

[CL 33459515 by benoit gadreau in 5.4 branch]
2024-05-06 12:24:19 -04:00
sara schvartzman
bd3a1ecca4 Control Rig: Fix cannot swap preview mesh on modular rigs
#jira UE-213740
#rb Thomas.Sarkanen
#rnx


#ushell-cherrypick of 32966475 by sara.schvartzman

[CL 33427610 by sara schvartzman in 5.4 branch]
2024-05-03 11:41:36 -04:00
Josh Adams
a758939e6f - Fixed an issue where per-platform packaging settings were getting confused when project settings were changed (the per-platform ones were not getting updated). This is a heavy handed approach to wiping platform config caches, and reloading them as needed
#rb Chris.Babcock
#jira UE-211808
#p4v-cherrypick 33010002

[CL 33200768 by Josh Adams in 5.4 branch]
2024-04-24 11:27:53 -04:00
dan oconnor
f30f0d88c0 Handle nested components when looking for components that were declared natively but no longer are. Because we did not handle this we would usually remove nested components.
#rb ben.hoffman
#jira UE-213059

[CL 33198537 by dan oconnor in 5.4 branch]
2024-04-24 10:06:50 -04:00
jack cai
7cc7df5a9c [Skeletal mesh editor] Guard against invalid personal tookkit ptr since the refresh callback for lodinfo is fired async and by the time it fires this weak ptr can be invalid
cherry picked from 33112219

#jira UE-212055, PLAY-39030

[CL 33175191 by jack cai in 5.4 branch]
2024-04-23 14:31:38 -04:00
brooke hubert
4eaa873dcf Fixing multiple RC issues
#Jira UE-212166 UE-212156

Original CL 32067376

----

[Path Picker] Fix an issue where path picker on initial notify would pass virtual paths, when the configuration was not set to support them

#Jira UE-205782
#rb Julien.StJean, ronald.koppers

[CL 32935130 by brooke hubert in 5.4 branch]
2024-04-12 13:05:31 -04:00