361 Commits

Author SHA1 Message Date
Wojciech Krywult
d271c828b9 SDK (1): Changes in common code needed to support SDK changes on some platforms
#jira UE-210757
#rb
#tests Integrated //UE5/Partner-Latte-5.4/... @32408657 (the last non-robomerge change)

[CL 32557111 by Wojciech Krywult in 5.4 branch]
2024-03-27 16:55:10 -04:00
matthew sorrels
0dc0af5b5f Fix crash when cooking Android OpenGLES on Linux by replacing swscanf based parser with native FindNextHLSLDefinitionOfType
#jira UE-205727
#rnx
#rb dan.elksnitis, Dmitriy.Dyomin, Florin.Pascu

[CL 32500348 by matthew sorrels in 5.4 branch]
2024-03-26 03:00:44 -04:00
yuriy odonnell
aff3ec7f8f Suppress false positive static analysis warning
#jira UE-208257

[CL 32498927 by yuriy odonnell in 5.4 branch]
2024-03-26 02:09:02 -04:00
Yuriy ODonnell
8286d68c09 Handle line directives in ShaderMinifier ExtractBlock()
* Fix reporting line numbers in shader compile errors/warnings

#rb Laura.Hermanns
#jira UE-207792
#ushell-cherrypick of 31714435 by Yuriy.ODonnell

[CL 31725235 by Yuriy ODonnell in 5.4 branch]
2024-02-22 12:16:25 -05:00
carl lloyd
c1edfa3ade Added support for Metal Shader Converter to Metal
- Disabled by default
    - Removed MetalDerivedData and moved shader compiler specific code to seperate files

#rb Laura.Hermanns
#jira UE-204112

[CL 31524725 by carl lloyd in 5.4 branch]
2024-02-15 12:38:42 -05:00
christopher waters
d090f2823b Removing extra '\0' from files output from ShaderConductor.
DxcCreateBlob apparently force adds this on creation of strings, so we need to account for that when creating a view of the result.

#rb dan.elksnitis, Laura.Hermanns

[CL 31306629 by christopher waters in 5.4 branch]
2024-02-08 16:59:53 -05:00
graham wihlidal
1ea8fe45eb Fixed RDNA2 disassembler to correctly handle v_madak_f32 and v_madmk_f32 advancing with a trailing literal
[FYI] rune.stubbe, brian.karis, john.huelin, jian.ru, jamie.hayes



#[robomerge][bot5] -FNMain
Fixed case on consoles where Nanite export depth would not fully clear all non-Nanite pixels, leaving corrupt rendering in certain cases (like disabling the transient allocator, or running with -rdgimmediate).

#rb yuriy.odonnell
#[fyi] brian.karis, rune.stubbe, jamie.hayes, zach.bethel
#jira UE-202941, UE-205770

Fixed some additional ISA issues by adding v_fmaak_f32, v_fmamk_f32, v_fmamk_f16, and v_fmaak_f16 to the trailing literal check

[FYI] rune.stubbe, brian.karis, jian.ru, jamie.hayes, luke.thatcher



#[robomerge][bot5] -FNMain
Add NANITE_TESSELLATION permutation to Nanite SW rasterizer shaders to fix issues where we were assuming that if displacement is connected in the material shader parameters, that displacement would not be disabled in the final compiled material.

#rb graham.wihlidal
#[fyi] rune.stubbe, brian.karis
Fix for flickering tessellated triangles with corrupt values in raster bin meta between tessellated cluster and patch raster.

#rb jamie.hayes
#[fyi] rune.stubbe, brian.karis

#changelist validated
#virtualized

#ushell-cherrypick of 31148557 by graham.wihlidal
#ushell-cherrypick of 31154834 by graham.wihlidal
#ushell-cherrypick of 31164583 by graham.wihlidal
#ushell-cherrypick of 31182678 by jamie.hayes
#ushell-cherrypick of 31228365 by graham.wihlidal

[CL 31281009 by graham wihlidal in 5.4 branch]
2024-02-07 19:58:41 -05:00
steve robb
57ca754749 Fixed up more bool-taking calls to take EAllowShrinking instead.
[CL 30894744 by steve robb in 5.4 branch]
2024-01-25 14:17:31 -05:00
steve robb
f029468598 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
aris theophanidis
8ae2292282 Remove Compression.h from CoreMinimal.h
It's about 1/4 of CoreMinimal.h but rarely needed (Compression.h pulls on CriticalSection.h and Map.h that are costly).
#rb Yoan.StAmant

[CL 30683417 by aris theophanidis in ue5-main branch]
2024-01-18 09:56:55 -05:00
yuriy odonnell
a09c23c4f6 ShaderMinifier - Use memstack for various temporary allocations
#jira UE-203990
#rb Jason.Nadro

[CL 30647996 by yuriy odonnell in ue5-main branch]
2024-01-16 17:45:20 -05:00
dan elksnitis
89776aba21 [shaders] add ANSICHAR path for FShaderSource and enable by default
#rb Yuriy.ODonnell, Laura.Hermanns
#jira UE-196110

[CL 30632304 by dan elksnitis in ue5-main branch]
2024-01-16 09:15:51 -05:00
dan elksnitis
f230a0d2d0 [shaders] shaderconductorcontext improvements:
- add support to shaderconductor to load shader source from a FAnsiStringView
- remove internal string conversion helpers in favour of using FAnsiString
- don't make copies of input strings if they are provided in ANSI format

#rb Laura.Hermanns

[CL 30594203 by dan elksnitis in ue5-main branch]
2024-01-12 11:06:50 -05:00
dan elksnitis
9bcbc546f7 [shaders] fix minifier test inputs to include simd padding
#rb Yuriy.ODonnell
#jira UE-203438

[CL 30567118 by dan elksnitis in ue5-main branch]
2024-01-11 09:14:09 -05:00
graham wihlidal
74a234bb5d RDNA disassembler fixes
**
- Support for DS instructions
- Fixed DS microcode format
- Added missing instructions

#rb Rune.Stubbe
#fyi brian.karis, yuriy.odonnell, dan.elksnitis, luke.thatcher
#jira none

[CL 30513791 by graham wihlidal in ue5-main branch]
2024-01-09 14:57:00 -05:00
dan elksnitis
3dacd52109 [shaders] add support for single byte char path for minifier simd optimizations
#rb Yuriy.ODonnell
#jira UE-196110

[CL 30393653 by dan elksnitis in ue5-main branch]
2023-12-19 08:59:03 -05:00
dan elksnitis
a9037b25ed [shaders]
- add FShaderSource class which wraps source as populated by preprocessing and subsequently accessed by compilation and other debug features; this class automatically inserts zeroed padding such that 16-byte-wide SIMD string comparison operations do not require a non-SIMD tail to process any overhang.
- add typedefs for the string/view/character types and update preprocessing code to use these typedefs instead of the explicit types
- add explicit if constexprs in minifier code around char width to disable simd optimizations for char width != 2 (and subsequently skip the non-simd tail if char width == 2 since FShaderSource automatically adds the required padding)

#rb Jason.Nadro, Yuriy.ODonnell

[CL 30358137 by dan elksnitis in ue5-main branch]
2023-12-15 15:28:27 -05:00
dan elksnitis
be1f64ef8d [shaders] remove unused remnants of TEXT macro parsing code
#rb massimo.tristano

[CL 30214077 by dan elksnitis in ue5-main branch]
2023-12-08 12:36:13 -05:00
dan elksnitis
6ed653a189 [shaders] further preprocessing cleanup
- move sequence of preprocessing steps out of ShaderPreprocessor module and into UE::ShaderCompilerCommon::ExecuteShaderPreprocessingSteps; the former is now explicitly just the low-level preprocessor lib
- add an implementation of PreprocessShader in FBaseShaderFormat so backends which have no custom code to execute as part of preprocessing can just automatically inherit this implementation, and fix up such backends to eliminate now-unnecessary overrides

#rb christopher.waters, Laura.Hermanns

[CL 30178136 by dan elksnitis in ue5-main branch]
2023-12-07 08:55:41 -05:00
dan elksnitis
c1f33c7a82 [shaders] debug usf/direct compile cleanup
- never append the environment defines as commented code to the source used for further preprocessing/compilation; instead only append it to the debug USF
- strip comments after loading the debug usf in direct compile mode as some backends expect comments to have already been removed and the extra ones we add to the debug dump cause them to barf
- change all #if 0s in the debug usf to block comments instead so the above can strip them (said backends also don't like preprocessor directives left in the file)

#rb Jason.Nadro, rob.krajcarski

[CL 30161438 by dan elksnitis in ue5-main branch]
2023-12-06 13:32:32 -05:00
dan elksnitis
cc7c2c54f4 [shaders] shader format preprocessing cleanup & refactoring
- move uniform buffer cleanup and dead stripping into ShaderPreprocessor module's PreprocessShader function
- add "required symbols" to compiler input struct to specify additional symbols to keep during minification aside from those specified by the entrypoint; modify API such that both an entry point string and additional symbols can be specified (to avoid each backend needing to manually parse the compound RT entry point string)
- make use of ModifyShaderCompilerInput in all backends to set additional defines and required symbols on input struct up front; only use the AdditionalDefines map in cases where it's actually necessary
- remove the various per-platform defines for enabling minifier, no longer required now that this has been rolled out for all backends
- fix SCW directcompile mode; this had rotted due to pieces of the FShaderCompilerEnvironment having been added that weren't explicitly serialized to either cmdline or in the shader source. this now serializes as a base64 string written inside the USF containing all portions of the environment required for compilation (using the same serialization function as is used to write/read the SCW input file)
- use a debug flag for indicating we're in "direct compile" mode and should load the debug USF off disk, rather than the poorly named "bSkipPreprocessedCache" (this name is both inaccurate and also confusing due to the addition of the preprocessed job cache)
- modify platform "force wave32" mechanism to use a pragma directive to set a compiler define, instead of doing string replacement in the preprocessed source
- add a view version of the RT entrypoint parsing to use in preprocessing, note that other paths still need to construct fstrings due to further manipulation so keeping the FString path around too
- clean up backends manually checking the "directcompile" cmdline arg

#rb christopher.waters, Yuriy.ODonnell
#rb Chris.Waters
#rb Laura.Hermanns

[CL 30023082 by dan elksnitis in ue5-main branch]
2023-11-30 15:56:34 -05:00
marc audy
763a611985 Fix C4072 warnings
#rnx

[CL 29852844 by marc audy in ue5-main branch]
2023-11-20 17:26:53 -05:00
daniele vettorel
e39770acde Support exporting shader symbols info for PC D3D_SM6 shaders.
The PDB name is either retrieved from the PDB blob part of DXC's output, or is generated using the shader hash that DXC reports even when no PDB is requested. We don't export PDBs because it would result in duplicate data as we use embedded PDBs.

#rb christopher.waters, Laura.Hermanns

[CL 29723169 by daniele vettorel in ue5-main branch]
2023-11-14 15:18:29 -05:00
marc audy
399bcf9971 Disable PVS warning V758
Silence V570 false positives for bit field assignments
Silence various other PVS warnings
#rnx

[CL 29706746 by marc audy in ue5-main branch]
2023-11-14 00:29:43 -05:00
laura hermanns
d6acdc4eab Make DXC compile arguments consistent between Vulkan backend and CompileDXC.bat script.
#jira UE-198594
#rb Dan.Elksnitis
#rnx

[CL 29569710 by laura hermanns in ue5-main branch]
2023-11-08 14:23:36 -05:00