18 Commits

Author SHA1 Message Date
devin doucette
394009b52d DDC: Fix race conditions on counters in the Jupiter and S3 cache stores
#rb Steve.Robb
#rnx

[CL 31260858 by devin doucette in 5.4 branch]
2024-02-07 12:10:52 -05:00
aris theophanidis
8ae2292282 Remove Compression.h from CoreMinimal.h
It's about 1/4 of CoreMinimal.h but rarely needed (Compression.h pulls on CriticalSection.h and Map.h that are costly).
#rb Yoan.StAmant

[CL 30683417 by aris theophanidis in ue5-main branch]
2024-01-18 09:56:55 -05:00
steve robb
0bbd5e4d69 Fixed deprecated FString constructors.
#rb james.hopkin

[CL 29690489 by steve robb in ue5-main branch]
2023-11-13 14:15:15 -05:00
nick edwards
69726f5ee7 Update code using FJsonObject to use TCHAR strings instead of ANSI strings. Removes unnecessary string conversions and removes compilation errors when FJsonObject is updated to use FStringViews.
[CL 28536648 by nick edwards in ue5-main branch]
2023-10-06 08:18:42 -04:00
steve robb
a84e22104b Replaced GET_VARARGS* macros with GET_TYPED_VARARGS*.
#rb james.hopkin
#jira UE-194628

[CL 28346416 by steve robb in ue5-main branch]
2023-09-29 13:00:07 -04:00
david harvey
bdb4199eeb Remove unnecessary WindowsHWrapper.h & MinWindows.h include - both files will be automatically included by AllowWindowsPlatformTypes.h
#jira UE-152863
#rnx
#rb Josh.Adams

[CL 26912096 by david harvey in ue5-main branch]
2023-08-08 05:50:53 -04:00
devin doucette
402d04cde9 DDC: Added request name to FCacheStoreRequestStats
#jira UE-133395
#rb Zousar.Shaker
#rnx

[CL 26210120 by devin doucette in ue5-main branch]
2023-06-23 10:51:52 -04:00
devin doucette
23c14b391a DDC: Added ICacheStoreStats to S3
#jira UE-133395
#rb Zousar.Shaker
#rnx

[CL 26158531 by devin doucette in ue5-main branch]
2023-06-21 15:23:06 -04:00
bryan sefcik
892629fe83 Fixed some paths that got updated to include the full "ThirdParty" path.
#jira
#preflight 6320877bbc40358fa2995069

[CL 21997782 by bryan sefcik in ue5-main branch]
2022-09-13 21:48:33 -04:00
bryan sefcik
a3dddc6630 Pass 1 on Developer include fixes:
Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.

#jira
#preflight 631e281694758d0bf2ea1399

[CL 21960082 by bryan sefcik in ue5-main branch]
2022-09-11 18:32:18 -04:00
Marc Audy
e42d1fa0a3 Fix implicit conversion
#preflight
#rnx

[CL 21897568 by Marc Audy in ue5-main branch]
2022-09-08 13:36:12 -04:00
devin doucette
3e2538a313 DDC: Removed the legacy cache store implementations and limit cache bucket names to 63 characters
The cache bucket name was already limited to 63 characters in practice by Horde Storage. This makes it consistent across every cache store.

#preflight 629e6f0a1c7e8f9a180e192a
#rb Zousar.Shaker

#ROBOMERGE-OWNER: Devin.Doucette
#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-COMMAND: _robomerge[bot4] UE5-MAIN
#ROBOMERGE-SOURCE: CL 20536454 via CL 20536805 via CL 20536993
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20538633 by devin doucette in ue5-main branch]
2022-06-07 11:17:10 -04:00
mark lintott
da46ade47c Added Cache Speed Stats to Analytics
Added Zen Server Stats to Analytics
#rb zousar.shaker, devin.doucette
#jira none
#preflight 6295d84bd57da28cc8ee9eab

[CL 20434901 by mark lintott in ue5-main branch]
2022-05-31 05:11:05 -04:00
David Harvey
b5840fed7f removing several PLATFORM_HOLOLENS references, mostly around WindowsHWrapper etc.
#jira UE-149794
#rnx
#preflight 628f7a4df622d972b5db8318
#rb pending

[CL 20391626 by David Harvey in ue5-main branch]
2022-05-27 07:04:22 -04:00
Devin Doucette
455b4ece9e DDC: Extended -DDC-MissTypes to match -DDC-Verify
In the examples below, <Node> is the name of a node in the cache store graph, or All to apply to every node.
-DDC-<Node>-MissTypes=StaticMesh+Texture will simulate a miss on every access to to static mesh and texture keys.
-DDC-<Node>-MissTypes=StaticMesh@12.5+Texture will simulate misses on 12.5% of accesses to static mesh keys and every access to texture keys.
-DDC-<Node>-MissRate=5 -DDC-<Node>-MissTypes=Texture will simulate misses on every access to texture keys and 5% of other keys.
-DDC-<Node>-MissRate=5 will simulate misses on 5% of keys.
-DDC-<Node>-MissSalt=PositiveInt32 will set the salt used to match keys to simulate misses on. A key always has the same simulated miss behavior with the same salt.

#preflight 6244d102b33098a72dc136df
#rb Zousar.Shaker

[CL 19572200 by Devin Doucette in ue5-main branch]
2022-03-31 10:06:47 -04:00
Devin Doucette
1318804bb2 DDC: Fixed timing scopes for FileSystem, PakFile, S3
Edited the timing scopes to exclude invocation of the completion callback.

#preflight 62325890262232d86f812368
#rb Zousar.Shaker
#rnx

[CL 19419775 by Devin Doucette in ue5-main branch]
2022-03-17 09:07:20 -04:00
devin doucette
5953a87414 DDC: Fixed an error caught by StressTestUnity
#jira none
#preflight 620af27d583261b0a67b105b
#lockdown Aurel.Cordonnier
#rb Zousar.Shaker
#rnx

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18989454 in //UE5/Release-5.0/... via CL 18992558 via CL 18992930
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18997149 by devin doucette in ue5-main branch]
2022-02-15 11:27:30 -05:00
devin doucette
2800210897 DDC: Enabled compression of legacy cache data
- FileSystem, Http, Pak, S3 use the ValueWithLegacyFallback mode by default, which cause them to fall back to searching for uncompressed data if compressed data is not found.
- FileSystem has been fixed to store up to 1 MiB of compressed data inline with the value package rather than separately in content-addressable storage.
- Pak has been optimized to have GetChunks only load the required region of the requested value, rather than the whole value.
- Pak has been changed to stop storing data inline in the record package, since it will end up in the same file anyway when stored separately.
- Pak will upgrade the compressor and compression level when a compressed pak file is requested. Default cache compression uses Oodle Mermaid VeryFast and will upgrade to Oodle Kraken Optimal2.
- Zen does not have compression enabled by default, pending deployment of a new version that stores compressed values to Horde Storage.
- Added a missing request barrier when saving uncompressed data as compressed.

Example reduction in file system cache size when cooking for Windows:
- CitySample dropped from 66.5 GiB to 21.8 GiB.
- Lyra dropped from 2.54 GiB to 672 MiB.
- ShooterGame dropped from 1.21 GiB to 380 MiB.

Example reduction in compressed pak file cache size when cooking for Windows:
- CitySample dropped from 22.3 GiB to 18.5 GiB.
- Lyra dropped from 691 MiB to 543 MiB.
- ShooterGame dropped from 387 MiB to 313 MiB.

#jira UE-134381
#preflight 620a703f583261b0a658e043, 620a6fb2803d9066e6805310, 620a733117632e948459b6af
#lockdown Aurel.Cordonnier
#rb Zousar.Shaker

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18983671 in //UE5/Release-5.0/... via CL 18983890 via CL 18984096
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18984126 by devin doucette in ue5-main branch]
2022-02-14 14:43:39 -05:00