21 Commits

Author SHA1 Message Date
jimmy smith
2fac1cece3 Retroactive fix up from comments from review and const tidyup
#rb dan.thompson

[CL 25908611 by jimmy smith in ue5-main branch]
2023-06-09 19:46:34 -04:00
jimmy smith
97169e1e8c Fix for very large binks files creating garbage data
#rb dan.thompson
#jira UE-188256

[CL 25887585 by jimmy smith in ue5-main branch]
2023-06-08 23:20:33 -04:00
jimmy smith
e19439490f Bink Format; use duration/samplerate to set max seektable size.
#rb dan.thompson phil.popp
#jira UE-187214

[CL 25825083 by jimmy smith in ue5-main branch]
2023-06-06 15:21:14 -04:00
dan thompson
62c3c31c05 Updating bink audio encoder to support larger seek tables and lower sample rates.
#rb fabian.geisen
#jira UE-187214
#jira UE-173274
#preflight 6477e019947ff6973cd05b8d

[CL 25732576 by dan thompson in ue5-main branch]
2023-06-01 13:44:14 -04:00
jimmy smith
13dbfcba26 READD: Chunked Seektables for BinkAudio (with Fixes)
#rb dan.thompson igor.dallavanzi

[CL 25645493 by jimmy smith in ue5-main branch]
2023-05-26 12:21:41 -04:00
jimmy smith
3b948e43be [Backout] - CL25419229
[FYI] jimmy.smith
Original CL Desc
-----------------------------------------------------------------
Chunked Seektables for BinkAudio
#rb dan.thompson igor.dallavanzi

[CL 25497743 by jimmy smith in ue5-main branch]
2023-05-16 17:05:51 -04:00
jimmy smith
201ef64f16 Chunked Seektables for BinkAudio
#rb dan.thompson igor.dallavanzi

[CL 25420189 by jimmy smith in ue5-main branch]
2023-05-10 20:29:00 -04:00
jimmy smith
499bb33b24 Change Bink Quality mapping to use full 1-100 range. Add Project Setting to change "Default Compression Quality". Rewrite of DDC key hash to fix collisions.
NOTE: Bumping Bink version as mapping changed. Also bumping Streamcache versions as hash function changed.
#jira FORT-557932
#rb dan.thompson aaron.mcleran
#preflight 63dd54e5442a87d63d4a0dbc

[CL 23994694 by jimmy smith in ue5-main branch]
2023-02-03 14:08:56 -05:00
Dan Thompson
56d05caea1 Adding logs for bink audio encode errors.
#rb jeff.roberts
#preflight 63b87063763c6c106440532f

[CL 23603493 by Dan Thompson in ue5-main branch]
2023-01-06 16:37:28 -05:00
Dan Thompson
a41296f722 Updating Bink DDC version for encoder update in CL 22082773
#rb trivial
#preflight 6328eb0ff87253e021def47c

[CL 22083075 by Dan Thompson in ue5-main branch]
2022-09-19 18:30:53 -04:00
Dan Thompson
58dde8e8c4 Add arm64 to ddc keys to avoid ddc consistency issues due to current floating point compiler switches.
#jira UE-160013
#preflight 63179d34a20b67673b0e8a28

[CL 21828071 by Dan Thompson in ue5-main branch]
2022-09-06 16:10:44 -04:00
jimmy smith
b92f1fdf0d Configuration support for AudioInfos / AudioFormats per platform
#jira UE-159832
#rb Aaron.mcleran Phil.Popp Dan.Thompson Josh.Adams
#preflight 62d260033c3df323907eaa93

[CL 21153330 by jimmy smith in ue5-main branch]
2022-07-18 17:47:55 -04:00
jimmy smith
315c5c6340 Fixup Bink Quality mapping logic based on community feedback
#rb aaron.mcleran
#preflight 629153eb8b6ee67725932267

[CL 20400703 by jimmy smith in ue5-main branch]
2022-05-27 18:50:42 -04:00
will damon
cd43d1bb9a Rebuild bink audio SDK libraries as universal binaries for macOS
- on macOS Catalina 10.15.7
- with Xcode 12.4
- as universal binaries with arm64 and x86_64 slices

- Add BuildForMac.command script
- Add CMakeLists.txt

#rb jeff.roberts, dan.thompson
#jira UE-145175
#rnx
#preflight 624efca5f94f766ffaad8ef3

[CL 19671743 by will damon in ue5-main branch]
2022-04-07 12:43:30 -04:00
Dan Thompson
cad7c1a18d Adding a warning so we remember to check Bink Audio encoding when the editor is up and running on apple silicon.
#fyi aaron.mcleran
#rb will.damon
#preflight 624b6252981a2c8eb4b51231

[CL 19615457 by Dan Thompson in ue5-main branch]
2022-04-04 17:35:14 -04:00
danny couture
af747e2742 Allow async sound wave compression for ogg vorbis, adpcm and bink
- Make the basic sound compression thread-safe by gathering immutable inputs from USoundWave before going async
  - Report oggvorbis, adpcm and bink codec as thread-safe
  - Remove old USoundWave write-back during cook as it is not needed anymore and would not be executed on DDC hit anyway.
  - Fix missing RawData lock protection where RawData is used in editor

  - 2h47m to 2h03m when cooking FN content with sound not present in the local DDC cache

#tests
  - No binary diff on ShooterGame and FN cooked content
  - Sound related automation tests all pass in EngineTest

#rnx
#rb Jimmy.Smith
#preflight 623dc8b84368f558e3167cc0

[CL 19525145 by danny couture in ue5-main branch]
2022-03-28 07:05:08 -04:00
danny couture
a648ad798d Add Insight trace to audio encoders
#rnx
#rb Francis.Hurteau
#preflight 622f3bea0a342dea04e5c084

[CL 19372113 by danny couture in ue5-main branch]
2022-03-14 09:36:35 -04:00
Aaron McLeran
2a1b2efc24 Static analysis fixes
#jira UE-121293
#rb none

[CL 17464332 by Aaron McLeran in ue5-main branch]
2021-09-08 17:37:20 -04:00
Dan Thompson
1d6928acd2 Bink Audio support for >48khz. Well... support in that they play, however Bink Audio (like most perceptual codecs) don't bother to send such high frequencies, so I add a warning to resample down prior to encoding. It's just a waste of performance.
This looks like a large change but the relevant change is binka_ue_file_header.h. Then rebuilt libs, and a bunch of source changes that never made it over in the initial checkin.

#jira UE-119962
#preflight 60fb20bc391d460001ff28a5

[CL 16942270 by Dan Thompson in ue5-main branch]
2021-07-23 17:31:13 -04:00
Dan Thompson
47b4614e9b Moving Bink Audio SDK out of ThirdParty #pf 60c96e1ff7cffb00017213ef
[CL 16684298 by Dan Thompson in ue5-main branch]
2021-06-16 00:35:07 -04:00
Dan Thompson
6db5d71ebb Bink Audio :: 3/4 :: Encoder :: #pf 60aea2116905a6000136901e
Unreal side of the encoder. Mostly just a thunk to the SDK, with some interleaving and splitting for the Unreal streaming system.

[CL 16679911 by Dan Thompson in ue5-main branch]
2021-06-15 17:21:24 -04:00