130 Commits

Author SHA1 Message Date
steve robb
7da84c1d1b Replaced UE_NODISCARD with [[nodiscard]].
[CL 30593744 by steve robb in ue5-main branch]
2024-01-12 10:47:04 -05:00
andrea botti
61195ecf40 [RemoteControl]
Adding controller description and made controller name unique

#rb Jean.Perrier

[CL 30514616 by andrea botti in ue5-main branch]
2024-01-09 15:36:16 -05:00
andrea botti
3597cc6867 [RemoteControl]
Better error in RC, both for the Editor and the API.

#rb jeremie.roy, Simon.Therriault

[CL 30082923 by andrea botti in ue5-main branch]
2023-12-04 10:58:52 -05:00
andrea botti
745b6fad83 [RemoteControl]
Add Getter path when Reading Property.

#rb jeremie.roy

[CL 29840190 by andrea botti in ue5-main branch]
2023-11-20 08:37:10 -05:00
joe pribele
1e6438eb61 combining FObjectPropertyPtr and FObjectProperty and FClassPropertyPtr and FClassProperty together
simplifies usage of Object Properties and fixes a few edge cases

see zousar.shaker for issues

#rb zousar.shaker

[CL 29761675 by joe pribele in ue5-main branch]
2023-11-15 17:27:09 -05:00
andrea botti
a1c5e3bd21 [RemoteControl]
Fix Undo/Redo crash with the WebApp open while calling the OnPropertyUnexposed.
Fix Rename issue in the WebApp and OnFieldsRenamed never broadcasted in the Engine.
Fix Rename Transaction not created correctly.
Fix RCTransactionListener not keeping the Delegate by reference causing the system to not call bound function to the Delegate if they were bound after the creation of the TransactionListener.

#rb jeremie.roy

[CL 29711290 by andrea botti in ue5-main branch]
2023-11-14 08:59:44 -05:00
nick edwards
1ee04c17ae Swap FHttpRequestHandler to TDelegate from TFunction. Allows for more convenient callback handling.
Fixed up usage of FHttpRequestHandler across engine and projects.

#tests Ran some RPC tests successfully, which execute RPCs against the engine utilizing HTTPServer.

[CL 29401814 by nick edwards in ue5-main branch]
2023-11-03 07:44:22 -04:00
ionut matasaru
57769f8235 Fixed usage of TRACE_CPUPROFILER_EVENT_SCOPE macros in engine plugins.
* TRACE_CPUPROFILER_EVENT_SCOPE(ScopeName) --> to be used with a plain text as scope name (not a string!). If the parameter is a string ("abc" or TEXT("abc")), the quotes (and the TEXT prefix) will be included in the actual timer name.
* TRACE_CPUPROFILER_EVENT_SCOPE_STR("scope name") --> to be used with a static string (const ANSICHAR* or const TCHAR*); ex: when the scope name needs to include a space char
* TRACE_CPUPROFILER_EVENT_SCOPE_TEXT(*MyScopeName) --> to be used with a dynamic string (const ANSICHAR* or const TCHAR*)
See also the comments for these macros in ProfilingDebugging\CpuProfilerTrace.h.

#rb Catalin.Dragoiu

[CL 28337738 by ionut matasaru in ue5-main branch]
2023-09-29 04:29:47 -04:00
elliot colp
5abe7869f1 [RemoteControl] Add missing include to fix incremental build
#rb trivial
#jira UE-156392

[CL 27529921 by elliot colp in ue5-main branch]
2023-08-31 14:06:01 -04:00
elliot colp
7540b788d2 [RemoteControl] Add zlib compression option for WebSocket traffic
#jira UE-156392
#rb Alejandro.Arango, Jeremie.Roy

[CL 27527132 by elliot colp in ue5-main branch]
2023-08-31 12:51:37 -04:00
elliot colp
b896314c9b [RemoteControl] Fix ContributeToTransaction always failing when WebSocket transaction is first created
#rb Alejandro.Arango

[CL 27223354 by elliot colp in ue5-main branch]
2023-08-18 18:26:10 -04:00
elliot colp
23979ca837 [RemoteControl] Remove unnecessary ensures
#jira UE-190663
#rb Alejandro.Arango

[CL 26493664 by elliot colp in ue5-main branch]
2023-07-20 15:43:24 -04:00
elliot colp
4eacdce9e0 [UnrealStage] Fix color grading outliner entries becoming grey when level is reloaded
#jira UE-189303
#rb Jeremie.Roy, Patrick.Hardy

[CL 26214377 by elliot colp in ue5-main branch]
2023-06-23 14:24:04 -04:00
Elliot Colp
5b7947ba0f [RemoteControl] Fix HTTP query parameters not being parsed when sent via WebSocket http route
#jira UE-188884
#rb Jeremie.Roy

[CL 26060020 by Elliot Colp in ue5-main branch]
2023-06-16 13:29:14 -04:00
kirill zorin
b6ee3a6c64 Fix UE_LOG callsites that have format string-related UB
#rb trivial
#preflight 647107780a6634dbb236a0a6

[CL 25651638 by kirill zorin in ue5-main branch]
2023-05-26 15:52:39 -04:00
jeremie roy
f64749b722 Fix remote control crash on exit
#jira UE-185974
#preflight 6463c3fefa4cf41651bc844c
#rb simon.therriault

[CL 25494647 by jeremie roy in ue5-main branch]
2023-05-16 15:17:50 -04:00
jeremie roy
b1d8fc9d47 Fix race condition in web interface requests that would result in an empty preset.
Fix forwarded local IP being treated as remote IP for security purposes

#jira UE-182875
#rb amir.keren
#preflight 644042eb8d0bcde49c5eafd6

[CL 25139576 by jeremie roy in ue5-main branch]
2023-04-20 19:04:26 -04:00
Elliot Colp
58359ce279 [RemoteControl] Fix property reset over HTTP. Fix property reset for properties with no CDO data
#jira UE-183193
#rb Jeremie.Roy
#preflight 644022f573470c177c8f027b

[CL 25110739 by Elliot Colp in ue5-main branch]
2023-04-19 13:31:44 -04:00
jeremie roy
3818b77d66 Fix server restart when changing RC settings
Fix Websocket keeping port open after changing it (Our version of lws has a bug that keeps listening on port even if lws_context_destroy is called

#rb simon.therriault
#jira UE-181152
#lockdown alejandro.arango
#preflight 6425a3be9621ba9cb4443c66

[CL 24858283 by jeremie roy in ue5-main branch]
2023-03-30 14:59:08 -04:00
paul vincent
0cd9996cca Remote Control - Crash when changing levels
#jira UE-181176
#rb Alejandro.Arango Simon.Therriault Jeremie.Roy
#preflight 6421a6f9c42c7fd1cb83c2aa

[CL 24810980 by paul vincent in ue5-main branch]
2023-03-27 18:26:29 -04:00
jeremie roy
6f50b74191 Remote Control expose websocket server bind address
#jira UE-180918
#preflight 641c5c0c691c5ebc15afda23
#lockdown alejandro.arango
#rb simon.therriault

[CL 24763869 by jeremie roy in ue5-main branch]
2023-03-23 12:41:57 -04:00
jeremie roy
0fad228315 Remote Control Security
Unify Allowed IP and AllowListed IP settings
Unify Use Passphrase and Allow passphrase



#jira UE-180586
#rb simon.therriault
#preflight 64149e303f3d31c94a973dd0
#lockdown alejandro.arango

[CL 24724032 by jeremie roy in ue5-main branch]
2023-03-20 17:19:34 -04:00
nick edwards
4bc34701c0 Fix C++20 compile error. Some types in RemoteControl are can no longer be aggregate initialized in C++20.
#preflight 6418451642618c85c474ea25
#rb none
#jira none

[CL 24719412 by nick edwards in ue5-main branch]
2023-03-20 13:28:35 -04:00
jeremie roy
e9a955c2ee Fix remote control routes circumventing security features
Remote control internal preprocessors will now be redirected to the same preprocessors that are used for http routes.

#jira UE-176324
#rb simon.therriault
#lockdown alejandro.arango
#preflight 6412090c924f0cb7223190f8

[CL 24678296 by jeremie roy in ue5-main branch]
2023-03-16 16:16:54 -04:00
paul vincent
b1252d8dce Remote Control Web Interface bind address should not be 0.0.0.0
#jira UE-175336
#rb Alejandro.Arango Simon.Therriault Jeremie.Roy
#preflight 640a016eaf3fc3529230903b

[CL 24578393 by paul vincent in ue5-main branch]
2023-03-09 12:42:37 -05:00