529 Commits

Author SHA1 Message Date
jean perrier
9e1c817e58 [Remote Control] Fix for properties with setter through nDisplay interception.
Details:

Properties with setters have been added in CL 20273706. It has been added by extending InvokeCall to support FProperty::CallSetter path. Prior to this, Setters where a UFunction, so it was fine to intercept the InvokeCall. After the change, it would still intercept InvokeCall, but lose the information about which property is being set, since there is no UFunction.

Fix:

CanInterceptFunction was added in CL 24562094 (to fix something else), but it correctly makes InvokeCall that can't be intercepted fallback to intercepting SetObjectProperties, which works correctly with the CallSetter path.

#jira UE-210665
#rb Juan.Portillo

[CL 32534414 by jean perrier in 5.4 branch]
2024-03-26 21:19:05 -04:00
andrea botti
fd91ad7c1a [RemoteControl] Fix ensure hit with Text action
Fix Text action that hit an ensure when changing their value

#rb Juan.Portillo
#jira UE-208923

[CL 32496830 by andrea botti in 5.4 branch]
2024-03-26 00:49:34 -04:00
jeremie roy
6ac8d97dbf Remote Control - Update list of disallowed functions
#rb Geoffrey.Douglas, jason.walter

[CL 32487746 by jeremie roy in 5.4 branch]
2024-03-25 18:03:18 -04:00
andrea botti
87348b53e1 [RemoteControl]
Fix automation Test failing

#rb jeremie.roy
#jira UE-206663

[CL 31568736 by andrea botti in 5.4 branch]
2024-02-16 11:59:42 -05:00
andrea botti
0a93c64865 [RemoteControl]
Visual errors in viewport when using float controller or rotators to rotate object

#rb Matt.Chapman
#jira UE-203132

[CL 31391423 by andrea botti in 5.4 branch]
2024-02-12 13:38:19 -05:00
juan portillo
50cac1c5ac Remote Control:
- Added static bool to return whether Guid Renewal is being allowed when duplicating
- Tracker Component to not refresh its tracker properties when Guid renewal is allowed, as it's analogous to duplicating things "as-is"

#rb Matt.Chapman


#changelist validated
#virtualized

[CL 31375226 by juan portillo in 5.4 branch]
2024-02-11 21:16:42 -05:00
andrea botti
2cf25f64f0 [RemoteControl]
Array Customization for Path behaviour to add Input button

#rb Juan.Portillo

[CL 31291537 by andrea botti in 5.4 branch]
2024-02-08 10:09:41 -05:00
jean perrier
d40808294d [RemoteControl] Alternative API to prevent remote control presets from renewing their Guids on duplicate.
The Motion Design Rundown editor is loading and duplicating level assets containing embedded remote control presets. This is done as part of the Rundown editor's work flow in order to have a copy of the RCP that will be used to run the controllers and capture the resulting values. We want the duplicated RCP to keep it's guids the same as the original.

The original method for doing this was to use EDuplicateMode::PIE. However, since there are may be no PIE instances running, this method hits some check failures. One such failure in RemapGuid (LazyObjectPtr.cpp) seems to indicate EDuplicateMode::PIE can't be used if there are no PIE instances running.

To resolve this issue for the moment, we will add an API to explicitly disable the guid renewal.

#rb Juan.Portillo

[CL 31142805 by jean perrier in 5.4 branch]
2024-02-02 16:59:03 -05:00
andrea botti
90f1d41795 [RemoteControl]
While in the Operation Mode you are unable to toggle on the Logic Panel.
Switched position of the Logic Panel button and the Protocol button.

#rb Matt.Chapman
#jira UE-205303

[CL 31049032 by andrea botti in 5.4 branch]
2024-01-31 10:50:08 -05:00
andrea botti
7995f09de8 [RemoteControl]
Make controller Id widget to not scale in height but always be centered

#jira UE-205268

[CL 31006833 by andrea botti in 5.4 branch]
2024-01-30 10:16:05 -05:00
andrea botti
2efdc48709 [RemoteControl]
Rename controllers column from "Name" to "Controller Id"

#rb juan.portillo
#jira UE-205145

[CL 31006207 by andrea botti in 5.4 branch]
2024-01-30 09:44:11 -05:00
andrea botti
9fb6e66af8 [RemoteControl]
FindSetter function will not return early in Editor if not found in the first tries.

#rb Juan.Portillo

[CL 30945922 by andrea botti in 5.4 branch]
2024-01-26 17:58:48 -05:00
andrea botti
282ce74a02 [RemoteControl]
Fix:
- Instead of Emptying the RealProperties in propId now we only add newer ones
- Crash when creating a behaviour
- Crash when copying some Struct
- Blocked copy of ObjectProperty value in PropId Action to avoid crash (For example with the Material)
- Added copy for Struct only if Allowed (Color/LinearColor/Vector/Rotation)
- Crash when calling OnObjectPropertyChanged in Preset because recursive in some case
- Changed from AddLambda to AddSPLambda

#rb Matt.Chapman

[CL 30932763 by andrea botti in 5.4 branch]
2024-01-26 13:49:12 -05:00
steve robb
57ca754749 Fixed up more bool-taking calls to take EAllowShrinking instead.
[CL 30894744 by steve robb in 5.4 branch]
2024-01-25 14:17:31 -05:00
andrea botti
1e790cfd8d [RemoteControl]
Fix:
- PropId not always working correctly in Game
- Float property will be treated as Double
- Color property will be treated as LinearColor

#rb Loris.Rossi

[CL 30883791 by andrea botti in 5.4 branch]
2024-01-25 08:39:31 -05:00
andrea botti
d82f06ccfc [RemoteControl]
Fix:
- Block creation of actions that are not supported by PropertyBag
Since the function that returns the value type is private we have to use a workaround by creating a BagDesc and then retrieve the value type from that to check that it is not None.

#rb Juan.Portillo

[CL 30883092 by andrea botti in 5.4 branch]
2024-01-25 07:58:33 -05:00
andrea botti
2a1c6de61c [RemoteControl]
Fix PropertyId in certain cases will be displayed wrongly.

#rb brad.monahan

[CL 30780412 by andrea botti in ue5-main branch]
2024-01-22 13:30:57 -05:00
andrea botti
5c97fb1d60 [RemoteControl]
Add check during BindObject for RootComponent validity.

#rb brad.monahan

[CL 30780161 by andrea botti in ue5-main branch]
2024-01-22 13:21:30 -05:00
andrea botti
aeb9682407 [RemoteControl]
Add check for Editable properties in PropertyId action

#rb brad.monahan

[CL 30780125 by andrea botti in ue5-main branch]
2024-01-22 13:20:10 -05:00
andrea botti
7f8f056a31 [RemoteControl]
Add search for BP_Set while searching for setter.

#rb brad.monahan

[CL 30779981 by andrea botti in ue5-main branch]
2024-01-22 13:17:40 -05:00
andrea botti
daf4c5271a [RemoteControl]
Sub-Property Id

#rb Juan.Portillo

[CL 30721354 by andrea botti in ue5-main branch]
2024-01-19 13:21:33 -05:00
jean perrier
e654e130ca [Remote Control] Fix another edge case with unregistering embedded presets on a "Save As".
#rb andrea.botti
#rnx

[CL 30689119 by jean perrier in ue5-main branch]
2024-01-18 12:55:17 -05:00
marc audy
19e84555b3 Silence PVS warnings
[CL 30653812 by marc audy in ue5-main branch]
2024-01-17 01:34:02 -05:00
andrea botti
c5c3eb54be [RemoteControl]
Adding support for FVector2D Controller

#rb jeremie.roy

[CL 30624041 by andrea botti in ue5-main branch]
2024-01-15 16:06:36 -05:00
andrea botti
3e9cd2fee6 [RemoteControl]
UI change for ActionPanel and Behaviours

#rb Juan.Portillo

[CL 30618122 by andrea botti in ue5-main branch]
2024-01-15 09:14:40 -05:00