96 Commits

Author SHA1 Message Date
nicholas howe
11be0addff MetasoundMusicClockDriver thread safety fixes.
[REVIEW] [at]buzz.burrowes [at]charlie.huguenard [at]jake.burga [at]robert.rouhani
#rb charlie.huguenard

[CL 31575758 by nicholas howe in 5.4 branch]
2024-02-16 14:51:29 -05:00
rob gay
675e3bbf00 Minor pool clean-up & additional protections in light of review of last submission
#rb maxwell.hayes
#jira UE-201787
#rnx
#tests AudioUnitTests, ran bug repro

[CL 31457907 by rob gay in 5.4 branch]
2024-02-13 20:59:01 -05:00
rob gay
e8f67ef2c7 - Fix for shutdown crash in FWaveAsset construction due to IStreamingManager becoming invalid while operator cache is building proxies async
- Fix for shutdown stall caused by operator cache not canceling async build gracefully
#jira UE-201787
#rnx
#rb maxwell.hayes
#tests AudioUnitTests, ran bug repro

[CL 31457842 by rob gay in 5.4 branch]
2024-02-13 20:57:28 -05:00
Maxwell Hayes
3454ac3cf4 Cleaning up metasound experimental cvars
#rb Phil.Popp
#jira UE-205183
#rnx

[CL 31178199 by Maxwell Hayes in 5.4 branch]
2024-02-05 12:33:10 -05:00
steve robb
f029468598 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
maxwell hayes
cb6bc25e3c Adding audio csv stats around tracking potential perf culprits.
#rb jimmy.smith

[FYI] Will.Widen

[CL 30402732 by maxwell hayes in ue5-main branch]
2023-12-19 16:07:38 -05:00
AdricEpic
473f754908 - Registration Race Condition Fixes (Attempt #2 w/ cook fixes)
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns (2/2 will be deprecating old MetasoundFrontendRegistries.h header path)
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
[FYI] sondra.moyls
#tests AudioQA/EngineTest MetaSound Automated Tests, AudioTests, cook WindowsClient, submit and backout and then fix those problems
#jira UE-198785

[CL 30354102 by AdricEpic in ue5-main branch]
2023-12-15 13:21:12 -05:00
rob gay
65111a0774 Fix for cook errors, undo changelist 30246187
#rb helen.yang
#rnx

[CL 30255375 by rob gay in ue5-main branch]
2023-12-11 20:36:24 -05:00
rob gay
a876bffd23 - Registration Race Condition Fixes
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
#tests AudioQA MetaSound Automated Tests, AudioTests
#jira UE-198785

[CL 30246215 by rob gay in ue5-main branch]
2023-12-11 14:43:42 -05:00
charlie huguenard
0397d1e2b3 [Metasound] Notify listeners only once per render block when a dynamic generator's vertex interface changes.
[FYI] matthew.booth
#rb helen.yang

[CL 30128280 by charlie huguenard in ue5-main branch]
2023-12-05 14:13:33 -05:00
rob gay
c0a29efaed Add cvar to disable manual MetaSoundPrecache all together
#rb helen.yang
#rnx

[CL 30094958 by rob gay in ue5-main branch]
2023-12-04 16:22:01 -05:00
helen yang
3b8e0c7acf Retrieve MetaSound graph before building graph operator in async task (cvarable) and add nullptr checks
[REVIEW] [at]aaron.mcleran, [at]rob.gay
#rb Aaron.McLeran, hilda.cruz, Rob.Gay, ryan.mangin

#localization none
#tests preflight 656ceb1d8b7aa8578b8b235a
#preferred_allowlister derek.ehrman

[CL 30072616 by helen yang in ue5-main branch]
2023-12-03 21:31:16 -05:00
maxwell hayes
dd5caaaf58 Add cvar to allow resetting metasound operators on cache insertion to potentially deallocate memory.
[REVIEW] [at]rob.gay
#rnx

#localization none
#tests local LLM A/B in PIE to confirm regression fixed w/o affecting weapon audio functionality
[FYI] aaron.mcleran

[CL 29596933 by maxwell hayes in ue5-main branch]
2023-11-09 10:54:35 -05:00
phil popp
559eaa393f Fix default parameter values when skipping preset
#jira UE-199604
#rb Maxwell.Hayes
#rnx

[CL 29385950 by phil popp in ue5-main branch]
2023-11-02 18:41:29 -04:00
maxwell hayes
62beb18e59 [Metasound] Follow up changes to operator pooling behavior.
#jira UE-179996
#rb phil.popp

#swarm https://p4-swarm.epicgames.net/reviews/29255703

[CL 29295416 by maxwell hayes in ue5-main branch]
2023-10-31 18:35:37 -04:00
helen yang
6d393901a2 Add MetaSounds LLM tag to OnGenerateAudio
#rb phil.popp

[CL 29161461 by helen yang in ue5-main branch]
2023-10-26 21:13:44 -04:00
maxwell hayes
8e9187b0cf [Metasounds] Operator precaching mechanism.
#jira UE-185725, UE-179996,
#rb phil.popp
#swarm https://p4-swarm.epicgames.net/reviews/27703580

[CL 28775007 by maxwell hayes in ue5-main branch]
2023-10-13 17:49:56 -04:00
ionut matasaru
57769f8235 Fixed usage of TRACE_CPUPROFILER_EVENT_SCOPE macros in engine plugins.
* TRACE_CPUPROFILER_EVENT_SCOPE(ScopeName) --> to be used with a plain text as scope name (not a string!). If the parameter is a string ("abc" or TEXT("abc")), the quotes (and the TEXT prefix) will be included in the actual timer name.
* TRACE_CPUPROFILER_EVENT_SCOPE_STR("scope name") --> to be used with a static string (const ANSICHAR* or const TCHAR*); ex: when the scope name needs to include a space char
* TRACE_CPUPROFILER_EVENT_SCOPE_TEXT(*MyScopeName) --> to be used with a dynamic string (const ANSICHAR* or const TCHAR*)
See also the comments for these macros in ProfilingDebugging\CpuProfilerTrace.h.

#rb Catalin.Dragoiu

[CL 28337738 by ionut matasaru in ue5-main branch]
2023-09-29 04:29:47 -04:00
charlie huguenard
7838330b9f [Metasound] Notify users when a generator's I/O changes
#rb phil.popp

[CL 27842984 by charlie huguenard in ue5-main branch]
2023-09-13 14:53:04 -04:00
stan hormell
f6c41a01d5 [Backout] - CL 27692414 and CL 27732161 - Smoke Crash
#jira FORT-653198
#fyi Maxwell.Hayes
Original CL Desc
-----------------------------------------------------------------
[Metasounds] Adding unreal insights markup:
* Added asset name metadata to "RegisterWithFrontEnd"
* Added per-asset counter for the number of concurrent operators alive at a time.

#jira UE-179996
#rb

[CL 27741788 by stan hormell in ue5-main branch]
2023-09-10 14:48:15 -04:00
Maxwell Hayes
1f1ec75fc8 Follow up tweaks to instance counting (code review comments after PFaS went through).
#jira UE-179996
#rb Phil.Popp

[CL 27732161 by Maxwell Hayes in ue5-main branch]
2023-09-08 18:19:44 -04:00
Maxwell Hayes
c0cc14b36b [Metasounds] Adding unreal insights markup:
* Added asset name metadata to "RegisterWithFrontEnd"
* Added per-asset counter for the number of concurrent operators alive at a time.

#jira UE-179996
#rb

[CL 27692414 by Maxwell Hayes in ue5-main branch]
2023-09-07 18:19:05 -04:00
matthew booth
2c1190d1d5 [Metasound] Add the ability to get Metasound rendering perf numbers (timing) at runtime.
#rb [at]phil.popp [at]charlie.huegunard [at]rob.gay

[CL 27338257 by matthew booth in ue5-main branch]
2023-08-24 08:28:12 -04:00
robert manuszewski
cfe46a88ad TObjectPtr compilation fixes ahead of enabling GC barrier
#rb trivial
[FYI] Kirill.Zorin, Johan.Torp, Zousar.Shaker

[CL 26767884 by robert manuszewski in ue5-main branch]
2023-08-02 06:51:30 -04:00
phil popp
c382cf4cfb Fix for disconnecting MetaSound node using builder API does not update output
#jira UE-189292
#rb Rob.Gay

[CL 26446133 by phil popp in ue5-main branch]
2023-07-18 16:24:42 -04:00